------------------------------------------------------------------------
r1831234 | jleroux | 2018-05-09 10:26:44 +0200 (mer. 09 mai 2018) | 4 lignes
Fixed: Sending mail button from viewProfile doesn't work
(OFBIZ-7075)
There was a quote error in the Montalbano Florian's patch, this fix it
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1831236 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1831078 | jleroux | 2018-05-07 09:48:57 +0200 (lun. 07 mai 2018) | 6 lignes
Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)
Now that we use Tomcat 9 this problem is over
Thanks: Jacopo for upgrading to Tomcat 9
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1831080 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:
<after-login>
<event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
<event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
<event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
</after-login>
We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.
Thanks to Vikas Mayur for solve this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1830305 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1828255 | jleroux | 2018-04-03 18:37:09 +0200 (mar., 03 avr. 2018) | 7 lines
Fixed: Required parameters are optional for createWorkRequirementFulfillment service
(OFBIZ-8622)
As per entity def, required parameter should be requirementId instead of
requirementTypeId.
Thanks: Suraj for the last patch
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1828306 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1827439 | jleroux | 2018-03-21 21:53:41 +0100 (mer., 21 mars 2018) | 5 lines
Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)
It should have been org.apache.catalina.connector.RequestFacade"
instead of javax.servlet.http.HttpServletRequest see the Jira for details
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1827440 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1826997 | jleroux | 2018-03-16 16:39:18 +0100 (ven., 16 mars 2018) | 7 lines
Fixed: The server hour normally shown in the jobs list is no longer showing
(OFBIZ-10278)
With FTL formatting in OFBIZ-7636, the commented single line got broken into 3
lines making it an invalid js code.
Thanks: Aditya
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1827000 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1826938 | jleroux | 2018-03-16 10:35:06 +0100 (ven., 16 mars 2018) | 12 lines
Fixed: Logout do not remove autoLogin
(OFBIZ-4959)
I used the only available (and I must say confusing) WebappInfo.getName() when
I needed the webAppName not the WebappInfoName. So this put in a new
WebappInfo.getMountPoint() and use it in getWebappInfo
Also use LoginWorker.autoLoginSet() in different places where I missed it. In
other words all autoUserLogin coockies are deleted on login and logout, and
an autoUserLogin cookie is created when going locally from a webapp to another,
with checkExternalLoginKey
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1826939 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1826797 | jleroux | Thu Mar 15 11:29:59 2018 | 5 lines
Fixed: The getJSONuiLabel javascript function is no longer working
(OFBIZ-10277)
The data were well retrieve, but the syntax used to extract them was not working
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1826798 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Pass JVM options to OFBiz when using Gradle.
(OFBIZ-10253)
This enables passing JVM options like memory, garbage collection or JMX
configurations to the OFBiz VM. Falls back to the previously hard coded
default if not set.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1826377 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824855 | jleroux | 2018-02-20 12:59:07 +0100 (mar., 20 févr. 2018) | 7 lines
Reverted: Secure the login.secret_key_string
(OFBIZ-9966)
I forgot to revert this part; I guess got conflict issues and then forgot.
I'll also revert in R16 and R17 and close as won't fix, I gave my arguments
that's enough for me.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824856 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824847 | jleroux | 2018-02-20 12:04:15 +0100 (mar., 20 févr. 2018) | 6 lines
Fixed:Access the online help in Rainbow themes
(OFBIZ-10222)
The help icon did not render well on IE11. It's now OK on all major browsers
Thanks: Julien for the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824848 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824803 | jleroux | 2018-02-19 20:23:36 +0100 (lun., 19 févr. 2018) | 18 lines
Fixed: Logout do not remove autoLogin
(OFBIZ-4959)
Logout method do not disable autoLogin functionality.
Instead of that it just initializes autoLogin in session and request.
jleroux: this was also needed by OFBIZ-10206 "Security issue in Token Based
Authentication".
This creates a keep-autologin-cookie boolean attribute in the webapp element of
the ofbiz-component.xml, documented in ofbiz-component.xsd
This attribute is used to get the value from the ofbiz-component.xml files in a
new autoLogoutCleanCookies() LoginWorker method. This method is used not only
when login out but also when login in. This to be sure that in every cases the
cookies related to the webapps are removed.
For now only the ecommerce, ecomseo et webpos webapps are keeping and using
their autologin cookies
Thanks: Roberto Benítez Monje for report and Taher for discussion and suggestion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824804 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824732 | jleroux | 2018-02-19 11:49:25 +0100 (lun., 19 févr. 2018) | 6 lines
Fixed:Access the online help in Rainbow themes
(OFBIZ-10222)
As reported by Dmitriy Tsyganok on GitHub we missed the Help Icon
Thanks: Dmitriy Tsyganok
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824733 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824316 | jleroux | 2018-02-15 15:38:51 +0100 (jeu., 15 févr. 2018) | 7 lines
Improved: Use Tomcat default ciphers
(OFBIZ-10223)
Tomcat provides a default ciphers definition better to use it and let Tomcat
handles that for us, we know Tomcat security is strong
Thanks: Paul Foxworthy for the help understanding the syntax :)
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824317 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1824260 | jleroux | 2018-02-14 17:40:19 +0100 (mer., 14 févr. 2018) | 1 line
Improved: Token Based Authentication
(OFBIZ-9833)
No functional change, removes TODOs that I recently
(1 week ago in r1823324) put to myself to quickly check.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824261 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1823876 | jleroux | 2018-02-11 19:51:07 +0100 (dim., 11 févr. 2018) | 9 lines
Fixed: UtilNumber.getBigDecimalRoundingMode() returns a wrong value
(OFBIZ-10218)
While working on OFBIZ-9571 I found that getBigDecimalRoundingMode() returns
DEFAULT_BD_SCALE when the passed value for the file parameter is emtpy.
This has certainly be C/P from getBigDecimalScale() and never found before.
While at it I refactored a bit getBigDecimalRoundingMode() and
getBigDecimalScale()
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823877 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1823467 | jleroux | 2018-02-07 15:17:51 +0100 (mer., 07 févr. 2018) | 7 lines
Completed:: Security issue in Token Based Authentication
(OFBIZ-10206)
Updates the security.properties content related to JWT
Refers to the last up to date external-server-test-example.patch at OFBIZ-10206
Makes demo-trunk.ofbiz.apache.org default external-server-name so that anybody
can try the feature from own machine. The use-external-server=Y was already set
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823469 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1823324 | jleroux | 2018-02-06 14:17:57 +0100 (mar., 06 févr. 2018) | 26 lines
Fixed: Security issue in Token Based Authentication
(OFBIZ-10206)
The version I committed so far in OFBIZ-9833 has a small security issue.
See the Jira description for all details
To test I have attached a OFBIZ-10206-external-server-test-example.patch to
the Jira
This removes the external-server-query property now useless
In ContextFilter the getHeader (wrapper) now uses an autoLoginCookie to get
the userLoginId passed in the JWT instead of externalServerUserLogin parameter.
A sourceServerWebappName parameter must be passed from the client request to
allow reading the autoLoginCookie.
This userLoginId is then retrieved on the target server from the JWT in the
externalServerLoginCheck which is simplified.
In LoginWorker
getAutoLoginCookieName() has now 2 versions to allow to pass a webappname
A new autoLogoutFromAllBackendSessions() method has been added but for now
commented out. Decommenting it out will be submitted as a patch in OFBIZ-4959.
Thanks: Leila Mekika for reporting the security issue directly to me
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823325 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1822882 | jleroux | 2018-02-01 16:27:17 +0100 (jeu., 01 févr. 2018) | 7 lines
Improved: Token Based Authentication
(OFBIZ-9833)
I just thought that for security it's best to have both the source and
target server using the use-external-server property.
Also default to N when requesting this property
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823316 13f79535-47bb-0310-9956-ffa450edef68