Commit Graph
942 Commits
Author SHA1 Message Date
Jacques Le Roux 22b8ecb557 Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)
Comment out the XMLRPC tests. This alone should allow Buildbot 3.2 to run the
integration tests.
2021-12-16 07:05:26 +01:00
Jacques Le Roux 4724b9e2ee Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
We don't fear collisions for "url". It's only used in testXmlRpcRequest during
a sole test, write that in exclude.xml

Also removes an unused MODULE in XmlRpcTests class
2021-12-13 16:23:54 +01:00
Jacques Le Roux ca03e21ae8 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Rearranges order of modifiers after transient insertion, in classes
ProductConfigWrapper, ModelEntity, ModelViewEntity and ModelService
2021-12-06 09:42:47 +01:00
Jacques Le Roux 1ecf6d3929 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Adds @SuppressWarnings("serial") to AbstractJob and removes unused MODULE var
from PurgeJob
2021-12-06 09:37:36 +01:00
Jacques Le Roux d4306b9f59 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
ComparableRange is a super class of DateRange that is Serializable. So
ComparableRange needs to be Serializable Too. Same with AbstractJob for PurgeJob
and GenericServiceJob
2021-12-06 09:33:31 +01:00
Jacques Le Roux ed6241cb52 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
transient is needed for not serialisable fields of a Serializable class
2021-12-06 09:23:55 +01:00
Jacques Le Roux aab412b948 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Renames ControlServlet class to OfbizControlServlet, because it shadowed the
simple name of it superclass
It can be exceptionally confusing, create lots of situations in which you have
to look at import statements to resolve references and creates many
opportunities to accidentally define methods that do not override methods
in their superclasses.

Same for XmlRpcClient.java
2021-12-05 13:03:50 +01:00
Jacques Le Roux 4d9d191dfd Fixed: Fix some bugs Spotbugs reports (OFBIZ-12386)
Need to check for null before return
2021-11-18 08:07:53 +01:00
Jacques Le Roux c85f60279b Improved: Remove Checkstyle warning related to double parenthesis at start of lines (OFBIZ-12340)
At https://markmail.org/message/3mhzlqew3igad3r2 I reported an issue that I was
not able to really qualify. After exchanging with a Checkstyle expert
(see markmail thread).

I was unable to find what in our checkstyle.xml file was wrongly throwing these
warnings. I decided that there was no reason to throw those warnings.

So I decided to put the SuppressionCommentFilter in our checkstyle.xml file and
use CHECKSTYLE_OFF: ALMOST_ALL/CHECKSTYLE_ON: ALMOST_ALL around
the concerned lines as documented here
https://checkstyle.sourceforge.io/config_filters.html#SuppressionCommentFilter_Examples
2021-10-17 15:38:30 +02:00
Jacques Le Roux a5bdcc6f9e Fixed: post-auth Remote Code Execution Vulnerability (OFBIZ-12332)
This definitely solves all issues by introducing a CacheFilter and
RequestWrapper classes inspired by several works found on the Net.
Also moves the change introduced before in ContextFilter to CacheFilter.

The basic problem is that you only can use once
ServletRequest::getInputStream or the ServletRequest::getReader
Also not both, even once, ie they can be seen as same from this POV.

The integration tests all pass.

Also replace the checked String "</serializable>" by "</serializable" as, like
reported by Jie Zhu, the former could be bypassed by using "</serializable >"

Thanks: Jie Zhu for report
2021-10-10 08:00:51 +02:00
Jacques Le Roux cd03a6a98f Improved: post-auth Remote Code Execution Vulnerability (OFBIZ-12332)
Temporarily comments out XMLRPC tests.

I'll work on a definitive solution ASAP
2021-10-09 07:48:55 +02:00
Nicolas Malin 8548f3a8a1 Fixed: Remove unnecessary variable instanciation
No Functional change
2021-09-17 15:14:13 +02:00
Nicolas Malin 32cca8a81b Fixed: Groovy DSL failed to use 'run service' from an event call (OFBIZ-12322)
When you call a groovy script from an event controller, some information are present note on the same place on the binding context.

Example if you call a groovy script as service you found the userLogin with parameters.userLogin or when you call it as event, the userLogin is on the binding context root.

The problem appear with the DSL method 'run service' who search the missing value need by a service (userLogin, locale and timezone) on the map parameters on the binding context, so failed to populate correctly the information for an event.

Call from event
    Map serviceResult = run service: 'createInvoice', with: [partyId: partyId, invoiceDate: nowTimestamp]

Failed due to security issue : missing userLogin on the service context.
2021-09-17 15:03:23 +02:00
Nicolas Malin 5bd3ccfa40 Improved: Groovy DSL add success(Map) method (OFBIZ-12317)
Improve the groovy dsl with a success method that return directly all fields

    Previously we used:
        Map result = success()
        result.myId = myId
        return result

    Now we can write:
        return success(myId: myId)

Or

    Previously we used:
        Map result = success('Wonderful !')
        result.myId = myId
        return result

    Now we can write:
        return success('Wonderful !', myId: myId)
2021-09-15 14:26:05 +02:00
Nicolas Malin f82f7631b1 Implemented: Groovy DSL add label method (OFBIZ-12319)
Improve the groovy dsl with a simple method 'label' to resolve an uiLabel instead of use 'UtilProperty.getMessage()' on groovy script.

    Previously we used:
        UtilProperties.getMessage("AccountingUiLabels", "AccountingUpdatePaymentPermissionError", 'locale'))

    Now we can write:
        label("AccountingUiLabels", "AccountingUpdatePaymentPermissionError")
2021-09-15 12:07:15 +02:00
Nicolas Malin 3dd89a5219 Fixed: Fix checkstyle issue
detected by the buildbot and not by ./gradlew check
2021-08-11 14:59:47 +02:00
Eugen Stan 25c75e2839 Implemented: Clojure Service engine (OFBIZ-12302) (#317)
* Added Clojure service and service test and example service
* Added clojure engine
2021-08-10 16:09:39 +02:00
Jacques Le Roux 2c421cedfb Fixed: Add http to https redirect rule for ofbiz.apache.org (OFBIZ-10590)
This prevented to run the stable demo, hence the next, weirdly the trunk had
not this problem. Anyway better safe than sorry... Maybe related to Gradle
version or rather libs loaded?

The reason why the stable (and old) demos were not running is because the
EntitySaxReaderTests did not pass
2021-07-20 07:47:32 +02:00
Eugen Stan cd40cc28a7 Improved: Clean commented code from ofbiz services (#310)
(OFBIZ-8040)
2021-07-08 09:56:44 +02:00
Jacques Le Roux 643b9c7ea7 Improved: Comment out the SOAP and HTTP engines (OFBIZ-12212)
The SOAP and HTTP engines are open doors to security issues.
At https://markmail.org/message/pgtjyh23bazq4s2w I proposed to comment them out
as we did for RMI in the past.
Of cause it must be clearly documented how to use them if needed.

Here is the email content:

    After the recent fix for the CVE-2021-26295[1] we discussed with the security
    team about the opportunity need to comment out the SOAP and HTTP engines
    like we did in the past for RMI[2], this obviously for security reason.

    [1] OFBIZ-12167 "Adds a blacklist (to be
    renamed soon to denylist) in Java serialisation (CVE-2021-26295)"
    [2] OFBIZ-6942 "Comment out RMI related
    code because of the Java deserialization issue [CVE-2016-2170] "

I just put a small comment in webtools controller, it should be enough.

The tests pass
2021-03-29 13:13:53 +02:00
Jacques Le Roux 1bf977ae07 Fixed: Error in deleting Financial Account (OFBIZ-12153)
1. Navigate to URL: accounting/control/FindFinAccount
2. Click on Find button. List of fin account will be displayed.
3. Click on delete button near available balance column.

Thanks: Lalit Dashora for report, Sourabh Jain for the initial fix, Pawan Verma
for the defintive fix
2021-03-05 06:12:43 +01:00
Wiebke Pätzold 8f323d493d Improved: Each variable declaration in an own statement (OFBIZ-12169) 2021-02-09 13:33:15 +01:00
Wiebke Pätzold b65be41fc7 Improved: if else construct must use parentheses (OFBIZ-12169) 2021-02-09 09:11:48 +01:00
Wiebke Pätzold 95d37d2189 Removes and adds whitespaces as suggested by checkstyle (OFBIZ-12169) 2021-02-09 08:46:20 +01:00
Michael Brohl bae3628501 Declare classes final as suggested by checkstyle (OFBIZ-12169)
Helper and Worker classes which are likely to be extended by custom
projects where left as is.
2021-02-08 17:09:56 +01:00
Wiebke Pätzold 2fe5e15a83 Improved: Adds newline at the end of file (OFBIZ-12169) 2021-02-08 16:31:13 +01:00
Jacques Le Roux b445e17407 Fixed: Issue in ServiceDemoData.xml due to an error with MX_FED_HOLIDAYS
LoadAll was failing:
2020-11-18 21:08:45 +01:00
Jacques Le Roux 17de4f6e07 Improved: Added multiple "es" and "es-MX" values. Added Mexican Federal Holidays
Fixed: Mexican States Abbreviations

In GeoData_MX.xml abbreviations of the Mexican States were wrong and
"Mexico City" state was labeled as County, which is not.

In CommonUiLabels.xml and CommonEntityLabels.xml were added some missing values
to "es" and "es-MX" languages

In ServiceDemoData.xml were added the Mexican federal holidays under the
temporal expression "MX_FED_HOLIDAYS"

Thanks: Zottacko WallyMan
2020-11-18 17:05:41 +01:00
Suraj Khurana acdddaf85c Improved: Corrected some spacing issues in code, where there are extra white spaces, this will fix some checkstyle issues in framework component.
(OFBIZ-12022)
2020-09-26 14:01:43 +05:30
Girish Vasmatkar 31a6171c0b Fixed: Issue in OpenAPI generation due to duplicate ModelParam in the IN model param list. Added a BinaryOperarion function
to account for duplicates(OFBIZ-11328)
2020-09-18 16:26:18 +05:30
Jacques Le Roux 346c63bfdf Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
We have a lot of "do nothing" in Java code. In case of catch we should at least
have Debug.logError(e, MODULE); and maybe an explanation in the comment.
2020-09-15 15:24:45 +02:00
Suraj Khurana a5619831eb Improved: Added missing Javadocs for remaining methods in framework component, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
Thanks Jacques for review.
2020-09-13 11:28:00 +05:30
Suraj Khurana 97b1688b0d Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in framework component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements. Thanks Jacques for review.
2020-09-12 12:05:16 +05:30
Suraj Khurana bc5e945ded Improved: Corrected line is longer than 150 characters checkstyle issues in framework component.
(OFBIZ-11921)
Also fixed some other extra space and naming related checkstyle issues observed.
Thanks Jacques for review.
2020-09-04 12:25:12 +05:30
Jacques Le Roux a7121bff23 Improved: Improves service-eca.xsd documentation (OFBIZ-9994)
Fixes some issues
2020-08-30 18:56:52 +02:00
Akash Jain 66a76ffd5a Improved: Fix Literals comparisons with variable to avoid NPE (OFBIZ-11929)
Thanks, Devanshu Vyas for your contribution.
2020-08-30 17:20:23 +05:30
Jacques Le Roux d534f78c6a Improved: Improves service-eca.xsd documentation (OFBIZ-9994)
Also with formatting
2020-08-30 11:09:10 +02:00
Suraj Khurana f98f5ebb86 Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
Also fixed some other checkstyle issues that requires re-factoring.
Thanks Jacques for review.
2020-08-28 16:54:15 +05:30
Suraj Khurana 58a026fbf8 Fixed: testIntegration issue caused due to mistakenly updated static string 'WITHDRAWAL' and updated variable in groovy test case.
(OFBIZ-11926)
Also used getter method for entity auto tests to get the dispatcher from OFBizTestCase.
2020-08-26 23:47:21 +05:30
Suraj Khurana f357b997c0 Improved: Corrected class names, method names, data members of class and variables names in framework component.
(OFBIZ-11926)
Also corrected some formatting and line length related checkstyle issues.
2020-08-26 21:40:40 +05:30
girishvasmatkar fdb67aee72 WIP: Implemented: Added support for defining nested attributes.(OFBIZ-11902) (#231)
* Added nested attr definition and code to handle nested attributes

* Checkstyle error fix

* Fixed indentation and tabs issues
2020-08-22 23:50:12 +05:30
Pawan Verma 6cb67c1a40 Improved: Replace .size() == 0 with isEmpty() in Java files(OFBIZ-11944)
Thanks, priya for the report and patch and jacques for the review.
2020-08-22 19:17:10 +05:30
Suraj Khurana 9689201b84 Improved: Make data members of class as private and added accessor methods for the same, also corrected occurences of the same in framework component.
(OFBIZ-11963)
Also made some related checkstyle code enhancements.
Thanks jacques for finalizing Javadoc pattern during this effort.
2020-08-22 13:20:39 +05:30
Suraj Khurana 8c10d4ae72 Improved: Added missing Javadocs for some methods, this is required for all classes which looks like designed for extension (can be subclassed).
(OFBIZ-11947)
This is done for framework component. Also corrected some variables as per naming convention best practices.
Thanks Jacques for review.
2020-08-17 12:30:26 +05:30
Jacques Le Roux 3155906740 Improved: small typo in trunk (OFBIZ-11952)
I also replaced tabs by spaces in applications/product/servicedef/services.xml

Thanks: Alex Bodnaru
2020-08-13 09:16:20 +02:00
Jacques Le Roux b895a9c889 Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)
Fixes few javadoc issues

Since this has been ignored for few commits I need to increase
tasks.checkstyleMain.maxErrors from 12224 to 12247 (did not check the detail)
2020-08-08 14:04:08 +02:00
Priya Sharma 5dbf5cb9eb Improved: Removed unused imports from Java files for fixinf checkstyle errors
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-07 18:57:02 +05:30
Priya Sharma 3fe72d440f Improved: Remove unused imports from Java files (OFBIZ-11930) (#222)
Improved: Remove unused imports from Java files
(OFBIZ-11930)
Thanks: Priya Sharma
2020-08-06 19:51:09 +05:30
Suraj Khurana 33f05c1684 Improved: Corrected all redundant modifiers occurences in framework component. Also, fixed some other checkstyle line formatting and spacing issues.
(OFBIZ-11925)
2020-08-06 18:53:13 +05:30
Suraj Khurana 7d82b17c72 Improved: Corrected some line is longer than 150 characters checkstyle issues in framework component. Also fixed some extra spaces and naming conventions related checkstyle issues.
(OFBIZ-11921)
2020-08-03 10:11:40 +05:30