The issue exists also in the older version.
The field "requirementByDate" form "FindApprovedProductRequirements" in
RequirementForms.xml has been set wrongly and it should be "requiredByDate".
This causes the result could not be queried out properly as indicated as below:
The result is governed by the service "getRequirementsForSupplier",
where reads the list from the view "RequirementAndRole".
In the view entity definition, the field is defined as
<alias entity-alias="RQ" name="requiredByDate"/>,
but it is not the case in the form "FindApprovedProductRequirements" above.
After changing it to the correct name, the bug is solved.
jleroux: Same exists in OrderEntryForms::FindRequirements
Thanks: Schumann Ye for report Pierre Smits for creating the initial PR494
The fix for bug CVE-2020-9484 introduced a time of check, time of use
vulnerability that allowed a local attacker to perform actions with the
privileges of the user that the Tomcat process is using. This issue is only
exploitable when Tomcat is configured to persist sessions using the FileStore.
Also reverts node from 13.14.0 back to 16.13.1. It accidentally slipped in with
OFBIZ-11960
When you use a callback, at this time we haven't to possibility to resolve the area target from the context like this
<wm:link target="WorkEffortAgreement/delete">
....
<wm:set-callback area-target="${useThisTarget}">
...
</wm-setcallback>
</wm:link>
Adding testIntegration in the GH Gradle process does not work.
For a reason I'll not dig in, it ALWAYS fails at:
Cannot find service [indexProductsFromContent] location class
(org.apache.ofbiz.content.search.SearchServices)
The common BB config was broken by Apache Commons (actually a converter issue).
Though the BB syntax checker does not report it's OK, it should be after Sebb's
fix
In general, a <object>TabBar menu is intended to give users access to overview related to the <object>. And a <object>SubTabBar menu is intended to give users to actions to be performed on the <object>, like status changes, adding new records, etc.
The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu
Modified: AccountingMenus.xml
- moved 'edit' menu-item for invoice from InvoiceTabBar menu to InvoiceSubTabBar menu. adjusted label.
Currently the create buttons for the main objects of the catalog components are located within the find and profile widgets/templates of those object.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
added: main action menu, having menu-items for
- new product process
- new store process
- new catalog process
- new category process
subject to catalog create permissions
added: decorator section for inclusion of main action menu where appropriate
Some cleanup
Screen EditProductStoreGroupAndAssoc does not connect with grid forms referenced.
Modified: StoreScreens.xml
moved from form references to grid references
removed screen duplicate
additional cleanup
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
ShipmentGatewayConfigScreens.xml: from form ref to grid ref , additional cleanup
ShipmentGatewayConfigForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
I just tried g npm_outdated undocumented Gradle task and got this result*:
> Task :npm_outdated
Package Current Wanted Latest Location
dompurify 2.3.3 2.3.4 2.3.4 ofbiz-framework
jquery 3.5.1 3.6.0 3.6.0 ofbiz-framework
jquery-migrate 3.3.1 3.3.2 3.3.2 ofbiz-framework
jquery-ui-dist 1.12.1 1.13.0 1.13.0 ofbiz-framework
This updates accordingly. I keep this task open as an umbrella tasks for similar
subtasks in future like we have OFBIZ-10213
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
FacilityGroupScreens.xml: from form ref to grid ref , additional cleanup
FacilityGroupForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
According to the definition in widget-form.xsd the use of a combination
of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
FacilityScreens.xml: from form ref to grid ref , additional cleanup
FacilityForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
Thanks: Jacques for inspiration and guidance, Aditya Sharma for sharing
thoughts and visions and Ingo Richter for finding this gem.
- changed grid 'EditProductPriceRulesCondition' list-name to reflect
correct list
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/EditBillingAccount?billingAccountId=9010
Modified:
BillingAccountScreens.xml
- screen EditBillingAccount: restructured to work with view permissions
- screen CommonBillingAccountDecorator: added label visible to all billing account screens
- additional cleanup
BillingAccountForms.xml
- added form BillingAccount for users with VIEW permission
- additional cleanup
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.
Modified:
ShippingScreens.xml in product: from form ref to grid ref , additional cleanup
ShippingForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
Currently the create buttons for the main objects of the marketing application are located
within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz,
and thus the appeal of it for adopters and users, these create buttons/links/etc.
should be in a main action menu visible at all times when a user is working within
the application of the component.
Modified:
MarketingMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
ContactListScreens.xml
DataSourceScreens.xml
MarketingCampaignScreens.xml
MarketingReportScreens.xml
SegmentScreens.xml
TrackingCodeScreens.xml
Currently the create buttons for the main objects of the humanres plugin are located within find and profile widgets/templates of those objects.
In order to improve the usability of this plugin, OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the web appliclation of the component.
Modified:
HumanresMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
EmplLeaveScreens.xml
EmployeeScreens.xml
EmploymentScreens.xml
PartyQualScreens.xml
PartyResumeScreens.xml
PartySkillsScreens.xml
PerfReviewScreens.xml
This complements previous commit:
<<After another issue reported today by Steven Payne on user ML about the
execution policy of PowerShell7, rather than using the pwsh path I document in
README.adoc solutions for cases we crossed so far.>>
with also trivial formatting.
Thanks: David S Hunter and Steven Payne for reports on user ML
After another issue reported today by Steven Payne on user ML about the
execution policy of PowerShell7, rather than using the pwsh path I document in
README.adoc solutions for cases we crossed so far.
Moreover I noticed today that my previous fix was not enough. "pwsh" was used
twice in the cmd line!
Thanks: David S Hunter and Steven Payne for reports on user ML
This complete the previous Improvement, Rendering different HTML container types with ScreenRenderer (OFBIZ-10495), where the xml macro are forgotten.
In same time resynchronise also missing macro renderColumn*
Tentative to fix issues reported by SonarCloud:
Unexpected shorthand "margin" after "margin-right"
Unexpected duplicate "padding"
Also try changes for INFRA-22689
"No status emails sent to commits@ofbiz.apache.org"
Related to BuildBot migration from 0.8 to 3.2 version (INFRA-22279).
Also to test the BuildBot Rat build, now updated by Gavin
I have also to check why the README.PDF file is not there:
https://nightlies.apache.org/ofbiz/trunk/readme/pdf/