Commit Graph
28265 Commits
Author SHA1 Message Date
Jacques Le Roux 51930641c5 Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)
The issue exists also in the older version.

The field "requirementByDate" form "FindApprovedProductRequirements" in
RequirementForms.xml has been set wrongly and it should be "requiredByDate".

This causes the result could not be queried out properly as indicated as below:

The result is governed by the service "getRequirementsForSupplier",
where reads the list from the view "RequirementAndRole".
In the view entity definition, the field is defined as
<alias entity-alias="RQ" name="requiredByDate"/>,
but it is not the case in the form "FindApprovedProductRequirements" above.

After changing it to the correct name, the bug is solved.

jleroux: Same exists in OrderEntryForms::FindRequirements

Thanks: Schumann Ye for report Pierre Smits for creating the initial PR494
2022-01-31 12:25:04 +01:00
Jacques Le Roux d324f6abee Fixed: Attribute 'placeholder' is not allowed to appear in element 'text'
Completes the previous fix by Wei Zhang. This was committed at a wrong place
for OFBIZ-5341. Only text was concerned, not date-time
2022-01-29 10:57:31 +01:00
Jacques Le Roux bbc5757782 Fixed: Upgrade Tomcat from 9.0.54 to 9.0.58 (OFBIZ-12539)
The fix for bug CVE-2020-9484 introduced a time of check, time of use
    vulnerability that allowed a local attacker to perform actions with the
    privileges of the user that the Tomcat process is using. This issue is only
    exploitable when Tomcat is configured to persist sessions using the FileStore.

Also reverts node from 13.14.0 back to 16.13.1. It accidentally slipped in with
OFBIZ-11960
2022-01-26 12:40:29 +01:00
Nicolas Malin 4936f6f145 Improved: Use flexible expander to resolve the area target on call back (OFBIZ-12509)
When you use a callback, at this time we haven't to possibility to resolve the area target from the context like this

                <wm:link target="WorkEffortAgreement/delete">
                    ....
                    <wm:set-callback area-target="${useThisTarget}">
                       ...
                    </wm-setcallback>
                </wm:link>
2022-01-24 07:16:36 +01:00
Jacques Le Roux 8b3e8b5a22 Improved: no functional change, removes tests in GH actions
Adding testIntegration in the GH Gradle process does not work.

For a reason I'll not dig in, it ALWAYS fails at:
Cannot find service [indexProductsFromContent] location class
(org.apache.ofbiz.content.search.SearchServices)
2022-01-15 12:23:35 +01:00
Jacques Le Roux 1a022418d0 Improved: no functional change, add tests to GH actions
Buildbot is stale at the moment and it's better to not rely only on it.
This adds testIntegration to the GH Gradle process
2022-01-15 10:00:36 +01:00
Jacques Le Roux 8a0bdbaf3b Fixed: no functional change, changes VERSION file to test BB 22 config
Since bb_worker4_ubuntu is stale
temporary trying with bb_worker5_ubuntu
2022-01-14 15:16:22 +01:00
Jacques Le Roux f6e5b85a05 Fixed: no functional change, removes a space in VERSION file to test BB 22 config
The common BB config was broken by Apache Commons (actually a converter issue).
Though the BB syntax checker does not report it's OK, it should be after Sebb's
fix
2022-01-13 14:04:42 +01:00
Jacques Le Roux 937ecd5098 Fixed: no functional change, just adds a space in Version to test BB config
IRC ofbiz-bot is planned by Infra to be available this month
2022-01-13 13:23:50 +01:00
Jacques Le Roux 2d7ceaa6b5 Fixed: no functional change, right version (22.01) in gradle.yaml (fix a typo)
This will also allow to test the just updated BB config, thanks to Pierre's
report on dev ML
2022-01-13 10:57:22 +01:00
Jacques Le Roux a114a20ba8 Fixed: no functional change, right version (22.01) in gradle.yaml
This will also allow to test the just updated BB config, nothing happened last
time no ideas why yet...
2022-01-13 10:14:05 +01:00
Jacques Le Roux 1c8e598ece Fixed: no functional change, right version (22.01) in README.adoc
This will also allow to test the just updated BB config
2022-01-13 09:32:06 +01:00
Jacques Le Roux 958ef1185e Fixed: Updates README.adoc file from trunk to next 2022-01-10 19:17:35 +01:00
Jacques Le Roux 02a13d9f3c Fixed: Updates codeql-analysis.yml file from trunk to release22.01 2022-01-10 18:34:35 +01:00
Jacques Le Roux e13d335618 Fixed: Updates VERSION file from trunk to release22.01 2022-01-10 18:32:18 +01:00
Jacques Le Roux 7f7026e5da Improved: makes a French label consistent on the page
Both "Points d'accord commercial" and "Liste des articles de l'accord" were used
Now only "article" is used no longer "point"
2022-01-10 10:36:00 +01:00
Pierre Smits bbe64fa19e Improved: Move edit of invoice header to InvoiceSubTabBar (OFBIZ012440) (#409)
In general, a <object>TabBar menu is intended to give users access to overview related to the <object>. And a <object>SubTabBar menu is intended to give users to actions to be performed on the <object>, like status changes, adding new records, etc.
The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu

Modified: AccountingMenus.xml
- moved 'edit' menu-item for invoice from InvoiceTabBar menu to InvoiceSubTabBar menu. adjusted label.
2022-01-10 10:23:50 +01:00
Pierre Smits 70a9ef70d7 Improved: Have a Menu in Catalog featuring actions to create the main objects (OFBIZ-11774) (#433)
Currently the create buttons for the main objects of the catalog components are located within the find and profile widgets/templates of those object.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.

added: main action menu, having menu-items for
- new product process
- new store process
- new catalog process
- new category process
subject to catalog create permissions

added: decorator section for inclusion of main action menu where appropriate

Some cleanup
2022-01-09 15:54:54 +01:00
Pierre Smits 9bf15d0a49 Fixed: Store Group screen don't connect with grids (OFBIZ-12481) (#435)
Screen EditProductStoreGroupAndAssoc does not connect with grid forms referenced.

Modified: StoreScreens.xml
moved from form references to grid references
removed screen duplicate
additional cleanup
2022-01-09 15:51:11 +01:00
Pierre Smits a9adf8de71 Improved: List and Grid (OFBIZ-11345) (#434)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ShipmentGatewayConfigScreens.xml: from form ref to grid ref , additional cleanup
ShipmentGatewayConfigForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-09 09:19:06 +01:00
Jacques Le Roux c3a6636e40 Improved: Use gradlew npm_outdated gradle-node-plugin taks to check outdated scripts (OFBIZ-12480)
I just tried g npm_outdated undocumented Gradle task and got this result*:

> Task :npm_outdated
Package         Current  Wanted  Latest  Location
dompurify         2.3.3   2.3.4   2.3.4  ofbiz-framework
jquery            3.5.1   3.6.0   3.6.0  ofbiz-framework
jquery-migrate    3.3.1   3.3.2   3.3.2  ofbiz-framework
jquery-ui-dist   1.12.1  1.13.0  1.13.0  ofbiz-framework

This updates accordingly. I keep this task open as an umbrella tasks for similar
subtasks in future like we have OFBIZ-10213
2022-01-08 13:04:10 +01:00
Jacques Le Roux 83d0880ab8 Improved: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)
Updates flot from 0.8.2 to 4.2.2 using npm
2022-01-08 11:18:40 +01:00
Pierre Smits 1b0b723887 Improved: List and Grid (OFBIZ-11345) (#432)
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
FacilityGroupScreens.xml: from form ref to grid ref , additional cleanup
FacilityGroupForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-08 08:59:28 +01:00
Pierre Smits bcd23f784b Improved: List and Grid (OFBIZ-11345) (#431)
According to the definition in widget-form.xsd the use of a combination
of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
FacilityScreens.xml: from form ref to grid ref , additional cleanup
FacilityForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-07 09:47:03 +01:00
Pierre Smits dcef04cfe2 Improved: VIEW permissions FinAccount mutations (OFBIZ-12451) (#410)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account mutations screen  sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with):
https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw

Modified:
- FinAccountScreens.xml: work with permissions, added ref to mutations template for user with VIEW permission
Added:
- Mutations.ftl template.
2022-01-07 09:03:05 +01:00
bjugl 4ae01b94f1 Improved: Replace ELRTE plugin with Trumbowyg (OFBIZ-10093) (#425)
Thanks: Jacques for inspiration and guidance, Aditya Sharma for sharing
thoughts and visions and Ingo Richter for finding this gem.

- changed grid 'EditProductPriceRulesCondition' list-name to reflect
correct list
2022-01-07 12:16:27 +05:30
Pierre Smits b9af0ccb09 Improved: Remove unused labels from AccountingUiLabels.xml (OFBIZ-9352) (#413)
Removing unused labels from AccountingUiLabels.xml
Checked screens, forms, templates, scripts and java code
2022-01-06 17:19:35 +01:00
Pierre Smits 583ccf966d Improved: VIEW permissions BillingAccount (OFBIZ-12457) (#414)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/EditBillingAccount?billingAccountId=9010

Modified:
BillingAccountScreens.xml
- screen EditBillingAccount: restructured to work with view permissions
- screen CommonBillingAccountDecorator: added label visible to all billing account screens
- additional cleanup
BillingAccountForms.xml
- added form BillingAccount for users with VIEW permission
- additional cleanup
2022-01-06 17:14:10 +01:00
Pierre Smits a22aff5659 Improved: Invoice - CommonInvoiceDecorator (OFBIZ-12458) (#415)
Modified: InvoiceScreens.xml
- moved invoice menus to pre-body decorator section
- moved label to above menus for the invoice
- additional cleanup
2022-01-06 16:58:46 +01:00
Pierre Smits 6e46892a6f Improved: Agreement - CommonAgreementDecorator (OFBIZ-12462) (#418)
title of an agreement is shown below its menu(s).

Modified: AgreementScreens.xml
moved label involving agreement title to pre-body decorator-section
2022-01-06 16:47:05 +01:00
Pierre Smits c7ebb3ffbf Improved: List and Grid (OFBIZ-11345) (#426)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ShippingScreens.xml in product: from form ref to grid ref , additional cleanup
ShippingForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-06 12:00:31 +01:00
Pierre Smits 2779c99bce Improved: Have a menu in Marketing featuring actions to create main objects (OFBIZ-11783) (#428)
Currently the create buttons for the main objects of the marketing application are located
within find and profile widgets/templates of those objects.

In order to improve the usability of this application, OFBiz,
and thus the appeal of it for adopters and users, these create buttons/links/etc.
should be in a main action menu visible at all times when a user is working within
the application of the component.

Modified:
MarketingMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
ContactListScreens.xml
DataSourceScreens.xml
MarketingCampaignScreens.xml
MarketingReportScreens.xml
SegmentScreens.xml
TrackingCodeScreens.xml
2022-01-06 11:58:45 +01:00
Pierre Smits 75aeb494a0 Improved: Have a Menu in Humanres featuring actions to create the main objects (OFBIZ-11777) (#429)
Currently the create buttons for the main objects of the humanres plugin are located within find and profile widgets/templates of those objects.

In order to improve the usability of this plugin, OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the web appliclation of the component.

Modified:
HumanresMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
EmplLeaveScreens.xml
EmployeeScreens.xml
EmploymentScreens.xml
PartyQualScreens.xml
PartyResumeScreens.xml
PartySkillsScreens.xml
PerfReviewScreens.xml
2022-01-06 11:56:26 +01:00
Pierre Smits 4f18c3f0f1 Improved: Dutch translations (OFBIZ-10363) (#430)
some cleanup (duplicate) and improved Dutch translations
2022-01-06 11:23:44 +01:00
Jacques Le Roux b3d77d4ef4 Documented: Gradle Wrapper is not downloaded with 18.12.03 (OFBIZ-12471)
This complements previous commit:
<<After another issue reported today by Steven Payne on user ML about the
execution policy of PowerShell7, rather than using the pwsh path I document in
README.adoc solutions for cases we crossed so far.>>
with also trivial formatting.

Thanks: David S Hunter and Steven Payne for reports on user ML
2022-01-04 10:40:39 +01:00
Jacques Le Roux 6e46edfb37 Fixed: Gradle Wrapper is not downloaded with 18.12.03 (OFBIZ-12471)
After another issue reported today by Steven Payne on user ML about the
execution policy of PowerShell7, rather than using the pwsh path I document in
README.adoc solutions for cases we crossed so far.

Moreover I noticed today that my previous fix was not enough. "pwsh" was used
twice in the cmd line!

Thanks: David S Hunter and Steven Payne for reports on user ML
2022-01-03 18:41:35 +01:00
Nicolas Malin 7341e5662c Fixed: Screen Xml renderer failed on renderContainer[Begin,End] ftl macro (OFBIZ-12478)
This complete the previous Improvement, Rendering different HTML container types with ScreenRenderer (OFBIZ-10495), where the xml macro are forgotten.

In same time resynchronise also missing macro renderColumn*
2022-01-03 10:22:48 +01:00
Jacques Le Roux 6a3e4e0ee3 Improved: updates NOTICE to 2022 2022-01-02 19:35:05 +01:00
Jacques Le Roux 27200c9f2b Implemented: No status emails sent to commits@ofbiz.apache.org by BuildBot (OFBIZ-12477)
This fixes temporarily and voluntarily broken accounting-tests-data-load test
case by adding a previously removed letter
2022-01-02 12:07:21 +01:00
Jacques Le Roux 326435e3a0 Implemented: No status emails sent to commits@ofbiz.apache.org by BuildBot (OFBIZ-12477)
This temporarily and voluntarily breaks the tests, by removing a letter to
accounting-tests-data-load test case
2022-01-02 11:38:11 +01:00
Jacques Le Roux fce5d349f5 Improved: Improve Helveticus theme (OFBIZ-12276)
Tentative to fix issues reported by SonarCloud:
  Unexpected shorthand "margin" after "margin-right"
  Unexpected duplicate "padding"

Also try changes for INFRA-22689
"No status emails sent to commits@ofbiz.apache.org"
2022-01-02 09:16:18 +01:00
Jacques Le Roux 6b7e6c3fc0 Documented: no reason to have a "+" there, on same line is OK 2022-01-01 18:04:47 +01:00
Jacques Le Roux 4dc2b3eab9 Improved: Adds missing ASL2 header in exclude.xml
Reported by https://nightlies.apache.org/ofbiz/trunk/rat-output.html
2022-01-01 13:19:26 +01:00
Jacques Le Roux f4fcc63cc4 Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)
No functional change (adds a space in VERSION file) to test RAT changes in new
Buildbot config
2021-12-31 20:24:52 +01:00
Jacques Le Roux 5b991402e1 Documented: Changes link to HTML README (OFBIZ-12456)
Related to BuildBot migration from 0.8 to 3.2 version (INFRA-22279).
Also to test the BuildBot Rat build, now updated by Gavin

I have also to check why the README.PDF file is not there:
https://nightlies.apache.org/ofbiz/trunk/readme/pdf/
2021-12-31 11:49:50 +01:00
Jacques Le Roux 952519e898 Documented: Changes "Default User Documentation website uri" (OFBIZ-12456)
Related to BuildBot migration from 0.8 to 3.2 version (INFRA-22279).
2021-12-31 10:47:02 +01:00
Jacques Le Roux af7fde656b Revert "Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)"
This reverts commit 14e31c1653.

Got an issue while swithing to R18
2021-12-29 18:26:09 +01:00
Jacques Le Roux 14e31c1653 Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)
No functional change (adds a space in LICENSE file) to test R18 change in new
Buildbot config
2021-12-29 18:22:33 +01:00
Jacques Le Roux e2f9e021c7 Improved: Migrate Ofbiz bb 0.8 config to 3.2 (OFBIZ-12456)
No functional change (removes a space in LICENSE file) to test a change in new
Buildbot config
2021-12-29 09:26:59 +01:00
Jacques Le Roux a744965567 Fixed: [SECURITY] CVE-2021-44832: Apache Log4j2 (OFBIZ-12475)
See complete explanation at https://issues.apache.org/jira/browse/OFBIZ-12475
2021-12-29 09:05:30 +01:00