Commit Graph
28 Commits
Author SHA1 Message Date
Jacques Le Roux 29705efa65 Improved: Add global web.xml to simplify session timeout configuration (OFBIZ-12255)
Currently, session timeout is configured in apps separately, but session is
shared globally, so the smallest one take effects, and it will not take effect
separately for different apps.

Then it is both inconvenient and confusing to increase session timeout value,
as all values in those files need to be updated.

A global web.xml is needed, to simplify session timeout configuration.

Thanks: Xin Wang
2021-06-22 15:51:32 +02:00
Jacques Le Roux 369d5f6c95 Fixed: Ensure that the SameSite attribute is set to 'strict' for all cookies.
(OFBIZ-11470)

As reported by OWASP ZAP:
A cookie has been set without the SameSite attribute, which means that the
cookie can be sent as a result of a 'cross-site' request. The SameSite attribute
is an effective counter measure to cross-site request forgery, cross-site script
inclusion, and timing attacks.

The solution was not obvious in OFBiz for 2 reasons:

1. There is no HttpServletResponse::setHeader. So we need to use a filter
  (SameSiteFilter) and even that is not enough because of 2:
2. To prevent session fixation we force Tomcat to generates a new jsessionId,
ultimately put in cookie, in LoginWorker::login. So we need to add a call to
SameSiteFilter::addSameSiteCookieAttribute in
UtilHttp::setResponseBrowserDefaultSecurityHeaders.
2020-03-20 17:50:17 +01:00
Samuel Trégouët 62c617eeec Fixed: Add XML declaration in “web.xml” files
(OFBIZ-6993)

These declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-12-07 22:58:29 +01:00
Mathieu Lirzin 3b14e7afa9 Reverted: "Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)"
This reverts commit a93b1fcb78.
2019-11-27 21:42:33 +01:00
Mathieu Lirzin b006b8c7cb Revert "Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993)"
This reverts commit 226e901981.
2019-11-27 21:40:10 +01:00
Samuel Trégouët 226e901981 Improved: Update “web.xml” files version 3.0 → 4.0 (OFBIZ-6993) 2019-11-27 17:29:41 +01:00
Samuel Trégouët a93b1fcb78 Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)
these declarations avoid SAXParseException traceback when parsing web.xml
the first time in WebappUtil.parseWebXmlFile
2019-11-27 17:28:44 +01:00
Jacques Le Roux d2485c4069 Fixed: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Following "Session timeout for webapps" discussion on dev ML 
https://markmail.org/message/p6fbiojjrwb2ybxd

We decided to put back the session-timeout value in web.xml files and to remove
the line
    session.setMaxInactiveInterval(60*60); //in seconds
from ControlEventListener.java

Thanks: Deepak Nigam for report and Girish Vasmatkar for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1851068 13f79535-47bb-0310-9956-ffa450edef68
2019-01-11 16:12:01 +00:00
Deepak Dixit 1620e4e0ca Improved: No functional change, Only added license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812309 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 18:43:14 +00:00
Jacques Le Roux 456ad70aca Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Programmatically replaces the web.xml <session-config> declarations and uses 
the @WebListener annotation to start the process. This avoid to duplicates 
things everywhere in web.xml files. Since the web.xml files have precedence 
on annotations, the setting can be easily overridden when necessary.

Now that we also use HTTPS in ecommerce the ecommerce session cookie is 
also secured.

I also noted that we had 8 weird <session-timeout> declarations:
    in solr component: <session-timeout>2</session-timeout>
    in themes: <session-timeout>1</session-timeout>

Also in Rainbowstone we lacked the <cookie-config> and <tracking-mode> 
declarations. I think it's not good.

I resolve these points by simply removing the <session-config> in web.xml files 
of themes and Solr.

Thanks: Pradhan Yash Sharma  for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811041 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 07:12:57 +00:00
Jacques Le Roux 70fc173a0d No functional changes, code cleaning
While working on OFBIZ-9230 I noticed those needed changes



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785861 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 17:11:35 +00:00
Jacopo Cappellato 794a4dfbbb Implemented: removed the "controller" related logic, that is now provided by the
new ControlFilter, from the ContextFilter; modified existing applications to use 
the two filters in a chain; removed from the other specialized filters all the 
logic that was duplicated or extended from ContextFilter.

A web application, in order to leverage the OFBiz framework, requires that a 
series of objects are in its contexts (servlet context, session and request) 
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented 
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related 
to access control and redirection rules (some of them performed in coordination 
with the ControlServlet), making it difficult to deploy this filter in all the 
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the 
OFBiz codebase: specifically it was not deployed in web applications that 
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the 
ones in the "ecommerce" and "solr" components.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761304 13f79535-47bb-0310-9956-ffa450edef68
2016-09-18 08:08:30 +00:00
Pranay Pandey 8dd9964d31 [OFBIZ-7311] - Applied the patch from the ticket. Removing the unused references of the maincss.css from source code, following is done-
1) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
Reason: Since, there is no file like 'maincss.css' exist under any includes directory. 
2) Removed the unused references of maincss.css from FTLs, code
<link rel="stylesheet" href="${StringUtil.wrapString(baseUrl!)}/images/maincss.css" type="text/css"/> 
has been removed.
Reason: This is an interesting thing, these FTLs were using the maincss.css located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0 
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic HTML code to style, instead of using style defined in 'maincss.css' which were exist in release-4.0
4) Updated some references from 'maincss.css' to style.css in comments.
5) Also removed the entry of including '/images/maincss.css' and '/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.

Thanks Wai for reviewing the work and thanks Swapnil M Mane for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1758389 13f79535-47bb-0310-9956-ffa450edef68
2016-08-30 13:37:27 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Jacques Le Roux 9bbd16e9fa Temporary fix for "UtilXml.LocalResolver.resolveEntity] could not find LOCAL DTD/Schema with publicId [null] and the file/resource is [web-app_3_0.xsd]" - https://issues.apache.org/jira/browse/OFBIZ-6807
As suggested by Deepak keeps only <<web-app version="3.0">> in web.xml files instead of whole xmlns and schemaLocation. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726388 13f79535-47bb-0310-9956-ffa450edef68
2016-01-23 11:52:08 +00:00
Jacques Le Roux c06e6f7f62 2 modified patches from Rahul Bhammarker for "Add session tracking mode and make cookie secure" https://issues.apache.org/jira/browse/OFBIZ-6655
Need to enhance security at web-app level. 
As per current implementation:
- The cookie containing the session identifier is not secure
- The session identifier is transmitted in the query string of the URL

To fix these issue we have to add following session config otpions in web.xml
{code}
<session-config>
	<cookie-config>
	    <http-only>true</http-only>
	    <secure>true</secure>
	</cookie-config>
	<tracking-mode>COOKIE</tracking-mode>
</session-config>
{code}

Also we need to update the web-app servlet specification from 2.3 to 3.0
{code}
<web-app version="3.0"
        xmlns="http://java.sun.com/xml/ns/javaee"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://java.sun.com/xml/ns/javaee
                            http://java.sun.com/xml/ns/javaee/web-app_3_0.xsd">
{code}
https://tomcat.apache.org/whichversion.html

jleroux: these are only the framework+themes+applications patches, with 3 entries not applied


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1719872 13f79535-47bb-0310-9956-ffa450edef68
2015-12-14 10:02:24 +00:00
Arun Patidar 3865ff485d [OFBIZ-6171] Applied patch from Pierre Smits for replacing 'Open for Business' references with 'Apache OFBiz'.Thanks Pierre for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1706589 13f79535-47bb-0310-9956-ffa450edef68
2015-10-03 14:15:21 +00:00
Adrian Crum dcecdd25a4 Reorganized the screen widget src folder so classes are more organized.
This commit might break some Groovy scripts. There seemed to be a lot of C&P widget import statements, but there were no widget classes being used in the script, so I removed them. I might have overlooked something though.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652852 13f79535-47bb-0310-9956-ffa450edef68
2015-01-18 21:03:40 +00:00
Jacques Le Roux 438fb59265 Puts a better comment in templates/web.xml
Remove useless and confusing websiteId in web.xml files

I did not remove some others, but I believe they don't make sense as they are.
Take for instance those data
<WebSite webSiteId="EBAY_STORE1" siteName="eBay Store1" standardContentPrefix="http://demo.ofbiz.org" productStoreId="90101"/>
<WebSite webSiteId="EBAY_STORE2" siteName="eBay Store2" standardContentPrefix="http://demo.ofbiz.org" productStoreId="90102"/>
<WebSite webSiteId="GOOGLEBASE" standardContentPrefix="http://demo.ofbiz.org" productStoreId="9000" />

Sorry but http://demo.ofbiz.org/ leads nowhere!

And do we need to keep those referring to productStoreId="9000" in web.xml files? They have not their own webapps
<WebSite webSiteId="CmsSite" siteName="CMS Web Site"/>
<WebSite webSiteId="OfbizSite" siteName="OFBiz Web Site"/>
<WebSite webSiteId="GOOGLECHECKOUT" productStoreId="9000" />
<WebSite webSiteId="GOOGLECHECKOUT" productStoreId="9000" />

I think we should keep in web.xml files, only ecommerce/clone and webPos (uses POS store)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1526686 13f79535-47bb-0310-9956-ffa450edef68
2013-09-26 21:07:10 +00:00
Adrian Crum eaee24fd1f Added missing DOCTYPE declarations in some web.xml files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1243422 13f79535-47bb-0310-9956-ffa450edef68
2012-02-13 07:08:03 +00:00
Adrian Crum 4b7cd7434a Changed the screen widget boundary comment behavior per a discussion on the dev mailing list. Setting the widget.properties file widget.verbose property to false now acts like a "master switch" to turn off all widget boundary comments - it ignores all other settings. If the property is set to true, then the setting can be overridden in web.xml or in the screen context.
This commit also removes the demonstration widgetVerbose setting in the Example component's web.xml file - which caused some confusion, and it comments out the setting in the web.xml file that is used for creating new components.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172954 13f79535-47bb-0310-9956-ffa450edef68
2011-09-20 02:55:44 +00:00
Hans Bakker 0a59303a34 remove the rest of the website definitions from seed data, the ones that are left are in the demo data
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1158099 13f79535-47bb-0310-9956-ffa450edef68
2011-08-16 03:43:06 +00:00
Jacques Le Roux 9ef845d0ad A patch from BJ Freeman "complete web.xml for error reporting" (https://issues.apache.org/jira/browse/OFBIZ-3820) - OFBIZ-3820
BJ: when there is an error, the control servlet looks for an error path in <param-name>allowedPaths</param-name>
it does not find one throwing an exception which buries the orginal error.
instead of changing the code it is just easier to add the /error: path.
then the real error gets reported correctly.

JLR: This will maybe help to better understand some errors on demo servers, and can't hurt

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@954135 13f79535-47bb-0310-9956-ffa450edef68
2010-06-12 20:47:08 +00:00
Vikas Mayur 2d9fd7e6fb Removed unwanted newlines from the templates files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@937961 13f79535-47bb-0310-9956-ffa450edef68
2010-04-26 08:22:57 +00:00
Ashish Vijaywargiya 5cbccfe029 Applied patch from jira issue OFBIZ-3509 - create-component ant task creates web.xml with hardcoded values of "example" for webSiteId and localDispatcherName.
Thanks Chris for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@916243 13f79535-47bb-0310-9956-ffa450edef68
2010-02-25 10:55:02 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 66b80767e4 A patch from Bruno Busco "WebSiteId parameter description" (https://issues.apache.org/jira/browse/OFBIZ-2232) - OFBIZ-2232
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751216 13f79535-47bb-0310-9956-ffa450edef68
2009-03-07 07:59:46 +00:00
Jacopo Cappellato 83ad2d2294 Ant target for the automatic creation of an ofbiz component in the hot-deploy folder.
ant create-component

You will be prompted for:
1) component name (e.g. "test")
2) component resource name (e.g. "Test")
3) webapp name (e.g. "testapp")
4) base permission (e.g. "TEST")

and the target will create the component in the hot-deploy folder.
Restart ofbiz and the new application will be up and running.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741605 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 16:04:05 +00:00