Commit Graph
12 Commits
Author SHA1 Message Date
Jacques Le Roux 6727f469dc Reverted: work related to PartyRole handling initiated with (OFBIZ-5980)
Currently OFBiz is broken and hard to fix. You can't even create an order !

Revert "Improved: visibility of expire button (OFBIZ-12362) (#331)"
This reverts commit e3b125ef4c.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#330)"
This reverts commit a8ab2be55a.

Revert "Improved: seed data (OFBIZ-12355) (#328)"
This reverts commit b204b867b4.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 85e066deb3.

Revert "Reverted: damn I did not revert the right push :/"
This reverts commit b867b2a89f.

Revert "(OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#325)"
This reverts commit 8ed2252df8.

Revert "Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 5b5e03f71b.

Revert "Improved: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)"
This reverts commit 46f7ee91d3.

Revert "Improved: seed data (OFBIZ-12353) (#324)"
This reverts commit fade92bb57.
2021-11-08 20:41:51 +01:00
Pierre Smits a8ab2be55a (OFBIZ-5980) Improvement: PartyRole record(s) expiration/revocation (#330)
added/changed/updated:
- added field definition for from and through date to the entity
- added service for expiration
- request-map for expiration
- appropriate forms to work with  added entity fields
- added groovy code to check existing when adding PartyRole record and call expiration service if needed
- adding fromDate value to seed, test and demo data
2021-11-02 11:36:52 +01:00
Jacques Le Roux 85e066deb3 Reverted: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)
Reverts commit 46f7ee91d3

Reverted on Pierre Smits kindly asking for authoring by pushing a PR, not only a
thanks while committing his patch after testing it locally
2021-11-02 10:30:51 +01:00
Jacques Le Roux 46f7ee91d3 Improved: Have the ability to revoke (expire) roles of a party (OFBIZ-5980)
Currently it only possible to delete a role. That can lead to potential error
messages, when a particular role is associated with records where the roleTypeId
is used as a foreign key in the entity-model/database and the user tries to
delete that role from the list.

In order to avoid such, it is better to revoke the PartyRole record by setting
an expiration date (end date) on the record.

Thanks: Pierre Smits
2021-11-01 12:46:29 +01:00
Jacques Le Roux b76d95d72a Improved: Unit test case for service - testSendOrderChangeNotification
(OFBIZ-8811)(OFBIZ-9647)(OFBIZ-9671)

While working on this I stumbled upon an issue related with 
webSiteId="OrderEntry" well related by Ratnesh Upadhyay in OFBIZ-9647.

Unlike him I decided not to remove the webSiteId="OrderEntry" entries but to
replace them by webSiteId="WebStore"

Tests pass!


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1867889 13f79535-47bb-0310-9956-ffa450edef68
2019-10-02 14:46:00 +00:00
Suraj Khurana 5dfb8a24cd Improved: Unit test case for service - CreateReturnItemShipment.
(OFBIZ-8859)
Thanks Avnindra Sharma for reporting the issue and Yogesh Naroliya for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1860005 13f79535-47bb-0310-9956-ffa450edef68
2019-05-25 16:45:44 +00:00
Suraj Khurana 2da3a43aa1 Fixed: Test integration were failing if plugins directory is empty due to dependent data on projectmgr component.
This came into notice after revision 1856609.
Thanks Jacques for reporting it and everyone else who participated in the discussion.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1859111 13f79535-47bb-0310-9956-ffa450edef68
2019-05-11 11:58:20 +00:00
Suraj Khurana 362f154b74 Added: Unit test case for service - CreateReturnAdjustment.
(OFBIZ-8857)
Thanks Avnindra Sharma for reporting, Pawan Verma for discussion and Vivek Singh Bisen for providing the updated patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1856609 13f79535-47bb-0310-9956-ffa450edef68
2019-03-30 07:12:25 +00:00
Rishi Solanki cfef87d6f1 Improved: Remove empty field values from xml data files so that it will not override existing data with empty values. Removed all empty data fields from data files.
(OFBIZ-10282)
Thanks to Arun Patidar for reporting and review.
Thanks to Suraj Khurana for providing patch for the improvement.
Thanks to Jacques for discussion and finalizing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830545 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 10:52:55 +00:00
Rishi Solanki 00260d1204 Improvement: Missing Relationship from OrderHeader to WebSite (OFBIZ-9647). Added relationship from order header to website entity. And removed wrong data.
Applied patch from (OFBIZ-9647). Thanks Ratnesh Upadhyay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1809749 13f79535-47bb-0310-9956-ffa450edef68
2017-09-26 14:33:05 +00:00
Deepak Dixit 52d5517c44 Improved: Added unit test case for following order related services
- SetCustRequestStatus
- GetRequirementsForSupplier
- GetNextQuoteId
 - GetCustRequestsByRole
 - CreateRequirementRole
 - CreateRequirementFromItemATP
 - CreateCustRequestContent
 - CreateCustRequestAttribute
 - CreateAutoRequirementsForOrder
 - CreateATPRequirementsForOrder
 - CopyQuoteItem
 - CopyCustRequestItem


 (OFBIZ-8962)(OFBIZ-8961)(OFBIZ-8960)(OFBIZ-8959)(OFBIZ-8957)(OFBIZ-8956)(OFBIZ-8945)(OFBIZ-8944)(OFBIZ-8943)(OFBIZ-8942)(OFBIZ-8941)(OFBIZ-8940)

Thanks Avnindra Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768214 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 13:37:02 +00:00
Deepak Dixit 6ebf17a01b Improved: Unit test case for service - sendOrderConfirmation
(OFBIZ-8507)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1766723 13f79535-47bb-0310-9956-ffa450edef68
2016-10-26 19:10:14 +00:00