Commit Graph
14749 Commits
Author SHA1 Message Date
Jacques Le Roux 51930641c5 Fixed: Wrong Field Name Definition in RequirementForms (OFBIZ-12505)
The issue exists also in the older version.

The field "requirementByDate" form "FindApprovedProductRequirements" in
RequirementForms.xml has been set wrongly and it should be "requiredByDate".

This causes the result could not be queried out properly as indicated as below:

The result is governed by the service "getRequirementsForSupplier",
where reads the list from the view "RequirementAndRole".
In the view entity definition, the field is defined as
<alias entity-alias="RQ" name="requiredByDate"/>,
but it is not the case in the form "FindApprovedProductRequirements" above.

After changing it to the correct name, the bug is solved.

jleroux: Same exists in OrderEntryForms::FindRequirements

Thanks: Schumann Ye for report Pierre Smits for creating the initial PR494
2022-01-31 12:25:04 +01:00
Jacques Le Roux 7f7026e5da Improved: makes a French label consistent on the page
Both "Points d'accord commercial" and "Liste des articles de l'accord" were used
Now only "article" is used no longer "point"
2022-01-10 10:36:00 +01:00
Pierre Smits bbe64fa19e Improved: Move edit of invoice header to InvoiceSubTabBar (OFBIZ012440) (#409)
In general, a <object>TabBar menu is intended to give users access to overview related to the <object>. And a <object>SubTabBar menu is intended to give users to actions to be performed on the <object>, like status changes, adding new records, etc.
The menu-item for editing the invoice header (aptly translated as 'Header') is currently located in the InvoiceTabBar menu in AccountingMenus.xml.
Given that this menu-item is intended for users with UPDATE permissions and to give those users access to a screen to edit the data, this menu-item must move to the InvoiceSubTabBar menu

Modified: AccountingMenus.xml
- moved 'edit' menu-item for invoice from InvoiceTabBar menu to InvoiceSubTabBar menu. adjusted label.
2022-01-10 10:23:50 +01:00
Pierre Smits 70a9ef70d7 Improved: Have a Menu in Catalog featuring actions to create the main objects (OFBIZ-11774) (#433)
Currently the create buttons for the main objects of the catalog components are located within the find and profile widgets/templates of those object.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.

added: main action menu, having menu-items for
- new product process
- new store process
- new catalog process
- new category process
subject to catalog create permissions

added: decorator section for inclusion of main action menu where appropriate

Some cleanup
2022-01-09 15:54:54 +01:00
Pierre Smits 9bf15d0a49 Fixed: Store Group screen don't connect with grids (OFBIZ-12481) (#435)
Screen EditProductStoreGroupAndAssoc does not connect with grid forms referenced.

Modified: StoreScreens.xml
moved from form references to grid references
removed screen duplicate
additional cleanup
2022-01-09 15:51:11 +01:00
Pierre Smits a9adf8de71 Improved: List and Grid (OFBIZ-11345) (#434)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ShipmentGatewayConfigScreens.xml: from form ref to grid ref , additional cleanup
ShipmentGatewayConfigForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-09 09:19:06 +01:00
Pierre Smits 1b0b723887 Improved: List and Grid (OFBIZ-11345) (#432)
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
FacilityGroupScreens.xml: from form ref to grid ref , additional cleanup
FacilityGroupForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-08 08:59:28 +01:00
Pierre Smits bcd23f784b Improved: List and Grid (OFBIZ-11345) (#431)
According to the definition in widget-form.xsd the use of a combination
of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
FacilityScreens.xml: from form ref to grid ref , additional cleanup
FacilityForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-07 09:47:03 +01:00
Pierre Smits dcef04cfe2 Improved: VIEW permissions FinAccount mutations (OFBIZ-12451) (#410)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account mutations screen  sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with):
https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
https://demo-trunk.ofbiz.apache.org/accounting/control/FindPaymentsForDepositOrWithdraw

Modified:
- FinAccountScreens.xml: work with permissions, added ref to mutations template for user with VIEW permission
Added:
- Mutations.ftl template.
2022-01-07 09:03:05 +01:00
bjugl 4ae01b94f1 Improved: Replace ELRTE plugin with Trumbowyg (OFBIZ-10093) (#425)
Thanks: Jacques for inspiration and guidance, Aditya Sharma for sharing
thoughts and visions and Ingo Richter for finding this gem.

- changed grid 'EditProductPriceRulesCondition' list-name to reflect
correct list
2022-01-07 12:16:27 +05:30
Pierre Smits b9af0ccb09 Improved: Remove unused labels from AccountingUiLabels.xml (OFBIZ-9352) (#413)
Removing unused labels from AccountingUiLabels.xml
Checked screens, forms, templates, scripts and java code
2022-01-06 17:19:35 +01:00
Pierre Smits 583ccf966d Improved: VIEW permissions BillingAccount (OFBIZ-12457) (#414)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the billing account screen, sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with): https://demo-trunk.ofbiz.apache.org/accounting/control/EditBillingAccount?billingAccountId=9010

Modified:
BillingAccountScreens.xml
- screen EditBillingAccount: restructured to work with view permissions
- screen CommonBillingAccountDecorator: added label visible to all billing account screens
- additional cleanup
BillingAccountForms.xml
- added form BillingAccount for users with VIEW permission
- additional cleanup
2022-01-06 17:14:10 +01:00
Pierre Smits a22aff5659 Improved: Invoice - CommonInvoiceDecorator (OFBIZ-12458) (#415)
Modified: InvoiceScreens.xml
- moved invoice menus to pre-body decorator section
- moved label to above menus for the invoice
- additional cleanup
2022-01-06 16:58:46 +01:00
Pierre Smits 6e46892a6f Improved: Agreement - CommonAgreementDecorator (OFBIZ-12462) (#418)
title of an agreement is shown below its menu(s).

Modified: AgreementScreens.xml
moved label involving agreement title to pre-body decorator-section
2022-01-06 16:47:05 +01:00
Pierre Smits c7ebb3ffbf Improved: List and Grid (OFBIZ-11345) (#426)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ShippingScreens.xml in product: from form ref to grid ref , additional cleanup
ShippingForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2022-01-06 12:00:31 +01:00
Pierre Smits 2779c99bce Improved: Have a menu in Marketing featuring actions to create main objects (OFBIZ-11783) (#428)
Currently the create buttons for the main objects of the marketing application are located
within find and profile widgets/templates of those objects.

In order to improve the usability of this application, OFBiz,
and thus the appeal of it for adopters and users, these create buttons/links/etc.
should be in a main action menu visible at all times when a user is working within
the application of the component.

Modified:
MarketingMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
ContactListScreens.xml
DataSourceScreens.xml
MarketingCampaignScreens.xml
MarketingReportScreens.xml
SegmentScreens.xml
TrackingCodeScreens.xml
2022-01-06 11:58:45 +01:00
Pierre Smits 75aeb494a0 Improved: Have a Menu in Humanres featuring actions to create the main objects (OFBIZ-11777) (#429)
Currently the create buttons for the main objects of the humanres plugin are located within find and profile widgets/templates of those objects.

In order to improve the usability of this plugin, OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the web appliclation of the component.

Modified:
HumanresMenus.xml - added MainActionMenu
To following screens - added ref to MainActionMenu, clean-up
CommonScreens.xml
EmplLeaveScreens.xml
EmployeeScreens.xml
EmploymentScreens.xml
PartyQualScreens.xml
PartyResumeScreens.xml
PartySkillsScreens.xml
PerfReviewScreens.xml
2022-01-06 11:56:26 +01:00
Pierre Smits 4f18c3f0f1 Improved: Dutch translations (OFBIZ-10363) (#430)
some cleanup (duplicate) and improved Dutch translations
2022-01-06 11:23:44 +01:00
Jacques Le Roux 27200c9f2b Implemented: No status emails sent to commits@ofbiz.apache.org by BuildBot (OFBIZ-12477)
This fixes temporarily and voluntarily broken accounting-tests-data-load test
case by adding a previously removed letter
2022-01-02 12:07:21 +01:00
Jacques Le Roux 326435e3a0 Implemented: No status emails sent to commits@ofbiz.apache.org by BuildBot (OFBIZ-12477)
This temporarily and voluntarily breaks the tests, by removing a letter to
accounting-tests-data-load test case
2022-01-02 11:38:11 +01:00
Pierre Smits 03b16828da Improved: List and Grid (OFBIZ-11345) (#427)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
ProductScreens.xml in product: from form ref to grid ref , additional cleanup
ProductForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2021-12-29 08:27:10 +01:00
Jacques Le Roux 8c6d3272bd Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Fixes random  object created and used only once in classes:
  SSLUtil
  OrderTestServices
  FinAccountHelper
  GiftCertificateServices

Also related minor formatting in HashCrypt and ContextFilter
2021-12-28 12:11:12 +01:00
Pierre Smits 1d21cfbe75 Improved: Have a Menu in Order featuring actions to create the main objects (OFBIZ-11772) (#407)
Currently the create buttons for the main objects of the order components are located within the find and profile widgets/templates of those object.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.

Modified:
added: MainActionMenu for the order component, having:

menu-item to start the order creation
menu-item to start the quote creation
menu-item to start the request creation
menu-item to start the requirement creation
menu-item to start the return creation
menu-item to start the allocation plan creation
removed: menu-item to create a request from RequestSubTabBar
AllocationPlanScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
CommonScreens.xml
improved: grouping regarding customer requests
CustRequestScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
removed 'menu-bar' decorator section
OrderEntryCommonScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
OrderReturnScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
removed: 'basic-nav' container
OrderViewScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
QuoteScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
removed: container with create quote link
QuoteWorkEffortScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
ReportScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
RequirementScreens.xml
added: decorator-section for pre-body to include the MainActionMenu
removed: container having create link
2021-12-28 11:09:47 +01:00
Jacques Le Roux 4e01679854 Improved: suppresses 2 warnings related to deprecated CSVFormat.DEFAULT.withHeader()
This was not done correctly last time (previous commit e4d4329)
2021-12-26 19:20:43 +01:00
Jacques Le Roux e4d43297a9 Improved: suppresses 2 warnings related to deprecated CSVFormat.DEFAULT.withHeader()
Also adds a try-with-ressource in InvoiceServices::importInvoice to properly
close csvReader on returns. Hence removes an useless csvReader.close().

Several comments about Eclipse giving wrong advice
<<Resource leak: '<unassigned Closeable value>' is not closed at this location>>
It's OK, we are inside try-with-ressources.

Finally removes a redundant final in PartyServices::importParty
2021-12-26 18:22:48 +01:00
Jacques Le Roux 06092ae0af Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
As advised by SpotBugs:

<<This code creates a java.util.Random object, uses it to generate one random
number, and then discards the Random object. This produces mediocre quality
random numbers and is inefficient. If possible, rewrite the code so that the
Random object is created once and saved, and each time a new random number is
required invoke a method on the existing Random object to obtain it.

If it is important that the generated Random numbers not be guessable, you must
not create a new Random for each random number; the values are too easily
guessable. You should strongly consider using a java.security.SecureRandom
instead (and avoid allocating a new SecureRandom for each random number needed).

Rank: Troubling (14), confidence: High
Pattern: DMI_RANDOM_USED_ONLY_ONCE
Type: DMI, Category: BAD_PRACTICE (Bad practice)>>

uses <<private static final SecureRandom SECURE_RANDOM = new SecureRandom();>>
in classes:
PaymentGatewayServices
ValueLinkApi
ContactMechServices
ProductStoreWorker
DesCrypt
HashCrypt
EntityCrypto
ContextFilter.java

Despite doing so SpotButs still reports the same error for those classes.
As it's obviously an error I prefer to not excludes those cases that will maybe
not be reported in a future version of SpotButs in Eclipse. For instance they
are not reported at all in previous version (4.5.1) but are in 4.5.2
2021-12-26 14:50:32 +01:00
Pierre Smits 8d7d4eb14e Improved: List and Grid (OFBIZ-11345) (#422)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
WorkEffortScreens.xml and CommonScreens.xml in product: from form ref to grid ref , additional cleanup
WorkEffortRelatedSummary.xml and CommonScreens.xml in product: from form ref to grid ref , additional cleanup
WorkEffortForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2021-12-26 09:19:34 +01:00
Pierre Smits a4cbc2c7bc Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450) (#424)
* Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450)

When adding a Price Rule, whether it be a Product Category, Product, Party, Party Classification, the system doesn't show a price difference.
The price rules work with the Database as they do get changed when saved. But their functionality doesn't work, it won't give a price increase or decrease or restriction.

Modified:
Various data files to enhance demonstration of price rule functionality

Modified: ProductDemoData.xml
- restructured some price rule data elements
- added additional price rule data elements

Modified:
PriceServices.java: added partyClassificationGroupId to the mix
2021-12-22 16:06:03 +01:00
Pierre Smits 75dab17c87 Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450) (#420)
* Fixed: Price Rules: Price rules configurations are not syncing with eCommerce storefront (OFBIZ-12450)

When adding a Price Rule, whether it be a Product Category, Product, Party, Party Classification, the system doesn't show a price difference.
The price rules work with the Database as they do get changed when saved. But their functionality doesn't work, it won't give a price increase or decrease or restriction.

Modified:
Various data files to enhance demonstration of price rule functionality

* Improved: Price Rule (OFBIZ-12450)

Modified: ProductDemoData.xml
- restructured some price rule data elements
- added additional price rule data elements
2021-12-18 09:19:25 +01:00
Pierre Smits a8538c24fd Fixed: PriceRule - values of existing ProductPriceCond record not shown (OFBIZ-12467) (#421)
When a price rule is shown in the screen, the associated existing conditions are not shown in the overview for the conditions
Modified: Priceforms.xml
- changed grid 'EditProductPriceRulesCondition' list-name to reflect correct list
2021-12-18 09:18:38 +01:00
Pierre Smits ea7c4f155b Fixed: PriceScreens.xml - incorrect reference in screen (OFBIZ-12465) (#419)
With commit 92533b5 the reference in screen FindProductPriceRule was not changed
when the relating object in PriceForms.xml changed from form to grid.

Modified: PriceScreens.xml
changed reference in FindProductPriceRule from include-form to include-grid
2021-12-17 09:55:53 +01:00
Jacques Le Roux b9735b208a Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
Finally it's better to use || than | (did not check well last time) in
ProductSearchSession::makeSearchParametersString
kc.isAnyPrefix() || kc.isAnySuffix()
So also removes the exclusion

No problem for report field in AbstractReportThread as explained in exclude.xml
2021-12-16 13:09:38 +01:00
Jacques Le Roux ae42c968bf Fixed: Have configuration options for accounting (OFBIZ-6189)
When set to "Y" and loaded in memory the create.invoice.per.shipment
SystemProperty invalidates the testInvoicePerShipmentSetFalse integration test.bat

This temporarily comment it out in order to go on with INFRA-22279

This is a related message: https://markmail.org/message/agurw2linzu2comj
where alternatives are suggested

Thanks: Pierre Smits for the help
2021-12-13 11:49:23 +01:00
Pierre Smits 45e89bdd1e Improved: Accounting remove create trigger for objects (OFBIZ-12447) (#404)
With the implementation of the Accounting MainActionMenu, various menu-items and/or other triggers to create an object are now obsolete

modified:
AccountingMenus.xml
- removed 'create' menu-items for invoice and payment
GlScreens.xml
- removed trigger for a new gl transaction.
2021-12-12 17:59:07 +01:00
Pierre Smits 1c4ca97b72 Improved: List and Grid (OFBIZ-11345) (#405)
According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
PromoScreens.xml: from form ref to grid ref , additional cleanup
PromoForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up
2021-12-12 17:55:54 +01:00
Pierre Smits 9dbdcb63cc Improved: Have a Menu in Manufacturing featuring actions to create the main objects (OFBIZ-11782) (#406)
Currently the create buttons for the main objects of the manufacturing application are located within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz and thus the appeal of it for adopters and users, these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the appliclation of the component.

modified:
ManufacturingMenus.xml - added MainActionMenu
CommonScreens.xlm - added pre-body decorator-section with MainActionMenu ref.
2021-12-12 17:23:24 +01:00
Pierre Smits 7b492abd89 Improved: Have configuration options for Content (OFBIZ-6670) (#398)
Improved: Have configuration options for Content (OFBIZ-6670)

The configuration of an OFBiz is determined by 2 aspects:
configuration settings required to successfully start the implementation
configuration settings required to have component functions work properly
The latter involve default choices for various functions to cater to the usability of business processes (and therefore screen/forms and/or screens/templates.
Several of these configuration settings are already loaded into the SystemProperty table in the underlying RDBMS, to enable adjustments of the systemPropertyValue while the implementation is in use. While it is not expected that these settings change often, it is possible that they are required to be changed during the lifespan of the company/organisation.
However, it should not be required to go through a deployment process of regarding such changed configuration settings in the OFBiz production instance (which most - if not all - companies/organisations require when files are changes).
Having all configuration settings of components in the SystemProperty table enhances the usability of OFBiz allowing system administrators to adjust the value(s) of system property records while the instance keeps running.

added: SystemProperty records in ContentSystemPropertyData.xml
Modified:
ofbiz-component.xml: reference of ContentSystemPropertyData.xml to load at seed loading moment

added:  missing SystemProperty records in ContentSystemPropertyData.xml

Thanks to Jacques for the review
2021-12-12 14:07:53 +01:00
Jacques Le Roux 4de3a37c54 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In ProposedOrder::calculateStartDate and TimeDuration::TimeDuration better use a
long directly (efficiency)

In ConfigXMLReader, removes unused getViewMap method

In ServiceArtifactInfo, some formatting and in writeServiceCallGraphEoModel
method add missing <<if (calledServiceSet != null) {>>

Adds and documents false positives in exclude.xml.
Remains 14 issues, I'll document them in the Jira and 'll later discuss them
on dev ML (committers attention needed). None of them are security issues :)
C:/projectsASF/Git/ofbiz-framework/plugins/rest-api/src/main/java/org/apache/ofbiz/ws/rs/listener/ApiContextListener.java:38 Ecriture d'un champ statique org.apache.ofbiz.ws.rs.listener.ApiContextListener.servletContext depuis la méthode d'une instance org.apache.ofbiz.ws.rs.listener.ApiContextListener.contextInitialized(ServletContextEvent) [Of Concern(15), High confidence]
C:/projectsASF/Git/ofbiz-framework/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/GenericMapValues.java:49 org.apache.ofbiz.base.util.collections.GenericMapValues.equals(Object) checks for operand being a java.util.List  [Troubling(14), High confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/ldap/src/main/java/org/apache/ofbiz/ldap/cas/OFBizCasAuthenticationHandler.java:91 Déréférencement immédiat du résultat d'un readLine() dans org.apache.ofbiz.ldap.cas.OFBizCasAuthenticationHandler.login(HttpServletRequest, HttpServletResponse, Element) [Of Concern(15), Normal confidence]
C:/projectsASF/Git/ofbiz-framework/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/GenericMapValues.java:49 org.apache.ofbiz.base.util.collections.GenericMapValues.equals(Object) checks for operand being a java.util.Set  [Troubling(14), High confidence]
C:/projectsASF/Git/ofbiz-framework/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java:875 Un appel de méthode dans new org.apache.ofbiz.widget.renderer.macro.MacroFormRendererTest$36(MacroFormRendererTest, ModelForm) passe null à un paramètre déréférencé de façon inconditionnelle dans org.apache.ofbiz.webapp.control.RequestHandler.makeLink(HttpServletRequest, HttpServletResponse, String) [Scary(8), Normal confidence]
C:/projectsASF/Git/ofbiz-framework/framework/widget/src/test/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRendererTest.java:848 Un appel de méthode dans new org.apache.ofbiz.widget.renderer.macro.MacroFormRendererTest$35(MacroFormRendererTest, ModelForm) passe null à un paramètre déréférencé de façon inconditionnelle dans org.apache.ofbiz.webapp.control.RequestHandler.makeLink(HttpServletRequest, HttpServletResponse, String) [Scary(8), Normal confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/src/main/java/org/apache/ofbiz/ecommerce/janrain/JanrainHelper.java:71 Ecriture d'un champ statique org.apache.ofbiz.ecommerce.janrain.JanrainHelper.apiKey depuis la méthode d'une instance new org.apache.ofbiz.ecommerce.janrain.JanrainHelper(String, String) [Of Concern(15), High confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/pricat/src/main/java/org/apache/ofbiz/htmlreport/AbstractReportThread.java:160 Champ jamais écrit : org.apache.ofbiz.htmlreport.AbstractReportThread.report [Troubling(12), Normal confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/ecommerce/src/main/java/org/apache/ofbiz/ecommerce/janrain/JanrainHelper.java:72 Ecriture d'un champ statique org.apache.ofbiz.ecommerce.janrain.JanrainHelper.baseUrl depuis la méthode d'une instance new org.apache.ofbiz.ecommerce.janrain.JanrainHelper(String, String) [Of Concern(15), High confidence]
C:/projectsASF/Git/ofbiz-framework/framework/base/src/main/java/org/apache/ofbiz/base/util/cache/CacheSoftReference.java:29 org.apache.ofbiz.base.util.cache.CacheSoftReference est Serializable mais sa super-classe ne possède pas de constructeur par défaut visible [Troubling(14), High confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/ldap/src/main/java/org/apache/ofbiz/ldap/activedirectory/OFBizActiveDirectoryAuthenticationHandler.java:110 Alimentation à perte d'une variable locale dans la méthode org.apache.ofbiz.ldap.activedirectory.OFBizActiveDirectoryAuthenticationHandler.getLdapSearchResult(String, String, Element, boolean) [Of Concern(15), High confidence]
C:/projectsASF/Git/ofbiz-framework/plugins/ldap/src/main/java/org/apache/ofbiz/ldap/openldap/OFBizLdapAuthenticationHandler.java:95 Alimentation à perte d'une variable locale dans la méthode org.apache.ofbiz.ldap.openldap.OFBizLdapAuthenticationHandler.getLdapSearchResult(String, String, Element, boolean) [Of Concern(15), High confidence]
C:/projectsASF/Git/ofbiz-framework/framework/base/src/main/java/org/apache/ofbiz/base/util/collections/FlexibleServletAccessor.java:193 org.apache.ofbiz.base.util.collections.FlexibleServletAccessor.equals(Object) checks for operand being a String  [Troubling(14), High confidence]
C:/projectsASF/Git/ofbiz-framework/framework/service/src/main/java/org/apache/ofbiz/service/test/XmlRpcTests.java:47 Ecriture d'un champ statique org.apache.ofbiz.service.test.XmlRpcTests.url depuis la méthode d'une instance new org.apache.ofbiz.service.test.XmlRpcTests(String) [Of Concern(15), High confidence]
2021-12-11 16:21:36 +01:00
Jacques Le Roux 8b9fc99d7d Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In ProductWorker::getProductFeaturesApplIncludeMarketingPackage fixes a possible
null dereferencement (tested too late)

In FileUtil::unZip uses a try-w-resource w/ ZipFile to close it. I crossed an
issue with automated OOTB formatting (clean-up on save in Eclipse). Fixed with
my external default editor (could not find where to change that in
OFBizJavaFormatter.xml

In ServiceArtifactInfo::calledServiceEcaSet fixes a possible null dereferencement
(tested too late), also minor formatting

In MacroScreenRenderer::renderScreenletSubWidget fixes a possible null
dereferencement (tested too late)

in FileUtil
2021-12-10 16:09:42 +01:00
Pierre Smits 0babdf468f Improved: List and Grid (OFBIZ-11345) (#397)
* Improved: List and Grid (OFBIZ-11345)

According to the definition in widget-form.xsd the use of a combination of a form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor various list form references in screens.

Modified:
InvoiceScreens.xml: from form ref to grid ref , additional cleanup
InvoiceForms.xml: from form definition with list ref to grid definition with list ref, additional clean-up

* Improved: List and Grid (OFBIZ-11345)

Modified:
InvoiceScreens.xml: missed ref to ListInvoicePaymentInfo in InvoiceScreens.xml
2021-12-10 11:04:37 +01:00
Jacques Le Roux 4494d071fa Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442)
PR399 missed GlTransaction
2021-12-10 10:24:49 +01:00
Jacques Le Roux 2702f93806 Improved: replaces CommonNew by CommonCreate in AccountingMenus
Why Create instead of New (and surely no Create New, which is, at least in
French, a pleonasm, and we have already replaced everywhere)?

Mostly because it's an action so a verb is appropriate.
2021-12-10 09:58:24 +01:00
Pierre Smits e736a5fc70 Improved: Have a Menu in Accounting featuring actions to create the main objects (OFBIZ-11780) (#403)
Currently the create buttons for the main objects of the accounting application are located within find and profile widgets/templates of those objects.
In order to improve the usability of this application, OFBiz and thus the appeal of it for adopters and users, these create buttons/links/etc. should be in a main action menu visible at all times when a user (with the CREATE permission) is working within the application of the component.

Modified:
- AccountingMenus.xml: added MainActionMenu for users with CREATE permission
- AgreementScreens.xml: added ref to MainActionMenu in CommonAgreementDecorator
- BillingAccountScreens.xml: added ref to MainActionMenu in CommonBillingAccountDecorator
- BudgetScreens.xml: added ref to MainActionMenu in various appropriate screens
- CommonScreens.xml: added ref to MainActionMenu in various appropriate screens
- FinAccountScreens.xml: added ref to MainActionMenu in CommonFinAccountDecorator
- FixedAssetScreens.xml: added ref to MainActionMenu in various appropriate screens
- InvoiceScreens.xml: added ref to MainActionMenu in CommonInvoiceDecorator
- PaymentGatewayConfigScreens.xml: added ref to MainActionMenu in GenericPaymentGatewayConfigDecorator
- PaymentGroupScreens.xml: added ref to MainActionMenu in FindPaymentGroup
- PaymentScreens.xml: added ref to MainActionMenu in CommonPaymentDecorator
- TaxAuthorityScreens.xml: added ref to MainActionMenu in CommonTaxAuthorityDecorator
- TransactionScreens.xml: added ref to MainActionMenu in GenericTransactionDecorator
2021-12-10 09:49:36 +01:00
Pierre Smits 7c4a7512b4 Improved: VIEW permissions show ManufacturingTabBar items (OFBIZ-12442) (#399)
Currently, when a user with only VIEW permissions accesses the manufacturing component menu-items of the ManufacturingAppBar are not shown due to too restrictive conditions.
These menu-items allow users to access various overviews related to manufacturing, like
 * production runs,
 * routings (production schemas),
 * routing task (schema tasks),
 * production calendar,
 * etc.

Improved:
ManufacturingMenus.xml - removed 'CREATE' condition from menu-items in ManufacturingAppBar, additional title improvement(s)
ManufacturingUiLabels.xml - updated labels regarding menu-items in ManufacturingAppBar.
2021-12-10 09:48:15 +01:00
Jacques Le Roux 0aa06d9c3d Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In WebToolsServices::entityImportDir fixes a possible null dereferencement
In ProductionRunServices::createProductionRunFromConfiguration fixes a possible
null dereferencement and remove 2 unused vars
2021-12-10 09:42:28 +01:00
Jacques Le Roux bf269556a4 Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In UspsServices::uspsPriorityMailInternationalLabel better complete fixes for
product possible null dereferencements
2021-12-09 11:55:40 +01:00
Pierre Smits d538b84164 Improved: VIEW permissions Payment Attributes (OFBIZ-12439) (#396)
Though there is an entity PaymentAttribute this cannot be accessed by user with VIEW permissions when accessing a Payment.
See:
for entity data: https://demo-trunk.ofbiz.apache.org/webtools/control/entity/find/PaymentAttribute
test payment: https://demo-trunk.ofbiz.apache.org/accounting/control/paymentOverview?paymentId=8003

Modified:
AccountingMenus.xml
added menu-item for payment attributes to InvoiceTabBar menu
controller.xml
added request-map and view-map for request paymentAttributes
PaymentScreens.xml
added screen for payment attributes
PaymentForms.xml
added grid to display payment attributes
AccountingUiLabels.xml - added label PageTitlePaymentAttributes, used in screen PaymentAttributes
2021-12-09 10:28:18 +01:00
Jacques Le Roux 5a64c3d27d Improved: Fix some bugs Spotbugs reports (OFBIZ-12386)
In exclude.xml:
removes Confidence lines, no need to complicate things
Adds 2 DC_DOUBLECHECK false reports; synchronized is used there (maybe not the
best way but it's OK as is)

In ProductConfigWrapper::equals fixes use of == instead of equals (tested)
In UspsServices::uspsPriorityMailInternationalLabel fixes 2 possible null
dereferencements

In EntityExpr::checkRhsType fixes a possible null dereferencement
2021-12-09 07:25:25 +01:00
Pierre Smits 25dc02412d Fixed: Weird behaviour with currency symbols (OFBIZ-12443) (#400)
* Fixed: Weird behaviour with currency symbols (OFBIZ-12443)

In some screens the $ currency symbol is not showing well.

Modified:
FinAccountTrans.ftl - fixed a typo
FinAccountForms.xml: ensured that for the monetary amount fields (actualBalance and availableBalance) the correct currencyUomId value is taken
2021-12-09 07:05:05 +01:00
Pierre Smits c9c494982c Improved: VIEW permissions FinAccount transactions (OFBIZ-12438) (#395)
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk demo with userId = auditor, accessing the Financial Account transactions screen  sees editable fields and/or triggers (to requests) reserved for users with 'CREATE' or 'UPDATE' permissions.
See (test with):
https://demo-trunk.ofbiz.apache.org/accounting/control/EditFinAccount?finAccountId=ABN_CHECKING
https://demo-trunk.ofbiz.apache.org/accounting/control/FindFinAccountTrans

Modified:
FinAccountScreens.xml: restructured screen FindFinAccountTrans
FinAccountForms.xml: improved form FindFinAccountTrans

Added:
FinAccountTrans.ftl, for users with VIEW permissions, additional cleanup
FinAccountTransTotals.ftl, improve legibility of code of FinAccountTrans.ftl
2021-12-08 11:21:16 +01:00