Commit Graph
23904 Commits
Author SHA1 Message Date
Hans Bakker 3c15931494 missing </div> and reduce length of lines
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774853 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 07:01:48 +00:00
Michael Brohl 97ba34128e Improved: refactor javadocs in OFBiz to be standards compliant
(OFBIZ-9144)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774815 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 23:34:51 +00:00
Michael Brohl 5a3c73fc2f Improved: Client side validation required in Tax Infos (Add Party Tax Authority Info).
(OFBIZ-7437)

Thanks: Padmavati Rawat for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774806 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:51:52 +00:00
Michael Brohl 2d7fb26c99 Improved: Client side validation is missing at Add Ebay Configuration form.
(OFBIZ-7866)

Thanks: Deepak Nigam for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774805 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:46:29 +00:00
Michael Brohl 1fae29d4a7 Improved: Client side validation is missing at Create Ebay Account form.
(OFBIZ-7952)

Thanks: Deepak Nigam for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774804 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:41:31 +00:00
Michael Brohl 5b74eac710 Improved: Client side validation is missing at Create User Login form.
(OFBIZ-7984)

Thanks: Deepak Nigam for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774802 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:37:10 +00:00
Michael Brohl 76e73ad5c0 Improved: Proper client side validation while creating price rule from catalog manager.
(OFBIZ-7307)

Thanks: Suraj Khurana for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774801 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:31:14 +00:00
Michael Brohl 260c6c0424 Improved: Require client side validation while creating Product Association.
(OFBIZ-7424)

Thanks: Padmavati Rawat for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774800 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:27:22 +00:00
Michael Brohl 59d7b72ce0 Improved: Client side validation on Add product categories form in catalog.
(OFBIZ-7425)

Thanks: Suraj Khurana for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774799 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:20:55 +00:00
Michael Brohl fbcff9ffdc Improved: Client side validation required in Add Billing Accounts Role.
(OFBIZ-7429)

Thanks: Padmavati Rawat for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774798 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 20:12:53 +00:00
Michael Brohl bee722c1f1 Improved: Client Side validation missing on Create New Tax Authority Form.
(OFBIZ-7436)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774796 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 19:56:27 +00:00
Michael Brohl 2017ee3091 Improved: Client Side validation missing on Create Payment screen.
(OFBIZ-7430)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774794 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:27:13 +00:00
Michael Brohl 9d3ffe77d6 Improved: Proper Form validation should be added while creating new agreement product.
(OFBIZ-7441)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774790 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:22:43 +00:00
Michael Brohl 3da2380660 Improved: Proper form validation should be there while creating Agreement Item Party.
(OFBIZ-7458)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774788 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:18:58 +00:00
Michael Brohl 0615bf828f Improved: Proper form validation should be there while creating Agreement Item Facility.
(OFBIZ-7461)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774786 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:15:10 +00:00
Michael Brohl d196677a16 Improved: Proper form validation should be there while creating Agreement Roles.
(OFBIZ-7511)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774785 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 16:09:55 +00:00
Michael Brohl e0f14c91c2 Improved: Proper Form Validation should be there while adding new Example Feature.
(OFBIZ-7476)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774776 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 15:25:12 +00:00
Michael Brohl 9bb0dc5f4a Fixed: Error occurred when making Shopping list public/private from Party Detail screen.
(OFBIZ-7683)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774772 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 15:11:03 +00:00
Michael Brohl 9608823026 Improved: corrected typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774737 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 11:12:13 +00:00
Jacques Le Roux 344ffc3e92 No functional change to test svn to git sync
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774731 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 10:42:39 +00:00
Deepak Dixit 38e185ea02 Improved: Add Party criteria to Routing Tasks
(OFBIZ-9134)
Thanks  Paul Foxworthy  and Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774725 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 09:04:23 +00:00
Jacques Le Roux d8f924f0ee No functional change, assures that all Java files are svn:native
This is mostly related with the new pricat component and 2 files in cmssite (I 
guess also related with the new pricat component )

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774165 13f79535-47bb-0310-9956-ffa450edef68
2016-12-14 10:16:04 +00:00
Taher A. Alkhateeb 71f512a0d2 Improved: refactor javadocs in OFBiz to be standards compliant
(OFBIZ-9144)

This is the first commit to the above mentioned issue which fixes many javadoc
errors dispersed through the different components. The fixes are not
necessarily improvements to the javadocs but rather making them valid javadocs
to prevent reporting errors from gradle


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1774154 13f79535-47bb-0310-9956-ffa450edef68
2016-12-14 09:22:32 +00:00
Jacques Le Roux 6bc29e380d No functional change, removes an useless duplicated line
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773603 13f79535-47bb-0310-9956-ffa450edef68
2016-12-11 19:51:30 +00:00
Jacques Le Roux ab05e107fc No functional change, fixes wrong package-names, not sure these files are even
needed...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773541 13f79535-47bb-0310-9956-ffa450edef68
2016-12-10 21:20:42 +00:00
Jacques Le Roux 09060ba56a No functional change, fixes a wrong package-name
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773540 13f79535-47bb-0310-9956-ffa450edef68
2016-12-10 21:16:18 +00:00
Jacopo Cappellato 635657bbc5 Fixed: removed a redundant null check and parenthesis.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773405 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 14:21:56 +00:00
Jacopo Cappellato 2dc10024e4 Fixed: removed empty file (invalid class), a leftover of the commit that
removed Cobertura some time ago.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773363 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 11:40:33 +00:00
Jacopo Cappellato d15dabb392 Fixed: incorrect @see reference to method in Javadoc.
Thanks: Taher Alkhateeb for the report. 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773354 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 10:33:54 +00:00
Jacopo Cappellato bd40d8526f Fixed: a series of wrong argument names in Javadoc comments.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773338 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 08:49:56 +00:00
Jacopo Cappellato 262e87f79e Fixed: form macros with incorrect arguments.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773337 13f79535-47bb-0310-9956-ffa450edef68
2016-12-09 08:47:41 +00:00
Deepak Dixit dac6b95849 Improved: Added user friendly error message in duplicateProduct service, if passed productId already exists than return uer friendly error message instead of entity exception.
(OFBIZ-7402)
   
   Thanks Arvind and Padma for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773213 13f79535-47bb-0310-9956-ffa450edef68
2016-12-08 11:03:26 +00:00
Taher A. Alkhateeb 7a2de0e59b Improved: Refactor and simplify the startup sequence in OFBiz
(OFBIZ-8337)

Fix a minor exclusion typo in the sourceSets block

Thanks: Jacques Le Roux for reporting the issue


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773202 13f79535-47bb-0310-9956-ffa450edef68
2016-12-08 09:17:04 +00:00
Jacques Le Roux 2e084123de No functional change, updates the demos to run R16.11 as stable and 13.07 as old
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773090 13f79535-47bb-0310-9956-ffa450edef68
2016-12-07 14:44:34 +00:00
Shi Jinghai 71acaf13e7 Improved: LoginWorker HashCrypt the type of hash for one-way encryption
(OFBIZ-8537)

Committed wangjunyuan's new patch.

Thanks: wangjunyuan for the new patch to make the PBKDF2 hashed password comply with RFC 6070, the feedbacks of Jacques and Nicolas on the previous patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773066 13f79535-47bb-0310-9956-ffa450edef68
2016-12-07 12:45:15 +00:00
Shi Jinghai 0cf495ae73 Fixed: Add a PriCat component under specialpurpose
(OFBIZ-9123)

Removed the following duplicated labels in PricatUiLabels.xml:
ExcelTableNoRow
ExcelTableColumnNumberNotMatch
ExcelTableColumnNotMatch
ExcelParsingRow

Thanks: Jacques points out these bugs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773058 13f79535-47bb-0310-9956-ffa450edef68
2016-12-07 11:50:47 +00:00
Jacques Le Roux 02621aef12 No functional change, remove a duplicated labels put in with r1768256
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1773029 13f79535-47bb-0310-9956-ffa450edef68
2016-12-07 09:13:28 +00:00
Shi Jinghai a2854c96ee Reverted: LoginWorker HashCrypt the type of hash for one-way encryption
(OFBIZ-8537)

Change the currentPassword of flexadmin back to SHA format as the PBKDF2 password string in the patch doesn't follow RFC standard.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772899 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 14:17:01 +00:00
Deepak Dixit d09255c0b7 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Taher A. Alkhateeb 8074a9b3c6 Improved: Refactor and simplify the startup sequence in OFBiz
(OFBIZ-8337)

This is another major commit to the refactoring of the startup sequence in
OFBiz with the following highlighted changes:

- Delete the NativeLibClassLoader.java
- Delete the native classpath logic in Classpath.java
- Refactor the ComponentContainer and StartupControlPanel to operate without
  the NativeLibClassLoader. This substantially simplifies the code
- Declare a URLClassLoader in ComponentContainer that is instantiated upon
  building the classpath for all components. This makes the classloader start
  in one shot
- Simplify the Config file and remove fields that are not used. Also
  refactor some messy logic for loading the props file and other code
  improvements
- Refactor all the .properties files for startup to have a consistent
  structure that clearly documents all available properties and the
  default value for each property. This change is also related to the
  changes applied on Config.java
- Remove the declaration of the StartupLoader implementation class
  from all startup .properties files because only one implementation exists
  and it should be the default always.
- Refactor the loaders retrieval code (main, rmi, test, load-data) defined
  in the startup .properties files
- Refactor some switch statements to comply with java coding standards
- Add the DTDs defined in base through Gradle because we removed the
  NativeLibClassLoader and the classpath buildup logic in StartupControlPanel

Thanks: Jacopo Cappellato for reviewing the work


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772879 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:31:00 +00:00
Taher A. Alkhateeb 03bb6055d6 Improved: removed unused runtime libraries
Some runtime libraries were migrated fromt old jar files in OFBiz and are
no longer necessary for the system to perform properly. Hence we are deleting
these libraries from the build script dependencies.

Discussion reference: http://markmail.org/message/j4ayk7zjzbaf7fhz


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772839 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 08:19:51 +00:00
Shi Jinghai e564df2f42 Fixed: Add a PriCat component under specialpurpose
(OFBIZ-9123)

1. EXCELIMPORT_USERLOGIN is 3 chars too long.
2. should use titles in the relations.

Thanks: Jacques points out these bugs.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772689 13f79535-47bb-0310-9956-ffa450edef68
2016-12-05 15:30:29 +00:00
Shi Jinghai dbcfeaefb0 Implemented: LoginWorker HashCrypt the type of hash for one-way encryption
Added PBKDF2 hash type to encrypt password.

Thanks: wangjunyuan for this contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772589 13f79535-47bb-0310-9956-ffa450edef68
2016-12-05 01:32:51 +00:00
Christian Geisert 690a90c79b Fixed: Corrected typo which caused calcTaxForDisplay service call to fail (problem with Ecommerce frontend when using showPricesWithVatTax)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772354 13f79535-47bb-0310-9956-ffa450edef68
2016-12-02 14:30:30 +00:00
Deepak Dixit c4dc53c251 Fixed: Added missing code to get the ItemIssuance in setInvoicesToReadyFromShipment service. This bug was introduced at r#1628288 while delegator to EntityQuery convertion. Also added complete code to check null shipment on setInvoicesToReadyFromShipment, code was incompletely implemented.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772346 13f79535-47bb-0310-9956-ffa450edef68
2016-12-02 14:01:57 +00:00
Taher A. Alkhateeb 7d2d6216ca Improved: Refactor and simplify the startup sequence in OFBiz
(OFBIZ-8337)

Continuing the refactoring work on the startup sequence, this commit
specifically focuses on the ComponentContainer and how it loads
components into the system. The following changes are made:

- simplify and cleanup the ofbiz-containers.xml to have only one entry
- substantially simplify the ComponentLoaderConfig class and remove unnecessary defined state
- delete the JustLoadComponentsContainer (used to exist for the server command --testlist which no longer exists)
- fully refactor the ComponentContainer class and breakup the messy logic into chunks of private methods. The methods are also properly documented.
- remove an old reference to the testlist container which no longer exists



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772256 13f79535-47bb-0310-9956-ffa450edef68
2016-12-01 19:29:23 +00:00
Jacopo Cappellato f6bcc33e69 Fixed: Removed duplicated service declarations.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1772081 13f79535-47bb-0310-9956-ffa450edef68
2016-11-30 16:31:23 +00:00
Paul Foxworthy 40119e0db0 [Improved]: Recognise BASE TABLE table type in database metadata (OFBIZ-7129)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771995 13f79535-47bb-0310-9956-ffa450edef68
2016-11-30 06:42:42 +00:00
Deepak Dixit a5c9a1cc7b Completed: Upgrade Tomcat embed websocket jar to 8.0.39
(OFBIZ-9124)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771935 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 18:05:49 +00:00
Jacques Le Roux 2bc1ba2e47 No functional change, just add in build.gradle the syntax when using Xlint.
I know it's in readme, but I tend to look directly in code...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1771932 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 17:54:37 +00:00