Commit Graph
310 Commits
Author SHA1 Message Date
Hans Bakker 0c5a93074c fix the new notification services using sendMailFromTemplateSetting using body parameters
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768245 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 10:08:55 +00:00
Adam Heath 886e885d39 Add a newInstance() variant that takes a collection of reader urls.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765737 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 20:06:18 +00:00
Scott Gray 7531687fdd OFBIZ-2259: Implemented test data rollback per test-suite using the GenericDelegator
Provides the following benefits:
1. Test data independence per component suite
2. Ability to run tests repeatedly without reloading the database
3. Continued database independence for the testing tools
4. The possibility of future improvements for controlling when data is rolled back (per unit test, group of unit tests within a suite or
even tree structured tests where data is partially rolled back before continuing)
5. The future possibility to export data changes resulting from a test run
6. The future possibility to verify a test result automatically based on the output of #4

The rollback currently doesn't catch changes resulting from async service calls and also doesn't rollback changes to SequenceValueItem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765057 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 06:01:36 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath a1a9782939 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759240 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:58:16 +00:00
David E. Jones 4a1705a315 Removed some more references to applications stuff from framework, including small cleanup of service engine to get rid of WebAppDispatcher and use new factory method in GenericDispatcher, and changed AvailableServices.groovy to get the real dispatcher list instead of a hard-coded one; also updated eclipse classpath file for new webslinger stuff
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757671 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 06:27:03 +00:00
Adam Heath a941692516 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757069 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:23:25 +00:00
Adam Heath 231f647742 Typo in javadoc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@753371 13f79535-47bb-0310-9956-ffa450edef68
2009-03-13 20:01:44 +00:00
Adam Heath 9057861730 Add the appropriate configuration to allow webslinger to work at
runtime.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@753084 13f79535-47bb-0310-9956-ffa450edef68
2009-03-13 01:18:54 +00:00
David E. Jones a521969954 Changed the HTML checking to only check and never change values; if they come from a webapp they will already be canonicalized, and for services calling other services and such we don't want to do canonicalization or the like
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751990 13f79535-47bb-0310-9956-ffa450edef68
2009-03-10 06:14:15 +00:00
Jacques Le Roux f0b05c11a9 switch( => switch (
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751007 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:56:24 +00:00
Jacques Le Roux 13a934f823 In spirit of Adam's r749341 and following http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#489
The idea is also that a lot of code is duplicated and then changed (copy/paste). Hence having a rightly formatted code help to keep it rightly formatted
1st (simple) step : ){ => ) { (I checked all occurrences but of course other pairs of eyeballs are welcome)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750993 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:31:13 +00:00
Adam Heath ecd71ac2eb Revert back to the previous version.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750345 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 07:05:04 +00:00
Adam Heath c41f9edc98 Converted to <test-group>, as these are really all related.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750297 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 02:41:37 +00:00
David E. Jones 1a5c2de3c5 Changed LoginWorker.makeLoginUrl back to returning a String and implemented a more general solution for the @ofbizUrl and @ofbizContentUrl tags so that they do decoding and are now tolerant of encoded URLs just in case it happens; this should be a more general fix and avoid the problem more; also a few cleanups like resolving warnings
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744418 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 08:17:05 +00:00
David E. Jones 09825430f1 Added new allow-html tag on the attribute, auto-attribute, and override elements; has 3 options: none, safe, and any; the comments in the XSD file describe what each of these do; the important thing to know is that none is the default meaning no html is allowed; if html is needed use safe and look at the antisamy-esapi.xml file to see policy details; in extreme trust cases use any where any html is allowed; note that many services need updating which should allow at least safe html, and it may take some time to discover all of those and get them handled; please send in issues and requests for service attributes that should allow safe html
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742352 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 09:34:34 +00:00
David E. Jones 9075027988 Some cleanups, no functional changes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742238 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 03:16:02 +00:00
David E. Jones 4d9382e887 Cleanup and pretty-up a bunch of log statements; moved some less helpful ones to verbose, combined some, and generally tried to make logs in various places more user friendly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741424 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:04:58 +00:00
Jacques Le Roux 572b7683e0 All tabs to 4 spaces in *.groovy, *.java, *.xml : less problems in future with that aspect...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737003 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 11:08:47 +00:00
Jacques Le Roux 9c5e043c53 Cleanup_labels35.patch from Marco Risaliti 'Clean up labels" (https://issues.apache.org/jira/browse/OFBIZ-1780) - OFBIZ-1780
This close this issue.
There are some labels related to geoLocation in this commit, I will commit the geoLocation work as is since I will not have much time this next weeks to work on it. Anyway it's already sufficient as a basis for other parts. 



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735402 13f79535-47bb-0310-9956-ffa450edef68
2009-01-18 09:06:03 +00:00
Adrian Crum 258acadf91 Improved exception handling in JavaMailContainer.java. Problem reported in https://issues.apache.org/jira/browse/OFBIZ-156.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@732727 13f79535-47bb-0310-9956-ffa450edef68
2009-01-08 15:40:02 +00:00
Jacques Le Roux c890b3ef32 Reverted on Adam's guidances
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728536 13f79535-47bb-0310-9956-ffa450edef68
2008-12-21 22:25:22 +00:00
Jacques Le Roux d5f99b443a A modified patch from Erik Wegner "Patch for all language files (*Labels.xml) to correct language order, find duplicates or invalid entries" (https://issues.apache.org/jira/browse/OFBIZ-2073) - OFBIZ-2073
I removed some hunks, see https://issues.apache.org/jira/browse/OFBIZ-2073?focusedCommentId=12656651#action_12656651



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@726808 13f79535-47bb-0310-9956-ffa450edef68
2008-12-15 21:28:06 +00:00
Jacques Le Roux 5f1f00276d A patch from Philipp Hoppen " Individual logfiles for scheduled jobs" (https://issues.apache.org/jira/browse/OFBIZ-2042) - OFBIZ-2042
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@719836 13f79535-47bb-0310-9956-ffa450edef68
2008-11-22 11:24:28 +00:00
Adrian Crum 725c12fc77 More Temporal Expression work:
1. Fixed a bug in the TimeOfDayRange class where it didn't calculate properly across a daylight saving transition.
2. Added interval and count to TimeOfDayRange. Now the next() method will increment according to the new fields.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@718373 13f79535-47bb-0310-9956-ffa450edef68
2008-11-17 20:42:16 +00:00
Adrian Crum 5dc2fbe3b6 Temporal Expression class improvements:
1. Hardened classes.
2. Added accessor methods to expression classes and added a visitor interface. These are in preparation for the upcoming iCalendar integration.
3. JavaDoc improvements.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@713848 13f79535-47bb-0310-9956-ffa450edef68
2008-11-13 22:44:52 +00:00
Adam Heath 0c8e487006 This is a bit more map-like now.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709906 13f79535-47bb-0310-9956-ffa450edef68
2008-11-02 18:55:05 +00:00
Adam Heath d8f09e9985 makeValidContext now takes a read-only context; the underlying
methods already did it this way, so this keeps calling code from
having to copy the context itself.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709905 13f79535-47bb-0310-9956-ffa450edef68
2008-11-02 18:53:38 +00:00
Bilgin Ismet Ibryam 828d56b761 A patch from Joe Eckard "Groovy & Beanshell Service Engines do not provide DispatchContext to scripts" - OFBIZ-1979
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@707599 13f79535-47bb-0310-9956-ffa450edef68
2008-10-24 10:35:00 +00:00
Adrian Crum 0a591e6583 Made the Temporal Expressions UI more France friendly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@701257 13f79535-47bb-0310-9956-ffa450edef68
2008-10-02 22:00:11 +00:00
Adrian Crum 1171dcddb0 Temporal Expression UI fixups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@700497 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 15:17:28 +00:00
Adrian Crum 08d114f1d8 Temporal Expression UI artifacts. There is a Temporal Expression Maintenance screen in the Webtools component.
I tried my best to break this up into re-usable pieces and put them where I thought they made sense. Feel free to move things around if you have a better idea.

Internationalization note: this commit contains new UI labels.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@700310 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 23:58:59 +00:00
Adrian Crum 1a5b389697 Moved a couple of the temporal expression related classes to the base component, removed some POC code, and added elapsed time calculation to the TimeDuration class.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@698055 13f79535-47bb-0310-9956-ffa450edef68
2008-09-23 01:07:16 +00:00
Adrian Crum a777172d63 More temporal expression fixups.
I think this is ready now. The expression language won't change and the Java API won't change, so we can start building on it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@696344 13f79535-47bb-0310-9956-ffa450edef68
2008-09-17 15:38:16 +00:00
Adrian Crum f91d030bfc Safety/sanity checks for the temporal expression Java code.
Yes, there is millisecond arithmetic in this code. No, I haven't changed my view on it - millisecond arithmetic is still Evil. In this case I'm just using it to get a java.util.Calendar instance in the neighborhood of where I need it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@696134 13f79535-47bb-0310-9956-ffa450edef68
2008-09-17 02:39:19 +00:00
Adrian Crum 50724da6b9 More temporal expression work - additional JavaDocs, code fixups, converted all job sandbox jobs to temporal expressions.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@695995 13f79535-47bb-0310-9956-ffa450edef68
2008-09-16 18:19:55 +00:00
Adrian Crum 7692f1851b Updated the job scheduler to use temporal expressions. Recurrence rules still work - so there is no rush to change existing installations.
I moved the recurrence count to the job sandbox. Keeping counters in the recurrence info was a bad idea. Any other code that relied upon counters in recurrence info will have to be redesigned to use temporal expressions.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@695695 13f79535-47bb-0310-9956-ffa450edef68
2008-09-16 00:10:17 +00:00
Adrian Crum 07002b3ebb Small fixup for last commit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@695691 13f79535-47bb-0310-9956-ffa450edef68
2008-09-16 00:00:40 +00:00
Adrian Crum 9f0dc4b5f1 Temporal expression recurring event framework. Based upon a design by Martin Fowler, and discussed in https://issues.apache.org/jira/browse/OFBIZ-1956.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@695688 13f79535-47bb-0310-9956-ffa450edef68
2008-09-15 23:40:31 +00:00
Adrian Crum 04b1c1f098 PersistedServiceJob.java improved messages - no functional change.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@689179 13f79535-47bb-0310-9956-ffa450edef68
2008-08-26 19:34:06 +00:00
Hans Bakker dacfc87aa2 email poller seems to stop polling without notice...change log severity level
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@687693 13f79535-47bb-0310-9956-ffa450edef68
2008-08-21 10:25:02 +00:00
Adrian Crum ead3169d5c FlexibleStringExpander refactor.
1. Improved parsing logic - the entire expression is pre-parsed now.
2. Factory method stores parsed expressions in the cache.
3. Single null/empty expression instance - saves on memory.
4. Class names and variable names shortened to reduce object size.
5. Small performance improvements.

The expression cache is set up with no limit. We'll have to see if that needs to be changed. Larger installations might need to limit the expression cache size.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@687422 13f79535-47bb-0310-9956-ffa450edef68
2008-08-20 18:50:04 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath 2617681b51 Remove svn:executable on a bunch of stuff.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684389 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 00:53:43 +00:00
Adam Heath c9d5ac3ea9 Fix typo in Debug.verbose message.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@683441 13f79535-47bb-0310-9956-ffa450edef68
2008-08-06 23:11:34 +00:00
Adam Heath e2e6f2bf4b More generics.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682059 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 21:39:11 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
David E. Jones 32c9cdf316 One more enhancement to entity-auto to automatically handle the oldStatusId OUT population and checking StatusValidChange for status changes; note that this does nothing to keep a status history, that should be done in a custom service called by SECA rule
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679301 13f79535-47bb-0310-9956-ffa450edef68
2008-07-24 08:24:43 +00:00
David E. Jones 987d4fc1a0 Expanded entity-auto engine to support auto fromDate; a bunch more changes to example component services to eliminate implementations possible so far; now there are just a few left
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679288 13f79535-47bb-0310-9956-ffa450edef68
2008-07-24 07:08:10 +00:00