Commit Graph
310 Commits
Author SHA1 Message Date
Jacques Le Roux 2777b83223 Fix r885091 where isNotEmpty has been used by error instead of isEmpty
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885092 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 13:59:45 +00:00
Jacques Le Roux c72b29cb1f Use UtilValidate.isNotEmpty methods instead of (obj != null) || (obj.length > 0) and (obj != null) || (obj.size > 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883549 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 23:41:34 +00:00
Jacques Le Roux 4e0d303e06 Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.length == 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883507 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 21:42:18 +00:00
Jacques Le Roux 8ae9319710 Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.size == 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883492 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 20:34:27 +00:00
Adam Heath 820d11eb97 Deprecate UtilCache constructors, and add a create helper function.
This is the first step to making utilCacheTable concurrent, and
non-blocking.  To do so, the constructor has to have no side-effects.
This means it can't modify utilCacheTable itself; this will be moved to
the helper function created above.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883217 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 02:56:28 +00:00
Jacopo Cappellato c3ee42f73a New improved version of an enhancement to the service framework after I reverted my first one because it was causing some issues with service validations.
Added two new IN parameter, internally (and automatically) set for service definitions:
login.username
login.password
They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883056 13f79535-47bb-0310-9956-ffa450edef68
2009-11-22 10:23:09 +00:00
Jacopo Cappellato c55722b2e3 Reverted change I did in 882187 because Bilgin Ibryam has reported an issue with it (it is causing an error in services which require auth).
I will investigate more and provide a better fix.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882836 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 07:28:20 +00:00
Jacopo Cappellato 23a095ab67 Added two new IN parameter, internally (and automatically) set for service definitions:
login.username
login.password
They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882187 13f79535-47bb-0310-9956-ffa450edef68
2009-11-19 16:06:43 +00:00
Scott Gray c3d2b880de Delay the completion of the testServiceEcaGlobalEventExec test to allow the global ecas to complete before the next test is run, fixes OFBIZ-3124 reported by Jeremy Wickersheimer
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@835548 13f79535-47bb-0310-9956-ffa450edef68
2009-11-12 21:13:49 +00:00
Scott Gray f69cbf5456 Don't attempt to cast Service Eca Set Field values to string after formatting, fixes ClassCastException caused by when using certain formats
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@835541 13f79535-47bb-0310-9956-ffa450edef68
2009-11-12 20:57:36 +00:00
Jacques Le Roux c8372e6329 Fix bugs I introduced at r833725 converting while loops to enhanced for loops, thanks to Todor Spasov on dev ML.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834444 13f79535-47bb-0310-9956-ffa450edef68
2009-11-10 12:01:37 +00:00
Jacques Le Roux ac889d7a13 A modified patch from Marc Morin "Resolve java warnings exposed in Eclipse : framework - entityext" (https://issues.apache.org/jira/browse/OFBIZ-3108) - OFBIZ-3108
I replaced 4 while loops by for loops. Doing that I removed the empty checks. So I also used a FastList in StrungUtile.split() which I also refactored a bit.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@833725 13f79535-47bb-0310-9956-ffa450edef68
2009-11-07 18:14:22 +00:00
Jacopo Cappellato 816a5c1e67 Added the ability to set the exportAll flag in the RemoteDispatcher from a configuration file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@831176 13f79535-47bb-0310-9956-ffa450edef68
2009-10-30 01:10:25 +00:00
Jacopo Cappellato 1755bb5560 Added demo truststore file to be used by client applications invoking services using the RemoteDispatcher (see for example the ExampleRemoteClient class).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@829476 13f79535-47bb-0310-9956-ffa450edef68
2009-10-25 01:00:28 +00:00
Scott Gray 8a46a8ae24 Fixed a bug in the RouteEngine service engine (engine="route") where no ECAs were being triggered when running a route service asynchronously, this is caused because in general ECAs aren't triggered until a service is called synchronously but the RouteEngine was simply returning instead of doing a runSync on a separate thread. Fixed this by changing the RouteEngine to extend the GenericAsyncEngine and letting it handle the async calls in the same way it does for other engines.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@828839 13f79535-47bb-0310-9956-ffa450edef68
2009-10-22 20:27:10 +00:00
Scott Gray d360614c52 When scheduling a service to be run do it within it's own transaction.
This resolves a bug I encountered where a long running (couple of minutes) service was scheduling jobs but the poller was unable to get a lock on those JobSandbox rows which prevented the poller from queuing any jobs at all for the duration of the service.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@828289 13f79535-47bb-0310-9956-ffa450edef68
2009-10-22 03:19:21 +00:00
Adrian Crum 9ee18d37c5 Updated client code to use the new Delegator factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@823633 13f79535-47bb-0310-9956-ffa450edef68
2009-10-09 17:44:24 +00:00
Adrian Crum 7fa08f9079 Replaced GenericDelegator.getGenericDelegator(...) calls with new factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821649 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 01:53:50 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Jacques Le Roux 52a03030bb A new feature from Shi Yusen (https://issues.apache.org/jira/browse/OFBIZ-2948) - OFBIZ-2948
This change will make it possible to invoke both static method and instance method. See http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Method.html#invoke(java.lang.Object,%20java.lang.Object...)
Thanks to Scott for optimisation advice

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@819281 13f79535-47bb-0310-9956-ffa450edef68
2009-09-27 10:35:21 +00:00
Scott Gray 2afbb75457 Get rid of a whole pile of unnecessary string instantiations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818665 13f79535-47bb-0310-9956-ffa450edef68
2009-09-24 23:49:02 +00:00
Adam Heath 69a9cfb394 Fix typo in runAsync verbosity message.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@816007 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 23:24:24 +00:00
Adam Heath c8abe01fa5 Apply patch from OFBIZ-1023, adding returnSuccess(List); the javadoc
from the patch wasn't used, however.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@815916 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 18:10:49 +00:00
Adam Heath 0cdcfa6189 Service definitions are now wrapped with their filename and line
number, for easier debugging.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812783 13f79535-47bb-0310-9956-ffa450edef68
2009-09-09 06:15:08 +00:00
Adrian Crum 74ea95889c Reverted rev 802567.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812692 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 20:56:14 +00:00
Hans Bakker e0ba7104ce create a 'set' of documents: a technical and a user guide and added more info
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812021 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 07:31:11 +00:00
Jacques Le Roux 3fedb9e5ed Some ASL2 headers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811870 13f79535-47bb-0310-9956-ffa450edef68
2009-09-06 19:54:25 +00:00
Jacques Le Roux 97dc9401b3 A patch from Bob Morley "loadCartFromOrder assumes service call is successful" (https://issues.apache.org/jira/browse/OFBIZ-2782) - OFBIZ-2782
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810921 13f79535-47bb-0310-9956-ffa450edef68
2009-09-03 12:54:16 +00:00
Jacques Le Roux f2cc4c2d52 Fix for "ServiceUtil.getUserLogin tests on null but not empty" (https://issues.apache.org/jira/browse/OFBIZ-2838) - OFBIZ-2838
Thank you Al for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810370 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 06:22:23 +00:00
Scott Gray 166671a08b Changed the reloadCrashedJobs method to look for crashed jobs by statusId rather than null finish and cancel dates
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@809530 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 10:24:58 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
David E. Jones d4aa04aee8 Added some documentation about the service definition transaction related attributes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@797962 13f79535-47bb-0310-9956-ffa450edef68
2009-07-26 17:45:24 +00:00
Adrian Crum e4ee374a66 Conversion from java.util.Calendar to com.ibm.icu.util.Calendar. I didn't convert the Cloud component - I wasn't sure if the Calendar class was being passed through SOAP.
OFBiz users who have modifications or add-ons can make the same substitution to get them to compile.

I'll let the dust settle from this, then I'll add the user-selected calendar capability.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792987 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 15:39:21 +00:00
David E. Jones 497a7cbf0d Change to handling of error messages in simple-methods called as a service to pass errors through in List/Map and not combine into one big String, add text you can't change, etc; now logs details and passes errors as-is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792633 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 18:51:00 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
David E. Jones b7120f61db Removed this deprecated flag for now since it isn't really deprecated yet
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@787416 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:47:09 +00:00
David E. Jones 776d75659c Added divs since it looks like in the bizznesstime theme that h2 no longer causes a newline; also fixed serial warning in ServiceEcaRule
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@780597 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 08:51:12 +00:00
Andrew Zeneski 336a1cf7b2 more improvements to the message wrapper logic for getting attachments and reading multipart messages; added methods to get headers; mail container now marks messages which are too big to process (the max size setting) as read (but never deleted) so they are not always being checked but remain in the mailbox for human review
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774178 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 03:05:00 +00:00
Andrew Zeneski 9bd6c7d37a added a bunch of mail handing methods to the message wrapper to make dealing with email messages easiler
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774087 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 21:09:48 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
Adam Heath 1a31984695 Several minor generics fixes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771124 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:35:52 +00:00
Andrew Zeneski 485805fe3f Renamed AbtractAuthorization to AbstractAuthorization (bad typo)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770836 13f79535-47bb-0310-9956-ffa450edef68
2009-05-01 21:53:29 +00:00
Andrew Zeneski f36c5a9335 No longer requiring the boolean field 'expanded' as part of the API; after dicussing w/ Adrian; the FSE can handle pre-expanded strings
Added new API method findMatchingPermission() which takes a regular expression for the base permission returning the value of all matching permissions (see unit tests)
Fixed missing base permission in SecurityData.xml

JIRA OFBIZ-2381


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770401 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 19:14:48 +00:00
Andrew Zeneski d8f436a148 Integration with new Authz API - JIRA OFBIZ-2381
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769936 13f79535-47bb-0310-9956-ffa450edef68
2009-04-29 21:11:35 +00:00
Hans Bakker cdf0d78cf0 corrected non-thread safe code after a comment from David
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769377 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 12:46:43 +00:00
Hans Bakker 4c0c034121 some more faultfixing on customer request notifications: mainly the partyIdTo was not provided
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769274 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 07:49:12 +00:00
Hans Bakker 9c6612b740 intermittent error seems to be solved with this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769236 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 04:16:19 +00:00
Scott Gray 4acd7cc4f9 Corrected simple method documentation regarding the transaction timeout UOM, added the same to the services xsd and fixed a couple of service defs that appeared
to be specifying milliseconds rather than seconds.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769205 13f79535-47bb-0310-9956-ffa450edef68
2009-04-27 23:53:40 +00:00
Jacques Le Roux 5de088f285 I have not seen this error for some times, but anyway this is more secure, suggested by Stephen Rufle on user ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768675 13f79535-47bb-0310-9956-ffa450edef68
2009-04-26 07:43:24 +00:00