------------------------------------------------------------------------
r1868615 | jleroux | 2019-10-19 10:12:07 +0200 (sam. 19 oct. 2019) | 6 lignes
Fixed: Fix multi modal opening
(OFBIZ-11211)
Simplifies a little bit the current code.
Thanks: Leila for patch and Carl for confirmation
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868616 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1868611 | jleroux | 2019-10-19 08:42:07 +0200 (sam. 19 oct. 2019) | 11 lignes
Improved: Handling tenant in XmlRpcEventHandler
(OFBIZ-10284)
The XMLRPC service does not support tenants. Even if the tenant domain is
included in the HTTP request the call does not affect the correct tenant.
The issue and fix has been discussed in in the thread
https://markmail.org/message/bz4dofrxqp6i7ove
jleroux: I was able to port the R16 patch provided by Rajesh to the trunk.
Thanks: Rajesh Kumar Mallah
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868612 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1868553 | jleroux | 2019-10-17 16:26:42 +0200 (jeu. 17 oct. 2019) | 14 lignes
Fixed: FTL error for purchase order with Bulk Item Type
(OFBIZ-11252)
Steps to regenerate:
1. Login into the ordermgr application and click on Order Entry tab
2. Create PO with any supplier
3. Fill details and click on Continue
4. Now select Product Category with Item type Bulk and add the description and
Click on add to order
5. Finalize order with Finalize Order button
6. Add Term type, ship group option, etc details and create Order.
7. Scroll down to Order Items section and See the FTL error on the screen.
Thanks: Devanshu Vyas
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868554 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1868545 | jleroux | 2019-10-17 14:19:33 +0200 (jeu. 17 oct. 2019) | 16 lignes
Fixed: EditExample always update status, because current Status not shown
(OFBIZ-11230)
In the EditExample Form, the drop-down is populates with the Valid change status
only. So current status is not in the list and the status print in the drop-down
is the next authorized. I want to modify exampleName or exampleType, I go to
editExample and change what I want and validate. The problem is status is also
changed!
There are 12 other same or similar cases. For the first of them (in FinAccount)
there is the same bug: when I change FinAccount Name, status change too. If I
add current="first-in-list" in the tag drop-down it works
jleroux: Quote is a peculiar case due to OFBIZ-7337 which was a wrong fix
Thanks: Oliver for the analysis and the fix
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868546 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1868395 | jleroux | 2019-10-13 12:37:08 +0200 (dim. 13 oct. 2019) | 8 lignes
Fixed: Merge UrlRegexpTransform and OfbizUrlTransform classes
(OFBIZ-11229)
OFBIZ-4361 depends on this issue. Here is a first version, the main identified
point was when the request isn't present (email send, service call) the website
isn't pull from context. This solves this aspect
Thanks: Nicolas for the patch
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868396 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1868298 | jleroux | 2019-10-11 18:45:16 +0200 (ven. 11 oct. 2019) | 20 lignes
Fixed: NotSerializableException after uploading images to an order
(OFBIZ-11123)
I found that using in r1866259 the same fix than Si Chen used in OFBIZ-750 was
wrong. The code just above this fix is
{code:java}
if (obj instanceof Serializable) {
reqAttrMap.put(name, obj);
}
{code}
The problem with this code is that if does not handle inner Maps which may
contain a non Serializable Object. So the solution is rather to get one level
deeper and apply the same. We can then remove the harcoded lines with
"uploadedFile" and "_REQUEST_HANDLER_" below. Then all possible cases are handled
as long as we have not inner-inner-Maps
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1868299 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1867998 | jleroux | 2019-10-05 10:05:54 +0200 (sam. 05 oct. 2019) | 8 lignes
Improved: no functional change
As reported by Ethan Vos on user ML, sometimes the alias between wget and
Invoke-WebRequest is not present on Windows 7, better keep it simple!
Also removes the comment:
Anyway I believe this should be only used in dev environment
which is no longer true
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867999 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-4361)
OFBiz contains a nice process to generate link through WebSite entity.
Unfortunately when you send an email, the standard service didn't propage the website
to the body content email, so we can't use it.
This improvement is needed on forgot password process to resolve the correct uri
and go back on good OFBiz component: where the user requested for a new password.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867961 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Check run payment(A/P) transactions not getting available for reconciliation
(OFBIZ-10796)
Check run payment group transactions don't get available for Financial Account reconciliation. Though the financial account balance gets updated during the A/P check run process, the system must allow the user with an additional step of reconciling the transactions.
The cause of this is that the financial account transaction doesn't get created in the 'Created' status and has an 'Approved' status. An approved status financial transaction directly updates the financial account balance and thus don't appear in the list of the transactions to be reconciled.
Thanks: Chinmay Patidar for your contribution and Pierre Smits for the review.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867931 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: User is unable to update the review of product
(OFBIZ-10799)
Redirected request with eligible parameters so that If the user had a search using any parameter result should persist after the update.
Thanks: Ashish Sharma for report and Pierre Smits and Jacques Le Roux for the review.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867905 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1867585 | jleroux | 2019-09-26 17:38:52 +0200 (jeu. 26 sept. 2019) | 9 lignes
Fixed: Error in log when looking for parties at partymgr/control/main
(OFBIZ-11201)
These are similar issues in Minilang than the one fixed initially for
<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>
Fixed by replacing by
<set field="userLoginSize" value="${groovy:logins.size()}"/>
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867586 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11212)
When you use a date-find element on form, the defaut option are in code like to greater_than and less _than
public DateFindField(int fieldSource, String type) {
super(fieldSource, type);
this.defaultOptionFrom = greaterThanEqualTo;
this.defaultOptionThru = lessThanEqualTo;
}
but on macro
<#macro renderDateFindField ...
<option value=greaterThan<#if defaultOptionFrom==greaterThan> selected=selected</#if>></option><#rt/>
...
<option value=opLessThan<#if defaultOptionThru==opLessThan> selected=selected</#if>></option><#rt/>
...
</#macro>
So the value java isn't correct with ftl values and default value never used.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867583 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1867577 | jleroux | 2019-09-26 16:41:50 +0200 (jeu. 26 sept. 2019) | 8 lignes
Fixed: Fix multi modal opening
(OFBIZ-11211)
The issue is that when closing the modal the div inside html dom is not removed.
Then opening a second time create another identical div. Since a lookup is based
on an unique id, this id is no more unique...
Thanks: Carl Demus
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867578 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-11207)
When you create a xml form with upload as type, you can't use on-event-update-area element to submit it by ajax.
Otherwise, OFBiz return an error message on 'uploadFile is empty.
To solve it, we analyze the enctype's form before submit it to move on FormData instead a direct serialize [1]
example form where the problem has been present
****
<form name='AddNicelyFile' type='upload' target='CreateNicelyFile'>
<field name='uploadedFile' title='File'><file/></field>
<field name='addButton'><submit/></field>
<on-event-update-area event-type='submit' area-id='window' area-target='FileDisplaying'/>
</form>
****
Thanks to Samuel Tregouet for this fix
[1] https://developer.mozilla.org/en-US/docs/Web/API/FormData/Using_FormData_Objects
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867437 13f79535-47bb-0310-9956-ffa450edef68
(including admin) via 'Forget Your Password'
(OFBIZ-4361)
Trunk backport r1866478 and r1866518
Currently, any user (via ecommerce 'Forget Your Password') has the ability to
reset another users password, including 'admin' without permission.
By simply entering 'admin' and clicking 'Email Password', the following is
displayed:
The following occurred:
A new password has been created and sent to you. Please check your Email.
This now forces the user of the ERP to change their password.
It is also possible to generate a dictionary attack against ofbiz because there
is no capta code required. This is serious security risk.
I have modified the patch following comments I made in the Jira, notably
Removed unused Java variables
Removed a check in LoginEvents::forgotPassword which prevented to show error
messages
Changed fr and en SecurityExtPasswordSentToYou
+ SecurityExtThisEmailIsInResponseToYourRequestToHave labels
+ template PasswordEmail.ftl
+ loginservices.token_incorrect labels
Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
Removed changes in general.properties
I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)
There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is
inapplicable!
Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess
with some Gil's help, and all others for comments and ideas
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867296 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1867099 | jleroux | 2019-09-18 09:29:18 +0200 (mer. 18 sept. 2019) | 17 lignes
Fixed: Error in log when looking for parties at partymgr/control/main
(OFBIZ-11201)
There is this a (long stack trace) error in log (only), mostly
java.lang.ClassCastException: java.util.ArrayList cannot be cast to java.util.Map
at org.apache.ofbiz.base.util.string.UelFunctions.getSize(UelFunctions.java:318)
I did not notice any other effect, so the fix only cleans the log.
It's actually an issue in ListParty grid with this line:
<set field="userLoginSize" value="${util:size(logins)}" type="Integer"/>
This fixes it by replacing by
<set field="userLoginSize" value="${groovy:logins.size()}"/>
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867100 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1866920 | jleroux | 2019-09-14 10:19:18 +0200 (sam. 14 sept. 2019) | 18 lignes
Fixed: Path Traversal in webtools/control/FetchLogs and ViewFile
(OFBIZ-11196)
These are not really path traversal issues.
We can't solve them using the traditional way to fix path traversal issues
(ie normalising path). Because Fetchlogs and ViewFile are actually reading
files and if you have the right to read these files then nothing will prevent
you to read them.
The problem is more what those requests are supposed to do.
Fetchlogs is supposed to read a log in the log dir
and ViewFile is supposed to read a file containing labels
(ie either an XML or Properties file).
So the solution is to allow these requests to only do what they are supposed to
do. This is what is done in ViewFile and FetLogs Groovy files.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1866921 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1866890 | jleroux | 2019-09-13 12:15:03 +0200 (ven. 13 sept. 2019) | 8 lignes
Improved: FindArInvoices request needs performance improvement regarding use of
EntityListIterator::hasNext method
(OFBIZ-11198)
FindAPInvoices request does not suffer from this issue nor findInvoice request.
This was due to <screen name="FindArInvoices"> definition
Using something similar than <screen name="FindApInvoices"> fixes the issue
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1866891 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865852 | pawan | 2019-08-24 16:28:57 +0200 (sam. 24 août 2019) | 8 lignes
Fixed: Issue of unable to view a PartyContent on view profile page of a party
(OFBIZ-11038)
When click on view button img request will be hit along with contentName and imgId as a parameter. This request invokes serveImage event(DataEvents.java) which is deprecated now.
Instead of img request we can call stream request with contentId as a parameter that invokes serveObjectData event.
This will work as per the value of content-disposition-type (requestHandler.properties) i.e. attachement or inline
Thanks: Devanshu Vyas for reporting the issue and Humera Khan for the patch and Prachi Shastri for testing of the bug.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1866593 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1866259 | jleroux | 2019-09-02 09:32:48 +0200 (lun. 02 sept. 2019) | 10 lignes
Fixed: NotSerializableException after uploading images to an order
(OFBIZ-11123)
In a lot of services we use the ByteBuffer object to upload files.
When a such service is used with the redirect-parameter in a controller the
ByteBuffer needs to be serialized. Unfortunately ByteBuffer (in our case its
subclass HeapByteBuffer) is not serializable. So that can't work.
Fortunately no redirect-parameter concerns uploadedFile so we can safely remove
it from reqAttrMap in RequestHandler
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1866260 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10145)
When you run 'sh gradle/init-gradle-wrapper.sh', if the script gradlew at the OFBiz root isn't present we download it from bintray.
Improvements to comments and messages in the init-gradle-wrapper.sh script do on r1865605 by Jacopo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1866123 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865924 | nmalin | 2019-08-26 11:54:55 +0200 (lun. 26 août 2019) | 6 lignes
Fixed: CategoryServices returns null when opening Product main page
(OFBIZ-11175)
Increase parsing control to don't realize it on null value for viewSizeString
when call service getProductCategoryAndLimitedMembers.
Thanks Jacques Leroux for raise this issue
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865927 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865891 | jleroux | 2019-08-25 15:24:10 +0200 (dim. 25 août 2019) | 5 lignes
Improved: Use Labels in themes names
(OFBIZ-9863)
Remove duplicated block that I forgot to remove
This had no effects but I found an XML error in log
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865892 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865883 | jleroux | 2019-08-25 11:48:31 +0200 (dim. 25 août 2019) | 8 lignes
Fixed: UiLabel is missing for Web Analytics Type on content component
(OFBIZ-11170)
Steps to reproduce
content/control/EditWebAnalyticsConfig?webSiteId=WebStoreClone
On that Web Analytics Type UiLabel is missing.
Thanks: Rahul Marjiwe
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865884 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Issue in creating promotion action
(OFBIZ-11058)
Reason for this issue is a duplicate parameter with name customMethodId, We have dropdown and hidden field for the same parameter, this converts customMethodId value to a list.
Thanks: Lalit Dashora for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865821 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865370 | jleroux | 2019-08-17 20:26:42 +0200 (sam. 17 août 2019) | 7 lignes
Improved: Use Labels in themes names
(OFBIZ-9863)
Adds labels and necessary calls in Theme.xml
While at it, improves other backend themes labels by removing redundancy, at
least in French and English.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865371 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865367 | jleroux | 2019-08-17 20:08:14 +0200 (sam. 17 août 2019) | 4 lignes
Fixed: <description> of <visual-theme> in Theme.xml does not work
(OFBIZ-9867)
There is no str:label in UelFunctions class but util:label
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865368 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865347 | jleroux | 2019-08-17 13:34:01 +0200 (sam. 17 août 2019) | 9 lignes
Fixed: Issue loading solr component (JNDI timeout)
(OFBIZ-11156)
We need to provide a JNDI environment property for Solr to load faster
Fixes previous commit where I hastily harcoded in jndi.properties file
Used a system property which can be used to define a JNDI environment
property
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865348 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1865344 | jleroux | 2019-08-17 13:07:01 +0200 (sam. 17 août 2019) | 4 lignes
Fixed: Issue loading solr component (JNDI timeout)
(OFBIZ-11156)
We need to provide a JNDI environment Property for Solr to load faster
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865345 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Change the uggly favicon with the new one ! | Using new OFBiz logo
(OFBIZ-10522)
Fixed issues with logo size for flatgrey theme with some custom css to fix its height and width
Replaced old logo with the new one in tomahawk theme along with some custom css to fix its height and width
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1865104 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1864930 | jleroux | 2019-08-11 15:23:19 +0200 (dim. 11 août 2019) | 4 lignes
Fixed: [FB] Find Security Bugs
(OFBIZ-9973)
As suggested by Mathieu on dev ML factorises the use of Path::normalize
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1864931 13f79535-47bb-0310-9956-ffa450edef68
to our build notes
(OFBIZ-10145)
Adds the Windows init-gradle-wrapper scripts (both .bat et .ps1) in all
concerned branch (trunk, R18, R17)
These are very simple because I believe (almost?) nobody is using a Windows
server to deploy OFBiz in production. So they will be only used in development
environment. In case deployment in production is needed they supply a base to
work on...
The init-gradle-wrapper.ps1 scripts use only HTTP and not HTTPS because it's
very difficult to handle all the issues related with different versions of
Powershell and .net in different versions of Windows. Better to let that to
deployment in case it's really needed...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1864927 13f79535-47bb-0310-9956-ffa450edef68