For some themes, we rely on toLowerCase method to build a Less file path.
toLowerCase("I") = "ı" for some locales (TR, AZ), which lead to incorrect
file paths and finally broken themes.
The tenant relevant Gradle tasks are:
OFBiz Server tasks
------------------
createTenant - Create a new tenant in your environment
loadAdminUserLogin - Create admin user with temporary password equal to ofbiz.
You must provide userLoginId
loadAll - Load default data; meant for OFBiz development, testing, and demo
purposes
loadTenant - Load data using tenantId
loadAll is the new "ant load-data" and should clearly only used for
"OFBiz development, testing, and demo purposes".
Remains the import functionalities. We don't want to get to far with that,
a warning is enough.
Thanks: Pierre Smits for report
Actually I put in a path error then, it's not
value="/common/js/node_modules/node_modules/dompurify/dist/purify.min.js"
but
value="/common/js/node_modules/dompurify/dist/purify.min.js"
This fixes it
initialReferrer (OFBIZ-12672)
Analogous to the existing limitation of the "initialUserAgent" to 250
characters, installation of a limitation of 2000 characters for
initialRequest and initialReferrer, so as not to exit with
"MysqlDataTruncation: Data truncation: Data too long for column
'INITIAL_REFERRER' at row 1" in the case of very long requests.
(OFBIZ-12670)
Introduces a SystemProperty security#security.datafile.loadurls.enable
which can be set to true to allow loading of urls in the XML import.
Currently, when you wish return a message to a user after an event request, you need to set it ine the called event.
for a service in java :
ServiceUtil.returnSuccess("Your service is a success")
for a service in groovy :
return success("Your service is a success")
for a Java class :
request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");
If during an integration, you want to use standard service like createProduct, createPartyRelationship, and need a specific message for users, you need to define your own service.
For escape this case and increase the service usability, I propose to implement a new system to override the event return by a definition depending on the buisness context.
For that two improvement :
1. Add new child element to request-map->response on the controller
With given the exact value:
<response name="success" type="request" value="json">
<return-user-message value="Your service is a success"/>
</response>
With a flexible expander:
<response name="success" type="request" value="json">
<return-user-message value="Your service to change is a success"/>
</response>
With a property:
<response name="success" type="request" value="json">
<return-user-message ressource="CommonUiLabels" value="CommonSuccessfullyCreated"/>
</response>
From a context field:
<response name="success" type="request" value="json">
<return-user-message from-field="mySpecificReturnMessage"/>
</response>
2. From the context directly sent from the form
<form name="CallEvent" target="MyEvent" .. >
<field name="_CUSTOM_EVENT_MESSAGE_"> <hidden value="Your service to change is a success"/>
<field name="_CUSTOM_ERROR_MESSAGE_"> <hidden value="Your service failed"/>
Thanks to Florian Motteau for the implementation help
Fix a null pointer exception when a menu extend a menu with empty item.
In this case, we use a empty link for the extended menu.
Thanks to Jacques Leroux for the alert
Currently the create buttons for the main objects of the work effort are located within the find and other widgets/templates of those objects.
In order to improve the usability of OFBiz (and thus the appeal of it for adopters and users) these create buttons/links/etc. should be in a main action menu visible at all times when a user is working within the component.
modified:
WorkEffortMenus.xml - added MainActionMenu for users with CREATE permission in the component
CommonScreens.xml - added MainActionMenu as an 'include-menu' ref in various common decorator screens.
Added MainActionMenu as an 'include-menu' in screen definitions in various other Screen.xml files where appropriate
additional cleaning.
Extend standard find services (prepareFind, executeFind and performFind) to use a built dynamicView instead of just an entityName.
With this, you can prepare a dedicated dynamicView and call the performFind with on result a database optimisation.
Thanks to Leila Mekika for this proposal and patch
On the widget-form.xsd definition, the element on-field-event-update-area haven't possibility to define some parameters.
But on java code, the on-field-event-update-area is read like on-event-update-area.
If you put some parameters on your code, your editor raise a syntax error but OFBiz analyse and execute it well.
<wf:field name="reload" >
<wf:submit/>
<wf:on-field-event-update-area event-type="click"
area-target="ReloadIt">
<wf:auto-parameters-service service-name="computeForReload" send-if-empty="false"/>
</wf:on-field-event-update-area>
</wf:field>
By the way we can synchronize the on-field-event-update-area xsd on on-event-update-area.
When you define a display-entity you have the possibility to add a sub-hyperlink related to the element displayed.
<field name="partyIdFrom">
<display-entity entity-name="PartyNameView" key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
<sub-hyperlink target="viewprofile" description="view">...</sub-hyperlink>
</display-entity>
<field>
This display the party name with a link "view" connected.
When you use the name as link without a dedicate sub link, you need to change all the form to resolve the information to display for creating an hyperlink
<row-actions>
<entity-one entity-name="PartyNameView" value-field="partyName">
<field-map field-name="partyId" from-field="partyIdFrom"/>
</entity-one>
<set field="partyNameValue" value=" ${partyName.groupName}${partyName.firstName} ${partyName.lastName}"/>
</row-actions>
<field name="partyIdFrom">
<hyperlink target="viewprofile" description="${partyNameValue}">..</hyperlink>
</field>
We lost the advantage of the display-entity. With this case, we improve display-entity with the following rule :
If the display-entity has a subhyperlink and the subhyperlink haven't description, the description of the link is the display-entity description.
In the code, if a sub-hyperlink has an empty description, we convert the display entity as a hyperlink
The service "resequence" compute for a content all sequenceNum for linked content assoc.
The code is very old (before apache) so apply a slim refactor and migrate the service name resequence to resequenceContentAssocChildren.
By the way I kept the service definition resequence to move it as deprecated.
Adds <img> and <hr> to CustomSafePolicy, removes obsolete <tt>. <img> allows
only attributes src and alt.
Both <br> and <br /> are correct. For that, this rather uses
TagBalancingHtmlStreamEventReceiver
Thanks: Ingo Wolfmayr
Reverts tika-core to 1.28.4 and fop to 2.3
I did not launch the tests, those did not pass:
ecommercetests testSendOrderConfirmation
widgettests testFopMacroLibrary
Tika is a bit annoying, no security releases after Sept. 30
New line just to apply change made in Buildbot config to run w/ Java 11
Seems last time Buildbot did not catch up or something is wrong
I double checked Buildbot config is properly set to run w/ Java 11 and change is
committed
Trying again after Gavin confirmed it should be OK on Slack #asfinfra channel
New line just to apply change made in Buildbot config to run w/ Java 11
Seems last time Buildbot did not catch up or something is wrong
I double checked Buildbot config is properly set to run w/ Java 11 and change is
committed
I noticed that JpegImageParser from Apache Commons Imaging never had a write
option. So I commented it out. I tested uploading, it's OK
org.apache.axiom.om.impl.builder.StAXOMBuilder has been replaced by
org.apache.axiom.om.OMXMLParserWrapper
in SOAPEventHandler.java
The rest of information is in the main build.gradle
I got 2 test errors on Win7. I'll see how it goes on GH and BB.
Maybe it's write.lock issues with Lucene or/and Solr indexes
Mentionned at https://tika.apache.org/
Apache Tika 1.28.4 has been released! This release includes security related
fixes and dependency upgrades
Note: The Apache Tika PMC has set September 30, 2022 as the End Of Life for the
Tika 1.x branch.
Allows both <br> and <br /> to pass in UtilCodec::checkStringForHtmlSafe, both
are correct.
Clarifies owasp.properties documentation about how to create own sanitizer
policies
When you generate an order on a party who have a PartyAcctgPreference with a customMethod orderSequence_enforced, the service failed due to the missing parameter partyAcctgPreference.
Like quote and invoice it's preferable to forward the partyAcctgPreference information.
When you use two menus where the second extend the first, menu items and menu links aren't correctly propagated.
The menu items and menu links presents on the second menu already have the first menu on their model.
****
<menu name="FirstMenu" extends="CommonInlineBarMenu" extends-resource="component://common/widget/CommonMenus.xml">
<menu-item name="MyItem">
<link target="GoAction"/>
</menu-item>
</menu>
<menu name="SecondMenu" extends="FirstMenu"/>
****
The result, if during the rendering some information are generated from the menu, in the previous case, it's always the "FirstMenu" that would be use.
Like when your menu generate a hidden-form, the SecondMenu link the bad form
****
<form method="post" action="GoAction" onsubmit="javascript:submitFormDisableSubmits(this)" name="SecondMenu">...</form>
<a href="javascript:ajaxSubmitFormUpdateAreas('FirstMenu', 'xxx')">MyItem</a>
****
To solve it and don't break the thread safe pattern, I introduce two new constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and MenuLink in memory with the new parent. With this, the SecondMenu iw now completely duplicated on memory and now share any reference with the extended menu.
Thanks to Marco Rodrigues that detect this problem