Fixed: Unable to continue to Step 3 in One Page Checkout

(OFBIZ-11318)

The following error is returned when trying to continue to Step3 when checking
out using One Page Checkout.

Could not create new purpose, a purpose with that type already exists.:
[GenericEntity:PartyContactWithPurpose][contactFromDate,2020-01-05 19:48:18.29
(java.sql.Timestamp)][contactMechId,10020(java.lang.String)]
[contactMechPurposeTypeId,SHIPPING_LOCATION(java.lang.String)]
[partyId,admin(java.lang.String)][purposeFromDate,2020-01-05 19:48:18.332
(java.sql.Timestamp)

It does not happen with DemoCustomer but at least with admin user

It was caused by OFBIZ-10588. I checked for similar issues and found that, in
unlike in createUpdateBillingAddress, in createUpdateShippingAddress and
createUpdateCreditCard partyId was used without a prior setting from
parameters.partyId

Thanks: James Young for proposing a solution. I rather fixed otherwise this and
another similar case in createUpdateCreditCard
This commit is contained in:
Jacques Le Roux
2020-02-07 14:43:43 +01:00
parent 37b8e5b0e8
commit 77d6a5ff91
@@ -856,7 +856,8 @@ under the License.
<call-map-processor xml-resource="component://order/minilang/customer/CheckoutMapProcs.xml"
processor-name="shipToAddress" in-map-name="parameters" out-map-name="shipToAddressCtx"/>
<check-errors/>
<set field="shipToAddressCtx.partyId" from-field="parameters.partyId"/>
<set field="partyId" from-field="parameters.partyId"/>
<set field="shipToAddressCtx.partyId" from-field="partyId"/>
<if-empty field="shipToAddressCtx.contactMechId">
<set field="shipToAddressCtx.contactMechPurposeTypeId" value="SHIPPING_LOCATION"/>
@@ -1094,7 +1095,8 @@ under the License.
</simple-method>
<simple-method method-name="createUpdateCreditCard" short-description="create and update credit card">
<set-service-fields service-name="createCreditCard" map="parameters" to-map="creditCardContext"/>
<set field="creditCardContext.partyId" from-field="parameters.partyId"/>
<set field="partyId" from-field="parameters.partyId"/>
<set field="creditCardContext.partyId" from-field="partyId"/>
<set field="creditCardContext.contactMechId" from-field="parameters.contactMechId"/>
<if-empty field="parameters.paymentMethodId">
<!-- call create Credit Card -->