Files
ofbiz-plugins/birt/groovyScripts/order/CheckReportBy.groovy
T
Pawan Verma b7ef54d494 Improved: Inconsistent String Comparisons(OFBIZ-9254)
There are some inconsistencies in the code for string comparison statusId.equals(PRUN_COMPLETED) whereas it should be written as PRUN_COMPLETED.equals(statusId) cause the former can throw NullPointerException if the variable found to be NULL.

Thanks: Devanshu for your contribution.
2020-07-30 17:02:52 +05:30

68 lines
2.0 KiB
Groovy

/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import org.apache.ofbiz.base.util.UtilValidate
reportBy = parameters.reportBy
exportType = parameters.exportType
if (!parameters.fromDate) {
request.setAttribute("_ERROR_MESSAGE_", "Please select From Date.")
return "error"
}
if ("pdf" == exportType) {
if ("day" == reportBy) {
return "dayPDF"
} else if ("week" == reportBy) {
return "weekPDF"
} else if ("month" == reportBy) {
return "monthPDF"
} else {
request.setAttribute("_ERROR_MESSAGE_", "Please select Report By.")
return "error"
}
}
if ("excel" == exportType) {
if ("day" == reportBy) {
return "dayExcel"
} else if ("week" == reportBy) {
return "weekExcel"
} else if ("month" == reportBy) {
return "monthExcel"
} else {
request.setAttribute("_ERROR_MESSAGE_", "Please select Report By.")
return "error"
}
}
if ("html" == exportType) {
if ("day" == reportBy) {
return "dayHTML"
} else if ("week" == reportBy) {
return "weekHTML"
} else if ("month"== reportBy) {
return "monthHTML"
} else {
request.setAttribute("_ERROR_MESSAGE_", "Please select Report By.")
return "error"
}
}