Commit Graph
155 Commits
Author SHA1 Message Date
Deepak Dixit ca0613b630 Improved: Updated tomcat-embed-websocket jar to 8.5.23
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1814926 13f79535-47bb-0310-9956-ffa450edef68
2017-11-11 07:09:50 +00:00
Jacques Le Roux a34c732847 Improved: Replace Inline Javascript with External Javascript
(OFBIZ-9465)

The OFBIZ-9465_example.patch was partially committed at r1804027.

Thanks: Aditya 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1814342 13f79535-47bb-0310-9956-ffa450edef68
2017-11-05 09:05:53 +00:00
Deepak Dixit e82e469e24 Improved: Manage life span of SecurityGroupPermission entity.
Applied patch from jira issue(OFBIZ-9801) Thanks Suraj Khurana for your contribution


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1812384 13f79535-47bb-0310-9956-ffa450edef68
2017-10-17 10:48:43 +00:00
Deepak Dixit f02613b01b Improved: No functional change, Only added license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1812310 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 18:43:49 +00:00
Jacques Le Roux 646e2e9d47 Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

Programmatically replaces the web.xml <session-config> declarations and uses 
the @WebListener annotation to start the process. This avoid to duplicates 
things everywhere in web.xml files. Since the web.xml files have precedence 
on annotations, the setting can be easily overridden when necessary.

Now that we also use HTTPS in ecommerce the ecommerce session cookie is 
also secured.

I also noted that we had 8 weird <session-timeout> declarations:
    in solr component: <session-timeout>2</session-timeout>
    in themes: <session-timeout>1</session-timeout>

Also in Rainbowstone we lacked the <cookie-config> and <tracking-mode> 
declarations. I think it's not good.

I resolve these points by simply removing the <session-config> in web.xml files 
of themes and Solr.

Thanks: Pradhan Yash Sharma  for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1811041 13f79535-47bb-0310-9956-ffa450edef68
2017-10-04 07:12:57 +00:00
Deepak Dixit 9f4cb137ef Improved:Use from-field pattern instead of value=dollor pattern in 'set' element
Apply slightly modified patch from jira issue, fixed some typo (OFBIZ-9607)
Thanks Suraj Khurana and Rohit Rai for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806327 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 20:24:09 +00:00
Deepak Dixit 2e8d588be8 Fixed: Stack trace on E-commerce Home page (OFBIZ-9652)
Updated common template path as now these common template moved to common-theme component.
Thanks Devanshu for your contribution. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806291 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 12:21:11 +00:00
Nicolas Malin 83b7d0a52a Fixed: Correct library ftl call to render the email body (OFBIZ-9138 Create a common theme)
add possibility to call the ThemeFactory.resolveTheme() with empty request if the visualTheme normaly present on the service context isn't found, so we return the default theme define in general.properties
Thanks to Jacques for raise this problem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806238 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 21:25:50 +00:00
Nicolas Malin 4791643c55 Implemented: Change all <set> screen and script groovy that call widget.properties values replaced by call to modelTheme (OFBIZ-9138 Create a common theme)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1806175 13f79535-47bb-0310-9956-ffa450edef68
2017-08-25 14:52:21 +00:00
Nicolas Malin b00ad07376 Fixed: Consistency and Readability improvements for view-map tag (OFBIZ-9110)
Consistency on the attribute order for view-map element as : name, type, page
Thanks to Ankush Upadhyay and Devanshu Vyas for the issue and the corrective patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1805891 13f79535-47bb-0310-9956-ffa450edef68
2017-08-23 12:17:44 +00:00
Deepak Dixit d02d1d3030 Improved: Replace fields with id-ne, id-long-ne and id-vlong-ne by id, id-long and id-vlong respectively which are not primary keys (OFBIZ-9355)
Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1804027 13f79535-47bb-0310-9956-ffa450edef68
2017-08-03 17:54:36 +00:00
Nicolas Malin e6083592e1 Implemented: Add a example of lookup with the presentation type 'none' after the ofbiz-framework commit 1802682 :set auto completion only in lookup field (OFBIZ-9378)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1803539 13f79535-47bb-0310-9956-ffa450edef68
2017-07-31 13:58:17 +00:00
Pranay Pandey e2bc04a869 Fixed: Wrong repository links on FormWidgetExamples page.
(OFBIZ-9494)

Updated the URL path and instead of changing it at all the places introduced a variable.  So in future same variable value can be changed instead of changing its redundant occurrences.

Thanks Aditya Sharma for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1802464 13f79535-47bb-0310-9956-ffa450edef68
2017-07-20 09:27:32 +00:00
Deepak Dixit c1f0182890 Improved: Replace fields with "id-ne", "id-long-ne" and "id-vlong-ne"
with "id", "id-long" and "id-vlong" respectively which are primary keys for plugin components.
(OFBIZ-9351)
Thanks Aditya Sharma for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1796380 13f79535-47bb-0310-9956-ffa450edef68
2017-05-27 11:32:18 +00:00
Jacques Le Roux 4e9ddccde9 Fixed: The help button or link does not show for the Birt, BI and example
components
(OFBIZ-9311)

Pricat was also concerned. Unlike hhfacility, I see no reasons why these 
components would use the GlobalDecorator instead of the ApplicationDecorator
(the ApplicationDecorator embeds the GlobalDecorator)

OFBIZ-9312 is a duplicate of this


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins/trunk@1791116 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 12:58:38 +00:00
Jacques Le Roux fc3e1db4f6 No functional changes
At http://markmail.org/message/ffmyw773p65fndey I wrote:

I'd like to follow the suggestion I made in the last message of the linked 
thread.
In other words, use
http://subversion.apache.org/docs/release-notes/1.8.html#repos-dictated-config
http://blogs.collab.net/subversion/the-road-to-repository-dictated-configuration-day-2-autoprops
Then this problem would be over. No longer need to check from time to time that
concerned files, have svn:eol-style=native property set
This imply that all OFBiz users use svn > 1.7, but we can inform them, et voilà

Then at markmail.org/message/h3q2yvj4db544ro7 I wrote:

Actually, since we get new committers now and then and their are able to create
new files I have a warning every 6 months which says "Check Java 
files, have all svn:eol-style=native" (I totally forgot that because I assume
the machine knows it and warns me ;))
I could extend that to all files (at least the most prominent types), I'll
see...

This does what the last sentence said for Groovy, XML and few new Birt 
Java files.

I'll see if I can implement the svn 1.8 repos-dictated-config ASAP!




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781219 13f79535-47bb-0310-9956-ffa450edef68
2017-02-01 10:58:46 +00:00
Jacques Le Roux 040f1b520c No functional change, updates Supported Content Types in example controller to
be the same than in birt controller

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1781037 13f79535-47bb-0310-9956-ffa450edef68
2017-01-31 09:22:11 +00:00
Taher A. Alkhateeb 436c99ca6d Implemented: renamed the directory specialpurpose to plugins
(OFBIZ-7972)

In another step towards completing the plugin system for OFBiz, we renamed
the /specialpurpose directory to /plugins and changed all occurences of the
word "specialpurpose" to "plugins" in all files found in the system

Reference discussion: http://markmail.org/message/hpyuxkmftiyn44w2


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/plugins@1778271 13f79535-47bb-0310-9956-ffa450edef68
2017-01-11 10:48:47 +00:00
Jacques Le Roux b20182123e Improved: Refactor forms in Example
(OFBIZ-9146)

Refactoring form definitions with type='single'
Refactoring various lists forms into grids.
Refactoring various list form references in screen widgets into grid references


Thanks: Pierre Smits

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1774906 13f79535-47bb-0310-9956-ffa450edef68
2016-12-18 16:55:27 +00:00
Michael Brohl 777a47634c Improved: Proper Form Validation should be there while adding new Example Feature.
(OFBIZ-7476)

Thanks: Ankit Joshi for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1774776 13f79535-47bb-0310-9956-ffa450edef68
2016-12-17 15:25:12 +00:00
Deepak Dixit 15bc40e491 Reverted: Minilang code readability and consistency improvements done at r#1768222, this commit reversed key and description of drop-down in the code.
(OFBIZ-9114)

Thanks  Wei Zhang for reporting the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1772880 13f79535-47bb-0310-9956-ffa450edef68
2016-12-06 12:37:42 +00:00
Deepak Dixit 547951e4d1 Completed: Upgrade Tomcat embed websocket jar to 8.0.39
(OFBIZ-9124)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1771935 13f79535-47bb-0310-9956-ffa450edef68
2016-11-29 18:05:49 +00:00
Jacques Le Roux 791d6333e7 Fixed: Search operation on 'AllExamplesWithDesiredCustomerFeaturesReport' entity
causing exception
(OFBIZ-8822)

Steps to regenerate:
1. Go to Entity Data Maintenance in webtools
2. Search entity 'AllExamplesWithDesiredCustomerFeaturesReport'. 
Click and go to the overview page.
3. Click on the Search button.

Thanks: to Pritam Kute for report and Pallavi Goyal for patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768779 13f79535-47bb-0310-9956-ffa450edef68
2016-11-08 20:36:12 +00:00
Divesh Dutta a4567c2486 Improvement: Minilang code readability and consistency improvements.
(OFBIZ-8929) (OFBIZ-8930) (OFBIZ-8953) (OFBIZ-8965) (OFBIZ-8972) (OFBIZ-8986) (OFBIZ-8991) 

Thanks: Ankush Upadhyay, Anuj Jain, Abhijeet for your patches. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768222 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:34:00 +00:00
Divesh Dutta 77af05bc8e Improvement: Miniland code readability and consistency improvements
(OFBIZ-8744) (OFBIZ-8745) (OFBIZ-8746) (OFBIZ-8748) (OFBIZ-8829) (OFBIZ-8830) (OFBIZ-8907) (OFBIZ-8908) (OFBIZ-8924) (OFBIZ-8925) 

Thanks: Ankush Upadhyay , Sega patidar , Abhijeet Ashapure for your patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1768219 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 14:14:04 +00:00
Arun Patidar 8bb8f78872 Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Arun Patidar 8b01e9b709 Implemented: Added CRUD services for CountryAddressFormat, ExampleFeatureApplType, GoodIdentificationType, InventoryItemType, InventoryItemTypeAttr, InvoiceContentType, InvoiceItemTypeAttr, InvoiceItemTypeMap, InvoiceType, NeedType, OrderAdjustmentTypeAttr, SalesOrderItemFact, SegmentGroupType, ShipmentGatewayConfigType, ShipmentGatewayDhl, ShipmentGatewayFedex, ShipmentType, ShippingDocument and ShoppingListType entities.
(OFBIZ-8087) (OFBIZ-8204) (OFBIZ-8245) (OFBIZ-8248) (OFBIZ-8249) (OFBIZ-8257) (OFBIZ-8261) (OFBIZ-8267) (OFBIZ-8270) (OFBIZ-8279) (OFBIZ-8284) (OFBIZ-8437) (OFBIZ-8439) (OFBIZ-8455) (OFBIZ-8460) (OFBIZ-8461)
(OFBIZ-8470) (OFBIZ-8473) (OFBIZ-8478)

Thanks: Rohit Koushal, Aman Mishra, Chinmay Patidar and Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1767101 13f79535-47bb-0310-9956-ffa450edef68
2016-10-29 09:01:09 +00:00
Arun Patidar 56e6fa0354 Implemented: Added CRUD services for FinAccountTransType, FinAccountTransTypeAttr, FinAccountType, FinAccountTypeAttr, FixedAssetAttribute, FixedAssetIdentType, FixedAssetProductType,
FixedAssetStdCostType,FixedAssetType, FixedAssetTypeAttr, GlAccountClass, GlAccountGroup, GlAccountGroupMember, GlAccountGroupType, GlAccountRole, GlAccountType, GlBudgetXref, FacilityCarrierShipment,
FacilityLocationGeoPoint and ExampleType entities.

(OFBIZ-8205) (OFBIZ-8206) (OFBIZ-8207) (OFBIZ-8209) (OFBIZ-8210) (OFBIZ-8211) (OFBIZ-8212) (OFBIZ-8213) (OFBIZ-8214) (OFBIZ-8215)
(OFBIZ-8216) (OFBIZ-8217) (OFBIZ-8218)  (OFBIZ-8219) (OFBIZ-8220) (OFBIZ-8221) (OFBIZ-8233) (OFBIZ-8234) (OFBIZ-8235)  (OFBIZ-8236)

Thanks: Rahul Singh Kushwah and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1765077 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 14:37:51 +00:00
Mridul Pathak 203bce1b2c Improved: Removed unused imports from groovy files in example component.
(OFBIZ-8483)

Thanks: Gopal Yadav for contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1765054 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 13:00:53 +00:00
Jacopo Cappellato 96b22285f4 Implemented: removed the "controller" related logic, that is now provided by the
new ControlFilter, from the ContextFilter; modified existing applications to use 
the two filters in a chain; removed from the other specialized filters all the 
logic that was duplicated or extended from ContextFilter.

A web application, in order to leverage the OFBiz framework, requires that a 
series of objects are in its contexts (servlet context, session and request) 
such as "delegator", "delegatorName", "dispatcher", "security" etc. etc...
This setup is performed by the logic contained in the servlet filter implemented 
by the ContextFilter class.
The execution of this logic is required for the application to run properly.
However, before this commit, in the ContextFilter there was other logic, related 
to access control and redirection rules (some of them performed in coordination 
with the ControlServlet), making it difficult to deploy this filter in all the 
web applications, especially the ones that implement special handling of paths.
In fact, this filter was deployed in most but not all the web application in the 
OFBiz codebase: specifically it was not deployed in web applications that 
require the execution of other filters (e.g. CatalogUrlFilter, etc...) like the 
ones in the "ecommerce" and "solr" components.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761304 13f79535-47bb-0310-9956-ffa450edef68
2016-09-18 08:08:30 +00:00
Taher A. Alkhateeb 8aa65b91c9 Improved: local library classpath setup in OFBiz
Now that all local jars are removed from OFBiz, there is no need to either
keep the "lib" directory in components or to automatically load these libs
if they exist. If users want to add custom libraries, then can place them
directly in the top level directory "lib".

Hence this commit removes the remaining lib directories in the accounting,
example and ldap components and fixes build.gradle to not iterate the lib
directories in components for loading jars inside of them.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1761302 13f79535-47bb-0310-9956-ffa450edef68
2016-09-18 06:58:27 +00:00
Deepak Dixit 96371e329f (OFBIZ-7991) Applied patch from jira issue
=====================================
Add UI labels for success / error messages in example component
=====================================
Thanks Tanmay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1759081 13f79535-47bb-0310-9956-ffa450edef68
2016-09-03 12:14:36 +00:00
Jacques Le Roux 354e809e29 A modified patch from Pierre Smits for "Remove legal statement from existing readme files" https://issues.apache.org/jira/browse/OFBIZ-8085
After commit, please rename readme files of components
manufacturing
assetmaint
birt
ecommerce
lucene
myportal
passport
projectmgr
scrum
solr

jleroux: Due to content I guess Pierre meant to add the .md suffix
I have also removed the useless ASL2 header of example/lib/README file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758702 13f79535-47bb-0310-9956-ffa450edef68
2016-09-01 05:11:45 +00:00
Pranay Pandey e44ba95d72 [OFBIZ-7311] - Applied the patch from the ticket. Removing the unused references of the maincss.css from source code, following is done-
1) Removed 'maincss.css' entry from 'allowedPaths' param of from web.xml
Reason: Since, there is no file like 'maincss.css' exist under any includes directory. 
2) Removed the unused references of maincss.css from FTLs, code
<link rel="stylesheet" href="${StringUtil.wrapString(baseUrl!)}/images/maincss.css" type="text/css"/> 
has been removed.
Reason: This is an interesting thing, these FTLs were using the maincss.css located under the images directory.
When I look the history of these files, following were my findings,
The 'maincss.css' file under the 'images' directory exist in release4.0 
http://svn.apache.org/repos/asf/ofbiz/branches/release4.0/framework/images/webapp/images/
after this release, this files no longer exist there.
3) Also, I have updated one file 'InventoryNoticeEmail.ftl' and used the basic HTML code to style, instead of using style defined in 'maincss.css' which were exist in release-4.0
4) Updated some references from 'maincss.css' to style.css in comments.
5) Also removed the entry of including '/images/maincss.css' and '/images/mainrtl.css' in SimpleDecorator
Since, these files no longer exist after release-4.0.

Thanks Wai for reviewing the work and thanks Swapnil M Mane for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1758389 13f79535-47bb-0310-9956-ffa450edef68
2016-08-30 13:37:27 +00:00
Deepak Dixit adc715c257 (OFBIZ-7625) Added file missing in last commit.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1757961 13f79535-47bb-0310-9956-ffa450edef68
2016-08-27 07:47:32 +00:00
Deepak Dixit 84a2c23810 (OFBIZ-7625) Applied patch from jira issue
===================================
Add "changeByUserLoginId" field for ExampleStatus
===================================
Thanks Nameet and Renuka for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1757960 13f79535-47bb-0310-9956-ffa450edef68
2016-08-27 07:42:02 +00:00
Jacques Le Roux f9c9d7a5f6 A 1st step for "Upgrade Tomcat to 8.5.3 (or 8.0.36)" - https://issues.apache.org/jira/browse/OFBIZ-7348
This is a security issue which was pending for too long. It only updates Tomcat to 8.0.36 because I got issues with 8.5.3 when just changing to 8.0.36 in build.gradle files worked.

I also changed the version number in LICENSE, even if some libs are only downloaded by Gradle as dependencies of the main present in build.gradle, this is a WIP.

I have investigated if we really need to have all the external jar libs in LICENSE even if we don't deliver them in 1st place, but are still used when building, see http://markmail.org/message/emnu6s5wu2yuyith


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1757318 13f79535-47bb-0310-9956-ffa450edef68
2016-08-23 07:35:32 +00:00
Jacques Le Roux 9179f9c8ba Fixes "Remove warnings regarding missing component lib folders" - https://issues.apache.org/jira/browse/OFBIZ-7776 - by cleaning/clearing the references to non existent/empty dirs.
Notes: 
* Also removes empty framework/base/lib/scripting and useless applications\content\lib\uno\README (miss doc in wiki)
* When jpim-0.1.jar will be (hopefully) replaced we can drop lib ref in framework/base/ofbiz-component.xml
* I wonder if we should let the geronimo component alone with only 2 classes, could we not put that in entity or entityext?
 
    



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1755306 13f79535-47bb-0310-9956-ffa450edef68
2016-08-05 12:27:21 +00:00
Taher A. Alkhateeb 29ef12a634 Fix and improve the library dependencies in Gradle - OFBIZ-7534
- Convert many compile dependencies to runtime dependencies in Gradle
- Move dependencies from framework to specialpurpose 
  (only one in example component)
- put a comment above dependencies which we think should be removed
  completely subject to further testing and confirmation from the
  community.

After investigating the libs we realized that most of the dependencies
in OFBiz are runtime rather than compile time. Furthermore, we also
suspect that many of the runtime dependencies are not needed, however
further testing is needed before we can confirm and remove them from
build.gradle


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1754640 13f79535-47bb-0310-9956-ffa450edef68
2016-07-31 08:54:26 +00:00
Pranay Pandey c3631771ed [OFBIZ-7865] No functional change. Corrected formatting of Example component ftl files for improved readability.
Thanks Vaibhav Jain for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752964 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 14:02:45 +00:00
Deepak Dixit 8f3141cd46 (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Mridul Pathak efe3862baf [OFBIZ-7525] UiLabels missing on Examples PDF. Thanks Ankit Joshi for contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752896 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 06:37:45 +00:00
Taher A. Alkhateeb 2963cd7188 Migrate ALL java files from /src to /src/main/java - OFBIZ-7790
This is the first of two steps in the above mentioned JIRA. This
first step changes the java source directory for every component
from /src to /src/main/java. The next step will be adding unit
tests to every component in /src/test/java

Thank you to Deepak Dixit for tips on how to use the SVN commands
to make the appropriate file moving.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752838 13f79535-47bb-0310-9956-ffa450edef68
2016-07-15 14:17:14 +00:00
Gil Portenseigne 9008b981b5 OFBIZ-7763 :
Remove all bsh libraries and bsh remaining fonctionnalities.
Bsh interpreter is replaced by GroovyShell evaluation.

To avoid groovyShell undefined var exception, the evaluated expression is analysed, detecting variables used and setting its to null if undefined in context.
Today only alphabetic variable with '_' are detected (i.e. my_variable==null).
Add in example a test replacement of &quot; syntax to simple quote.
Remove all found bsh references

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752231 13f79535-47bb-0310-9956-ffa450edef68
2016-07-11 23:04:54 +00:00
Taher A. Alkhateeb 25ffc93eb5 Another major patch for OFBIZ-7534 replacing Ant with Gradle
This is the first patch that takes OFBiz to the point of no return
in terms of switching from Ant to Gradle build system. Specifically
this patch applies the following items:

- Delete all old Ant and Maven build scripts
- Delete 169 Jar libraries and replace them with remote ones in the
  gradle build script
- update the gradle build scripts for the dependencies and other minor
  changes needed for the script work correctly

All tests pass with the command ./gradlew cleanAll loadDefault testIntegration

Again, thank you for everyone who contributed valueble time and effort in this
process.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1752033 13f79535-47bb-0310-9956-ffa450edef68
2016-07-09 18:10:19 +00:00
Jacques Le Roux 54917e8bbd A last slightly modified patch from James Yong for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
I have uploaded a patch for the simple methods schema.
In general, the top level attributes are converted to simpleType, and attributeGroups to complexType.

Changed the following attribute name
1. ‘field’ to ‘fieldType’
2. ‘level’ to ‘levelType'

Denormalize the following attributeGroups
1. attlist.compare
2. attlist.compare-field

Left attributeGroup ‘typeDefaultString’ unchanged, cos it doesn’t matter. Not in use, it seem.

jleroux: we also fixed an issue with 
<xs:element name="field" type="fieldType"/> 
to 
<xs:element ref="field"/>
In the patch 

And I found a small issue (not minilang related) in ExampleCompoundWidgets.xml
-            <sm:log message="CompoundWidgetsFunc runs" sm:level="info"/>
+            <sm:log message="CompoundWidgetsFunc runs" level="info"/>


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750647 13f79535-47bb-0310-9956-ffa450edef68
2016-06-29 14:06:29 +00:00
Jacques Le Roux ee836db2ea A patch from Amardeep Singh Jhajj for "Add websocket support in OFBiz" https://issues.apache.org/jira/browse/OFBIZ-7073
It also contains a slightly modified patch from Amardeep Singh Jhajj for "WebSocket Example - Push Notifications" - https://issues.apache.org/jira/browse/OFBIZ-7467 - It's adding working example (in example application) of WebSocket support

I tried to use websockets in OFBiz. I simply added tomcat-embed-websocket.jar in catalina lib and created one webapp for websocket and also added server endpoint class.
It didn't work. After that, I tried the same thing with plain j2ee application with embedded tomcat. It worked there.
I researched on above issue in OFBiz and got the reason. Websockets implementation need jar scanning enabled and it is currently disabled in OFBiz. Below is the code snippet of disabling jar scan from CatalinaContainer.java:

    JarScanner jarScanner = context.getJarScanner();
    if (jarScanner instanceof StandardJarScanner) {
        StandardJarScanner standardJarScanner = (StandardJarScanner) jarScanner;
        standardJarScanner.setScanClassPath(false);
    }

Jar scanning enabling increase OFBiz server startup time upto couples of minutes (in my case, it took approx 8 minutes), so we don't want this much of startup time for OFBiz.
I got the following document where I found the reason why websocket is not working if scanning disabled.

    https://wiki.apache.org/tomcat/HowTo/FasterStartUp

Here tips are given to decrease the startup time. This tips also include disabling of jar scanning. 
We can say disabling jar scanning is right approach because if we enable it then scanner will scan all the jars loaded in OFBiz startup that we don't want.
But, If we want websockets working then we have to enable jar scanning.
For enabling jar scanning, we need below code:

    standardJarScanner.setScanClassPath(true); // Will increase server startup time.

Solution: We can add filter on jar scanning. It will allow only some kind of jars only. For example: jars having websockets endpoints. I am attaching patch for the same here.
I added filter like if jar name string contains "discoverable" word then only it will be considered for jar scan. We can change jar name of our jars using build.xml to make it discoverable for jar scanning.
For example: I have added my websocket endpoint class in "specialpurpose/ecommerce/src" and changed the "name" property in build.xml of ecommerce component from "ofbiz-ecommerce"
to "ofbiz-ecommerce-discoverable". Here is the code snippet from build.xml:

    <property name="name" value="ofbiz-ecommerce-discoverable"/>

This change will create the jar with name "ofbiz-ecommerce-discoverable.jar" in "ecommerce/build/lib/".
Now created jar will be scanned in jar scanner as its name contains "discoverable" word in it.
This change will not increase server start up time more than couple of seconds (in my case, it just two seconds). So scanning time totally depends on the list of jars scanned.
Conclusion: We can use websocket support with the help of jar filters.

The very basic working example of sending push notifications to all connected clients using WebSocket added by Amardeep Singh Jhajj works as follow:
1. Adds support to show push notifications over every screen of an example application using WebSocket when any example created or updated.
2. As it's an example, so for now push notifications will only for example creation and update using SECA's.
3. Push notification will be shown on screen for 5 seconds only, we can close it before 5 seconds using close button if needed.
The UI of notification pop-up can be changed. I kept it simple (No fancy work) to just demonstrate the WebSocket usage.
To see it in action, Please follow the steps given in OFBIZ-7073 and apply patch given here.


jleroux: I committed the 2 patches at the same time because the changes in .classpath and the LICENSE files were in the example patch for OFBIZ-7467. 

I also slightly modified the example patch in order to provide an example where no sync issues are possible by using a Collections.synchronizedSet for the javax.websocket.Session Set. I also used synchronized loops as it's requested for synchronizedSet where it's used. I know it rather symbolic in the example component but it will remember developers about the possible sync issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1750557 13f79535-47bb-0310-9956-ffa450edef68
2016-06-28 18:50:04 +00:00
Jacques Le Roux f84f07a0fa A temporary workaround for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
Reverts the simple method to use the original schema without namespace. "Duplicates" simple-methods.xsd in simple-methods-ns.xsd as we did, to get the simple-method namespace for compound-widgets.

For myself: when we will do the 3rd more elegant option (no schema duplication), have been changed also:
minilang-catalog.xml
compound-widgets.xsd


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749938 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 16:40:22 +00:00
Jacques Le Roux 96cdb9c9d6 Oops typo, seems I touched a key there :/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749663 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 12:47:02 +00:00
Jacques Le Roux 4deae05a38 Fixes a "typo" in last commit for "Autocompletion for Compound Widget" - https://issues.apache.org/jira/browse/OFBIZ-7061
We used targetNamespace (should only be used in schema) instead of xsi:schemaLocation



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose@1749634 13f79535-47bb-0310-9956-ffa450edef68
2016-06-22 05:58:26 +00:00