From 265cc7f83ea3c9b4eb3495d5cb62cf6c4ea1bb2d Mon Sep 17 00:00:00 2001 From: Jacques Le Roux Date: Fri, 1 Apr 2022 10:41:55 +0200 Subject: [PATCH] Improved: Remove deprecation warning by removing direct call to Class::newInstance Class.newInstance() has a flaw, in which any Throwable from the constructor is thrown unchecked. It was deprecated in Java 9, but not marked for removal. It shows as a deprecation warning when compiling OfBiz with Java 11. Thanks: Heinz Kabutz for reporting and initially committing 0e6732b. This completes in plugins and all will we backported --- .../java/org/apache/ofbiz/ws/rs/util/OpenApiUtil.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/rest-api/src/main/java/org/apache/ofbiz/ws/rs/util/OpenApiUtil.java b/rest-api/src/main/java/org/apache/ofbiz/ws/rs/util/OpenApiUtil.java index 27066aa2c..5444242dd 100644 --- a/rest-api/src/main/java/org/apache/ofbiz/ws/rs/util/OpenApiUtil.java +++ b/rest-api/src/main/java/org/apache/ofbiz/ws/rs/util/OpenApiUtil.java @@ -18,6 +18,7 @@ *******************************************************************************/ package org.apache.ofbiz.ws.rs.util; +import java.lang.reflect.InvocationTargetException; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -298,8 +299,9 @@ public final class OpenApiUtil { return null; } try { - schema = (Schema) schemaClass.newInstance(); - } catch (InstantiationException | IllegalAccessException e) { + schema = (Schema) schemaClass.getDeclaredConstructor().newInstance(); + } catch (InstantiationException | IllegalAccessException | IllegalArgumentException | InvocationTargetException | NoSuchMethodException + | SecurityException e) { e.printStackTrace(); } @@ -377,8 +379,9 @@ public final class OpenApiUtil { continue; } try { - schema = (Schema) schemaClass.newInstance(); - } catch (InstantiationException | IllegalAccessException e) { + schema = (Schema) schemaClass.getDeclaredConstructor().newInstance(); + } catch (InstantiationException | IllegalAccessException | IllegalArgumentException | InvocationTargetException | NoSuchMethodException + | SecurityException e) { e.printStackTrace(); } if (schemaClass != null) {