(OFBIZ-9435)
Another round of refactoring in the start component with the following changes:
- Change the default adminKey to "NA" since it is only used in the "start"
context. Other contexts do not require an admin server (test, load-data)
- Simplify and cleanup the locale creation logic in the constructor and move
things out to the method with a return value
- Simplify the Timezone creation logic by moving it outside the constructor into
a small method
- Substantially simplify the determineOfbizPropertiesFileName(..) method by
reversing the order of condition evaluation (first, load-data, then test, then
anything else is start)
- Change default locale to be 'en' as the system crashes if not provided.
- Remove all comments from properties files except for start.properties and
refer to it from the other properties files
- Update the properties files accordingly
Thanks: Jacques Le Roux for review and suggestion to remove the comments from
properties files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1800368 13f79535-47bb-0310-9956-ffa450edef68