Files
ofbiz-framework/framework/webtools/groovyScripts/stats/StatBinsHistory.groovy
T
Jacques Le Roux e8a3c6f3d5 Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

In many Java and Groovy files we have auto generated catch blocks or empty catch 
blocks. 
To avoid such exception swallowing this should be improved to at least log the 
error and also return error in case of service.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1807162 13f79535-47bb-0310-9956-ffa450edef68
2017-09-03 19:27:49 +00:00

63 lines
2.4 KiB
Groovy

/*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import org.apache.ofbiz.base.util.*
import org.apache.ofbiz.security.Security
import org.apache.ofbiz.webapp.stats.*
id = parameters.statsId
typeStr = parameters.type
type = -1
try {
type = Integer.valueOf(typeStr)
} catch (NumberFormatException nfe) {
Debug.logError(nfe, "Caught an exception : " + nfe.toString(), "StatBinsHistory.groovy")
errMsgList.add("Entered value is non-numeric for numeric field: " + field.getName())
}
binList = null
if (type == ServerHitBin.REQUEST) {
binList = ServerHitBin.requestHistory.get(id)
} else if (type == ServerHitBin.EVENT) {
binList = ServerHitBin.eventHistory.get(id)
} else if (type == ServerHitBin.VIEW) {
binList = ServerHitBin.viewHistory.get(id)
}
if (binList) {
requestList = []
binList.each { bin ->
requestIdMap = [:]
if (bin != null) {
requestIdMap.requestId = bin.getId()
requestIdMap.requestType = bin.getType()
requestIdMap.startTime = bin.getStartTimeString()
requestIdMap.endTime = bin.getEndTimeString()
requestIdMap.lengthMins = UtilFormatOut.formatQuantity(bin.getBinLengthMinutes())
requestIdMap.numberHits = UtilFormatOut.formatQuantity(bin.getNumberHits())
requestIdMap.minTime = UtilFormatOut.formatQuantity(bin.getMinTimeSeconds())
requestIdMap.avgTime = UtilFormatOut.formatQuantity(bin.getAvgTimeSeconds())
requestIdMap.maxTime = UtilFormatOut.formatQuantity(bin.getMaxTimeSeconds())
requestIdMap.hitsPerMin = UtilFormatOut.formatQuantity(bin.getHitsPerMinute())
requestList.add(requestIdMap)
}
}
context.requestList = requestList
}