While looking for other cases like r1459222 and r1509164 introduced by r1300812 and r1305309. I noticed there were a lot of wrong for loops formatting (miss a white space after for), this changes it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1511742 13f79535-47bb-0310-9956-ffa450edef68
"other-field-size" of drop-down form element is a very nice feature, but it's crippled in current version.
attached a patch to make it works and added an example section for that into FormWidgetExample.
jleroux: Interesting, I did not know this feature existed, it was committed long ago by David (before ASF era)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1511279 13f79535-47bb-0310-9956-ffa450edef68
When you want edit/remove an entity from link call it's needed to give all pk on parameter element as like :
{quote} <field name="deleteLink">
<hyperlink target="example_deleteExampleFeatureAppl">
<parameter param-name="exampleId"/>
<parameter param-name="exampleFeatureId"/>
<parameter param-name="fromDate"/>
<hyperlink/>
</field>
{quote}
To simplify, I introduce auto-parameters-entity like this :
{quote}
<field name="deleteLink">
<hyperlink target="example_deleteExampleFeatureAppl">
<auto-parameters-entity entity-name="ExampleFeatureAppl"/>
<hyperlink/>
</field>
{quote}
or
{quote}
<form name="ListExampleFeatureAppls" type="list" default-entity-name="ExampleFeatureAppl">
<field name="deleteLink">
<hyperlink target="example_deleteExampleFeatureAppl">
<auto-parameters-entity/>
<hyperlink/>
</field>
{quote}
This method is inspired from auto-fields-entity and I homogenized on widget renderer screen (link), menu (link) and form (hyperlink, sub-link)
jleroux: I simply put returns in case of no dispatcher or delegator
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1506835 13f79535-47bb-0310-9956-ffa450edef68
Replaces
if(!jQuery('#content-messages'))
by
if(jQuery('#content-messages').length==0)
in framework\images\webapp\images\selectall.js line #354.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1506274 13f79535-47bb-0310-9956-ffa450edef68
When I reverted r1311214 for "set different ports for testing in a CI environment (e.g. Jenkins)" https://issues.apache.org/jira/browse/OFBIZ-4794 I did not notice Jacopo's also changed some ports value at r1324614
This reverts r1324614 to have things consistent. I don't backport (only R12.04 is concerned) because as long as catalina/ofbiz-component.xml is consistent (port =+ 1) things are working
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1502121 13f79535-47bb-0310-9956-ffa450edef68
Application menu item should be link not hidden form. As if its hidden form then you can not open it in new tab.
Default menu item link type auto, and its create an hidden for for link if controller request call an event, but in menu item this should be link.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1500382 13f79535-47bb-0310-9956-ffa450edef68
OOTB, it's a non functional change, since the getServiceResult() function was not yet used with parameters
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1499477 13f79535-47bb-0310-9956-ffa450edef68
of having to deal with some kind of map/generic value. This makes it
simpler to use full-text-search queries thru the entity
engine(postgresql and oracle).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497893 13f79535-47bb-0310-9956-ffa450edef68
allows other components to automatically insert themselves, without
having to modify any existing files. This can be used for integrating
with Jasig CAS, or with OpenID.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497892 13f79535-47bb-0310-9956-ffa450edef68
registered. In some cases, however, the Date convertor would be used
instead of the more correct Timestamp convertor. This fix implements a
most-specific type algorithm to find the better convertor.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497890 13f79535-47bb-0310-9956-ffa450edef68
field, then we need to be certain to remove the existing defined field
from the list of available fields. Otherwise, you'll end up with the
same field being queried in SELECT, and the same field being updated in
INSERT or UPDATE.
This issue was discovered when changing the type of a pre-existing
field(so that the length of the field could be increased).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497889 13f79535-47bb-0310-9956-ffa450edef68
When we navigate on create user login page from party profile on clicking "Create New" link in User Name(s) Section, "Cancel/Done" is not working correctly on Create User Login page. partyId is missing with link. It is not working on trunk and 12.04, not sure about other versions.
jleroux: 11.04 is concerned, 10.04 is OK
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497839 13f79535-47bb-0310-9956-ffa450edef68
With "zh" (chinese) locale, coutry-state associated list, if you choose a country there's no any associated state defined in system, the state filed does not change.
cause: incorrect translate of "CommonNoStatesProvinces" for "zh" locale. In that, it use full-width colon ":" instead of half one plus blank space(": ").
why half-width and blank space (": ")? see code in "getDependentDropdownValues" function:
jleroux; I added a comment to prevent such cases in future
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1497376 13f79535-47bb-0310-9956-ffa450edef68
Two simples errors after last change from FastList to standard java List :
1) go to example component / Dasboard
1.1) click on edit for one page
Screen is blocked
reason :
{code}
for (GenericValue portalPage : portalPages) {
cond = EntityCondition.makeCondition(UtilMisc.toList(
EntityCondition.makeCondition("ownerUserLoginId", EntityOperator.EQUALS, userLoginId),
EntityCondition.makeCondition("originalPortalPageId", EntityOperator.EQUALS, portalPage.getString("portalPageId"))),
EntityOperator.AND);
List <GenericValue> privatePortalPages = delegator.findList("PortalPage", cond, null, null, null, false);
if (UtilValidate.isNotEmpty(privatePortalPages)) {
portalPages.remove(portalPage);
portalPages.add(privatePortalPages.get(0));
}
}
{code}
code iterate on a list and modify it, I don't know how it could work before ;-)
I propose to use an other list on iterate
2) on appbarclose.ftl for tomawak theme there is
{code}
<#assign portalPage = delegator.findOne("PortalPage", findMap, true)>
{code}
when you click to "revert to original" in dasboard screen
{code}
Error on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl delegator.findOne("PortalPage", findMap, true) is undefined. It cannot be assigned to portalPage The problematic instruction: ---------- ==> assignment: portalPage=delegator.findOne("PortalPage", findMap, true) [on line 45, column 5 in component://tomahawk/includes/appbarClose.ftl] -
{code}
2.1) to see the error, modify ExampleMenus.xml and change menu-item name from "Dasboard" to "Dasboard1"
2.2) go to example / dashboard and edit one page
2.3) click to "revert to original"
I propose to add ?if_exists
One other bug in portal page personalization.
When trying to delete portlet or column in portal page, there is an error because in delete service, cache is used to read data before remove.
Correction proposed is to remove use-cache="true"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1493352 13f79535-47bb-0310-9956-ffa450edef68