Commit Graph
9449 Commits
Author SHA1 Message Date
Jacques Le Roux eaffb3d0f8 Fixed: setLocaleFromBrowser requires authentification
(OFBIZ-10460)

The setLocaleFromBrowser request map defined in common-controller.xml has an 
attribute of auth=false
While the service associated with it in framework/common/servicedef/services.xml 
has an attribute of auth=true.

jleroux: this was missing in the initial patch. At OFBIZ-9264 the description is
    "it sets the time zone of the user logged in to it's browser time zone."
So being logged in seems needed, hence better to set auth=true everywhere

Thanks: Mathieu Lirzin for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835586 13f79535-47bb-0310-9956-ffa450edef68
2018-07-10 17:31:50 +00:00
Jacques Le Roux e20b34bc24 Implemented: Add a mechanism to prevent the usage of EntitySyncRemove
(OFBIZ-10008)

No configurations is available to disable usage of EntitySyncRemove. 
And it's creating problems when having a large database and frequent delete 
operations.

saveEntitySyncRemoveInfo is used to create EntitySyncRemove records in 
GenericDelegator.removeValue() and removeByPrimaryKey().

This adds a mechanism to prevent the usage of EntitySyncRemove by adding a 
property in general.properties file used to configure in entityengine.xml 






git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835296 13f79535-47bb-0310-9956-ffa450edef68
2018-07-07 07:46:04 +00:00
Gil Portenseigne f428a7e803 Fixed: GetLocaleList call can provide duplicate results
(OFBIZ-10458)

A new Junit test is implemented to validate that no duplicates are present.
Groovy service has been refactored to use a more functional style

Thanks Mathieu Lirzin for reporting and providing the patch


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835282 13f79535-47bb-0310-9956-ffa450edef68
2018-07-06 21:10:07 +00:00
Deepak Dixit fcdfc47d0a Fixed: Framework webapp freemarkerTransform.properties has dependency on proudct component
(OFBIZ-10463)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835235 13f79535-47bb-0310-9956-ffa450edef68
2018-07-06 11:46:52 +00:00
Shi Jinghai 65905bd8d3 Reverted: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438

Forgot to revert site-conf.xsd.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835043 13f79535-47bb-0310-9956-ffa450edef68
2018-07-04 05:32:10 +00:00
Suraj Khurana 920050d685 Reverted: Empty header row should not render if list to render in file is empty because after this, search Result tables won't show first search result.
{OFBIZ-10438}

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835042 13f79535-47bb-0310-9956-ffa450edef68
2018-07-04 05:24:41 +00:00
Shi Jinghai 17d9904b83 Reverted: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834917 13f79535-47bb-0310-9956-ffa450edef68
2018-07-03 06:21:02 +00:00
Jacques Le Roux 39582de221 Improved: Factorize code logic from ‘ConfigXMLReader’
(OFBIZ-10453)

There is a lot of repetitive code in ConfigXMLReader. 
Using a functional interface as a parameter of a generic algorithm avoids those
repetitions.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834662 13f79535-47bb-0310-9956-ffa450edef68
2018-06-29 10:03:22 +00:00
Shi Jinghai b6a53caa21 Implemented: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438

Add apache license to MethodNotAllowedException.java.

Thanks: Mathieu Lirzin for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834570 13f79535-47bb-0310-9956-ffa450edef68
2018-06-28 03:00:23 +00:00
Shi Jinghai 4abebaea5a Implemented: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438

ControlServlet.java returned to the previous doGet/doPost structure.

Thanks: Mathieu Lirzin for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834465 13f79535-47bb-0310-9956-ffa450edef68
2018-06-27 05:48:59 +00:00
Shi Jinghai 68003b9526 Implemented: Add method attribute to request-map to controll a uri can be called GET or POST only
OFBIZ-10438

The request-map element has a new method attribute to control a uri be called by GET or POST or all.

Thanks: Mathieu Lirzin for the contribution.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1834389 13f79535-47bb-0310-9956-ffa450edef68
2018-06-26 02:00:33 +00:00
Taher A. Alkhateeb d46a33a627 Improved: improve XML parsing with more restrictive settings
(OFBIZ-10435)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833708 13f79535-47bb-0310-9956-ffa450edef68
2018-06-18 12:23:44 +00:00
Jacques Le Roux ca9b1bbd41 Reverted: Navigate from a domain to another with automated signed in
authentication
(OFBIZ-10307)

This reverts the work done previously for OFBIZ-9833 and OFBIZ-10206
Most parts of it will actually be reused later in a patch. By reverting it will 
allow to provide a patch for others to review


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833510 13f79535-47bb-0310-9956-ffa450edef68
2018-06-14 14:37:24 +00:00
Jacques Le Roux bdd946d0e8 Improved: Remove unused code in CommonEvents::setFollowerPage
(OFBIZ-10413)

`CommonEvents::setFollowerPage` contains two unused variable definitions.  
After basic search I found that this request handler is used only in 
`webapp/partymgr/controller.xml` 
However I was unable to understand its purpose, so I have added a comment to add
 some kind of docstring.

jleroux: this event method is never used because the pushPage request map is 
also never used. So we can get rid of the whole.
At the same time, fixes a typo in comment an remove an useless import

Thanks: Mathieu Lirzin for initial reporting

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833505 13f79535-47bb-0310-9956-ffa450edef68
2018-06-14 13:18:49 +00:00
Jacques Le Roux 4472a0e39e Improved: no functional change, fix a typo in a comment
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833388 13f79535-47bb-0310-9956-ffa450edef68
2018-06-12 09:22:40 +00:00
Rishi Solanki b9cf8a5d55 Improved: Add Support for Disable attribute in CheckBox Form Widget. Disabled attrivute can be used as
<field><check disabled=true/></field>

and default value for attribute will be false.
(OFBIZ-10367)
Thanks Pawan Verma for reporting the improvement and providing patch for that.
Thanks James Yong for testing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833231 13f79535-47bb-0310-9956-ffa450edef68
2018-06-09 12:34:49 +00:00
Jacques Le Roux 3304dec663 Fixed: The first visit event are not executed in case of CMS
(OFBIZ-10389)

Execution of the first visit events depends on the trackVisit function

In RequestHandler.java file

if (this.trackVisit(request) && session.getAttribute("_FIRST_VISIT_EVENTS_") == null) {
    // execute first visit event
}

trackVisit function does not honor the default controller request 
(in this case, cms) So, we should improve the code of trackVisit to honor 
default controller request.


Thanks: Swapnil M Mane

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832944 13f79535-47bb-0310-9956-ffa450edef68
2018-06-05 13:56:29 +00:00
Jacques Le Roux 66fa6b9c51 Improved: no functional change, fixes a typo in comment while at it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832930 13f79535-47bb-0310-9956-ffa450edef68
2018-06-05 11:29:11 +00:00
Jacques Le Roux c704689c3a Improved: no functional change, removes trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832762 13f79535-47bb-0310-9956-ffa450edef68
2018-06-03 08:55:51 +00:00
Jacques Le Roux 25f853db70 Fixed: Session fixation issue
(OFBIZ-10420)

Prevents the session fixation by making Tomcat generate a new jsessionId 
(ultimately put in cookie). Only do when really signing in to avoid unnecessary 
calls

This improves the way it's done by using request.changeSessionId() instead of 
creating a brand new session. So there is no possible side effects on client and
no need to set initial request info (using setInitialRequestInfo)

Thanks: Taher for asking about it










git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832756 13f79535-47bb-0310-9956-ffa450edef68
2018-06-03 08:33:09 +00:00
Jacques Le Roux 598eee0d93 Fixed: Session fixation issue
(OFBIZ-10420)

Fixes a session fixation security issue discovered by a client with the security
 audit tool "IBM Security AppScan Enterprise , Version : 9.0.3.7"

Prevents the session fixation by making Tomcat generate a new jsessionId 
(ultimately put in cookie). 

Only do when really signing in to avoid unnecessary calls
Though if the client has disabled the use of cookies, then a session will be 
new on each request, not a good choice on client side!




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832662 13f79535-47bb-0310-9956-ffa450edef68
2018-06-01 07:37:27 +00:00
Jacques Le Roux 94ec9094c4 Improved: Add session tracking mode and make cookie secure
(OFBIZ-6655)

In CrossSubdomainSessionValve::replaceCookie sets HttpOnly if it was in replaced
cookie

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832591 13f79535-47bb-0310-9956-ffa450edef68
2018-05-31 09:27:32 +00:00
Wei Zhang 6da8a7fc29 Fixed: Incorrect data type conversion of variable serviceEndTime in CoreEvents.java
(OFBIZ-10419)

A minor fix for serviceEndTime conversion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832577 13f79535-47bb-0310-9956-ffa450edef68
2018-05-31 01:20:54 +00:00
Jacques Le Roux 16ad1e4870 Improved: New documentation for EntitySync
(OFBIZ-10390)

No functional changes while working on EntitySync-manual.adoc and checking the 
opportunity of existing debug log (it's a bit verbose, but it's OK as is)
Simply uses a multi-catch where possible



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832411 13f79535-47bb-0310-9956-ffa450edef68
2018-05-28 17:34:20 +00:00
Jacques Le Roux 22b6c33e88 Improved: Empty header row should not render if list to render in file is empty
(OFBIZ-7598)

If list inside form doesn't contain data, then header row should not render from
better UI perspective and proper message should be shown to user.

Get to catalog/control/EditProductGoodIdentifications with eg 
productId=ID:GZ-1006 for a test 

Thanks: Suraj 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832401 13f79535-47bb-0310-9956-ffa450edef68
2018-05-28 14:37:44 +00:00
Rishi Solanki 8430ac5cc3 Improved: Generic message from entity-auto service can be enhanced. For example ProductStoreFacility Updated Successfully, we can have better success message as Product Store Facility Updated Successfully.
(OFBIZ-10409)
Thanks Suraj Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832309 13f79535-47bb-0310-9956-ffa450edef68
2018-05-26 13:00:56 +00:00
Jacques Le Roux 5ed72f1e95 Improved: Replace Inline js with External js in renderFormClose macro
(OFBIZ-9846)

Replaced inline js from renderFormClose macro to external js in OfbizUtils.js
Done following:
Used custom data attributes: data-focus-field to define focus field for the form.
Used attribute selector to find elements and set focus on the particular field.

Added "requireValidation" class to all the forms with required fields.

Used the class selector to find such forms & attached Validator plugin to it.

Steps to verify:

At add ProdCatalog page: https://localhost:8443/catalog/control/EditProdCatalog

Dialogs:
New Example dialog on Find Example page 
    Go to Find Example page https://localhost:8443/example/control/FindExample
    Click on New Example button
    Validations should work in dialog on form submit.

Additional Changes:

Link for dialog in HtmlMenuMacroLibrary still had the inline code. 
Replaced the code with external js code.

Validations on forms rendered with renderSubmitField macro from 
HtmlFormMacroLibrary.ftl seems not working 
https://demo-trunk.ofbiz.apache.org/partymgr/control/NewEmployee, will create 
a separate ticket for it.

jleroux: 
I agree about NewEmployee issue
As mentionned Aditya themes/rainbowstone/template/HtmlMenuMacroLibrary.ftl was
redundant, removed
I also removed commented out code in rainbowstone HtmlMenuMacroLibrary.ftl 
(left by Aditya while working on the issue I guess)

Thanks: Aditya 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832307 13f79535-47bb-0310-9956-ffa450edef68
2018-05-26 12:42:20 +00:00
Rishi Solanki bc4a0cbfc3 Improved: Remove Entity suffix from title of all entities. In all EntityModel.xml files, title should not contain Entity as suffix.
(OFBIZ-10408)
Thanks to Suraj Khurana for reporting the improvement and providing fix for that.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832235 13f79535-47bb-0310-9956-ffa450edef68
2018-05-25 12:19:07 +00:00
Jacques Le Roux fc8348f410 Improved: Refactor JavaEventHandler class
(OFBIZ-10410)

Instead of relying on manual synchronisation, use a concurrent map for caching 
loaded classes.  
Inline private `invoke` delegate which intent was fuzzy.  
Spread arguments when calling `Method::invoke` and `Class::getMethod`.

jleroux: interesting, it's the 1st use in OFBiz of the "::" syntax for calling
methods
(cf. https://docs.oracle.com/javase/specs/jls/se8/html/jls-15.html#jls-15.13-500)
I note that the string "::" is used in many places as a separator, notably
in caches, as  cache key separator but this should not be confusing.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832199 13f79535-47bb-0310-9956-ffa450edef68
2018-05-24 20:42:19 +00:00
Jacques Le Roux affc8a17cc Improved: Remove UtilValidate::isEmpty(String) method
(OFBIZ-10412)

UtilValidate class contains a `isEmpty` method both for `CharSequence` and for 
`String` types but since the first is an interface for the other and that the 
implementation are the same we don't need to keep the one for the concrete type.

Additionnaly I have removed the unused Generic type for the remaining 
implementation.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832170 13f79535-47bb-0310-9956-ffa450edef68
2018-05-24 13:36:08 +00:00
Jacques Le Roux 1840297cac Improved: Secure HTTP headers
(OFBIZ-6766)

After reading https://www.fastly.com/blog/headers-we-dont-want and more in the
Jira, only improves UtilHttp.setResponseBrowserProxyNoCache() by adding 
Cache-Control:private to avoid caching in proxy.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1832128 13f79535-47bb-0310-9956-ffa450edef68
2018-05-23 20:53:45 +00:00
Jacques Le Roux 257dd146a4 Improved: XML schemas should use predefined boolean type
(OFBIZ-10411)

To define boolean values, some ad-hoc enumeration of "true" and "false" are 
repeatedly used.  Since XML Schema defines a standard boolean datatype 
better to use it. 

For now only `site-conf.xsd` is fixed 

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831930 13f79535-47bb-0310-9956-ffa450edef68
2018-05-20 10:19:29 +00:00
Gil Portenseigne 9fbb3765e4 Implemented : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

This commit introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new communicationEventTypeId is created ('FILE_TRANSFER_COMM').

Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job (like sendEmailDated), to send associated contents to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and stored in communicationEvent, waiting for a new try.

For this purpose :

A new contactMechTypeId is introduced (FtpAddress), with its corresponding table. This contactMech store needed information for basic user/password authentication (server url and protocol, port, username, password, etc.)
A new service sendFileTransferDated that will look for pending file transfer and call following service.
A new service sendCommEventAsFtp that take a selected commEvent, check its structure and manage its status after trying the associated content file transfers.
A new service sendContentToFtp, that take a content and transfer it to a given FtpAddress.
A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural content file transfer, creating children communicationEvent to follow each content transfer separately (only for several content transfers).
A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS (To Implement), SFTP clients to manage Ftp connection and transfer.
A new property file to enable and manage redirection for testing purpose.

With this implementation, creating a communicationEvent, with a FtpAddress contactMechIdTo, and sendFileTransferDated job planned, the file is transfered to the ftp : communication event status set to COM_COMPLETE, if error occured the communication event status is set to COM_BOUNCED with error message on communicationEvent note.

Thanks Rishi for your feedbacks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831867 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 15:53:35 +00:00
Michael Brohl 9341c23b0f Reverted: Undo remove of test files in r1831567
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831846 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 10:48:44 +00:00
Jacques Le Roux 62fce8c184 Fixed:: Dynamic values not rendering properly in property tag of fail-property
attribute
(OFBIZ-10406)

While calling checkProductRelatedPermission, if permission is failed ten 
fail-property tag uses ${checkActionLabel} which is not handled properly in 
MessageElement.java.
There are 2-3 other occurrences as well of such type but not in working 
condition.

Thanks: Suraj

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831831 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 08:11:55 +00:00
Gil Portenseigne a71f88b1ad Fixed : change OFBiz always log level to OFF log4j level, instead of using FATAL log4j level
(OFBIZ-6206)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831788 13f79535-47bb-0310-9956-ffa450edef68
2018-05-17 15:02:03 +00:00
Michael Brohl 5c547ae60e Fixed: Removed unnecessary class and folders.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831567 13f79535-47bb-0310-9956-ffa450edef68
2018-05-14 13:34:03 +00:00
Jacques Le Roux a5a90ab1dc Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)

Now that we use Tomcat 9 this problem is over

Thanks: Jacopo for upgrading to Tomcat 9 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831078 13f79535-47bb-0310-9956-ffa450edef68
2018-05-07 07:48:57 +00:00
Jacopo Cappellato 59f97f6549 Implemented: Upgraded to latest Tomcat (9.0.7).
(OFBIZ-10036)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831074 13f79535-47bb-0310-9956-ffa450edef68
2018-05-07 06:41:47 +00:00
Jacques Le Roux 1848294a22 Documented: New documentation for EntitySync
(OFBIZ-10390)

Adds the PDF generation information for stand alone document

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831017 13f79535-47bb-0310-9956-ffa450edef68
2018-05-06 07:20:56 +00:00
Jacques Le Roux 1129ac14c7 Documented: New documentation for EntitySync
(OFBIZ-10390)

The current EntitySync documentation in wiki is POS oriented so somehow 
deprecated.
I have recently worked on a project with EntitySync and collected as much 
possible information. 
I also got David E. Jones's agreement to reuse the part on EntitySync in his 
2006 "Apache OFBiz Advanced Framework - Training Video Transcription" document.

So this is a new replacing asciidoc document, it's a WIP...

Thanks: David for agreement on reusing his doc.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830972 13f79535-47bb-0310-9956-ffa450edef68
2018-05-05 13:13:58 +00:00
Deepak Dixit d358bc4471 Improved: Added missing condition-service in entity-eca.xsd file
(OFBIZ-10220)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830960 13f79535-47bb-0310-9956-ffa450edef68
2018-05-05 10:45:00 +00:00
Deepak Dixit 645e6e1c47 Fixed: Fix typo 'paramters' => 'parameters'
(OFBIZ-10394)
Thanks Mathieu Lirzin for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830936 13f79535-47bb-0310-9956-ffa450edef68
2018-05-04 19:34:07 +00:00
Jacques Le Roux e551e6cf8d Improved: Generalize toMap to abitrary key types
(OFBIZ-10354)

The `toMap` static method doesn't use its 'K' generic type in its implementation

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830588 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 13:30:35 +00:00
Rishi Solanki cfef87d6f1 Improved: Remove empty field values from xml data files so that it will not override existing data with empty values. Removed all empty data fields from data files.
(OFBIZ-10282)
Thanks to Arun Patidar for reporting and review.
Thanks to Suraj Khurana for providing patch for the improvement.
Thanks to Jacques for discussion and finalizing the work.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830545 13f79535-47bb-0310-9956-ffa450edef68
2018-04-30 10:52:55 +00:00
Nicolas Malin 8e2d65f4d6 Fixed: ConfigXMLReader - Events are not executed in the order defined
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:

    <after-login>
        <event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
        <event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
        <event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
    </after-login>

We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.

Thanks to Vikas Mayur for solve this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830303 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:26:58 +00:00
Nicolas Malin b48d0cadc5 revert revision 1830301 that contains mix improvement, i will recommit them correclty
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830302 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:26:33 +00:00
Nicolas Malin 2695743cae Fixed: ConfigXMLReader - Events are not executed in the order defined
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:

    <after-login>
        <event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
        <event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
        <event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
    </after-login>

We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.

Thanks to Vikas Mayur for solve this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830301 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 07:21:47 +00:00
Gil Portenseigne d046d17f35 Reverted : Add a link onto a crashed Job to reset it
(OFBIZ-10371)

Thanks Scott for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830294 13f79535-47bb-0310-9956-ffa450edef68
2018-04-27 05:55:43 +00:00
Gil Portenseigne bed2be5f53 Improved: Change the display condition on the added link
(OFBIZ-10371)

This way to write the condition is easier for the eye, thanks Nicolas for the suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1830238 13f79535-47bb-0310-9956-ffa450edef68
2018-04-26 15:45:31 +00:00