This fixes the calendar issue in bluelight and remove the (X) button that broke the calendar layout (strangely was only from layered lookups)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940425 13f79535-47bb-0310-9956-ffa450edef68
For the pagination issue in bluelight and droppingcrumbs, the calendar issue in bluelight still exists
I have also added 2 lookup and calendar test fields in the 2d lookups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940234 13f79535-47bb-0310-9956-ffa450edef68
There are still issues in BLue Light and Dropping Crumbs, though I thought it will be easier to apply the same fix on them, but it's not
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@939582 13f79535-47bb-0310-9956-ffa450edef68
This patch fixes also some issues with buttons inside lookups not showing. However the main reason is still not fixed in the case of lookup rendered from FTL files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@936008 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3708 - Fields should be defined with span not div. (radio, date, lookup)
https://issues.apache.org/jira/browse/OFBIZ-3708
Field markup should be a valid inline element.
Defining fields with div (block) instead of span (inline) creates several problems:
* Missalignments in screen. (See LOOKUP_CAL screenshots)
* Implies a end-of-line after the div. (See CAL screenshots)
* If used inside inline elements which should be OK, becames XHTML validation errors. (Manufacturing -> MRP -> MRP log)
Because this is a markup problem, it spans to all the themes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@935312 13f79535-47bb-0310-9956-ffa450edef68
Lookups that were opened from lookups had layout bugs in buttons (shows the lookup image, certainly introduced by r932619) and links (color).
* flat grey
o next-last buttons (only in "lookup in lookup" it seems)
o blue color on links in the returned list, and on some buttons too (submit)
* dropping crumbs, blue light, bizzness time
o color on links in the returned list, and on some buttons too (find, submit, ...?)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933586 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3653 - CSS Style for select wrong in tomahawk theme
A better rendering of the select in the pagination bar.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932895 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3660 - CSS style for textarea wrong in tomahawk theme
https://issues.apache.org/jira/browse/OFBIZ-3660
The css for textarea tag have not margin and padding adjustements. The textarea is not left aligned in the same place than input[text] or select and the vertical space between fields is also different.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932735 13f79535-47bb-0310-9956-ffa450edef68
This fixes the flat-grey, dropping-crumbs and bizness-time themes. I think I will be able to close the Jira issue when Jira will be back (currently Brutus is still under maintenance for 6 hours)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932619 13f79535-47bb-0310-9956-ffa450edef68
I wanted to commit all changes at the same time but I cross more problems than I thought and prefer to get rid of them as soon they are solved...
Actually it may look like a minor issue but it's not because without these buttons you can't use the related feature
Fix an issue in TomaHawk where the "buttons" at bottom of calendar (actually text in white) where not showing when the calendar was called from a lookup
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932563 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3621 - XHTML validation errors (themes)
XHTML validation errors
* Unclosed INPUT
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* Uppercase tags or attributes.
* Unencoded ampersands in urls.
Other errors:
Header.ftl (tomahawk & droppingcrumbs)
Line 108. Wrong markup. Div can't be inside <a>
<a href="<@ofbizUrl>${logoLinkURL}</@ofbizUrl>" title="${layoutSettings.companyName}"><div> </div></a>
Style.css (tomahawk & droppingcrumbs)
Line 945. The logo is used as the background of the logo area, but because the size of the background image means nothing for dimensioning, it will be clipped.
background: url(../images/ofbiz_logo.png) no-repeat;
Solution: This is a hack to put the logo in the style sheet as the background. If the logo is only in the stylesheet without any trick, the logo will be clipped and disappears.
The logo can be loaded as an image directly in header.ftl and it will appear without clip and without any hack in header.ftl.
appbarOpen.ftl (droppingcrumbs)
Line 99, unclosed <li> and <ul>
header.ftl (bizznesstime)
Line 111. div can't be inside span.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@931665 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3653 - CSS Style for select wrong in tomahawk theme
The css style of select tag in style.css uses an height which is 1.6em when the height of text input is (1.1em + 0.4em * 2 + 0.1em * 2) = 2.1 em this gives a ugly look and in IE could cut the lower part of the text.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@931618 13f79535-47bb-0310-9956-ffa450edef68
This patch mostly solves this issues and it's clearly a progress: it's operationnal with some drawbacks, so I don't close the issue for now
here are the issues:
* some parts of the calendar are hidden (see screenshots in Jira issue)
* if you 1st click on the button the position is OK (just below) but if you scroll before and then click the position is to low (seems to follow the scroll)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@931523 13f79535-47bb-0310-9956-ffa450edef68
This patch does not fix an issue with calendar in layered lookups. So I will create a new Jira for that.
Also it introduces a small drawback: you can't no longer close a layered lookup with the right left cross button. But Esc. is still working, so it's not a blocker. I will have a look at this and if needed will create a new Jira
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@928292 13f79535-47bb-0310-9956-ffa450edef68