Commit Graph
333 Commits
Author SHA1 Message Date
Adam Heath 923bf9d8ff Fix several overly wide screens in specialpurpose/ecommerce:
1: product detail hard-coded the width of the image, even if the actual
image was smaller.
2: products with surveys(gift card purchase) were overly large, which
caused them to float below the left content.
3: the header on productcategory listings had background lines that
overflowed underneath the left and right columns.

The ecommerce app is now closer to something we'd actually show a real
customer, in its default configuration.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@995198 13f79535-47bb-0310-9956-ffa450edef68
2010-09-08 19:02:58 +00:00
Jacques Le Roux dec4ab2572 Introduces a very simple mean to set a dependent Id field when using a Name field as a lookup (the fields must have the same prefix, eg: partyName, partyId).
It uses the description (Id) shown with the Name. Hence the Lookup screen must be set in order to show a description in the autocomplete part. 
It seems this is not always easy notably when you need to show at least 2 parts for the Name (eg Person). 
At least it easy to set and it works well for simples case for now (eg PartyGroup)

I did not find another way since Ajax.Autocompleter can't update another field. 
The alternative would be navigation to the next hidden field, at least it would avoid the mandatory Id/Name pair. 
But it's more difficult to demonstrate in Example component


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@993508 13f79535-47bb-0310-9956-ffa450edef68
2010-09-07 19:55:49 +00:00
Jacques Le Roux 5fdb5272c5 Forgot to put the license headers into new files in r986370
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@986407 13f79535-47bb-0310-9956-ffa450edef68
2010-08-17 17:40:28 +00:00
Jacques Le Roux 7a285eed10 Miscellaneous improvement in Form Widgets examples. Notably introduces an, as much as possible generalized (so far), dependent drop-downs example. I have introduced 2 couples of dependent drop-downs.
The 1st one, country/states, is a common one and does not need (ie it's better to not) to be generalized. It can be used as is. It needs some pieces which are all included, see comments and follow... 

The 2d, category/products, have been taken as example but is not a good candidate. What if you get much categ or/and products? Anyway it's a good OOTB example and I had it at hand, so I used it. I have tried to generalize (abstract the couple of dropdowns) and it's almost there. The only issue I crossed, is when you want to use a couple of dependent drop-downs in the same form. As it's not a common case, the setDependentDropdownValuesJs.ftl template-script can be used in most cases...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@986370 13f79535-47bb-0310-9956-ffa450edef68
2010-08-17 16:18:24 +00:00
Jacques Le Roux 4ced84dd08 A patch from Karl Pitrich "When editing Portal Pages, Drag & Drop for Portlets does not work" (https://issues.apache.org/jira/browse/OFBIZ-3889) - OFBIZ-3889
When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work.
Where are several Issues in the MyPortal, some have fixes, none is commited to trunk.

Problems:

    * in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly
    * in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included


JLR: 
While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different  but by chance in myportal very close to common so I was finally able  to do both at along with  Karl's changes. Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit.

MyPortal
 * The login process in MyPortal was not tenant enabled, it's done in this commit.
 * I kept its specificity : newRegisterLogin and wonder why it has not been extended to common?

hhfacility
The login process in hhfacility was not tenant enabled, it's done in this commit. Doing so, I saw there i18n is not done, not an issue for me...







git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@985163 13f79535-47bb-0310-9956-ffa450edef68
2010-08-13 11:43:38 +00:00
Jacques Le Roux 04d803790b A patch from Rene Scheibe "Click Expand or Colaspe All does not work as expected" (https://issues.apache.org/jira/browse/OFBIZ-3744) - OFBIZ-3744
Reported by Sam Hamilton:
If you are on say this page - https://localhost:8443/catalog/control/EditProduct?productId=WG-9943
clicking on Expand All it will expand all the ones not expanded and then collapse the ones that were already open
clicking on Collapse All it will collapse all the ones open and open all the ones that were collapsed.

fixed issue

    * css.style.visible cannot be true/false as used so in collapseAll()
    * now using the $() container and calling visible() which returns true/false


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981051 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 13:07:13 +00:00
David E. Jones 800a85a38e Fixed two bugs with autocomplete functionality: init script in selectall.js was not doing the search/replace properly for ampersands, in the FindAutocompleteOptions.groovy script the andExprs were not really anded together so split into the or and main and lists and assembled the conditions properly, which will fix the conditionFields and the andCondition fields
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@980348 13f79535-47bb-0310-9956-ffa450edef68
2010-07-29 07:53:06 +00:00
Erwan de Ferrieres 3b3a0c404b using ajaxSubmitFormUpdateAreas, if the return error message was not in a list format, an error was displayed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@980038 13f79535-47bb-0310-9956-ffa450edef68
2010-07-28 12:45:04 +00:00
Erwan de Ferrieres 903b726770 As spotted by Matthieu Bollot on dev mailing-list, Su and Sa days were inverted
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@963271 13f79535-47bb-0310-9956-ffa450edef68
2010-07-12 12:52:28 +00:00
Erwan de Ferrieres c0f074773b Wrong parameters size was used for args with presentation=layer
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@961324 13f79535-47bb-0310-9956-ffa450edef68
2010-07-07 09:55:28 +00:00
Jacques Le Roux bc89697809 Found a Jacopo's message while browsing around calendarDateSelect.
I have not put pl.js and fi.js because they exist in the calendarDateSelect project.
I'd like to contribute those news to the calendarDateSelect project, but it's not a priority for me
I have asked how to contribute to the calendarDateSelect project

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@960376 13f79535-47bb-0310-9956-ffa450edef68
2010-07-04 18:22:50 +00:00
Jacques Le Roux 92fe067268 Should fix a problem reported by Scott on dev ML.
It's related to r886723: I forgot to create an en.js file (used as default).
I have also enhanced the other files but without total guarantee of correctness, at least it's better and improvable

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@960336 13f79535-47bb-0310-9956-ffa450edef68
2010-07-04 12:59:05 +00:00
Erwan de Ferrieres 417be33da1 When an error message is displayed, clicking on it will make it disappear
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@959960 13f79535-47bb-0310-9956-ffa450edef68
2010-07-02 12:10:58 +00:00
David E. Jones 8a6d9c7515 Small change to make the date/time format more consistent with added padding
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@956123 13f79535-47bb-0310-9956-ffa450edef68
2010-06-18 20:36:23 +00:00
Jacques Le Roux 00de634751 Generalize to set_values and _multivalues. BTW I found some issues related to OFBIZ-3746, I will reopen
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@952270 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 15:28:33 +00:00
Jacques Le Roux a6d8955001 Fixes "Lookup LookupCustRequestItem goes wrong when layered" (https://issues.apache.org/jira/browse/OFBIZ-3813) - OFBIZ-3813
The line bypassed was specifically added for "Lookup Layer Search of a Variant Product" (https://issues.apache.org/jira/browse/OFBIZ-3746) - OFBIZ-3746
But it did not was generalized enough, this should handle all the other cases where a link is in a cell of the result list that is not the 1st one cell



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@952249 13f79535-47bb-0310-9956-ffa450edef68
2010-06-07 14:36:33 +00:00
Jacques Le Roux d75fbce90a Allows to initially collapse the search screenlet of a layered lookup, default to false.
It was harder than I though because of the async nature of Ajax. So I had to use a setTimeout with a 400 ms timeout. Hopefully it will work in any environments. I chose 400 because I found it worked well on my machine, 300 also but to be sure I picked 400, 200 was too low it seems.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950481 13f79535-47bb-0310-9956-ffa450edef68
2010-06-02 10:44:16 +00:00
Jacques Le Roux 51b9d1bce2 A patch from Atul Vani (see https://issues.apache.org/jira/browse/OFBIZ-3555) - OFBIZ-3555
On IE8 the description was not being displayed at all.
With Firefox it was working fine. After doing some research I ended up with this patch. Seem like 'textContent' doesn't work in IE.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@949844 13f79535-47bb-0310-9956-ffa450edef68
2010-05-31 19:37:51 +00:00
Jacques Le Roux 1e9824ab0c * Remove useless white spaces in macro (make harder handling links in javascript)
* Implement target-parameter in case of layered lookup (was missing)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@949710 13f79535-47bb-0310-9956-ffa450edef68
2010-05-31 10:33:52 +00:00
Jacques Le Roux f8699d535d A patch from Atul Vani for an issue reported by Soumya Jyoti Guru at http://markmail.org/message/whb4am3n6ngsuwgk. It's related to https://issues.apache.org/jira/browse/OFBIZ-3667 - OFBIZ-3667
Atul's note: I noticed some strange behavior (like there's little shifting of elements).
Jacques's note: I noticed them too (it's in the calling form or layer) but it's far better than before and IMO acceptable

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@949174 13f79535-47bb-0310-9956-ffa450edef68
2010-05-28 13:27:36 +00:00
Jacques Le Roux c974d3224e A patch from Sascha Rodekamp "The position attribute (at least center) does not work when used in a lookup called from another lookup " (https://issues.apache.org/jira/browse/OFBIZ-3781) - OFBIZ-3781
Here is a little patch to fix the center issue. I had to remove some code which is not needed anymore.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@948694 13f79535-47bb-0310-9956-ffa450edef68
2010-05-27 07:07:05 +00:00
Jacques Le Roux b76b4f3808 A patch from Sascha Rodekamp " Calendar Don't open in Lookups" (https://issues.apache.org/jira/browse/OFBIZ-3780) - OFBIZ-3780
After all the last Patches the calendar didn't opened in the lookups ... But here is the fix.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@947424 13f79535-47bb-0310-9956-ffa450edef68
2010-05-23 15:08:57 +00:00
Jacques Le Roux 14adf43d86 * Especially fix a bug in fieldlookup.js.
When using description-field-name in a layered lookup called from another layered lookup (recursively or not) the description-field-name parameter (target2) in the call from the 2d lookup button was not modified, therefore the link was not working.

Miscellaneous:
* Format and fix some typos in fieldlookup.js
* Removes now useless commented out functions set_value and set_values in lookup.ftl
* Improves comments in FormWidgetExampleForms.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@947392 13f79535-47bb-0310-9956-ffa450edef68
2010-05-23 10:08:21 +00:00
Jacques Le Roux ed4edcb32e A patch from Sascha Rodekamp fix an issue with layered lookups call recursively in IE (see https://issues.apache.org/jira/browse/OFBIZ-3450) - OFBIZ-3450
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@947004 13f79535-47bb-0310-9956-ffa450edef68
2010-05-21 13:42:45 +00:00
Jacques Le Roux 3334d58ec8 A patch from Sascha Rodekamp "When you get disconnected (time out) from a layered lookup, you then get afterward ugly screens" https://issues.apache.org/jira/browse/OFBIZ-3450 - OFBIZ-3450
Fixes: when user session is destroyed: Log into an application (accounting for example) and select a form - layered lookups work correct. In another tab log into another application and then log out. Then on the first tab (accounting) try to use a lookup. In the lookup screen you will get the login screen (that's OK) but once you enter your username and password you get a blank screen.

Another issue related to external key is still existing

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@946596 13f79535-47bb-0310-9956-ffa450edef68
2010-05-20 11:47:30 +00:00
David E. Jones 5b7c6b73c2 Small change so that the lookup->target-parameter attribute is supported when also using the lookup->description-field-name
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@946593 13f79535-47bb-0310-9956-ffa450edef68
2010-05-20 11:27:16 +00:00
Jacques Le Roux bcff9669d5 A patch from Atul Vani (modified from a Sascha Rodekamp's patch) "Allow to open a layer lookup from a layer lookup recursively" (https://issues.apache.org/jira/browse/OFBIZ-3693) - OFBIZ-3693
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@946061 13f79535-47bb-0310-9956-ffa450edef68
2010-05-19 07:26:08 +00:00
Erwan de Ferrieres 212b8a6ba2 First version for a spinner when calling ajax requests
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@945126 13f79535-47bb-0310-9956-ffa450edef68
2010-05-17 13:01:20 +00:00
Erwan de Ferrieres f2810debd0 Adding the flotr debug library (not compressed), forgot to add it in previous commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@945045 13f79535-47bb-0310-9956-ffa450edef68
2010-05-17 09:33:34 +00:00
Erwan de Ferrieres a877c6fc4b Adding the capacity to create charts in OFBiz. Examples are based on the example component, and examples must be created to show charts.
Charts are using the flotr library (http://code.google.com/p/flotr/) which is under a MIT license and is based on the Prototype Javascript Framework.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@945044 13f79535-47bb-0310-9956-ffa450edef68
2010-05-17 09:29:38 +00:00
Jacques Le Roux e7264809aa A patch for "Allow to open a layer lookup from a layer lookup recursively" (https://issues.apache.org/jira/browse/OFBIZ-3693) - OFBIZ-3693
I keep the issue open because there is still a not blocking little quirk. I will have a look soon...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@944621 13f79535-47bb-0310-9956-ffa450edef68
2010-05-15 12:03:11 +00:00
Jacques Le Roux ed63676d23 A patch from Ankit Jain "Layered lookup inside the layered lookup not working" https://issues.apache.org/jira/browse/OFBIZ-3768 - OFBIZ-3768
This patch definitely closes this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@944614 13f79535-47bb-0310-9956-ffa450edef68
2010-05-15 11:42:01 +00:00
Jacques Le Roux 7bb30f3c4f A patch from Sascha Rodekamp "The minimize/enlarge buttons (+ -) blocks the layer" (https://issues.apache.org/jira/browse/OFBIZ-3692) - OFBIZ-3692
The previous related fix (r942084) was working locally but not on the demo server. We have not ideas why yet but this patch is a try to fix this issue...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@943909 13f79535-47bb-0310-9956-ffa450edef68
2010-05-13 15:20:18 +00:00
Jacques Le Roux abf9a51d32 A patch from Sascha Rodekamp "The minimize/enlarge buttons (+ -) blocks the layer" (https://issues.apache.org/jira/browse/OFBIZ-3692) - OFBIZ-3692
This fixes the last issue with the FTL layered lookups but is actually more general as it uses a 1999 origin when the HtmlScreenRendere class uses 999.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@942084 13f79535-47bb-0310-9956-ffa450edef68
2010-05-07 14:27:26 +00:00
Erwan de Ferrieres fba12467f8 setting evalscripts to true so lookups can work in portal pages
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@941014 13f79535-47bb-0310-9956-ffa450edef68
2010-05-04 19:52:55 +00:00
Jacques Le Roux 01d9292c72 A patch from Sascha Rodekamp "Missing Buttons on LookUp Search" (https://issues.apache.org/jira/browse/OFBIZ-3745) - OFBIZ-3745
This fixes the calendar issue in bluelight and remove the (X) button that broke the calendar layout (strangely was only from layered lookups)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940425 13f79535-47bb-0310-9956-ffa450edef68
2010-05-03 12:06:02 +00:00
Jacques Le Roux df40275120 A completed patch from Sascha Rodekamp "Lookup Layer Search of a Varient Product" (https://issues.apache.org/jira/browse/OFBIZ-3746) - OFBIZ-3746
Fix the variant issue in product lookups
Remove the temporary window presentation workaround (done at r939232)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940410 13f79535-47bb-0310-9956-ffa450edef68
2010-05-03 10:37:33 +00:00
Jacques Le Roux dd11ac1b1a A patch from Ankit Jain "Allow to open a layer lookup from a layer lookup" https://issues.apache.org/jira/browse/OFBIZ-3446 - OFBIZ-3446
Uncomment the line to return the name in the calling screen

I have also added groupName in the name returned (when looking for  partyGroup)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940401 13f79535-47bb-0310-9956-ffa450edef68
2010-05-03 09:10:49 +00:00
Jacques Le Roux bc012f02ae A patch from Ankit Jain "Allow to open a layer lookup from a layer lookup" https://issues.apache.org/jira/browse/OFBIZ-3446 - OFBIZ-3446
It does not hurt but I'm not quite sure it fix anything actually

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940309 13f79535-47bb-0310-9956-ffa450edef68
2010-05-02 19:26:48 +00:00
Bilgin Ismet Ibryam 0c28946a40 Moved autocompleter indicator creation to javascript.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940274 13f79535-47bb-0310-9956-ffa450edef68
2010-05-02 17:44:01 +00:00
Jacques Le Roux 84df06abef A patch from Sascha Rodekamp related to "Pagination in Layered Lookups" (https://issues.apache.org/jira/browse/OFBIZ-3726) - OFBIZ-3726
The pagination in the layered lookups was broken because of a previous patch. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@935904 13f79535-47bb-0310-9956-ffa450edef68
2010-04-20 13:23:40 +00:00
Bilgin Ismet Ibryam 667e52e947 Fixed lookup descriptions, which got broken after changes in the generated html.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@935644 13f79535-47bb-0310-9956-ffa450edef68
2010-04-19 16:04:30 +00:00
Jacques Le Roux 4cd873d37c A slightly modified "only one lookup decorator" patch from Sascha Rodekamp related to "Replace popup lookups by layer lookups" (https://issues.apache.org/jira/browse/OFBIZ-3442) - OFBIZ-3442
Merge the 2 lookup decorators in only one and dynamically adapt the rendered content

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@935578 13f79535-47bb-0310-9956-ffa450edef68
2010-04-19 14:03:41 +00:00
Scott Gray b033379d37 class is a reserved javascript keyword so you have to wrap it in quotes if you want to refer to an elements class attribute (I don't think Firefox complains but Safari does)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@935117 13f79535-47bb-0310-9956-ffa450edef68
2010-04-17 03:23:25 +00:00
Jacques Le Roux e9733780ce A patch from Sascha Rodekamp "Opening a lookup from a lookup in IE8 does not work", part of https://issues.apache.org/jira/browse/OFBIZ-3668 - OFBIZ-3668
The IE had problems with the variable 'item' ... maybe a reserved word ?!



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933226 13f79535-47bb-0310-9956-ffa450edef68
2010-04-12 13:27:02 +00:00
Jacques Le Roux c9ae599f32 A patch from Sascha Rodekamp "Cross button does not work if you don't click on the layer before", part of https://issues.apache.org/jira/browse/OFBIZ-3446 - OFBIZ-3446
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933170 13f79535-47bb-0310-9956-ffa450edef68
2010-04-12 10:09:13 +00:00
Jacques Le Roux cf77b5e6a0 A slightly modified patch from Atul Vani "Calendar rendered position too low when you scroll in a layered lookup" (https://issues.apache.org/jira/browse/OFBIZ-3667) - OFBIZ-3667
This patch attempts to fix the problem,calendar is now relatively positioned, and the parent element's height is set appropriately. 

I just added some "mod for OFBiz layered lookups" comments around changes as suggested Sascha

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933169 13f79535-47bb-0310-9956-ffa450edef68
2010-04-12 10:04:39 +00:00
Bilgin Ismet Ibryam 82a5bf6b02 A patch from OFBIZ-3555 "Show lookup value descriptions". This enhancements allows displaying a description for the IDs in lookup fields. To enable this feature set widget.lookup.showDescription to Y in widget.properties
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933130 13f79535-47bb-0310-9956-ffa450edef68
2010-04-12 07:54:10 +00:00
Jacques Le Roux 733cf6e562 Fix 2 comments,I commit because while I make some other changes during my tests I have to get this comments right again when reverting.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932964 13f79535-47bb-0310-9956-ffa450edef68
2010-04-11 18:04:22 +00:00
Bruno Busco 5d5e489598 A patch from Blas Rodriguez Somoza
OFBIZ-3637 - XHTML validation errors (framework excluding widget) round 2
https://issues.apache.org/jira/browse/OFBIZ-3637

XHTML validation errors

    * Unclosed tags INPUT, IMG, BR...
    * attributes without values (checked, selected, disabled, etc)
    * attribute values without "
    * required attributes not included (alt in img, type in style, type in script etc)
    * Uppercase tags or attributes.
    * Unencoded entities (ampersands).

Other changes:

selectall.js
line 333. ajaxAutoCompleter must work with unenconded or encoded ampersands.

EntityRefMain.ftl
line 176. <div> must be </div>


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932733 13f79535-47bb-0310-9956-ffa450edef68
2010-04-10 14:35:07 +00:00