1: product detail hard-coded the width of the image, even if the actual
image was smaller.
2: products with surveys(gift card purchase) were overly large, which
caused them to float below the left content.
3: the header on productcategory listings had background lines that
overflowed underneath the left and right columns.
The ecommerce app is now closer to something we'd actually show a real
customer, in its default configuration.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@995198 13f79535-47bb-0310-9956-ffa450edef68
It uses the description (Id) shown with the Name. Hence the Lookup screen must be set in order to show a description in the autocomplete part.
It seems this is not always easy notably when you need to show at least 2 parts for the Name (eg Person).
At least it easy to set and it works well for simples case for now (eg PartyGroup)
I did not find another way since Ajax.Autocompleter can't update another field.
The alternative would be navigation to the next hidden field, at least it would avoid the mandatory Id/Name pair.
But it's more difficult to demonstrate in Example component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@993508 13f79535-47bb-0310-9956-ffa450edef68
The 1st one, country/states, is a common one and does not need (ie it's better to not) to be generalized. It can be used as is. It needs some pieces which are all included, see comments and follow...
The 2d, category/products, have been taken as example but is not a good candidate. What if you get much categ or/and products? Anyway it's a good OOTB example and I had it at hand, so I used it. I have tried to generalize (abstract the couple of dropdowns) and it's almost there. The only issue I crossed, is when you want to use a couple of dependent drop-downs in the same form. As it's not a common case, the setDependentDropdownValuesJs.ftl template-script can be used in most cases...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@986370 13f79535-47bb-0310-9956-ffa450edef68
When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work.
Where are several Issues in the MyPortal, some have fixes, none is commited to trunk.
Problems:
* in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly
* in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included
JLR:
While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different but by chance in myportal very close to common so I was finally able to do both at along with Karl's changes. Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit.
MyPortal
* The login process in MyPortal was not tenant enabled, it's done in this commit.
* I kept its specificity : newRegisterLogin and wonder why it has not been extended to common?
hhfacility
The login process in hhfacility was not tenant enabled, it's done in this commit. Doing so, I saw there i18n is not done, not an issue for me...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@985163 13f79535-47bb-0310-9956-ffa450edef68
Reported by Sam Hamilton:
If you are on say this page - https://localhost:8443/catalog/control/EditProduct?productId=WG-9943
clicking on Expand All it will expand all the ones not expanded and then collapse the ones that were already open
clicking on Collapse All it will collapse all the ones open and open all the ones that were collapsed.
fixed issue
* css.style.visible cannot be true/false as used so in collapseAll()
* now using the $() container and calling visible() which returns true/false
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981051 13f79535-47bb-0310-9956-ffa450edef68
I have not put pl.js and fi.js because they exist in the calendarDateSelect project.
I'd like to contribute those news to the calendarDateSelect project, but it's not a priority for me
I have asked how to contribute to the calendarDateSelect project
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@960376 13f79535-47bb-0310-9956-ffa450edef68
It's related to r886723: I forgot to create an en.js file (used as default).
I have also enhanced the other files but without total guarantee of correctness, at least it's better and improvable
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@960336 13f79535-47bb-0310-9956-ffa450edef68
The line bypassed was specifically added for "Lookup Layer Search of a Variant Product" (https://issues.apache.org/jira/browse/OFBIZ-3746) - OFBIZ-3746
But it did not was generalized enough, this should handle all the other cases where a link is in a cell of the result list that is not the 1st one cell
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@952249 13f79535-47bb-0310-9956-ffa450edef68
It was harder than I though because of the async nature of Ajax. So I had to use a setTimeout with a 400 ms timeout. Hopefully it will work in any environments. I chose 400 because I found it worked well on my machine, 300 also but to be sure I picked 400, 200 was too low it seems.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@950481 13f79535-47bb-0310-9956-ffa450edef68
On IE8 the description was not being displayed at all.
With Firefox it was working fine. After doing some research I ended up with this patch. Seem like 'textContent' doesn't work in IE.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@949844 13f79535-47bb-0310-9956-ffa450edef68
Atul's note: I noticed some strange behavior (like there's little shifting of elements).
Jacques's note: I noticed them too (it's in the calling form or layer) but it's far better than before and IMO acceptable
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@949174 13f79535-47bb-0310-9956-ffa450edef68
When using description-field-name in a layered lookup called from another layered lookup (recursively or not) the description-field-name parameter (target2) in the call from the 2d lookup button was not modified, therefore the link was not working.
Miscellaneous:
* Format and fix some typos in fieldlookup.js
* Removes now useless commented out functions set_value and set_values in lookup.ftl
* Improves comments in FormWidgetExampleForms.xml
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@947392 13f79535-47bb-0310-9956-ffa450edef68
Fixes: when user session is destroyed: Log into an application (accounting for example) and select a form - layered lookups work correct. In another tab log into another application and then log out. Then on the first tab (accounting) try to use a lookup. In the lookup screen you will get the login screen (that's OK) but once you enter your username and password you get a blank screen.
Another issue related to external key is still existing
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@946596 13f79535-47bb-0310-9956-ffa450edef68
The previous related fix (r942084) was working locally but not on the demo server. We have not ideas why yet but this patch is a try to fix this issue...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@943909 13f79535-47bb-0310-9956-ffa450edef68
This fixes the last issue with the FTL layered lookups but is actually more general as it uses a 1999 origin when the HtmlScreenRendere class uses 999.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@942084 13f79535-47bb-0310-9956-ffa450edef68
This fixes the calendar issue in bluelight and remove the (X) button that broke the calendar layout (strangely was only from layered lookups)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940425 13f79535-47bb-0310-9956-ffa450edef68
Fix the variant issue in product lookups
Remove the temporary window presentation workaround (done at r939232)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940410 13f79535-47bb-0310-9956-ffa450edef68
Uncomment the line to return the name in the calling screen
I have also added groupName in the name returned (when looking for partyGroup)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@940401 13f79535-47bb-0310-9956-ffa450edef68
This patch attempts to fix the problem,calendar is now relatively positioned, and the parent element's height is set appropriately.
I just added some "mod for OFBiz layered lookups" comments around changes as suggested Sascha
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@933169 13f79535-47bb-0310-9956-ffa450edef68
OFBIZ-3637 - XHTML validation errors (framework excluding widget) round 2
https://issues.apache.org/jira/browse/OFBIZ-3637
XHTML validation errors
* Unclosed tags INPUT, IMG, BR...
* attributes without values (checked, selected, disabled, etc)
* attribute values without "
* required attributes not included (alt in img, type in style, type in script etc)
* Uppercase tags or attributes.
* Unencoded entities (ampersands).
Other changes:
selectall.js
line 333. ajaxAutoCompleter must work with unenconded or encoded ampersands.
EntityRefMain.ftl
line 176. <div> must be </div>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@932733 13f79535-47bb-0310-9956-ffa450edef68