Commit Graph
9349 Commits
Author SHA1 Message Date
Arun Patidar ff3653ed11 Applied fix from trunk for revision: 1825216
===

Improved:Update regex used for validating credit cards.
(OFBIZ-9761)
Thanks Amit Gadaley for your contribution and Michael Brohl for reviewing patch.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1825217 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 11:33:31 +00:00
Deepak Dixit dbcb375a61 Fixed: Alert message : Developer: for lookups to work you must provide a form name! appears when try to select contentId from Lookup.
(OFBIZ-10012)
Applied slightly modified patch
Thanks  Sonal for reporting and Aditya Sharma for providing patch for the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1825210 13f79535-47bb-0310-9956-ffa450edef68
2018-02-24 10:48:51 +00:00
Jacques Le Roux 007d5a08d9 "Applied fix from trunk for revision: 1824855"
------------------------------------------------------------------------
r1824855 | jleroux | 2018-02-20 12:59:07 +0100 (mar., 20 févr. 2018) | 7 lines

Reverted: Secure the login.secret_key_string
(OFBIZ-9966)

I forgot to revert this part; I guess got conflict issues and then forgot.

I'll also revert in R16 and R17 and close as won't fix, I gave my arguments
that's enough for me.
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824856 13f79535-47bb-0310-9956-ffa450edef68
2018-02-20 12:00:03 +00:00
Jacques Le Roux d0735d2181 "Applied fix from trunk for revision: 1824803 "
------------------------------------------------------------------------
r1824803 | jleroux | 2018-02-19 20:23:36 +0100 (lun., 19 févr. 2018) | 18 lines

Fixed: Logout do not remove autoLogin
(OFBIZ-4959)

Logout method do not disable autoLogin functionality. 
Instead of that it just initializes autoLogin in session and request.

jleroux: this was also needed by OFBIZ-10206 "Security issue in Token Based 
Authentication". 
This creates a keep-autologin-cookie boolean attribute in the webapp element of 
the  ofbiz-component.xml, documented in ofbiz-component.xsd
This attribute is used to get the value from the ofbiz-component.xml files in a
new autoLogoutCleanCookies() LoginWorker method. This method is used not only 
when login out but also when login in. This to be sure that in every cases the 
cookies related to the webapps are removed.
For now only the ecommerce, ecomseo et webpos webapps are keeping and using 
their autologin cookies

Thanks: Roberto Benítez Monje for report and Taher for discussion and suggestion
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824804 13f79535-47bb-0310-9956-ffa450edef68
2018-02-19 19:24:14 +00:00
Jacques Le Roux 07c205da74 "Applied fix from trunk for revision: 1824316 "
------------------------------------------------------------------------
r1824316 | jleroux | 2018-02-15 15:38:51 +0100 (jeu., 15 févr. 2018) | 7 lines

Improved: Use Tomcat default ciphers
(OFBIZ-10223)

Tomcat provides a default ciphers definition better to use it and let Tomcat 
handles that for us, we know Tomcat security is strong

Thanks: Paul Foxworthy for the help understanding the syntax :)
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824317 13f79535-47bb-0310-9956-ffa450edef68
2018-02-15 14:39:49 +00:00
Jacques Le Roux 54ae17d54f "Applied fix from trunk for revision: 1824260 "
------------------------------------------------------------------------
r1824260 | jleroux | 2018-02-14 17:40:19 +0100 (mer., 14 févr. 2018) | 1 line

Improved: Token Based Authentication
(OFBIZ-9833)

No functional change, removes TODOs that I recently 
(1 week ago in r1823324) put to myself to quickly check. 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1824261 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 16:40:45 +00:00
Jacques Le Roux 45f5c24ed0 "Applied fix from trunk for revision: 1823876"
------------------------------------------------------------------------
r1823876 | jleroux | 2018-02-11 19:51:07 +0100 (dim., 11 févr. 2018) | 9 lines

Fixed: UtilNumber.getBigDecimalRoundingMode() returns a wrong value
(OFBIZ-10218)

While working on OFBIZ-9571 I found that getBigDecimalRoundingMode() returns  
DEFAULT_BD_SCALE when the passed value for the file parameter is emtpy. 
This has certainly be C/P from getBigDecimalScale() and never found before.

While at it I refactored a bit getBigDecimalRoundingMode()  and 
getBigDecimalScale() 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823877 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 18:51:37 +00:00
Jacques Le Roux bfff6c8922 "Applied fix from trunk for revision: 1823562"
------------------------------------------------------------------------
r1823562 | jleroux | 2018-02-08 16:01:54 +0100 (jeu., 08 févr. 2018) | 1 line

Completed: Security issue in Token Based Authentication
(OFBIZ-10206)

No functional change, just better syntax
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823563 13f79535-47bb-0310-9956-ffa450edef68
2018-02-08 15:04:24 +00:00
Jacques Le Roux baee9bb1ca "Applied fix from trunk for revision: 1823467"
------------------------------------------------------------------------
r1823467 | jleroux | 2018-02-07 15:17:51 +0100 (mer., 07 févr. 2018) | 7 lines

Completed:: Security issue in Token Based Authentication
(OFBIZ-10206)

Updates the security.properties content related to JWT
 Refers to the last up to date external-server-test-example.patch at OFBIZ-10206
 Makes demo-trunk.ofbiz.apache.org default external-server-name so that anybody
 can try the feature from own machine. The use-external-server=Y was already set
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823469 13f79535-47bb-0310-9956-ffa450edef68
2018-02-07 14:20:49 +00:00
Jacques Le Roux 10ba1cb803 "Applied fix from trunk for revision: 1823324 "
------------------------------------------------------------------------
r1823324 | jleroux | 2018-02-06 14:17:57 +0100 (mar., 06 févr. 2018) | 26 lines

Fixed: Security issue in Token Based Authentication
(OFBIZ-10206)

The version I committed so far in OFBIZ-9833 has a small security issue.
See the Jira description for all details

To test I have attached a OFBIZ-10206-external-server-test-example.patch to 
the Jira

This removes the external-server-query property now useless

In  ContextFilter the getHeader (wrapper) now uses an autoLoginCookie to get 
the userLoginId passed in the JWT instead of externalServerUserLogin parameter.
A sourceServerWebappName parameter must be passed from the client request to
allow reading the autoLoginCookie.

This userLoginId is then retrieved on the target server from the JWT in the 
externalServerLoginCheck which is simplified.

In LoginWorker
  getAutoLoginCookieName() has now 2 versions to allow to pass a webappname

  A new autoLogoutFromAllBackendSessions() method has been added but for now 
  commented out. Decommenting it out will be submitted as a patch in OFBIZ-4959.

Thanks: Leila Mekika for reporting the security issue directly to me
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823325 13f79535-47bb-0310-9956-ffa450edef68
2018-02-06 13:21:34 +00:00
Jacques Le Roux 9968581f08 "Applied fix from trunk for revision: 1822882"
------------------------------------------------------------------------
r1822882 | jleroux | 2018-02-01 16:27:17 +0100 (jeu., 01 févr. 2018) | 7 lines

Improved: Token Based Authentication
(OFBIZ-9833)

I just thought that for security it's best to have both the source and 
target server using the use-external-server property.

Also default to N when requesting this property
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823316 13f79535-47bb-0310-9956-ffa450edef68
2018-02-06 12:18:15 +00:00
Jacques Le Roux 369dd2b1e5 "Applied fix from trunk for revision: 1821600"
------------------------------------------------------------------------
r1821600 | jleroux | 2018-01-19 09:39:05 +0100 (ven., 19 janv. 2018) | 11 lines

Improved: Token Based Authentication
(OFBIZ-9833)

No functional change

As reported by Jinghai on dev ML we should better use "Authorization" than
 "Authorisation" when retrieving the JWT token, even if both are accepted
https://en.wikipedia.org/wiki/List_of_HTTP_header_fields
Also improves the comment on token ttl

Thanks: Jinghai for report
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1823311 13f79535-47bb-0310-9956-ffa450edef68
2018-02-06 12:12:55 +00:00
Jacques Le Roux c6918b670e "Applied fix from trunk for revision: 1822383"
------------------------------------------------------------------------
r1822383 | jleroux | 2018-01-27 11:27:31 +0100 (sam., 27 janv. 2018) | 7 lines

Fixed: EntitySaxReader mostly-insert (store after create-error) Fix
(OFBIZ-1032)

This changes the label for more clarity. Actually there is not only inserts but
no replacements. Because you can also create and delete. This has been defined
after this label was created with OFBIZ-4949. So we have EntitySaxReader Action
enum and it's used in this this context.
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1822384 13f79535-47bb-0310-9956-ffa450edef68
2018-01-27 10:27:58 +00:00
Jacques Le Roux d8e24334e9 "Applied fix from trunk for revision: 1822310 "
------------------------------------------------------------------------
r1822310 | jleroux | 2018-01-26 16:13:42 +0100 (ven., 26 janv. 2018) | 29 lines

Fixed: EntitySaxReader mostly-insert (store after create-error) Fix
(OFBIZ-1032)

Karl:
Avoids rollback on create error to be able to store the entity instead 
(previous mostly-inserts feature).

Matin:
I think, the data load with "mostly inserts" activated should fail on a 
create-failure (what it does indeed already), so I see no need for a working 
solution of a fallback store attempt. Consistently the Feature should be renamed 
in the frontend from "mostly inserts" to "only inserts".

Kyra:
Additional trivial refactoring in the patch: I reduced the full qualified 
classname of org.xml.sax.SAXException in method signatures to the simple name.

This incorperates the changes that Martin has mentioned above. 
The unnecessary call to store() is removed, simplifying the process of creating 
and deleting entities. (These changes were already in Martins old patch but had 
the wrong format.) This means that the flag "mostly Inserts?" is not accurately 
worded since as long as there is only create fail, all operations are rolled 
back. So the second patch renames the flag and all appropriate parameters to 
"onlyInserts". 

jleroux: I made few no functional changes, apart not swallowing an exception

Thanks: Thanks Karl for the 1st patch, Martin to get further, and Kyra to 
complete the whole with a final touch and help to quickly test
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1822311 13f79535-47bb-0310-9956-ffa450edef68
2018-01-26 15:14:54 +00:00
Deepak Dixit 14b5abd4bd Applied fix from trunk for revision: 1822125
===

Improved:Removed unused import.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1822128 13f79535-47bb-0310-9956-ffa450edef68
2018-01-24 17:29:55 +00:00
Deepak Dixit 897ff1f508 Applied fix from trunk for revision: 1821628
===

Fixed: GeoAssoc data is missing for Telangana state of India (OFBIZ-10172)
Thanks Suraj Khurana for your contribution


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821634 13f79535-47bb-0310-9956-ffa450edef68
2018-01-19 12:24:34 +00:00
Jacques Le Roux fead503827 "Applied fix from trunk for revision: 1821386"
------------------------------------------------------------------------
r1821386 | jleroux | 2018-01-17 16:28:51 +0100 (mer., 17 janv. 2018) | 9 lines

Improved: Make xssi prefix configurable
(OFBIZ-9169)

In OFBIZ-5409 a prefix was added for GET ajax requests.
It would be beneficial if the prefix could be configured instead of hard coded

jleroux: at r1777942 I missed the general.properties change

Thanks: Michael Brohl for reporting the issue
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821387 13f79535-47bb-0310-9956-ffa450edef68
2018-01-17 15:30:07 +00:00
Jacques Le Roux 7fb2e126f5 "Applied fix from trunk for revision: 1821230"
------------------------------------------------------------------------
r1821230 | jleroux | 2018-01-16 12:02:17 +0100 (mar., 16 janv. 2018) | 9 lines

Fixed: Fix the HttpServletRequestWrapper in ContextFilter.doFilter()
(OFBIZ-10167)

As reported by Deepak on dev ML the returned name should be a parameter and not 
enforced to "Authorisation"

This removes a wrong comment (no functional change)

Thanks: Deepak for bug report
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821231 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 11:03:42 +00:00
Jacques Le Roux 57ec71a008 "Applied fix from trunk for revision: 1821226"
------------------------------------------------------------------------
r1821226 | jleroux | 2018-01-16 11:25:41 +0100 (mar., 16 janv. 2018) | 1 line

Fixed: Fix the HttpServletRequestWrapper in ContextFilter.doFilter()
(OFBIZ-10167)

As reported by Deepak on dev ML the returned name should be a parameter and not 
enforced to "Authorisation"

Thanks: Deepak for bug report
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821229 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 10:56:09 +00:00
Jacques Le Roux eab9d75122 "Applied fix from trunk for revision: 1821219 "
------------------------------------------------------------------------
r1821219 | jleroux | 2018-01-16 08:58:49 +0100 (mar., 16 janv. 2018) | 8 lines

Improved: Update Geo information according to ISO notifications, Mali
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836 and INFRA-15842,
so will be backported

Thanks: Kyra Pritzel-Hentley 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821220 13f79535-47bb-0310-9956-ffa450edef68
2018-01-16 07:59:33 +00:00
Jacques Le Roux dd4272ed15 "Applied fix from trunk for revision: 1821186 "
------------------------------------------------------------------------
r1821186 | jleroux | 2018-01-15 18:47:05 +0100 (lun., 15 janv. 2018) | 9 lines

Improved: Update Geo information according to ISO notifications, Moldova 
(the Republic of)/
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821187 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 17:47:56 +00:00
Jacques Le Roux 0e1f1ccae8 "Applied fix from trunk for revision: 1821144"
------------------------------------------------------------------------
r1821144 | jleroux | 2018-01-15 11:45:33 +0100 (lun., 15 janv. 2018) | 9 lines

Improved: Update Geo information according to ISO notifications, Lao People's 
Democratic Republic (the)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821149 13f79535-47bb-0310-9956-ffa450edef68
2018-01-15 12:30:14 +00:00
Jacques Le Roux b23b164e56 "Applied fix from trunk for revision: 1821112"
------------------------------------------------------------------------
r1821112 | jleroux | 2018-01-14 19:23:57 +0100 (dim., 14 janv. 2018) | 9 lines

Improved: Update Geo information according to ISO notifications, Korea 
(the Democratic People's Republic of)
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15836, so will be backported

Thanks: Kyra Pritzel-Hentley 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821113 13f79535-47bb-0310-9956-ffa450edef68
2018-01-14 18:24:16 +00:00
Jacques Le Roux ce7094e6e6 "Applied fix from trunk for revision: 1821036 "
------------------------------------------------------------------------
r1821036 | jleroux | 2018-01-12 22:59:22 +0100 (ven., 12 janv. 2018) | 11 lines

Fixed: streaming large content cause out of memory exception.
(OFBIZ-10133)

When ofbiz streams a large content (eg. video file), get out of memory exception.

To reproduce the issue see the Jira

jleroux: I just removed final for bufferSize, I see no needs for that local
variable

Thanks: Wai for the patch Michael for the discussion
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1821037 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 22:00:22 +00:00
Jacques Le Roux 8fc89f41de Revert r1820867 from ofbiz/ofbiz-framework/branches/release17.12:
"Applied fix from trunk for revision: 1820862" 
------------------------------------------------------------------------
r1820862 | jleroux | 2018-01-11 12:05:26 +0100 (jeu., 11 janv. 2018) | 11 lines

Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png is now in theme. This is only the framework part. 
I have also made change in theme but I need to review again and perhaps create 
a patch for others to review...
Note: testUpdatePartyGroup is OK

Then I'll also rename the logo in site to use the same name before maybe
referring to svn trunk repo to use only 1 file everywhere, same for the .ico
file
------------------------------------------------------------------------

This was totally wrong and useless :/ the url is at images not themes, sorry

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820993 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 14:12:56 +00:00
Jacques Le Roux 615001dda6 "Applied fix from trunk for revision: 1820966 "
------------------------------------------------------------------------
r1820966 | jleroux | 2018-01-12 12:24:48 +0100 (ven., 12 janv. 2018) | 9 lines

Fixed: Correcting findOne() in OfbizDslDescriptorForEclipse.dsld
(OFBIZ-10159)

The method findOne() which is set in the OfbizDslDescriptorForEclipse.dsld is 
wrong, since there is no implementation for this method, which only has a String 
and a List as parameters. I changed it to the correct method, so it can be used 
within groovy properly, also I put an implementation in the GroovyBaseScriptFile

Thanks: Dennis Balkir
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820967 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 11:27:34 +00:00
Jacques Le Roux 99ef3c852d "Applied fix from trunk for revision: 1820862"
------------------------------------------------------------------------
r1820862 | jleroux | 2018-01-11 12:05:26 +0100 (jeu., 11 janv. 2018) | 11 lines

Improved: Clean images, among them logos, in all locations used
(OFBIZ-10128)

The ofbiz_logo.png is now in theme. This is only the framework part. 
I have also made change in theme but I need to review again and perhaps create 
a patch for others to review...
Note: testUpdatePartyGroup is OK

Then I'll also rename the logo in site to use the same name before maybe
referring to svn trunk repo to use only 1 file everywhere, same for the .ico
file
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820867 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 12:13:22 +00:00
Deepak Dixit 7736e3c49e Applied fix from trunk for revision: 1820823
===

Fixed: Shipping Label printing not working (OFBIZ-10153)
Added viewShipmentLabel in http-request map so that pdf will be able to print the shipping lable.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820824 13f79535-47bb-0310-9956-ffa450edef68
2018-01-11 05:51:10 +00:00
Jacques Le Roux cabf3d9001 "Applied fix from trunk for revision: 1820644"
------------------------------------------------------------------------
r1820644 | jleroux | 2018-01-09 12:30:39 +0100 (mar., 09 janv. 2018) | 8 lines

Improved: Update Geo information according to ISO notifications
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

Here are China, Germany, Hungary and Indonesia

This is mostly to check WIP at INFRA-15394, INFRA-15785 and OFBIZ-10147

Thanks: Kyra Pritzel-Hentley
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820726 13f79535-47bb-0310-9956-ffa450edef68
2018-01-10 08:44:29 +00:00
Jacques Le Roux ee632a6795 "Applied fix from trunk for revision: 1820441 "
------------------------------------------------------------------------
r1820441 | jleroux | 2018-01-07 11:51:39 +0100 (dim., 07 janv. 2018) | 8 lines

Improved: Update Geo information according to ISO notifications, Ecuador
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15394, INFRA-15785 and OFBIZ-10147

Thanks: Kyra Pritzel-Hentley 
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820443 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 10:52:51 +00:00
Jacques Le Roux 5d1a48fc10 "Applied fix from trunk for revision: 1820375 "
------------------------------------------------------------------------
r1820375 | jleroux | 2018-01-06 08:13:44 +0100 (sam., 06 janv. 2018) | 8 lines

Improved: Update Geo information according to ISO notifications, Iceland
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

This is mostly to check WIP at INFRA-15394, INFRA-15785 and OFBIZ-10147

Thanks: Kyra Pritzel-Hentley

Note: I backport this simple and harmless commit in order to test the new
ofbizBranch17Framework builder AGAIN!!!
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820402 13f79535-47bb-0310-9956-ffa450edef68
2018-01-06 14:01:12 +00:00
Jacques Le Roux 7435767b1f "Applied fix from trunk for revision: 1820374 "
------------------------------------------------------------------------
r1820374 | jleroux | 2018-01-06 07:01:15 +0100 (sam., 06 janv. 2018) | 6 lines

Improved: Update Geo information according to ISO notifications, Cyprus
(OFBIZ-10028)

This follows this discussion http://markmail.org/message/xn7f552qvtpua2uq

Thanks: Kyra Pritzel-Hentley

Note: I backport this simple and harmless commit in order to test the new
ofbizBranch17Framework builder
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1820386 13f79535-47bb-0310-9956-ffa450edef68
2018-01-06 12:07:08 +00:00
Jacques Le Roux f85c2d66c9 "Applied fix from trunk for revision: 1819811"
------------------------------------------------------------------------
r1819811 | jleroux | 2018-01-02 13:22:17 +0100 (mar., 02 janv. 2018) | 6 lines

Fixed: Add WebSocket support in OFBiz
(OFBIZ-7073)

This was my bad at OFBIZ-7776

Thanks: Deepak for help on dev ML (good remembering)
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1819812 13f79535-47bb-0310-9956-ffa450edef68
2018-01-02 12:23:23 +00:00
Nicolas Malin e0ea10eabc Improved: In CSV export file from data-file add a new attribute to select the EOL type (OFBIZ-9536)
During the file CSV generation by data-file engine, it is not possible to choose the end of line char. It is always "CR". 
With this improvement it's now possible to define a eol-type attribute on data-file element with value CR or CRLF to use in the csv file result.
Example:
    <data-file name="MyCsvTest" separator-style="delimited" type-code="text" delimiter=";" eol-type="CRLF">
        <record name="Test">...
     </data-file>
Thanks Pierre Gaudin for this proposal.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819151 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 14:14:45 +00:00
Nicolas Malin 28ff342414 Improved: Import file with data-file, add start-line to escape the header column line (OFBIZ-10108)
When you load a CSV file some time with a data-file definition, if it contains some header column you can use the format attribute of you column.
Example:
ref;date
100;2017-10-10
200;2017-12-11

This definition failed :
    <data-file name="MyCsvTest" separator-style="delimited" type-code="text" delimiter=";">
        <record name="Test">
            <field name="ref" type="String" position="1"/>
            <field name="date" type="CustomTimestamp" format="yyyyy-MM-dd" position="2"/>
        </record>
     </data-file>

You need to read the date as string and after convert it on your code to escape the first line.
To solve it I added a new attribute start-line on data-file element :
    <data-file name="MyCsvTest" separator-style="delimited" type-code="text" *start-line="1"* delimiter=";">
        <record name="Test">
            <field name="ref" type="String" position="1"/>
            <field name="date" type="CustomTimestamp" format="yyyyy-MM-dd" position="2"/>
        </record>
     </data-file>

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819147 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 13:42:15 +00:00
James Yong ba2e822f27 Implemented: Tomcat SSO
(OFBIZ-10047)

This allow developers the option to use Tomcat SSO, instead of externalLoginKey, for SSO.

Thanks: Jacques and Michael for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819133 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 10:39:44 +00:00
Deepak Dixit 1c0e3a8dbe Reverted: Revision #1819126 causing test failure, reverted for now (OFBIZ-9969)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819132 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 10:27:27 +00:00
Deepak Dixit 0aabb0b015 Fixed: Added missing import in ValidateMethod.java (OFBIZ-9969)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819129 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:45:08 +00:00
Deepak Dixit 78a1b15a25 Improved: In 'ValidateMethod.java', when we don't pass any className from xml files. default value 'org.apache.ofbiz.base.util.UtilValidate' should be set for className. (OFBIZ-9969)
Thanks Sonal Patwari and Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819126 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:29:58 +00:00
Deepak Dixit fb77a3c477 Improved: Logging: change all System.out/.err/.. println to Debug.log... in the code base (OFBIZ-10045)
Thanks Michael Brohl and Kyra Pritzel-Hentley for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819124 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:08:04 +00:00
Michael Brohl 50c4bba4b2 Improved: Replace all "e.printStackTrace();" by calls to the Debug class.
(OFBIZ-10083)

Thanks Jacques Le Roux for reporting and Kyra Pritzel-Hentley 
for providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818921 13f79535-47bb-0310-9956-ffa450edef68
2017-12-21 12:33:04 +00:00
Michael Brohl 8b44971c41 Improved: Incomplete RoleMember Permission Checks for ROLE_MEMBER in
ModelPermission#evalRoleMember.
(OFBIZ-9636)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818708 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 19:39:14 +00:00
Michael Brohl 98ee1e4f01 Improved: Fixing defects reported by code analysis tools, package
org.apache.ofbiz.base.util.string.
(OFBIZ-10097)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818677 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 15:19:10 +00:00
Jacques Le Roux 35ee954560 Completed: Remove applet concept in OFBiz
(OFBIZ-10094)

Following discussion at http://markmail.org/message/dlp4zoo3xxuiefpn :

While reviewing http://svn.apache.org/viewvc?view=revision&revision=1811438 
I stumbled upon the usage of Java Applets

It's still possible to use Java Applets in browsers but most of the time it's 
not OOTB https://www.digitalcitizen.life/how-enable-java-all-major-web-browsers

And Java 9 deprecates it https://www.java.com/en/download/faq/jdk9_plugin.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818646 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 10:33:15 +00:00
Deepak Dixit 3812c6290a Reverted: Local changes committed at r#1818600
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818639 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 06:29:13 +00:00
Deepak Dixit 0a652486ff Fixed: Fixed typo done at r#1818003
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818606 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 18:38:54 +00:00
Deepak Dixit d24c956bf9 Improved: Moved plugins js from images to common/js (OFBIZ-5776)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818600 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 18:16:09 +00:00
Jacques Le Roux 8cb1011755 No functional change, reverts changes that inadvertently slipped in with
r1818580

Thanks Michael for make me noticing it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818595 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 17:39:29 +00:00
Michael Brohl 269c29c65e Improved: Fixing defects reported by code analysis tools, package
org.apache.ofbiz.service.jms.
(OFBIZ-10061)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818582 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 14:59:53 +00:00
Jacques Le Roux 1b9094d4b2 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Updates JGrowl  from 1.4.1 to 1.4.6

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818580 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 14:48:04 +00:00