Commit Graph
28 Commits
Author SHA1 Message Date
Jacques Le Roux daa2c243a9 "Applied fix from trunk for revision: 1859877"
------------------------------------------------------------------------
r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)

This was reopened after discussion at 
https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187
Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859878 13f79535-47bb-0310-9956-ffa450edef68
2019-05-24 13:51:26 +00:00
Rishi Solanki 7d29cd1888 Implemented: Add ability to record Return Communication. Added support to record communication event against return. Added new entity CommunicationEventReturn, crund and supporting screens. Also added support in the existing email services to handle the return cases.
(OFBIZ-9911)
Thanks to Ratnesh Upadhyay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821486 13f79535-47bb-0310-9956-ffa450edef68
2018-01-18 11:34:01 +00:00
Michael Brohl 2c2078768d Fixed: EmailServices.sendMailFromScreen improved to take multiple
attachments with appropriate type along with several email fixes.
(OFBIZ-9395).

This adds the missing service attributes for attachmentType and
attachmentTypeList which did not come with the initial patch. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1810260 13f79535-47bb-0310-9956-ffa450edef68
2017-10-01 10:39:18 +00:00
Arun Patidar b219815591 Implemented: Added CRUD services for Delivery, EmailTemplateSetting and EbayProductListingAttribute entity.
(OFBIZ-8050) (OFBIZ-8057)(OFBIZ-8058)

Thanks: Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761169 13f79535-47bb-0310-9956-ffa450edef68
2016-09-17 09:48:00 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Jacques Le Roux ec66e361e1 A big but straightforward commit for "Move minilang scripts from component://componentname/script/org/ofbiz to component://componentname/minilang" - https://issues.apache.org/jira/browse/OFBIZ-7267
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)

I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix 

I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to 
  "The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath. 


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747712 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 14:04:30 +00:00
Jacques Le Roux 7adfe90d71 Fixes <<Services allow arbitrary HTML for parameters with allow-html set to "safe">> https://issues.apache.org/jira/browse/OFBIZ-5254
After r751990, <<allow-html="any">> and <<allow-html="safe">> are the same: they do nothing! The only difference is the warning message from the OWASP Antisamy IntrusionDetector, which is both, as Christoph noted "giving you a false sense of security" or as I wrote "disturbing, wrong and useless". So there are no longer any reasons for differencing "safe" and "any".

This
* Deprecates "safe" (making it clear in the XSD documentation), keeping only "none" and "any". This is for backward compatibility, else we could completely remove the misleading "safe". Note that "none" is the default.
* Replaces in services definition all allow-html="safe" by allow-html="any"
* Remove from ModelService.java (near line 587) the code which throws the OWASP Antisamy IntrusionDetector message in log

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1536324 13f79535-47bb-0310-9956-ffa450edef68
2013-10-28 12:12:43 +00:00
Adrian Crum 5b675f5a79 Some code simplification in the new URL generation classes.
Also loosened things up a bit in the OfbizUrlBuilder class: allow object construction with partial information - required by some services. I don't like this approach because it makes it possible to create nonsensical URLs, but it is a necessary evil to keep the existing code working.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1535444 13f79535-47bb-0310-9956-ffa450edef68
2013-10-24 17:12:46 +00:00
Jacques Le Roux 8e6e049ad5 A patch from Varun Bhansaly "Email configuration - mail.smtp.starttls.enable ignored" https://issues.apache.org/jira/browse/OFBIZ-4943
The email configuration setting mail.smtp.starttls.enable is ignored by the system.
I encountered this while configuring OFBiz an email server which had TLS enabled.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1395104 13f79535-47bb-0310-9956-ffa450edef68
2012-10-06 16:18:09 +00:00
Jacques Le Roux 5e5f0e27a5 This introduces a mean to hide a service result in log (when the service is longer than 50 ms and Debug.timingOn() or > 200 ms and Debug.infoOn(), see ServiceDispatcher.java, just above line 600)
A hideResultInLog service attribute is added. If set to true the service result will be hidden from possible exposition in ServiceDispatcher.runSync() 
This is convenient when used for sending a password to an user (the password must be legible in the sent mail). 
I'm sure a lot of you would want to have no logs at all in production. But by experience I know that we need to log info in logs even in production. Especially when the system is quickly moving ahead...
So this is a sure mean to hide any password in logs, being current or backuped somewhere on the servers disks...


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1328122 13f79535-47bb-0310-9956-ffa450edef68
2012-04-19 21:41:39 +00:00
Andrew Zeneski 1a48bad49c socketFactory and port parameters were missing from the service definition even though they were being checked in the implementations; this addresses this oversight so that all settings can override general.properties when necessary by sending them directly to the service.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1028747 13f79535-47bb-0310-9956-ffa450edef68
2010-10-29 13:57:18 +00:00
David E. Jones 9b940f0056 Changed sendMailFromScreen service to support a list of attachments instead of just one
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1000753 13f79535-47bb-0310-9956-ffa450edef68
2010-09-24 07:47:05 +00:00
Hans Bakker b58eececc7 when emails are sent out related to a custrequest, create also the link between email and custrequest (same pattern as for order)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@955133 13f79535-47bb-0310-9956-ffa450edef68
2010-06-16 05:48:00 +00:00
Ashish Vijaywargiya 8f83bfeda0 The screen was broken for CommunicationEventOrder.
The order was not associating with communication event when the new communication event was generating in system for different mail notifications(like OrderConfirmation, OrderComplete, ShipmentComplete etc.)
Now after this commit it will work without any issues.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@927758 13f79535-47bb-0310-9956-ffa450edef68
2010-03-26 10:25:08 +00:00
Scott Gray f1d8327678 Emails will now be sent to any valid recipients even if the SMTP server rejected any invalid ones. This can be turned off if desired in general.properties and also on a per service call basis.
A failure notification will be sent to the email's "from" address, listing the failed recipients and the reason for each failure. The notification can be turned off by setting the sendFailureNotification parameter to false in the s

These changes fix a problem where emails are not sent to valid recipients and users receive no feedback when emails fail to be sent, generally because of the smtp server rejecting one or more recipients.

OFBIZ-3379, thanks to Pranay Pandey for the report and testing, also thanks to Tim Ruppert and Ruth Hoffman for their input into the issue.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@896213 13f79535-47bb-0310-9956-ffa450edef68
2010-01-05 20:48:15 +00:00
Hans Bakker 66d08c768e only allow 'safe' in in/outgoing email
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@789506 13f79535-47bb-0310-9956-ffa450edef68
2009-06-30 00:32:24 +00:00
Hans Bakker f97b2fe488 create commevent from email did not render the subject causing display giving an error, removed a not required seca
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@788589 13f79535-47bb-0310-9956-ffa450edef68
2009-06-26 05:48:26 +00:00
Hans Bakker ac71e4df92 another html allow
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@779020 13f79535-47bb-0310-9956-ffa450edef68
2009-05-27 06:18:23 +00:00
Hans Bakker 24de57b47d if mail is disabled in message.properties, message wrapper is not in result: made oprional in definition
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774653 13f79535-47bb-0310-9956-ffa450edef68
2009-05-14 06:31:40 +00:00
Andrew Zeneski d294d588cf minor changes to make sure the sendMail service is called through the service engine instead of as a method call; sendMail now returns a MimeMessageWrapper object with all the mail information to be used by communication event processing
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774196 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 04:58:24 +00:00
Hans Bakker 4c0c034121 some more faultfixing on customer request notifications: mainly the partyIdTo was not provided
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769274 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 07:49:12 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Hans Bakker c1491066f0 moved custrequest notification from myportal to order,moved other programs around, reorganized customer request status handling, replaced cust request roles from ftl to form, removed other used programs from myportal. Now only the party registration is left in myportal.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763135 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 07:58:00 +00:00
David E. Jones 4a1705a315 Removed some more references to applications stuff from framework, including small cleanup of service engine to get rid of WebAppDispatcher and use new factory method in GenericDispatcher, and changed AvailableServices.groovy to get the real dispatcher list instead of a hard-coded one; also updated eclipse classpath file for new webslinger stuff
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757671 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 06:27:03 +00:00
Jacques Le Roux 4f2463ec57 bi and common components
Following best practice.
Changed location="org/ofbiz/......... to location="component:// in the service location attribute.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755943 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 11:50:32 +00:00
Jacques Le Roux e03ab0e044 Trivials changes while working on https://issues.apache.org/jira/browse/OFBIZ-2000 and dependencies
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@745613 13f79535-47bb-0310-9956-ffa450edef68
2009-02-18 19:09:51 +00:00
David E. Jones e71fe34443 Added quick first pass for the sendMailFromTemplateSetting service that uses the new EmailTemplateSetting entity; note that this is still beta as I haven't tested it much, but it shows that concept and can be a basis for further work, possibly including refactor of ProductStoreEmailSetting to use this entity and service but that isn't necessary for other things to use it, etc
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744736 13f79535-47bb-0310-9956-ffa450edef68
2009-02-15 19:57:43 +00:00
David E. Jones f27b4eeaaa No functional changes, just reorganizing code: moved email services from content to the framework/common component except the CommunicationEvent related ones which are now in the party component along with other CommunicationEvent resources; changed framework components so that webapp no longer depends on common and common is higher level than the various tool components which was an odd dependency before; one new thing is in here and that is an entity called EmailTemplateSetting which is meant to be a generic version of the ProductStoreEmailSetting entity so we can have configurable email templates without depending on ProductStore, still need to write the service to send email from this (sendMailFromTemplateSetting)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744727 13f79535-47bb-0310-9956-ffa450edef68
2009-02-15 19:34:49 +00:00