------------------------------------------------------------------------
r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes
Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)
This was reopened after discussion at
https://markmail.org/message/jnaitmwahjcjmdn5
This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187
Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers
Thanks: Christoph Neuroth for report
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859878 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10646)
Following discussion at https://markmail.org/message/y3izmnxd7jd6jbkf
this cleans some Groovy files in the base component, notably:
* remove ant-scripts folder and its content.
* Rename framework/base/groovyScript to framework/base/groovyScripts;
* Move GroovyInit.groovy and GroovyServiceTest.groovy respectively to
framework/base/groovyScripts and framework/common/groovyScripts
and change their paths where used.
* Removes GroovyInit.groovy from excludedConfigFiles in build.gradle
* After OFBIZ-10611 it's possible to move GroovyBaseScript.groovy from
framework/service/src/main/java/org/apache/ofbiz/service/engine
to
framework/service/src/main/groovy/org/apache/ofbiz/service/engine
* Removes FileUtilTests.groovy from basetests.xml (missed it in OFBIZ-10611)
* Fixes a typo in test-suite.xsd
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1846485 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10515)
Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10472)
At the same time renames setLocaleFromBrowser to SetTimeZoneFromBrowser
everywhere it's needed
And adds a documentation about the auth mismatch as suggested by Mathieu
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835628 13f79535-47bb-0310-9956-ffa450edef68
convert services genericBasePermissionCheck, commonGetAllCrudPermissions and visualThemePermissionCheck from minilang to groovy.
The simple method genericBasePermissionCheck is maintain but indicate as deprecated in log to don't break direct call from other mini-lang script.
Thanks to Dennis Balkir for this patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823397 13f79535-47bb-0310-9956-ffa450edef68
attachments with appropriate type along with several email fixes.
(OFBIZ-9395).
This adds the missing service attributes for attachmentType and
attachmentTypeList which did not come with the initial patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1810260 13f79535-47bb-0310-9956-ffa450edef68
Updated label from remove to expire while removing security group from user login, also added new entity-auto service to expire user login security group record.
Thanks S. Yazied for reporting the issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1803561 13f79535-47bb-0310-9956-ffa450edef68
local browser.
(OFBIZ-9264)
If a time zone is already set for a user, this new feature won't override it.
The user still can set it's own time zone, but if it isn't set,
this avoids the time zone set to the default of the server.
jelroux: the momentjs license is MIT
Thanks: Francis Douet
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1788256 13f79535-47bb-0310-9956-ffa450edef68
have any impact during tests
It's not strange, it's documented (I did it but forgot):
"this can be used only against trunk demo and is not in the tests set to avoid a dependency on Internet"
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1786214 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8289) (OFBIZ-8307)(OFBIZ-8440)(OFBIZ-8728)(OFBIZ-8775)(OFBIZ-8776)(OFBIZ-8777)(OFBIZ-8778)(OFBIZ-8779)(OFBIZ-8780)(OFBIZ-8781)(OFBIZ-8782)(OFBIZ-8783)(OFBIZ-8784)(OFBIZ-8787)(OFBIZ-8964)
Thanks: Rahul Singh, Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768184 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8729)(OFBIZ-8730)(OFBIZ-8792)(OFBIZ-8793)(OFBIZ-8794)(OFBIZ-8795)(OFBIZ-8796)(OFBIZ-8797)(OFBIZ-8798)(OFBIZ-8799)(OFBIZ-8800)(OFBIZ-8801)(OFBIZ-8802)(OFBIZ-8803)(OFBIZ-8788)(OFBIZ-8789)(OFBIZ-8767)
(OFBIZ-8768)(OFBIZ-8769)(OFBIZ-8770)
Thanks: Chinmay Patidar, Amit Gadaley and Rishi Solanki for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767965 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8606)(OFBIZ-8607)(OFBIZ-8608)(OFBIZ-8609)(OFBIZ-8610)(OFBIZ-8611)(OFBIZ-8612)(OFBIZ-8613)(OFBIZ-8614)(OFBIZ-8615)(OFBIZ-8616)(OFBIZ-8647)(OFBIZ-8648)(OFBIZ-8649)(OFBIZ-8650)(OFBIZ-8651)(OFBIZ-8724)
(OFBIZ-8725)(OFBIZ-8726)(OFBIZ-8727)
Thanks: Amit Gadaley and Rishi Solanki for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767953 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-8167) (OFBIZ-8168) (OFBIZ-8169) (OFBIZ-8170) (OFBIZ-8171) (OFBIZ-8208)(OFBIZ-8246)(OFBIZ-8247)(OFBIZ-8259)(OFBIZ-8269)
Thanks: Amit Gadaley for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1761231 13f79535-47bb-0310-9956-ffa450edef68
* removed the code that implemented the deprecated "call-bsh" operation in Minilang
* removed the BeanShellContainer (it has been disabled a long time ago)
* removed the BeanShell service engine, no more used
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751947 13f79535-47bb-0310-9956-ffa450edef68
I removed duplicate paths were componentname was uselessly repeated after component://componentname/script/org/ofbiz (projectmngr was the only one using there project instead)
I had few typos, easily fixed thanks to the tests. There could be still typos but they are unexpected and anyway no-brainer to fix
I'm still wondering about specialpurpose/example/minilang/README.txt.
I changed its content to
"The minilang directory is for static resources that are interpreted at run time rather than being compiled. This goes on the classpath, but does not get built or put into a JAR file."
not sure it makes any sense, I don't see how this relates to the classpath.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747712 13f79535-47bb-0310-9956-ffa450edef68
I decided to comment out as less as possible because once the RMI loaders, the RMI dispatcher and the related test services are off there is no RMI related danger left (test services are not a danger but would fail during tests run). It's then easier for users who need RMI in their projects to have only to uncomment those and not digg everywhere. Because the naming (JNDI) server relies on the rmi loader it will also be commented out.
[CVE-2016-2170] The infamous Java serialization vulnerability
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1735569 13f79535-47bb-0310-9956-ffa450edef68
jleroux: the issue description is quite lengthy so I will summarise it here, please refer to the Jira issue for details.
"When a customer creates an account on eCommerce site, s/he will also need to answer a security question. This security question then can be used by the user to reclaim her/his account in case s/he forgets her/his password. If the user correctly answers the required security question while reclaiming her/his account, her/his password will be sent through email notification. This part would work in the same way as the existing functionality of email password (forget password)."
The description was actually more ambitious (several questions, possibility for users to create own questions) but AFAIK these parts have not been implemented.
Apart updating the patch which did not merge, I got 2 majors issues (and few others I will not report here) I bypassed with workarounds.
Unlike Harsha, and as I reported earlier in the issue, I never got the username (userLoginId) back when using hidden parameters in the request body (not in requestParameters, ie UtilHttp.getParameterMap(request)), nor actually any parameters. This is maybe due to my OS (Windows7 was XP before) or my email client (Outlook Express then, now Thunderbird) or even my SMTP configuration (I used my ISP SMTP server) but most probably because I did it all on my sole machine (localhost). I tried to understand what was happening to request body parameters with http://www.telerik.com/fiddler, but finally gave up because it's even more complicated when https is in the picture. So I decided to rather use parameters in the URL (Query string). It's a bit less safe, though the password is OFBiz encrypted, and should be replaced. But it's safe enough because only the user should receive this message and even if the message is sniffed during its journey it should be hard to decrypt the password!
Harsha used the SecurityExtUiLabels.xml (created by ashish at r1618415) in securityext component but there is already a SecurityextUiLabels.xml in common component. Since I use Windows OFBiz was unable to retrieve the labels from SecurityExtUiLabels.xml since I guess it looked into a SecurityextUiLabels.xml. So I renamed a SecurityExtUiLabels.xml to EmailPassword.xml.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1716915 13f79535-47bb-0310-9956-ffa450edef68
This patch adds code to Paginator to account for the entryList being instanceOf List and extracts from the context.results object the original listSize.
jleroux, important note from OFBIZ-6423 which depends on OFBIZ-6422: it is necessary to assign a value (true makes sense) to override-list-size attribute so that FormRenderer.renderItemRows sets the lowIndex correctly, because once the results of performFindList are displayed, otherwise pages > 0 are rendered as empty.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1710413 13f79535-47bb-0310-9956-ffa450edef68
1. Add zxing-core-3.2.0.jar to framework/base/lib and .classpath.
2. Add services_qrcode.xml and QRCodeService.java in framework/common/.
3. Add qrcode request in common-controller.xml and QRCodeEvents.java under framework/common/.
4. Add qrcode.properties and QRCodeUiLabels.xml under framework/common/.
5. Add a barcode example page in specialpurpose/example, entry is on page: /example/control/EditExample?exampleId=EX01, the example can be seen on page: /example/control/ExampleReportPdfBarcode?exampleId=EX01
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1696921 13f79535-47bb-0310-9956-ffa450edef68
Thanks Pierre Smits for reporting the issue and thanks Neeraj Kumawat for providing the patch for the same.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1696234 13f79535-47bb-0310-9956-ffa450edef68
In the Webtools we can asociate Geos but we have yet no means to untie them
This patch adds a new grid in EditGeoScreen to see/delete GeoAssoc and CommonEntityLabels default-resource-name on GeoAssocType for translation purpose.
jleroux: On Pierre's Smits suggestion Gil also added a clickable link to open the associated Geo and a column to show the geoTypeId of the associated Geo.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1687259 13f79535-47bb-0310-9956-ffa450edef68