Commit Graph
679 Commits
Author SHA1 Message Date
Jacques Le Roux daa2c243a9 "Applied fix from trunk for revision: 1859877"
------------------------------------------------------------------------
r1859877 | jleroux | 2019-05-24 15:47:08 +0200 (ven. 24 mai 2019) | 10 lignes

Fixed: Services allow arbitrary HTML for parameters with allow-html set to "safe"
(OFBIZ-5254)

This was reopened after discussion at 
https://markmail.org/message/jnaitmwahjcjmdn5

This is a new solution which follows the work done with OFBIZ-6669 and OFBIZ-10187
Roughly said, it uses org.owasp.html.PolicyFactory and org.owasp.html.Sanitizers

Thanks: Christoph Neuroth for report
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859878 13f79535-47bb-0310-9956-ffa450edef68
2019-05-24 13:51:26 +00:00
Jacques Le Roux 20f97a5f56 "Applied fix from trunk for revision: 1859055 "
------------------------------------------------------------------------
r1859055 | jleroux | 2019-05-10 07:15:28 +0200 (ven. 10 mai 2019) | 4 lignes

Fixed: no functional changes

Fixes typos

------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859056 13f79535-47bb-0310-9956-ffa450edef68
2019-05-10 05:15:56 +00:00
Deepak Dixit 4117e0580d Applied fix from trunk for revision: 1855497
===

Reverted: Changes done at r#1854306, Removed the extra space from CommonBranch uiLabel values


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1855498 13f79535-47bb-0310-9956-ffa450edef68
2019-03-14 09:26:30 +00:00
Jacques Le Roux 2e4cd0330a "Applied fix from trunk for revision: 1854306"
------------------------------------------------------------------------
r1854306 | jleroux | 2019-02-25 11:33:53 +0100 (lun. 25 févr. 2019) | 6 lignes

Improved: no functional change

A missing space before CommonBranch label made the word trunkbranch instead of
trunk branch.

I'll backport this
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1854307 13f79535-47bb-0310-9956-ffa450edef68
2019-02-25 10:40:47 +00:00
Jacques Le Roux d89b68face Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

Simplifies and adds comments for clarity

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848923 13f79535-47bb-0310-9956-ffa450edef68
2018-12-14 10:38:18 +00:00
Jacques Le Roux 5597b1d65a Improved: Splitting CommonRate and CommonProductRating
(OFBIZ-3844)

The CommonRate label is currently not used coherently throughout the application 
stack. The existing translations suggest that the commonly understood meaning of 
CommonRate is a rate as a tariff or day rate. However, in the product management 
GUI, the CommonRate label is used to demark the section where ProductRating 
setting are made.

The provided fix splits CommonRate into two labels, CommonRatioRate and 
CommonAssessRate (product rating). Also, the application/product/webapp/ form 
definition now references the CommonAssessRate label.

Thanks: Carsten Schinzer for report and patch, Adrian for suggestion and Markus
May for discussion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848834 13f79535-47bb-0310-9956-ffa450edef68
2018-12-13 09:43:03 +00:00
Jacques Le Roux c440f65a99 Improved: sorts a label and removes a duplicated one
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1843413 13f79535-47bb-0310-9956-ffa450edef68
2018-10-10 09:13:38 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Suraj Khurana 20af1d3319 Improved: Arranged framework UI labels in alphabetic order.
(OFBIZ-7345)
Thanks Shivangi for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840815 13f79535-47bb-0310-9956-ffa450edef68
2018-09-13 13:31:51 +00:00
Gil Portenseigne 00a1a84053 Improved : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

Rename SQL reserved words, thanks Deepak for reporting the issue and providing a patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835994 13f79535-47bb-0310-9956-ffa450edef68
2018-07-15 20:49:28 +00:00
Jacques Le Roux e20b34bc24 Implemented: Add a mechanism to prevent the usage of EntitySyncRemove
(OFBIZ-10008)

No configurations is available to disable usage of EntitySyncRemove. 
And it's creating problems when having a large database and frequent delete 
operations.

saveEntitySyncRemoveInfo is used to create EntitySyncRemove records in 
GenericDelegator.removeValue() and removeByPrimaryKey().

This adds a mechanism to prevent the usage of EntitySyncRemove by adding a 
property in general.properties file used to configure in entityengine.xml 






git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835296 13f79535-47bb-0310-9956-ffa450edef68
2018-07-07 07:46:04 +00:00
Gil Portenseigne 9fbb3765e4 Implemented : File transfer management with communicationEvent and new contactMech FTP_ADDRESS
(OFBIZ-10245)

This commit introduce a new way to manage file transfer in OFBiz.
Inspired by mailing communication event management, a new communicationEventTypeId is created ('FILE_TRANSFER_COMM').

Such commEvent with classics : partyIdFrom/partyIdTo/contactMechIdTo/entryDate etc. are analysed by a job (like sendEmailDated), to send associated contents to a configured FTP/SFTP/FTPS server. If failure happens, it is catched and stored in communicationEvent, waiting for a new try.

For this purpose :

A new contactMechTypeId is introduced (FtpAddress), with its corresponding table. This contactMech store needed information for basic user/password authentication (server url and protocol, port, username, password, etc.)
A new service sendFileTransferDated that will look for pending file transfer and call following service.
A new service sendCommEventAsFtp that take a selected commEvent, check its structure and manage its status after trying the associated content file transfers.
A new service sendContentToFtp, that take a content and transfer it to a given FtpAddress.
A seca createCommEventFromFtpTransfer on sendContentToFtp to manage plural content file transfer, creating children communicationEvent to follow each content transfer separately (only for several content transfers).
A new Interface FtpClientInterface, with the 3 implementations of FTP, FTPS (To Implement), SFTP clients to manage Ftp connection and transfer.
A new property file to enable and manage redirection for testing purpose.

With this implementation, creating a communicationEvent, with a FtpAddress contactMechIdTo, and sendFileTransferDated job planned, the file is transfered to the ftp : communication event status set to COM_COMPLETE, if error occured the communication event status is set to COM_BOUNCED with error message on communicationEvent note.

Thanks Rishi for your feedbacks

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1831867 13f79535-47bb-0310-9956-ffa450edef68
2018-05-18 15:53:35 +00:00
Nicolas Malin 6a5ffb512e Implemented: Add CustomScreen entity copy from CustomMethod pattern (OFBIZ-10186)
With this entity we can define some different widget screens available on the system (organised by type) to link with other entities for resolve a specific screen to use for a specific context (future actual case to implement, select a invoice pdf screen linked to a party) without framework modification

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1824274 13f79535-47bb-0310-9956-ffa450edef68
2018-02-14 23:15:11 +00:00
Nicolas Malin 5588618e0f Improved: Convert CategoryServices.xml mini lang to groovy (OFBIZ-10031)
thanks to Dennis Balkir for this help to minilang conversion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1822912 13f79535-47bb-0310-9956-ffa450edef68
2018-02-01 22:33:59 +00:00
Jacques Le Roux 5e1d1f763e Improved: Make xssi prefix configurable
(OFBIZ-9169)

In OFBIZ-5409 a prefix was added for GET ajax requests.
It would be beneficial if the prefix could be configured instead of hard coded

jleroux: at r1777942 I missed the general.properties change

Thanks: Michael Brohl for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821386 13f79535-47bb-0310-9956-ffa450edef68
2018-01-17 15:28:51 +00:00
James Yong b2004efd5a Improved: ID should be the abbreviation for identity in English
(OFBIZ-100131)

Cover translations that are missed earlier.
Also cover non-English translations.

Thanks: Jacques for the additional patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1820451 13f79535-47bb-0310-9956-ffa450edef68
2018-01-07 12:16:21 +00:00
James Yong 38d0f7455d Fixed: ID should be the abbreviation for identity in English
(OFBIZ-10131)

Replaced the word 'Id' with 'ID' in the *Labels.xml files for "en" locale.
Improved the logic for auto title so that labels generated for variables like productTypeId 
will be 'Product Type ID' instead of 'Product Type Id'.

Thanks: Jacques for the review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819906 13f79535-47bb-0310-9956-ffa450edef68
2018-01-02 21:58:37 +00:00
Jacques Le Roux 04f84bac79 Improved: Make the general.SystemPropertyValue same than the related property
in general properties
(OFBIZ-9924)

only VISUAL_THEME value was concerned

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816899 13f79535-47bb-0310-9956-ffa450edef68
2017-12-01 19:10:00 +00:00
Deepak Dixit 1620e4e0ca Improved: No functional change, Only added license header
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1812309 13f79535-47bb-0310-9956-ffa450edef68
2017-10-16 18:43:14 +00:00
Deepak Dixit 90181172a1 Fixed: Updated images component reference path, as we removed images component and now these files are part of common-theme componnet.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806273 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 08:30:02 +00:00
Rishi Solanki 8d9b566605 Reverted: Local changes mistakenly committed in revision 1806258
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806259 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 06:05:15 +00:00
Rishi Solanki b0651cbe4d Improvement: Move all data in applications to the datamodel component. (OFBIZ-9501)
Moved the data which belongs to content with seed reader.
Thanks Saurabh Dixit for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806258 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 05:54:15 +00:00
Deepak Dixit 70ea1b55c2 Fixed sequencing for ILS locale description.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801314 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:44:48 +00:00
Deepak Dixit 7bb7ac13ea Added mistakenly removed valued for ILS entity uiLabel.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801312 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:42:29 +00:00
Deepak Dixit 0d6bc54720 Fixed: Removed duplicate uiLable for ILS currency, also fix translation for French locale. (OFBIZ-9413)
Thanks Jacques for reporting

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801311 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 18:39:30 +00:00
Deepak Dixit 14f9c7331d Improved: Following uiLabels should move from ProductUiLabels.xml to CommonEntityLabels.xml. (OFBIZ-9408)
ProductShipmentUomAbbreviation_LEN_in
    ProductShipmentUomAbbreviation_WT_g
    ProductShipmentUomAbbreviation_WT_kg
    ProductShipmentUomAbbreviation_WT_lb
    These labels should be written in similer pattern as other labels of "Uom" entity are written in CommonEntityLabels.xml, for example :
    ProductShipmentUomAbbreviation_LEN_in will be written as
    Uom.abbreviation.LEN_in
    <entityName>.<fieldName>.<PrimaryKey>

Thanks Renuka for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801281 13f79535-47bb-0310-9956-ffa450edef68
2017-07-08 11:36:50 +00:00
Deepak Dixit 8aecef8445 Improved: Removed unused entity uiLabels for removed currency UOM (OFBIZ-9413)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1799209 13f79535-47bb-0310-9956-ffa450edef68
2017-06-19 13:50:34 +00:00
Jacques Le Roux 0e99a8a4f5 Fixed: Some labels are considered not used by the Label Manager
(OFBIZ-8154)

Removes CommonTerm and CommonTerms as they are unused. 
This also relates with OFBIZ-9346

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1794380 13f79535-47bb-0310-9956-ffa450edef68
2017-05-08 14:27:40 +00:00
Arun Patidar 5ac5ef81e0 Fixed: UI Label in file CommonErrorUiLabels.xml
(OFBIZ-9046) 

Thanks: Rahul Singh and Amit Gadaley for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1768195 13f79535-47bb-0310-9956-ffa450edef68
2016-11-05 11:33:07 +00:00
Jacques Le Roux 8749815f0a Improved: Remove redundant backend themes
(OFBIZ-8293)

This completes the previous commits where bizzness time and Dropping Crumbs were
removed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767920 13f79535-47bb-0310-9956-ffa450edef68
2016-11-03 16:07:44 +00:00
Jacques Le Roux 56648f77ce Improved: Remove redundant backend themes
(OFBIZ-8293)

This completes the previous commit where bizzness time and Dropping Crumbs were
removed

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767893 13f79535-47bb-0310-9956-ffa450edef68
2016-11-03 14:35:54 +00:00
Jacques Le Roux efee2bc4b5 No functional change: removes annoying superfluous spaces in labels.
Can't be found when searching from HTML source, HTML removes it. 
There are no others but in ALv2 headers. 
I have asked why on dev@community.apache.org out of curiosity.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1764064 13f79535-47bb-0310-9956-ffa450edef68
2016-10-10 11:43:46 +00:00
Jacques Le Roux 881b56ceeb Improves: Translate the svn and git info footers
(OFBIZ-7798)

We slightly changed the old format of the footer. The old format used only the 
translated words _uiLabelMap.CommonBuiltOn_ and _uiLabelMap.CommonWith_. 
On the other hand, the new format contains the words Branch, Revision, 
Built On and Java Version.

We need to translate all four words in the CommonUiLabels.xml and then 
incorporate them

old version:
" - Release-revision : ${releasePath}-r${info.entry.commit(revision)},  
${uiLabelMap.CommonBuiltOn} ${dateTime} ${uiLabelMap.CommonWith} 
Java ${java.version}

new version:
"Branch: ${info.entry.url.text()}" + System.lineSeparator()
"Revision: ${info.entry.commit.@revision}" + System.lineSeparator()
"Built on: ${timestamp}" + System.lineSeparator()
"Java Version: ${org.gradle.internal.jvm.Jvm.current()}"

Thanks: Taher Alkhateeb for the 1st patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1762077 13f79535-47bb-0310-9956-ffa450edef68
2016-09-23 18:09:19 +00:00
Deepak Dixit e165a4fd2c (OFBIZ-7980) Applied slightly modified patch from jira issue
=====================================
Add UI labels for success / error messages in common component
=====================================
Thanks Tanmay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759061 13f79535-47bb-0310-9956-ffa450edef68
2016-09-03 09:05:46 +00:00
Jacques Le Roux 98004b489c A patch from Pierre Smits for "Add missing CommonCode label" https://issues.apache.org/jira/browse/OFBIZ-8055
The label CommonCode is used in various places, however the label doesn't exist.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1758143 13f79535-47bb-0310-9956-ffa450edef68
2016-08-28 19:36:55 +00:00
Jacques Le Roux d562fc51c7 Fixes typos introduced with r1756543 for <<A patch from Pierre Smits for "Updating various labels in CommonUiLabels.xml" https://issues.apache.org/jira/browse/OFBIZ-7953>>
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1756547 13f79535-47bb-0310-9956-ffa450edef68
2016-08-16 20:58:32 +00:00
Jacques Le Roux 49a99454a8 A patch from Pierre Smits for "Updating various labels in CommonUiLabels.xml" https://issues.apache.org/jira/browse/OFBIZ-7953
jleroux: As it's mostly "nl" additions I let our qualified committer (Hans Bakker) check this part


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1756543 13f79535-47bb-0310-9956-ffa450edef68
2016-08-16 19:00:48 +00:00
Jacques Le Roux 7ada24fd04 This removes the pos component. OFBIZ-7804 "Check if we should fix or remove the POS (hence WebPos?)"
Most is done already. Test pass but testFopMacroLibrary but I don't see how it could be related to these changes, could be a quirk on Windows, BuilBot will tell us. Anyway, I will later double-check to be sure, also to see if I did not miss anything else.

I have voluntarily left 2 or 3 moot points
I was unable to remove possible POS references in <property key="FieldDescription.ProductStore.isImmediatelyFulfilled"> for certain language I'm unable to read.
I have to check if we should keep or not this code snippet
                <!-- if inventory info is not available for all of the products, then don't do the issuance, ie there has to be at least SOME inventory info in the database to facilitate inventory-less POS terminals -->
                <entity-count entity-name="InventoryItem" count-field="iiCount">
                    <condition-expr field-name="facilityId" operator="equals" from-field="orderHeader.originFacilityId"/>
                </entity-count>
I simply commented out twice this snippet in InvoiceServices.java, because I wonder if it would not be useful when the webPos will be able to issue money change
//                if (null == adj.get("amount")) { // JLR 17/4/7 : fix a bug coming from POS in case of use of a discount (on item(s) or sale, sale here) and a cash amount higher than total (hence issuing change)
//                    continue;
//                }

While at it, since I modified OPTIONAL_LIBRARIES, I also changed these svn:properties: svn:eol-style = native & svn:mime-type = text/plain


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1754402 13f79535-47bb-0310-9956-ffa450edef68
2016-07-28 12:27:20 +00:00
Arun Patidar fbe2dfb9d2 [OFBIZ-7140] Added Fetch Log Functionality parallel to View Log in webtools. Thanks Rishi Solanki for new feature and patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746227 13f79535-47bb-0310-9956-ffa450edef68
2016-05-31 05:26:43 +00:00
Nicolas Malin ab92393570 Add xls screen renderer to convert a screen definition like an html flow directly ready by a spreadsheet application
In addition, add an export example button on FindExample screen and add complete macro ftl renderer unit test. Issue OFBIZ-6931 proposed by Leila Mekika. Thanks to her, jacques and pierre for theirs remarks.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1746045 13f79535-47bb-0310-9956-ffa450edef68
2016-05-29 18:38:26 +00:00
Ashish Vijaywargiya 8d5599c88d Applied patch from jira issue - Quote report doesn't show terms of the quote - https://issues.apache.org/jira/browse/OFBIZ-5861
Thanks Pierre for creating the issue and Thanks Ravi for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1744910 13f79535-47bb-0310-9956-ffa450edef68
2016-05-21 11:38:36 +00:00
Jacques Le Roux f5d8feac88 An enhanced patch from Christian Carlow for "Add ability to change Routing statuses" - https://issues.apache.org/jira/browse/OFBIZ-6307
Only ROU_ACTIVE statusItem exists for statusTypeId ROUTING_STATUS.  Adding another such as ROU_INACTIVE would allow for more control over routings.  Doing so entails adding the statusId to the find and edit screens.
ROU_INACTIVE was add as a StatusItem and currentStatusId was added to the routing find form as a multi-drop down

jleroux: I added use of common/webcommon/includes/setMultipleSelectJs.ftl and French labels

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1741789 13f79535-47bb-0310-9956-ffa450edef68
2016-04-30 18:43:10 +00:00
Hans Bakker 10c844b687 improve uom convert error message
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1734875 13f79535-47bb-0310-9956-ffa450edef68
2016-03-14 02:37:12 +00:00
Jacques Le Roux 327fb83021 A patch from Tomas Pytelka for "Czech translation" https://issues.apache.org/jira/browse/OFBIZ-6885
jleroux: this was git patch, I'm now used to change them to apply, but I will explain how to generate svn patch from it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1729078 13f79535-47bb-0310-9956-ffa450edef68
2016-02-08 07:56:23 +00:00
Hans Bakker 9d39583bcf be able to set accounting company in the header, so other companent can change it too. https://issues.apache.org/jira/browse/OFBIZ-6802
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728584 13f79535-47bb-0310-9956-ffa450edef68
2016-02-05 01:45:50 +00:00
Gil Portenseigne 63e01c97f7 OFBIZ-6869 : Add properties in widget.properties, for easy customization of JGrowl alert. Thanks Jacques for the idea
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1728351 13f79535-47bb-0310-9956-ffa450edef68
2016-02-03 19:18:35 +00:00
Nicolas Malin 3a07efc5df correct locale (en to fr) associate to french translation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1726486 13f79535-47bb-0310-9956-ffa450edef68
2016-01-24 12:50:01 +00:00
Nicolas Malin ee44b0f8db add french label for CommonCost
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1724701 13f79535-47bb-0310-9956-ffa450edef68
2016-01-14 21:56:49 +00:00
Jacques Le Roux 0dd553ec96 A modified patch from Harsha Chadhar for "New feature to reclaim a user account - Using Security Questions" https://issues.apache.org/jira/browse/OFBIZ-4983
jleroux: the issue description is quite lengthy so I will summarise it here, please refer to the Jira issue for details.
"When a customer creates an account on eCommerce site, s/he will also need to answer a security question. This security question then can be used by the user to reclaim her/his account in case s/he forgets her/his password. If the user correctly answers the required security question while reclaiming her/his account, her/his password will be sent through email notification. This part would work in the same way as the existing functionality of email password (forget password)."

The description was actually more ambitious (several questions, possibility for users to create own questions) but AFAIK these parts have not been implemented.

Apart updating the patch which did not merge, I got 2 majors issues (and few others I will not report here) I bypassed with workarounds.

Unlike Harsha, and as I reported earlier in the issue, I never got the username (userLoginId) back when using hidden parameters in the request body (not in requestParameters, ie UtilHttp.getParameterMap(request)), nor actually any parameters. This is maybe due to my OS (Windows7 was XP before) or my email client (Outlook Express then, now Thunderbird) or even my SMTP configuration (I used my ISP SMTP server) but most probably because I did it all on my sole machine (localhost). I tried to understand what was happening to request body parameters with http://www.telerik.com/fiddler, but finally gave up because it's even more complicated when https is in the picture. So I decided to rather use parameters in the URL (Query string). It's a bit less safe, though the password is OFBiz encrypted, and should be replaced. But it's safe enough because only the user should receive this message and even if the message is sniffed during its journey it should be hard to decrypt the password!

Harsha used the SecurityExtUiLabels.xml (created by ashish at r1618415) in securityext component but there is already a SecurityextUiLabels.xml in common component. Since I use Windows OFBiz was unable to retrieve the labels from SecurityExtUiLabels.xml since I guess it looked into a SecurityextUiLabels.xml. So I renamed a SecurityExtUiLabels.xml to EmailPassword.xml.










git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1716915 13f79535-47bb-0310-9956-ffa450edef68
2015-11-27 20:37:15 +00:00
Jacques Le Roux 2e95018e59 Better French label, there are plenty similar others but it's OK
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1715670 13f79535-47bb-0310-9956-ffa450edef68
2015-11-22 18:28:55 +00:00