Commit Graph
20 Commits
Author SHA1 Message Date
Deepak Dixit d01361303c Improved: Reorganize import
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835954 13f79535-47bb-0310-9956-ffa450edef68
2018-07-15 08:46:54 +00:00
Deepak Dixit 092a5cc390 Fixed: Missing Import in CmsEditAddPrep.groovy
(OFBIZ-10475)

Applied slightly modified patch, Thanks Dennis Balkir for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835953 13f79535-47bb-0310-9956-ffa450edef68
2018-07-15 08:45:35 +00:00
Jacques Le Roux dbab78e671 Improved: no functional change, removes unneeded log info (missed it previously)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835383 13f79535-47bb-0310-9956-ffa450edef68
2018-07-09 08:25:48 +00:00
Jacques Le Roux 04d398d97b Improved: no functional change, removes unneeded log info
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835382 13f79535-47bb-0310-9956-ffa450edef68
2018-07-09 08:24:19 +00:00
Jacques Le Roux e9e0158458 Fixed: Template edit are not working correctly
(OFBIZ-9830)

jleroux: just noticed after r1811559  that the mimeTypeId was not used

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811564 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 12:34:19 +00:00
Jacques Le Roux fe38302313 Fixed: Template edit are not working correctly
(OFBIZ-9830)

Steps to recreate:
1. Go to ContentManager.
2. Go to Template.
3. Click Find, then click LEFTBAR in the search result.
4. Click Edit, then we get a error page.

Thanks: fumiyoshi.to

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811559 13f79535-47bb-0310-9956-ffa450edef68
2017-10-09 12:23:04 +00:00
Deepak Dixit ea5d994b78 Improved: Content : Remove unused imports from groovy files for code optimization.(OFBIZ-8487)
Thanks Suraj Khurana and Pradeep Choudhary for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1806264 13f79535-47bb-0310-9956-ffa450edef68
2017-08-26 07:21:00 +00:00
Deepak Dixit dea31737ea Fixed: Moved SurveyOptions.ftl in correct location.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1801364 13f79535-47bb-0310-9956-ffa450edef68
2017-07-09 10:03:41 +00:00
Jacques Le Roux ec2f674a92 Improved: EntityListIterator closed but not in case of exception
(OFBIZ-9385)

This is an improvement only because no cases were reported. But obviously in 
case of unlucky exception after the EntityListIterator creation and before it's 
closed the EntityListIterator remains in memory. 
It should be closed in EntityListIterator.finalize() but the less happens there 
the better.

I noticed Groovy has no try-with-ressources statement. I put a comment in
the description of OFBIZ-9296 "Update Gradle to 2.4.10" Maybe a solution would
be to use streams but really WTF! It seems Gradle 2.5 has autocloseable...

This contains also some refactoring and code cleaning




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1797373 13f79535-47bb-0310-9956-ffa450edef68
2017-06-02 11:25:17 +00:00
Jacques Le Roux 308b18ee83 No functional change.
Michael suggested in dev ML that we don't show the error in UI because VIEW_SIZE
 is only technical, which I agree with. The log is enough.
 
Actually it was already the case because I missed to move the
if (errMsgList) {
    request.setAttribute("_ERROR_MESSAGE_LIST_", errMsgList)
}
block below the now caught NumberFormatException

So I just need to remove the 2nd line in the catch, done.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789736 13f79535-47bb-0310-9956-ffa450edef68
2017-03-31 19:23:12 +00:00
Jacques Le Roux 4a3230c15c No functional change, fixes a C/P with wrong value name in errMsgList
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789711 13f79535-47bb-0310-9956-ffa450edef68
2017-03-31 17:00:58 +00:00
Jacques Le Roux ffc82e67ea Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While working on OFBIZ-7759, I stumbled upon this by chance. 
It's unlikely that this NumberFormatException is ever caught, but not a reason 
to swallow it. 

I checked there are no other swallowed exceptions in Groovy files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789710 13f79535-47bb-0310-9956-ffa450edef68
2017-03-31 16:56:04 +00:00
Arun Patidar 2bfc816e9b Improved: Removed semicolon from all Groovy files of all components.
(OFBIZ-8652)

Thanks: Rohit Koushal, Jacques Le Roux and Rishi Solanki for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1767764 13f79535-47bb-0310-9956-ffa450edef68
2016-11-02 19:09:13 +00:00
Jacques Le Roux a4cd270ca4 Fixed: You cannot edit an image in content
(OFBIZ-7000)

If you get to
content/control/EditLayout?drDataResourceId=NOCONTENTFOUND&contentId=NOCONTENTFOUND
When trying to editing you get an error

Mohammed Rehan Khan explored the issue and found that there is a condition in 
DataResourceWorker method to render content of 'text' mime type only, for others
 it returns exception.

We can fix this by setting up mimeTypeID as null in request param

Question: Why setting up mimeTypeTypeId as 'null' is fixing this issue?
Answer: As we don't have image specific worker method for rendering these type 
of contents, so we are using DataResourceWorker.renderDataResourceAsText() 
to render image type content as well. Due to following condition, 
targetMimeTypeId is setting up as "text/html" if sent null and hence not 
throwing the exception reported in the ticket.

Thanks: Mohammed Rehan Khan for the patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1765094 13f79535-47bb-0310-9956-ffa450edef68
2016-10-15 17:12:28 +00:00
Ashish Vijaywargiya 6f013aea3e Applied patch from jira issue - OFBIZ-8070 - Clean up commented out code in Groovy for Content. Thanks Aman for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1759151 13f79535-47bb-0310-9956-ffa450edef68
2016-09-04 07:32:47 +00:00
Deepak Dixit 834691742b (OFBIZ-6274) Renamed OFBiz artefacts from org.ofbiz.* to org.apache.ofbiz.*.Thanks to Taher for working on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1752920 13f79535-47bb-0310-9956-ffa450edef68
2016-07-16 10:30:49 +00:00
Ashish Vijaywargiya 86ec0749b9 Applied patch from jira issue - OFBIZ-6214 - Have overview of questions in EditSurveyQuestions.ftl paginate properly.
Thanks Pierre for creating the issue and thanks Yashwant for providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1751483 13f79535-47bb-0310-9956-ffa450edef68
2016-07-05 14:07:47 +00:00
Ashish Vijaywargiya 2e30592be6 Applied patch from jira issue OFBIZ-7565 - Remove HtmlFormWrapper dependencies from Survey Question Screen.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1750306 13f79535-47bb-0310-9956-ffa450edef68
2016-06-27 08:14:21 +00:00
Ashish Vijaywargiya 2672c0d915 Applied patch from jira issue OFBIZ-7527 - Questions from category should not come to apply on survey when creating/editing any question.
Thanks Ravi for the contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1749845 13f79535-47bb-0310-9956-ffa450edef68
2016-06-23 06:45:28 +00:00
Deepak Dixit 25b56a03ea (OFBIZ-7223) Relocate .groovy files in the content component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1747756 13f79535-47bb-0310-9956-ffa450edef68
2016-06-10 17:21:10 +00:00