Commit Graph
8917 Commits
Author SHA1 Message Date
Deepak Dixit 7fb5c14fe3 Improved: Removed deprecated entity related migration service, also removed some more deprecated entities that are located in entitymodel.xml instead entitymodel_old.xm (OFBIZ-9327)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792182 13f79535-47bb-0310-9956-ffa450edef68
2017-04-21 11:21:32 +00:00
Jacopo Cappellato 727101dfc2 Fixed: removed explicit includes of HtmlTemplate.ftl from FreeMarker templates
since this has been deprecated and it is no more supported.
(OFBIZ-9325)

Improved the nextPrev macro by moving some logic from the template to the macro.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1792018 13f79535-47bb-0310-9956-ffa450edef68
2017-04-20 06:38:20 +00:00
Jacques Le Roux a9ce80c8e6 Fixed: temporal expression screen missing date dialogbox
(OFBIZ-7066)

Problem:
go to https://localhost:8443/webtools/control/editTemporalExpression
go to frequency expression section
notice date dialog button is missing

Explanation:
Same Id used by 2 macros

Solution:
Set different Ids in macros and use them in template

jleroux: I set clear different ids based on macros names

Thanks: Wai for report Florian Montalbano for investigation

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791791 13f79535-47bb-0310-9956-ffa450edef68
2017-04-18 14:46:40 +00:00
Jacopo Cappellato 3475e8b748 Reverted: this reverts the commit 1785581 by Wei Zhang because it represented a
step back since the work done in rev. 1762227.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791763 13f79535-47bb-0310-9956-ffa450edef68
2017-04-18 08:43:50 +00:00
Jacques Le Roux 0f6a7a6638 After changing the How+to+migrate+OFBiz+from+Derby+to+MySQL+database page in
wiki following Ingo's suggestion on user ML, adapts also the entityengine
definition to modern mySQL use

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791361 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 13:02:33 +00:00
Jacques Le Roux a59c0054c8 Fixed: On setting verbose true, UtilHttp.getParameterMap() method prints
username and password in logs
(OFBIZ-9310)

In UtilHttp.getParameterMap(HttpServletRequest request, Set<? extends String>...
method, following line of code prints username and password in logs when verbose
 is set to true.

Debug.logVerbose("Request Parameter Map Entries: " + 
System.getProperty("line.separator") + UtilMisc.printMap(paramMap), module);

Aditya suggested:
Removed the line that prints "Request Parameter Map Entries" as it may print 
username and password entered by user when verbose set to true. 
It may not be a grave concern for staging environment as verbose are not logged 
there but it is still unethical to print such details.

jleroux: I decided to rather comment out the line which might still be useful
in some cases...

Thanks: Aditya Sharma

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791346 13f79535-47bb-0310-9956-ffa450edef68
2017-04-14 11:04:04 +00:00
Jacques Le Roux ef839cab56 Improved: SOAPEventHandler only outputs error to log when secureSoapAnswer
= false
(OFBIZ-9289)

jleroux: I agree there is no risk showing information in log

Thanks: Gareth Carter

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791288 13f79535-47bb-0310-9956-ffa450edef68
2017-04-13 17:39:34 +00:00
Jacques Le Roux d8661c1410 Reverted: r1791143 for "The createTenant Gradle task fails"
(OFBIZ-9273)

The fix was harmless but not to the point. Taher fixed the root cause at 
r1791168

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791218 13f79535-47bb-0310-9956-ffa450edef68
2017-04-13 07:10:28 +00:00
Jacques Le Roux bbe38dbae8 Fixed: The createTenant Gradle task fails
(OFBIZ-9273)

Problem:
When you enter
bq. gradlew createTenant -PtenantId=test
you get
FAILURE: Build failed with an exception.
* Where:
Build file 'C:\projectsASF\ofbiz-framework\build.gradle' line: 764
* What went wrong:
A problem occurred evaluating root project 'ofbiz'.
> Could not get unknown property 'pluginId' for task ':installAllPlugins' of 
type org.gradle.api.DefaultTask.

Investigation:
This issue is due creation of build.gradle file in plugin (with empty gradle 
task defined in it)

Solution:
Comment out build.gradle template content

Thanks: Deepak for confirmation, Swapnil M Mane for the investigation and patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1791143 13f79535-47bb-0310-9956-ffa450edef68
2017-04-12 16:38:59 +00:00
Jacopo Cappellato 92b5652156 Improved: cleaned up some old code without altering its functional behavior.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1790520 13f79535-47bb-0310-9956-ffa450edef68
2017-04-07 08:34:57 +00:00
Jacques Le Roux 9f8f5d52db No functional change, forgot resultMapNameAcsr as param in the Javadoc
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789738 13f79535-47bb-0310-9956-ffa450edef68
2017-03-31 19:40:00 +00:00
Jacques Le Roux b912d34c8f Improved: Refactor the runAction method in AbstractModelAction, ModelFormAction
and ModelTreeAction classes
(OFBIZ-9287)

This 3 methods share a pattern which should be refactored in a common protected
 method. The pattern is
{code}
if (!this.resultMapNameAcsr.isEmpty()) {
    this.resultMapNameAcsr.put(context, result);
    String queryString = (String) result.get("queryString");
    context.put("queryString", queryString);
    context.put("queryStringMap", result.get("queryStringMap"));
    if (UtilValidate.isNotEmpty(queryString)) {
        try {
            String queryStringEncoded = queryString.replaceAll("&", "%26");
            context.put("queryStringEncoded", queryStringEncoded);
        } catch (PatternSyntaxException e) {
         // obviously a PatternSyntaxException should not occur here
        }
    }
} else {
    context.putAll(result);
}
{code}
Enough for a refactor I'd say.

I created a ModelActionUtil class where I extracted the method I used in the 3
other classes.

This also removes the swallowed exception that we had in ModelFormAction and 
ModelTreeAction, but not in ModelActionUtil from where I extracted the method.
It's now consistent and if ever, for a very unlikely reason, the exception 
is thrown, people will know about it and will take appropriate measures.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789737 13f79535-47bb-0310-9956-ffa450edef68
2017-03-31 19:37:00 +00:00
James Yong e4a7a0ef72 Implemented: OFBiz Startup Message
(OFBIZ-9285)

Provide log message after all containers/components are loaded. 
This helps to inform new developer that OFBiz has started.

Thanks: Jacques and Taher for code review and mentoring.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789533 13f79535-47bb-0310-9956-ffa450edef68
2017-03-30 15:26:37 +00:00
Jacques Le Roux 0cddec3a01 Fixed: Fix Default or Empty Catch block in Java files
(OFBIZ-8341)

Obviously a PatternSyntaxException should not occur there. 
So I simply put a comment to document the fact even it it seems obvious.

I note though that the repeated pattern is a smell for refactoring...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1789163 13f79535-47bb-0310-9956-ffa450edef68
2017-03-28 15:26:02 +00:00
Jacques Le Roux abc255e3b9 No functional change, as suggested by Jacopo on dev ML referring to r1788065
<<With code like the above, I think that embedding everything in the try
clause makes the code a bit less readable. One option would be to split the 
entity query code in two lines>>

I used this suggestion on all locations it made sense. In few places it was
better to let it as is; separating would rather make the code a bit less 
readable.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1788263 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 15:09:23 +00:00
Jacques Le Roux d8d7ef6b15 Implemented: Make sure the local date time uses the time zone from the
local browser.
(OFBIZ-9264)

If a time zone is already set for a user, this new feature won't override it.
The user still can set it's own time zone, but if it isn't set, 
this avoids the time zone set to the default of the server.

jelroux: the momentjs license is MIT

Thanks: Francis Douet

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1788256 13f79535-47bb-0310-9956-ffa450edef68
2017-03-23 14:37:47 +00:00
Jacques Le Roux 16f0d33d79 Improved: Use try-with-resources statement wherever it's possible
(OFBIZ-8202)

Replace finally blocks closing EntityListIterator by 
try-with-resource, and refactors around

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787949 13f79535-47bb-0310-9956-ffa450edef68
2017-03-21 12:20:55 +00:00
Taher A. Alkhateeb efb6f60510 Fixed: Regression: a commit between R15 and the Gradle switch uses/blocks the ports
(OFBIZ-9196)
Disabled the admin server from starting on contexts other than "start"

This commit has reference to the below discussion thread in which buildbot
is failing in between commits due to blocking the admin server thread.
The commit enables the admin server only for the "start" ofbiz server command.
For all other commands the port is set to value zero and hence the admin server
is never initialized

https://s.apache.org/xfxS

Thanks: Taher for the fix

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787627 13f79535-47bb-0310-9956-ffa450edef68
2017-03-19 14:55:13 +00:00
Jacques Le Roux 14f1737a35 Fixed: Induce Model XML from Database throws exception
(OFBIZ-7473)

Go to Webtools -> Import/Export -> Induce Model XML from Database 
(https://localhost:8443/webtools/control/view/ModelInduceFromDb)
An exception is thrown: javax.servlet.ServletException: File 
[/entity/ModelInduceFromDb.jsp] not found.

jleroux: after moving FTL template to the template sub-dir we forgot links 
in the ctrlr. Changing the ctrlr is the best way.

Thanks: Thanks Gopal Yadav for the report . William Wang for the real cause

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787535 13f79535-47bb-0310-9956-ffa450edef68
2017-03-18 09:23:12 +00:00
Jacques Le Roux 3a2497a7a1 Completed: Removes the now useless hot-deploy directory
(OFBIZ-9268)

The hot-deploy removal was discussed at https://s.apache.org/7Y2w

This completes the previous commit at r1787461

Note: 
We need to remove or implement with Gradle the "depends-on" feature in 
ofbiz-component files
IMO, the applyOfbizPatchesAndHotDeploy.sh and svnUpHotdeploy.bat scrupts should 
be removed, done




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787473 13f79535-47bb-0310-9956-ffa450edef68
2017-03-17 18:39:25 +00:00
Jacques Le Roux 3c45e7d684 Improved: Handle only labels with the "_" separator between languages and
countries
(OFBIZ-9261)

This is handled in LabelManagerFactory.java

    Element valueElem = (Element) valueNode;
    // Support old way of specifying xml:lang value.
    // Old way: en_AU, new way: en-AU
    String localeName = valueElem.getAttribute("xml:lang");
    if( localeName.contains("_")) {
        localeName = localeName.replace('_', '-');
    }

I replaces this snippet by throwing an exception in order to now to 
automatically detect issues

Moreover I notices that there are no longer reasons to bypass the 
ExampleEntityLabels and ProductPromoUiLabels files

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787047 13f79535-47bb-0310-9956-ffa450edef68
2017-03-15 13:56:38 +00:00
Jacques Le Roux 12cde364f5 No functional change, we use CamelCase in Java not SnakeCase
Fixes previous commit where I missed this one, I must have used the refactoring
tool :/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787033 13f79535-47bb-0310-9956-ffa450edef68
2017-03-15 11:38:59 +00:00
Jacques Le Roux ba1460f6a6 No functional change, we use CamelCase in Java not SnakeCase
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787032 13f79535-47bb-0310-9956-ffa450edef68
2017-03-15 11:28:40 +00:00
Jacques Le Roux 547b765835 Improved: Wrong <"zh_TW" instead of "zh-TW" in 2 labels files
(OFBIZ-9260)
This is not really a bug because IIRW, for historical reason, we handle both in
 labels management. But this is really a problem when you use the "Validate" 
 option in Eclipse. Because those errors add to others and make complicate to 
 spot important issues in XML code.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1787024 13f79535-47bb-0310-9956-ffa450edef68
2017-03-15 11:00:41 +00:00
Jacques Le Roux 6abbbc81fb No functional change, I missed this so far but strangely it did not seem to
have any impact during tests

It's not strange, it's documented (I did it but forgot):
"this can be used only against trunk demo and is not in the tests set to avoid a dependency on Internet"


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1786214 13f79535-47bb-0310-9956-ffa450edef68
2017-03-09 18:11:06 +00:00
Deepak Dixit 2e7aacb148 Improved: Remove unnecessary cc and bcc , Applied slightly modified patch from jira issue.
(OFBIZ-9231) 

Thanks Suraj Khurana for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1786116 13f79535-47bb-0310-9956-ffa450edef68
2017-03-09 09:13:22 +00:00
Jacques Le Roux 60ebed29f1 Fixed: compareBigDecimals in org.ofbiz.minilang.method.conditional.Compare
does not compare certain values correctly
(OFBIZ-6386)

compareBigDecimals scales down and rounds up meaning you lose information and 
the comparison result is not as expected

Thanks: Gareth Carter for the patch, Mridul Pathak and Jacopo for discussing the
topic in all details (see the Jira issue)

I'm not yet sure but maybe this has revealed some hidden issues in test, see https://ci.apache.org/projects/ofbiz/logs/trunk/html/

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1786079 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 21:27:30 +00:00
Jacques Le Roux 6572f0ceb0 Completed: Missing reference to the delegator in HtmlFormMacroLibrary.ftl
(OFBIZ-9230)

No functional changes, completes r1785882. I missed the other macro types which 
don't implement these macros

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785925 13f79535-47bb-0310-9956-ffa450edef68
2017-03-08 08:21:49 +00:00
Jacques Le Roux 9b2209ef5d Fixed: Missing reference to the delegator in HtmlFormMacroLibrary.ftl
(OFBIZ-9230)

This has been temporarily fixed with r1784259. After a discussion on dev ML and
a code analysis reported in the Jira issue, I decided to follow Rishi Solanki's 
idea of using the delegatorName.

Since we have no context when executing a macro in the widget form, I decided 
to pass it to the macro. I had though to create an 
EntityUtilProperties.getPropertyValueFromDelegatorName() method to eventually 
pass the delegatorName. Two macros were concerned renderLookupField and 
renderTextField.

Note: while analysing the code I found that EntityExpr.checkRhsType() can face
a related kind of problem. I'll commit an improvement later...

Thanks: Wai for report and discussion and Rishi for pursuing his idea of using 
the delegatorName

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785882 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 20:33:09 +00:00
Jacques Le Roux 75d4db8c94 No functional change, just a comment
context is always null here. It misled me , so I prefer to put a comment


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785865 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 18:43:39 +00:00
Jacques Le Roux 70fc173a0d No functional changes, code cleaning
While working on OFBIZ-9230 I noticed those needed changes



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785861 13f79535-47bb-0310-9956-ffa450edef68
2017-03-07 17:11:35 +00:00
Wei Zhang 808f4823bb Lost <#include "component://widget/templates/HtmlFormMacroLibrary.ftl"/> in framework/common/template/HtmlTemplate.ftl
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785581 13f79535-47bb-0310-9956-ffa450edef68
2017-03-06 00:39:53 +00:00
Jacques Le Roux 18dfa2e799 No functional change, from Debug.Info to Debug.logError
More to test the Buildbot triggering

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785485 13f79535-47bb-0310-9956-ffa450edef68
2017-03-04 13:44:30 +00:00
Jacques Le Roux 1abfaae094 No functional change, fixes a typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1785478 13f79535-47bb-0310-9956-ffa450edef68
2017-03-04 13:08:50 +00:00
Jacques Le Roux d34001a9d4 Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

After my conclusions at OFBIZ-9240 I decided to reapply the changes and will 
test on demos.

Because WebSiteProperties reuse the port initially found in the 1st login URL
I tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to how the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl()
I think it was time...

Thanks: Pierre Smits for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784930 13f79535-47bb-0310-9956-ffa450edef68
2017-03-01 13:36:05 +00:00
Jacques Le Roux 1a6d7b307d Reverts revisions 1784558, 1784555, 1784549
No functional change, cleaner code
........
No functional change, fixes a typo
........
Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

Also fixes "16.11 ofbizUrl include host+port and break some reverse-proxy/docker
 setups"
(OFBIZ-9224)

It was an easy fix, I just imported
<SystemProperty systemPropertyId="port.https" systemResourceId="url" 
systemPropertyValue=""/>
in trunk demo and all work perfectly.

I also tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl() 
I think it was time...

Thanks: Pierre Smits and Leonard Lin for reports
........


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784760 13f79535-47bb-0310-9956-ffa450edef68
2017-02-28 15:36:42 +00:00
Jacques Le Roux 81f7694e6b No functional change, cleaner code
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784558 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 13:14:39 +00:00
Jacques Le Roux 761a9e8069 No functional change, fixes a typo
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784555 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 12:48:39 +00:00
Jacques Le Roux 31080df097 Fixed: "Login and logout process in demos shows a certificate issue"
(OFBIZ-9206)

Also fixes "16.11 ofbizUrl include host+port and break some reverse-proxy/docker
 setups"
(OFBIZ-9224)

It was an easy fix, I just imported
<SystemProperty systemPropertyId="port.https" systemResourceId="url" 
systemPropertyValue=""/>
in trunk demo and all work perfectly.

I also tried to replace locally
port.https=8443
by
port.https=
in url.properties (w/o SystemProperty) and did not face any issue but with 
portOffset. This is due to the WebSiteProperties class works and there is also 
an easy fix: don't add twice the portOffset when it's build from the request, 
and only then. Keep it as is when it's build from a WebSite GenericValue. 
We then trust the user and don't rely on the request.

I also removed the deprecated RequestHandler.getDefaultServerRootUrl() 
I think it was time...

Thanks: Pierre Smits and Leonard Lin for reports

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784549 13f79535-47bb-0310-9956-ffa450edef68
2017-02-27 12:33:42 +00:00
Jacques Le Roux 97a98e7d4c No functional change, related with "Missing reference to the delegator in
framework/widget/templates/HtmlFormMacroLibrary.ftl"
(OFBIZ-9230)

To reproduce

1. Load test data <SystemProperty systemResourceId="widget" 
systemPropertyId="widget.autocompleter.defaultMinLength" 
systemPropertyValue="3"/> 
2. Open https://localhost:8443/partymgr/control/main
3. You will still get warning below in log file


|EntityUtilProperties          |I| Could not get a system property for 
widget.autocompleter.defaultMinLength : null


jleroux: the reason is in the context of a FTL macro we lose the delegator 
(in context) when calling  
executeMacro(writer, sr.toString()); 
from 
MacroFormRenderer.renderTextField()
So we need to find a way to pass the delegator to be used when evaluating 
the Freemarker template. For now I have simply added a clearer explanation 
of the reason.

Thanks: Wei Zhang for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784259 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 10:52:09 +00:00
Jacques Le Roux e99b90b591 No functional change, removes trailing blanks
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784253 13f79535-47bb-0310-9956-ffa450edef68
2017-02-24 10:23:45 +00:00
Jacques Le Roux 8f71170c4d No functional change, right indentation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1784100 13f79535-47bb-0310-9956-ffa450edef68
2017-02-23 09:38:11 +00:00
Taher A. Alkhateeb 5c7f27986d Improved: removed deprecated left shift from plugin template in build.gradle
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1783854 13f79535-47bb-0310-9956-ffa450edef68
2017-02-21 09:42:18 +00:00
Nicolas Malin 5be9a2f2ad Improved: Improve FindGeneric entity screen with xml form (OFBIZ-9217)
Replace the current groovy and ftl form rendering by a dynamic call to screen xml with build the xml form by analyse the entity
The find operation is now realize by the perfomFind service

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1783427 13f79535-47bb-0310-9956-ffa450edef68
2017-02-17 17:00:31 +00:00
Jacques Le Roux 49df69cdd6 No functional change, remove unused and failing EntityClassLoader
Relates with OFBIZ-6210

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1782943 13f79535-47bb-0310-9956-ffa450edef68
2017-02-14 09:57:00 +00:00
Jacques Le Roux f0b3ba7634 Fixed: Reinstate url cache in UtilURL.fromResource
(OFBIZ-9208)

Adrian created the following commit to cache URL objects 


Revision: 1649979
Author: adrianc
Date: 07 January 2015 00:24:28
Message:
Some optimizations for URL lookups.
----
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilProperties.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

and was later reverted in this commit

Revision: 1650347
Author: adrianc
Date: 08 January 2015 17:53:59
Message:
Some small fixups for some of my previous commits.
----
Modified : /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/util/EntityClassLoader.java
Modified : /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilURL.java

We have found in one of our production servers that line 98 in UtilURL.java

url = loader.getResource(resourceName);

has caused locking and looking at the stack trace (from jstack). There are 
numerous threads waiting on locks from within this method

I propose the cache gets added back (we have done this as a patch on our systems
 with no ill effect)

FYI - The commits are in reference to the EntityClassLoader which is not used 
and does not work see OFBIZ-6210

Thanks: Gareth Carter for report and suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782520 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 20:38:46 +00:00
Jacques Le Roux b9f2477708 Fixed: SimpleMethod: FindByAnd never using EntityListIterator
(OFBIZ-9152)

Since the introduction of EntityQuery there was no distinction between a simple 
method tags 
<find-by-and use-iterator="true"> and <find-by-and use-iterator="false"> 
(except cache handling).
There is a condition "if (useIterator)" but with entityQueries did use 
"[...].queryList()".

Thanks: Mirko Vogelsmeier

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1782498 13f79535-47bb-0310-9956-ffa450edef68
2017-02-10 18:46:04 +00:00
Jacques Le Roux 084c4fd9db No functional changes
completes r1781219 by putting svn:eol-style=native to all file types declared 
in [auto-props] section of the svn config files.css

Actually this is only a 1st pass, it was too complicated to do it for  
all file types at once only concerned here
*.java;*.bsh;*.groovy;*.jsp;*.tld;*.ftl;*.js;*.sql;*.c;*.cpp;*.h;*.txt;*.sgml;
*.properties;*.xml;.classpath;.project;*.sld;*.gml;*.xsl;*.xsd
*.html;*.htm;*.css;*.md;README;NOTICE;LICENSE;rc.ofbiz.*;*.less;*.dsp;*.dsw

Most files should not be concerned by this change, but it's impossible to do
it one by one.

There are also changes in files with have mixed EOLs; because this has no sense
when using native which automatically resolves this issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781731 13f79535-47bb-0310-9956-ffa450edef68
2017-02-05 11:09:59 +00:00
Jacques Le Roux b057011c26 No functional change, reverts r1781366
I did not even notice I committed this bunch of WIP stuff. I guess I clicked 
somewhere while my machine was too buzy

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781367 13f79535-47bb-0310-9956-ffa450edef68
2017-02-02 10:54:06 +00:00
Jacques Le Roux e130654d28 No functional change, this was reverted in r1781367
I did not even notice I committed this bunch of WIP stuff. I guess I clicked 
somewhere while my machine was too buzy



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1781366 13f79535-47bb-0310-9956-ffa450edef68
2017-02-02 10:33:59 +00:00