Commit Graph
444 Commits
Author SHA1 Message Date
Jacques Le Roux 9fa3dbe1ea Revert "Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk"
This reverts commit 0add8bedbc.
2020-04-05 10:04:15 +02:00
Jacques Le Roux 0add8bedbc Merge branch 'JacquesLeRoux-POC-for-CSRF-Token-OFBIZ-11306' into trunk
Because of GitHub message on PR56:
This branch cannot be rebased due to conflicts

Conflicts handled by hand
RequestHandler.java
2020-04-04 18:33:11 +02:00
Suraj Khurana d097d8ddba Fixed: UserLoginPasswordHistory is not maintaining password as present in UserLogin.
(OFBIZ-10802)
Thanks Rohit Koushal for the patch. Thanks Jacques Le Roux and Gil Portenseigne for the review.
2020-02-22 12:50:54 +05:30
Jacques Le Roux 218d5a07a2 Fixed: impersonateLogin
(OFBIZ-5409)

I reopended this old issue because, while working on  OFBIZ-11329, I found that
userLogin and impersonateLogin should be removed from
jsonResponseFromRequestAttributes

Thanks: James Yong for pointing that out
2020-02-04 15:43:21 +01:00
Nicolas Malin 19339021e0 Improved: Use website to generate links on email content
(OFBIZ-4361)
OFBiz contains a nice process to generate link through WebSite entity.
Unfortunately when you send an email, the standard service didn't propage the website 
to the body content email, so we can't use it.

This improvement is needed on forgot password process to resolve the correct uri 
and go back on good OFBiz component: where the user requested for a new password.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867961 13f79535-47bb-0310-9956-ffa450edef68
2019-10-04 07:33:05 +00:00
Nicolas Malin 4406d24877 Fixed: Any ecommerce user has the ability to reset anothers password
(including admin) via 'Forget Your Password'
(OFBIZ-4361)
Trunk backport r1866478 and r1866518

Currently, any user (via ecommerce 'Forget Your Password') has the ability to 
reset another users password, including 'admin' without permission.  
By simply entering 'admin' and clicking 'Email Password', the following is 
displayed:

The following occurred:
A new password has been created and sent to you. Please check your Email.

This now forces the user of the ERP to change their password.  
It is also possible to generate a dictionary attack against ofbiz because there 
is no capta code required.  This is serious security risk.

I have modified the patch following comments I made in the Jira, notably
  Removed unused Java variables
  Removed a check in LoginEvents::forgotPassword which prevented to show error
    messages
  Changed fr and en SecurityExtPasswordSentToYou 
    + SecurityExtThisEmailIsInResponseToYourRequestToHave labels 
    + template PasswordEmail.ftl
    + loginservices.token_incorrect labels
  Added fr and en SecurityExtIgnoreEmail + SecurityExtLinkOnce labels
  Removed changes in general.properties
  I did not remove the 2 GetSecurityQuestion.ftl files (webpos one was still in)

There is still room for improvement. I'll discuss them on the Jira and dev
ML. But this version is already strong enough to not wait that the patch is 
inapplicable!

Thanks: mz4wheeler (Mike Z) for the Jira, Nicolas Malin for the patch, I guess 
with some Gil's help, and all others for comments and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1867296 13f79535-47bb-0310-9956-ffa450edef68
2019-09-21 19:12:23 +00:00
Mathieu Lirzin 4fd92eea61 Fixed: Fix javadoc build for OpenJDK 11
(OFBIZ-10757)

This removes HTML5 deprecated stuff such as ‘<tt>’ elements, and
‘cellpadding’ table attributes which were breaking the ‘:javadoc’
Gradle task when using OpenJDK 11.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1859124 13f79535-47bb-0310-9956-ffa450edef68
2019-05-11 20:40:37 +00:00
Jacques Le Roux cbab9e6a45 "Applied fix from trunk for revision: 1857099"
------------------------------------------------------------------------
r1857099 | jleroux | 2019-04-08 11:17:55 +0200 (lun. 08 avr. 2019) | 12 lignes

Improved: Using try-with-resources with File IO Objects.
(OFBIZ-9855)

Uses try with resources for File IO objects like ObjectInputStream and other 
objects. File classes have the AutoCloseable interface.

jleroux: this is only a part of the 2nd patch. The 1st patch will be committed
soon too...

All tests pass

Thanks: Pradhan Yash Sharma
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1857486 13f79535-47bb-0310-9956-ffa450edef68
2019-04-13 17:50:10 +00:00
Jacques Le Roux 5792a6b13f "Applied fix from trunk for revision: 1856667 "
------------------------------------------------------------------------
r1856667 | jleroux | 2019-03-31 11:14:16 +0200 (dim. 31 mars 2019) | 10 lignes

Fixed: EmailServices.sendMail causes a NPE, when sendFrom is missing
(OFBIZ-10706)

I tried to find the history for why the service does not take the 
defaultFromEmailAddress property from general.properties and I found that It was 
last modified in revision r418498 on 02/07/2006, I think it was always broken.

This uses defaultFromEmailAddress property in sendMail if sendFrom is missing

Thanks: Benjanmin Jugl reported, Pawan Verma fixed and others for discussion
------------------------------------------------------------------------


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release18.12@1856668 13f79535-47bb-0310-9956-ffa450edef68
2019-03-31 09:16:51 +00:00
Jacques Le Roux bbfc62d47a Improved: Fix or Silence various warnings
(OFBIZ-10701)

In order to detect potential issues early, the linting compiler option should be 
used by default and disabled with {{./gradlew -PXlint:none build}}.

Additionally it is important to reduce the number of warnings otherwise new 
warnings will remain unnoticed.

The warning related to the com.googlecode.concurrentlinkedhashmap dependency 
should resolves itself once we handle upgrade to Caffeine like proposed in 
OFBIZ-6747.

Thanks: Mathieu Lirzin

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1848673 13f79535-47bb-0310-9956-ffa450edef68
2018-12-11 13:33:49 +00:00
Jacques Le Roux 102dd5d242 Fixed: Correct behaviour of Autologin cookies
(OFBIZ-10635)

Renames "keep-autologin-cookie" to "use-autologin-cookie", and only create 
Autologin cookies when needed. No need to create Autologin cookies in 
applications that don't need it.

Don't pass webAppName to LoginWorker::getSecuredUserLoginId, that can be handled
with improved LoginWorker::getSecuredLoginIdCookieName

Removes LoginWorker::autoLogoutCleanCookies, no longer needed since only those
needed are created and kept (1 year at least after creation).

For both autoLogin and securedLoginId cookies sets the path to the application.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1845558 13f79535-47bb-0310-9956-ffa450edef68
2018-11-02 09:46:42 +00:00
Jacques Le Roux fbfa0daa5a Implemented: Navigate from a domain to another with automated signed in
authentication
(OFBIZ-10307)

This uses a JWT Token authentication to get from one domain, where you are 
signed in, to another domain where you get signed in automatically. 
Something like ExternalLoginKey or Tomcat SSO, but not on the same domain.

In the example component, the FormWidgetExamples screen contains 2 new fields 
in the LinksExampleForm which demonstrate the use from a local instance to the
trunk demo instance.

A simple documentation is available in 
  framework\webapp\src\docs\asciidoc\_include\wa-cross-domains-SSO.adoc

Thanks: Taher for review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1844880 13f79535-47bb-0310-9956-ffa450edef68
2018-10-26 09:32:46 +00:00
Gil Portenseigne a61c98775f Implemented : Impersonation of userLogin feature
(OFBIZ-10515)

Introduce a new feature that allow the impersonation of a login by an authorized user.
Add the documentation with all the details in security-impersonation.adoc.
Big thanks to Leila, Nicolas and Jacques for your contribution to this implementation.
Big thanks to Mathieu, Jacques, Pierre and Taher for your remarks and reviews that
improved this contribution quality. 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1842110 13f79535-47bb-0310-9956-ffa450edef68
2018-09-27 16:01:35 +00:00
Suraj Khurana 84f99c8cbd Improved: Modified QRCodeServices.java and used EntityUtilProperties. Removed unused data variables and used them directly inside the service.
(OFBIZ-7037)
Thanks everyone for your suggestions and review.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1840564 13f79535-47bb-0310-9956-ffa450edef68
2018-09-11 13:30:10 +00:00
Shi Jinghai c9f5a346ec Implemented: Remove org.apache.tomcat.util.net.secure_protocol_version from json output
OFBIZ-10443

Add org.apache.tomcat.util.net.secure_protocol_version to ignoreAttrs.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1838080 13f79535-47bb-0310-9956-ffa450edef68
2018-08-15 11:40:19 +00:00
Gil Portenseigne 266b63ac12 Fixed: Initial set of hasLoggedOut flag when logging in
(OFBIZ-10506)

Thanks Dennis for your patch

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837584 13f79535-47bb-0310-9956-ffa450edef68
2018-08-07 09:34:53 +00:00
Gil Portenseigne ceea6ce791 Improved : Remove all unnecessary boxing and unboxing in Java classes
(OFBIZ-10504)

Thanks Taher, Jacques, Mathieu and Rishi for the review

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1837577 13f79535-47bb-0310-9956-ffa450edef68
2018-08-07 07:30:43 +00:00
Gil Portenseigne f428a7e803 Fixed: GetLocaleList call can provide duplicate results
(OFBIZ-10458)

A new Junit test is implemented to validate that no duplicates are present.
Groovy service has been refactored to use a more functional style

Thanks Mathieu Lirzin for reporting and providing the patch


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1835282 13f79535-47bb-0310-9956-ffa450edef68
2018-07-06 21:10:07 +00:00
Jacques Le Roux bdd946d0e8 Improved: Remove unused code in CommonEvents::setFollowerPage
(OFBIZ-10413)

`CommonEvents::setFollowerPage` contains two unused variable definitions.  
After basic search I found that this request handler is used only in 
`webapp/partymgr/controller.xml` 
However I was unable to understand its purpose, so I have added a comment to add
 some kind of docstring.

jleroux: this event method is never used because the pushPage request map is 
also never used. So we can get rid of the whole.
At the same time, fixes a typo in comment an remove an useless import

Thanks: Mathieu Lirzin for initial reporting

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1833505 13f79535-47bb-0310-9956-ffa450edef68
2018-06-14 13:18:49 +00:00
Michael Brohl 0cb4f4af16 Improved: Extend updatePassword service API with optional parameter
requirePasswordChange.
(OFBIZ-10201)

Thanks Martin Becker for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826678 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 20:10:31 +00:00
Michael Brohl 02c37dc314 Fixed: EmailServices.sendMailFromScreen attachment rendering broken.
(OFBIZ-10246)

Thanks Martin for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1826674 13f79535-47bb-0310-9956-ffa450edef68
2018-03-13 19:46:28 +00:00
Gil Portenseigne 65fe235f51 Implemented: Add the ability in performFind service to set OR search criteria
(OFBIZ-10195)

This improvement add a way to specify a condition-group attribute on search fields, for performFind service usage.
The same group conditions are gathered with AND operator, and each group is added with a OR
The resulting condition is added to the other with AND operator.
Thanks Taher for your reviews and ideas

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1825350 13f79535-47bb-0310-9956-ffa450edef68
2018-02-26 09:57:36 +00:00
Jacques Le Roux 0940288cba Fixed: rename the common-theme component directory
(OFBIZ-10175)

Some of the remnants were still left. I got stuck with 
JsLanguageFileMappingCreator, so changed other left outs too.

This also fixes OFBIZ-10113  - Replace Asm select plugin with Select2.

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1823826 13f79535-47bb-0310-9956-ffa450edef68
2018-02-11 09:46:53 +00:00
Rishi Solanki 7d29cd1888 Implemented: Add ability to record Return Communication. Added support to record communication event against return. Added new entity CommunicationEventReturn, crund and supporting screens. Also added support in the existing email services to handle the return cases.
(OFBIZ-9911)
Thanks to Ratnesh Upadhyay for your contribution.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821486 13f79535-47bb-0310-9956-ffa450edef68
2018-01-18 11:34:01 +00:00
Jacques Le Roux 19d9b3ca30 Improved: Replace Asm select plugin with Select2.
(OFBIZ-10113)

Current Asm Select Plugin 
http://www.ryancramer.com/journal/entries/asmselect_v104/
can be replaced with Select2 (https://select2.org/).

* Select2 has much better community support on GitHub with 386 contributors 
  while Asm Select Plugin is handled by Ryan Cramer on http://www.ryancramer.com/.
* Select2 has 37 releases while Asm select has very few releases yet.
* Both the plugin has MIT license.

Refer https://select2.org/ and  
https://github.com/select2/select2 for more features and other information.

Added i18n support so added logic in JsLanguageFileMappingCreator and 
JsLanguageFilesMapping accordingly.
Added some custom CSS as the Select2 seems to be too fancy in accordance 
with the current OFBiz themes

Verify:
Multiple drop-downs field in FormWidgetExamples.
https://localhost:8443/example/control/FormWidgetExamples

Find Request page with StatusId , CustRequestId
https://localhost:8443/ordermgr/control/FindRequest

I have replaced the plugins though I feel the implementation of select multiple 
js code is to be reviewed & refactored. I will pick when I am done with all my 
current tasks if I get some consensus.

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1821001 13f79535-47bb-0310-9956-ffa450edef68
2018-01-12 15:47:47 +00:00
James Yong ba2e822f27 Implemented: Tomcat SSO
(OFBIZ-10047)

This allow developers the option to use Tomcat SSO, instead of externalLoginKey, for SSO.

Thanks: Jacques and Michael for the reviews

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819133 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 10:39:44 +00:00
Deepak Dixit fb77a3c477 Improved: Logging: change all System.out/.err/.. println to Debug.log... in the code base (OFBIZ-10045)
Thanks Michael Brohl and Kyra Pritzel-Hentley for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1819124 13f79535-47bb-0310-9956-ffa450edef68
2017-12-23 09:08:04 +00:00
Jacques Le Roux 35ee954560 Completed: Remove applet concept in OFBiz
(OFBIZ-10094)

Following discussion at http://markmail.org/message/dlp4zoo3xxuiefpn :

While reviewing http://svn.apache.org/viewvc?view=revision&revision=1811438 
I stumbled upon the usage of Java Applets

It's still possible to use Java Applets in browsers but most of the time it's 
not OOTB https://www.digitalcitizen.life/how-enable-java-all-major-web-browsers

And Java 9 deprecates it https://www.java.com/en/download/faq/jdk9_plugin.xml


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818646 13f79535-47bb-0310-9956-ffa450edef68
2017-12-19 10:33:15 +00:00
Michael Brohl b932ce362a Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.login.
(OFBIZ-9880)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818567 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 13:45:13 +00:00
Michael Brohl 6329196e14 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.email.
(OFBIZ-9876)

Thanks Julian Leichert for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818557 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 12:21:16 +00:00
Michael Brohl dcf4ab8ef6 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.image.
(OFBIZ-9878)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818556 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 12:01:53 +00:00
Michael Brohl 5bfe284067 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.qrcode.
(OFBIZ-9883)

Thanks Julian Leichert for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818551 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:52:13 +00:00
Michael Brohl 1d75c7f50c Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.preferences.
(OFBIZ-9927)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818548 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 10:16:05 +00:00
Michael Brohl 4f85d01d72 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.
(OFBIZ-9930)

Thanks Dennis Balkir for reporting and providing the patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818544 13f79535-47bb-0310-9956-ffa450edef68
2017-12-18 09:51:44 +00:00
Michael Brohl fe66233dc4 Improved: No functional change, removed obsolete import.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818466 13f79535-47bb-0310-9956-ffa450edef68
2017-12-17 09:41:58 +00:00
Jacques Le Roux e0d2057456 Improved: Always check if debug verbose is on when using Debug.logVerbose()
(OFBIZ-10052)

We discussed on this point: http://markmail.org/message/mplvusuqn7oshl4v 
and we agreed about better doing a check when using Debug.logVerbose().

I checked there are 300+ cases like that. Since it's an easy S/R 
This implements it

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818005 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:43:05 +00:00
Deepak Dixit 7e19de9966 Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1818003 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 12:03:17 +00:00
Deepak Dixit 63258e90f8 Reverted r#1817989, workign fine locally, reverted for now will check and commit again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817998 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 10:42:32 +00:00
Deepak Dixit d1f85a7e5d Improved: Replace all delegator findByAnd and findOne method calling by EntityQuery methods (OFBIZ-10029)
Applied slightly modified patch, rearrange import properly, 
Thanks Suraj Khurana for your contribution

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817989 13f79535-47bb-0310-9956-ffa450edef68
2017-12-13 09:21:33 +00:00
Michael Brohl bf6310c5e4 Improved: General refactoring and code improvements, package
org.apache.ofbiz.common.authentication.
(OFBIZ-9875)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817751 13f79535-47bb-0310-9956-ffa450edef68
2017-12-11 08:10:16 +00:00
Jacques Le Roux 48a2f6dc8b Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While reviewing recent Michael's FB commits I spotted a bunch of (unrelated) 
swallowed exceptions. This fixes them

Also few formatting and use of multi catches



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817703 13f79535-47bb-0310-9956-ffa450edef68
2017-12-10 12:00:07 +00:00
Jacques Le Roux cac7d76cba Implemented: Handle service response effectively
(OFBIZ-9981)
Included Debug.logError in ServiceUtil.returnProblem so that in case of any 
error occurred and handled, it will always be logged on the console.
jleroux: I put a toString() there, Debug.logError() does not work with maps

Also no functional change (better code) in QRCodeEvents
jleroux: I also replaced tabs by spaces there 
            and put debug info in exceptions

Thanks: Suraj Khurana

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817455 13f79535-47bb-0310-9956-ffa450edef68
2017-12-08 05:04:23 +00:00
Jacques Le Roux 8021fd3717 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Includes following changes
jQuery UI upgraded to 1.12.1
Included CSS files to theme properties and screens.

Manually added datepicker-en.js and datepicker-it-CH.js a new candidate added 
it to jsLanguageFilesMapping
Updated defaultDateTime path of dateTime picker it was having path of 
timepicker files.

I18n files for datepicker renamed from jquery.ui.datepicker- to datepicker- 
as comes with the JQuery ui package so that we don’t have to rename files 
manually everytime we upgrade.
https://github.com/jquery/jquery-ui/tree/master/ui/i18n
Can’t get jquery-ui-i18n.js file though it was not used either.

I have not updated jQuery.cookie-1.4.0.js as it is related to jstree and we will 
update & move it when we will update jstree.

Jeditable 1.7.2 upgraded to 1.7.3

I feel JQuery ui should also be in plugins folder with other JQuery plugin

Thanks: Aditya

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1817026 13f79535-47bb-0310-9956-ffa450edef68
2017-12-03 10:15:55 +00:00
Jacques Le Roux b7127e1ed2 Improved: Upgrade Jquery 1.11.0 to JQuery 3.2.1
(OFBIZ-9978)

Upgrades jQuery Timepicker Addon to 1.6.3 
https://github.com/trentrichardson/jQuery-Timepicker-Addon/
 jQuery UI Slider Access comes with JQuery Timepicker addon package.
 Moved localization to i18n (as comes with package) & made changes accordingly
 Working well with even jQuery UI 1.10.

Steps to verify:
https://localhost:8443/ordermgr/control/ListQuoteRoles?quoteId=CQ0001
https://localhost:8443/example/control/FormWidgetExamples
https://localhost:8443/catalog/control/EditProduct

Interestingly it supports Millisecond, Microsecond and Time Zone too.

jleroux: as required with such changes I ran the createJsLanguageFileMapping 
service to create or update the JsLanguageFilesMapping class content (this is
documented in JsLanguageFileMappingCreator class
We got some new ones:
-fa.js
-lv.js
-mk.js
-sl.js
-sq.js
but lost CZ (not quite sure about that one, I vaguely remember something we
discussed with Aditya )

Thanks: Aditya 

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1816377 13f79535-47bb-0310-9956-ffa450edef68
2017-11-26 10:18:36 +00:00
Jacques Le Roux c1a11e83ae Fixed: Fix Default or Empty Catch block in Java and Groovy files
(OFBIZ-8341)

While reviewing r1812057 I spotted a bunch of swallowed ClassCastExceptions

I then reviewed all ClassCastExceptions and this fixes all of them with a 
minimal logging

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815797 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 12:32:44 +00:00
Jacques Le Roux 3933ba15c0 No functional change, fixes typos and formatting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1815774 13f79535-47bb-0310-9956-ffa450edef68
2017-11-20 07:34:07 +00:00
Michael Brohl ee46dbb019 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.
(OFBIZ-9681)

Thanks Julian Leichert for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811438 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 15:47:59 +00:00
Michael Brohl cf3081a277 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.preferences.
(OFBIZ-9640)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811433 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:51:43 +00:00
Michael Brohl a7beb48720 Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.uom.
(OFBIZ-9634)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811428 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:12:51 +00:00
Michael Brohl 2a66a06aef Improved: Fixing defects reported by FindBugs, package
org.apache.ofbiz.common.qrcode.
(OFBIZ-9633)

Thanks Dennis Balkir for reporting and providing the patch.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/trunk@1811427 13f79535-47bb-0310-9956-ffa450edef68
2017-10-07 14:10:50 +00:00