Commit Graph
2896 Commits
Author SHA1 Message Date
David E. Jones 574d610ccf Small update to use OWASP ESAPI Encoder instead of java.net.URLEncoder for parameter strings
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741496 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:40:37 +00:00
Jacques Le Roux e0a2cd1428 A proposed change by Marco, Xerces complains but it's the easier solution for the Label Manager
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741495 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:38:12 +00:00
David E. Jones e0555f78d5 Fixed bug in new RequestHandler related to view override in the URL for a request with no event; addresses issue with entityref reported by Hans
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741494 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:37:41 +00:00
Jacques Le Roux 963f02faed Close https://issues.apache.org/jira/browse/OFBIZ-2168 - OFBIZ-2168
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741491 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:30:09 +00:00
Jacopo Cappellato 1dd37d9873 Removed reference in comment to Jetty container.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741482 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:15:43 +00:00
David E. Jones 57dcf34bcd Some refactoring of canonicalize feature, also change ServiceEventHandler to use UtilHttp stuff for parameters so this and other things take effect there
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741478 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:05:50 +00:00
David E. Jones 71a1ed6b95 All incoming parameters used through these parameter maps (which should be, but currently isn't, all use of parameters) will now go through the ESAPI canonicalize process
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741466 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 08:20:58 +00:00
David E. Jones 0b2e7e05c5 Added owasp esapi library, uses of it soon to come
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741442 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 07:02:59 +00:00
Hans Bakker 9ea7eebcc0 make example dashboard working again with the recent portal page changes and removed fulladmin pages from myportal because not required
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741439 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:59:53 +00:00
Hans Bakker 2638cce966 relation name too long
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741428 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:17:30 +00:00
David E. Jones 4d9382e887 Cleanup and pretty-up a bunch of log statements; moved some less helpful ones to verbose, combined some, and generally tried to make logs in various places more user friendly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741424 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:04:58 +00:00
David E. Jones da0f617961 Small change to make use-cache easier to parameterize; since cache conflicts with the iterator, have the use-cache setting override the use-iterator setting
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741396 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 04:18:20 +00:00
David E. Jones 7fdd5220cf Moved Help link from tab bar to the link section below it as the Help page was NOT a tab, or in other words by clicking on it you go to a screen outside fo the tab set and the tabs disappear
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741381 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 02:32:10 +00:00
David E. Jones afe3dc9c81 A few related changes:
Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.

Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.

Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.

To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741374 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 02:14:19 +00:00
Hans Bakker 077bd4641a the myportal component is functionally complete now having also different page sets for different securitygroups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741129 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 15:18:47 +00:00
Jacopo Cappellato 358b545a97 Fix to avoid the test to fail after recent change to "system" seed data.
By the way: is it correct to have a test rely on demo data like this one?


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741119 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 15:01:34 +00:00
Jacques Le Roux e026b40f9b More explicit labels for now but this needs to be generalized in form widget
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741063 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 10:26:35 +00:00
Bilgin Ismet Ibryam e7cd2e3bd0 Changed Double parameters to BigDecimal in convertUom and convertUomCustom services.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741049 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 08:52:24 +00:00
Jacques Le Roux 2b412a62c4 Better French translation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741041 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 08:03:01 +00:00
David E. Jones 4bd8c4399b Added XSD catalog file for webapp component, like exists in other components
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740697 13f79535-47bb-0310-9956-ffa450edef68
2009-02-04 11:10:46 +00:00
Jacques Le Roux 5c95acc38d Thanks to Labels Manager the French translation is now complete
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740338 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 16:24:30 +00:00
Jacques Le Roux 345d64b204 A patch from Bruno Busco " Moving Timestamp to footer" '(https://issues.apache.org/jira/browse/OFBIZ-2164) - OFBIZ-2164
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740299 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 13:21:30 +00:00
Bruno Busco 10a0feba88 Added ExpandAll function in javascript. This allows to expand or collapse all fieldgroups present in a page.
An example on how to use is present in the CommonProductDecorator
TODO: does not work on IE

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740296 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 13:12:49 +00:00
Jacopo Cappellato f46ea50361 Fixed wrong pref group type id.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740249 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 09:07:00 +00:00
Jacques Le Roux 2d295a8641 Marco's artifact_cleaning_framework.patch " Artifact cleaning after recent changes on xsd files" (https://issues.apache.org/jira/browse/OFBIZ-2137) - OFBIZ-2137
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740114 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 21:40:50 +00:00
Jacques Le Roux 5abb9596cb LabelsInfo14.patch from Marco "New tool to get labels information" (https://issues.apache.org/jira/browse/OFBIZ-2070) - OFBIZ-2070
+ some correct changes done with this update of Labels Manager (I updated some wrong ones by hand to keep going forward...)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739955 13f79535-47bb-0310-9956-ffa450edef68
2009-02-02 10:17:34 +00:00
Jacopo Cappellato e1b1c85e1e Added two new methods to the ViewHandler interface: getter/setter methods for the "name" field, used to store the name of the view handler as set in the controller.xml file.
No functional change, but this mode is required by the upcoming new screen renderer based on Freemarker macros.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739792 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 17:12:19 +00:00
Jacopo Cappellato f9572816da Fixed typo in a comment.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739790 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 17:00:13 +00:00
Adrian Crum 2d25c4e591 Fixed a bug where the property name wasn't being returned when the property wasn't found - reported on dev mailing list.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739786 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 16:55:09 +00:00
Jacopo Cappellato 4eeaa929bb Modified two FreeMarkerWorker methods to return the Environment object; no functional change, but this mode is required by the upcoming new screen renderer based on Freemarker macros.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739785 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 16:54:53 +00:00
Jacopo Cappellato 900ddd63cf Added ability to define entity-data-readers on the fly.
For example, if in a custom ofbiz-component.xml file you have:

<entity-resource type="data" reader-name="prod1" loader="main" location="data/ProdData1.xml"/>

you can load it running the ant task:

ant run-install-readers -Ddata-readers=prod1

even if the reader is not defined in entityengine.xml.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739782 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 16:43:05 +00:00
Jacques Le Roux 2eeaa25b8d <if-compare field-name= => <if-compare field=
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739769 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 14:13:19 +00:00
Jacques Le Roux aa1259c96e Another time caught by Eclipse (editing a file while replacing strings in other files)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739766 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 14:05:29 +00:00
Jacques Le Roux 5d9fd471dc <field-map(.*)env-name => <field-map$1from-field
<service(.*)result-map-name => <service$1result-map

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739764 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 13:54:08 +00:00
Jacopo Cappellato 98e71f1922 Misc cleanups for data files:
1) added {SHA} prefix to all hashed passwords
2) moved "admin" user to demo data; the only user maintained with seed data is now the "system" user
3) removed password for the "system" user; now there are no passwords in seed data



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739743 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 11:40:55 +00:00
Jacques Le Roux fb9d3a2e18 <entity-condition(.*) list-name= => <entity-condition$1 list=
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739740 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 11:08:49 +00:00
Jacques Le Roux 08915956a1 <if-empty field-name= => <if-empty field=
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739739 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 11:07:47 +00:00
Jacopo Cappellato af9e2ab62d Enhanced checkNewPassword to work like the "userLogin" method when dealing with hashed passwords.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739738 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 11:02:46 +00:00
Jacques Le Roux 290534059d <entity-one entity-name=(.*)value-name => <entity-one entity-name=$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739732 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 10:27:43 +00:00
Bruno Busco c4d9922812 Removed Login and Logout menu item from FTL based app-navigation menus. (Moved now to the header).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739724 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 09:58:36 +00:00
Jacques Le Roux 81fd022764 LabelsInfo15.patch from (https://issues.apache.org/jira/browse/OFBIZ-2070) - OFBIZ-2070
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739720 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 09:21:32 +00:00
Scott Gray c152c76dd6 Fix for issue OFBIZ-2142 reported by Hans Bakker: " error message of login service does not show with common/messages.ftl
"
The labels had been moved to a different resource file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739651 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 23:15:01 +00:00
Jacques Le Roux 6b08a4dfaa A patch from Bruno Busco "Removing Login/Logout from AppBarMenu" '(https://issues.apache.org/jira/browse/OFBIZ-2156) - OFBIZ-2156
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739594 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 19:58:33 +00:00
Jacques Le Roux 5a27bd50ad Reverted on Jacopo's advice
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739574 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 16:22:41 +00:00
Jacques Le Roux 80d35cda90 Make easier to see demonstration
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739568 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 14:57:28 +00:00
Bruno Busco 6ac6c68719 Reverted rev. 739406
Actually the issue reported should be solved changing any custom AppMenu markup structure (see Example for a markup template)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739523 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 08:30:48 +00:00
Jacques Le Roux 9ca39359a9 i18n, French l10n
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739409 13f79535-47bb-0310-9956-ffa450edef68
2009-01-30 21:06:22 +00:00
Jacques Le Roux c6113c578a A patch from Stephen Rufle "app-navigation style change breaks" '(https://issues.apache.org/jira/browse/OFBIZ-2153) - OFBIZ-2153
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739406 13f79535-47bb-0310-9956-ffa450edef68
2009-01-30 20:49:19 +00:00
Jacques Le Roux 12fd67fe8c Enhancement from Karim Rahimpur
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739219 13f79535-47bb-0310-9956-ffa450edef68
2009-01-30 09:26:21 +00:00
Hans Bakker 40f67a85d4 another error message improvement on the form type which can be confused with a service attribute type
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739195 13f79535-47bb-0310-9956-ffa450edef68
2009-01-30 07:02:59 +00:00