Commit Graph
2896 Commits
Author SHA1 Message Date
Adam Heath 25355eef63 Switch from LinkedMap to LinkedHashMap. Closes
https://issues.apache.org/jira/browse/OFBIZ-1334


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585641 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 19:42:06 +00:00
Adam Heath d3172979ca Use FastMap instead of HashMap. Closes
https://issues.apache.org/jira/browse/OFBIZ-1325


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585614 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 18:11:41 +00:00
Adam Heath 394a9508da Java 1.5 markup. Closes https://issues.apache.org/jira/browse/OFBIZ-1312
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585613 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 18:09:32 +00:00
Adam Heath bf5df1cc51 Use System.arraycopy to copy the loaderArgs array. Closes
https://issues.apache.org/jira/browse/OFBIZ-1309


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585612 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 18:07:29 +00:00
Adam Heath 9892eec19e Implement tri-state status management. The server status can now be
"Starting", "Running", or "Stopped".  I didn't implement "Stopping",
because it never was a problem for me.  Closes
https://issues.apache.org/jira/browse/OFBIZ-1297


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585607 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:56:23 +00:00
Adam Heath 478512ead6 Start the listener thread as soon as possible, so that the startup
status can be queried.  Before, it would be started very late in the
process, so it wasn't possible to see if java/ofbiz was actually
running.  Closes https://issues.apache.org/jira/browse/OFBIZ-1293


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585605 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:52:44 +00:00
Adam Heath 7ca8f182a6 Switch toString to StringBuilder, from StringBuffer. Closes
https://issues.apache.org/jira/browse/OFBIZ-1311


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585602 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:49:08 +00:00
Adam Heath 4e3a18d10a Use StringBuilder instead of string addition. Closes
https://issues.apache.org/jira/browse/OFBIZ-1339


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585600 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:47:11 +00:00
Adam Heath 1bf01bff57 Use ?: trinary for looking up NumberFormats. Closes
https://issues.apache.org/jira/browse/OFBIZ-1340


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585597 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:45:11 +00:00
Adam Heath c38212a6c3 Use Number.valueOf instead of new Number in simpleTypeConvert.
Closes https://issues.apache.org/jira/browse/OFBIZ-1337


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585596 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:40:55 +00:00
Adam Heath bcb983355d Make indexString use it's index variable(i), instead of always
using 0.  Closes: https://issues.apache.org/jira/browse/OFBIZ-1338


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585594 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:37:24 +00:00
Adam Heath 7197b591b8 Make addComponent(String) call addComponent(File). Closes
https://issues.apache.org/jira/browse/OFBIZ-1310


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585590 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:34:48 +00:00
Adam Heath cea96fee92 In simpleTypeConvert, where ever there was an if block that returned
TRUE/FALSE, they are now inlined, using ?:.  Closes
https://issues.apache.org/jira/browse/OFBIZ-1336,


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585589 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:32:47 +00:00
Adam Heath 3a0a201c34 Add internString(), which protects against NPE. Closes
https://issues.apache.org/jira/browse/OFBIZ-1307.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585578 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 17:12:17 +00:00
Adam Heath ddbcbed6d1 Remove was returning the *new* object, instead of the *old*. Closes
https://issues.apache.org/jira/browse/OFBIZ-1322.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585571 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 16:50:03 +00:00
Adam Heath 80398ba47a Don't use string addition in getMessage(), use a StringBuilder
instead.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585567 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 16:41:32 +00:00
Adam Heath fa3a837161 Implement the 2 other write variants, so that block-writing is
more efficient.  Closes https://issues.apache.org/jira/browse/OFBIZ-1323


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585557 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 16:26:45 +00:00
Adam Heath 69335961ab When sending a command to a running ofbiz instance, and waiting for
the response from the server, the socket is not ready; explicitly
checking for that will always fail.  This was the cause of the 'null'
messages during shutdown.  Applied patch from
 https://issues.apache.org/jira/browse/OFBIZ-1282 to fix the issue.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585526 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 14:53:07 +00:00
Adam Heath 1051352f0f Make all paths in these files relative; they no longer include
${ofbiz.home}.  Closes:
https://issues.apache.org/jira/browse/OFBIZ-1290.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585525 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 14:45:26 +00:00
Adam Heath 60d06ecee8 toString() would always append the first classpath element, for each
element in it's list; in other words, it wasn't using the loop index
variable i, but was using the constant 0 each time.  Closes:
https://issues.apache.org/jira/browse/OFBIZ-1308.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585523 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 14:39:12 +00:00
Adam Heath e481905579 getKeyFromMemory() wasn't incrementing currentIdx during the loop;
this means it would only ever be able to return the first key from
memory.  Resolves https://issues.apache.org/jira/browse/OFBIZ-1298.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585522 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 14:33:34 +00:00
Adam Heath bca4f0d9cf If a path in ofbiz-component.xml is not absolute, try to load the
sub-files relative to the location of the ofbiz-component.xml file.
This is from https://issues.apache.org/jira/browse/OFBIZ-1280.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585518 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 14:26:43 +00:00
Jacopo Cappellato e4723bd5b8 Fixed incorrect logic, introduced in rev. 584400, that was causing a problem in the main application bar: all the applications were visible to a user with the OFBTOOLS permission.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585432 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 10:00:52 +00:00
Jacopo Cappellato 449a91b728 Geo data for India. This is a modified version of the patch submitted by Vikash Anand in OFBIZ-1040
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585403 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 08:06:42 +00:00
Jacopo Cappellato adfb93a6e2 Removed duplicated quote; thanks to Bilgin Ibryam for the patch OFBIZ-1344
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585399 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 06:57:43 +00:00
Jacopo Cappellato e98a175f77 Applied patch from Adrian Crum to enhance support for RTL languages: if the user has selected an rtl language, then the rtl style sheet will be cascaded. OFBIZ-998
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585398 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 06:46:56 +00:00
Jacopo Cappellato e55d92e07a Now the Webtools application reuses the login screens defined in the common component.
Part of OFBIZ-1320


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585396 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 06:36:18 +00:00
Jacopo Cappellato 89f3fd0098 Applied patch from Adrian Crum as a first pass to share the same common login screens in all the applications.
OFBIZ-1320


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585393 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 06:24:17 +00:00
Jacopo Cappellato 3687738738 Small cleanups by Adrian Crum OFBIZ-902
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585389 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 06:12:49 +00:00
Adam Heath 201dca4f1e Update ofbiz.jar at the top-level whenever framework/base is built.
Also, clean said file at the same time.  Based on patch from
https://issues.apache.org/jira/browse/OFBIZ-1283.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585267 13f79535-47bb-0310-9956-ffa450edef68
2007-10-16 21:31:21 +00:00
Jacopo Cappellato 1f81945758 in view definitions, group-by fields that are not in the select clause are not added to the group by section.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585051 13f79535-47bb-0310-9956-ffa450edef68
2007-10-16 06:04:29 +00:00
Jacopo Cappellato a188d85806 First version/poc (proof of concept) for an integrated framework for business intelligence in OFBiz.
For now everything is in a separate specialpurpose component to facilitate the community review but as soon as everything will be consolidated the component will probably disappear (absorbed by the existing framework/applications components).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584727 13f79535-47bb-0310-9956-ffa450edef68
2007-10-15 10:55:07 +00:00
Jacopo Cappellato 24724bfa46 Added 'description' field and accessor methods to the ModelField and ModelViewEntity.ModelAlias classes to store the field level description specified in the entity definition (<description></description> tags).
Added new optional attributes to the alias-all element: function and group-by. If specified then to all the aliased fields the function and/or group-by element will be applied.
In ModelViewEntity, added new method to get the list of group-by fields as a subset of the passed in list: this is useful to get the list of group-by fields limited to the felds that are in the select clause.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584700 13f79535-47bb-0310-9956-ffa450edef68
2007-10-15 07:28:48 +00:00
Jacques Le Roux 9b2976071c A forgotten patch from Joe Eckard (sorry Joe) "Typo in RequestHandler.java" (https://issues.apache.org/jira/browse/OFBIZ-597) OFBIZ-597
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584697 13f79535-47bb-0310-9956-ffa450edef68
2007-10-15 06:51:12 +00:00
Adrian Crum d1347f62f9 Small fixes to the main CSS style sheet.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584418 13f79535-47bb-0310-9956-ffa450edef68
2007-10-13 15:55:24 +00:00
Jacques Le Roux 4f33d28293 A patch from Adrian Crum "Main navigation won't display links for apps when user has only _ADMIN permission" (https://issues.apache.org/jira/browse/OFBIZ-1241) - OFBIZ-1241
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584400 13f79535-47bb-0310-9956-ffa450edef68
2007-10-13 13:37:01 +00:00
Jacques Le Roux 6404f9a8b1 A patch from Adrian Crum "Improved Common Permission Checking Simple Method & Messages" (https://issues.apache.org/jira/browse/OFBIZ-1246)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@584399 13f79535-47bb-0310-9956-ffa450edef68
2007-10-13 13:35:05 +00:00
Jacopo Cappellato f0abf80501 In the 'convertUom' service the 'convertedValue' output parameter is now optional: if no converion is available, then null is returned, not an error (and a rollback etc...).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@583384 13f79535-47bb-0310-9956-ffa450edef68
2007-10-10 08:12:07 +00:00
Jacopo Cappellato 79422be8d1 Issue OFBIZ-668
1) replaced the logic inside the isEmail method with a call to org.apache.commons.validator.EmailValidator.isValid(...)
2) I've left the code that returns true if the string is empty
3) the only remarkable difference is that the original code was accepting (by default) a domain without dots (user@localhost); the new code requires a real domain (user@domain.com)

Thanks to John Martin for the advices.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@583373 13f79535-47bb-0310-9956-ffa450edef68
2007-10-10 07:19:10 +00:00
Jacopo Cappellato fefd8ae37e Added support for default-value attribute to the set operation in form widget actions.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@583366 13f79535-47bb-0310-9956-ffa450edef68
2007-10-10 06:34:13 +00:00
Jacopo Cappellato ae24b42ad7 Added ability to specify an event/action pairs on an hyperlink field.
Added escape code for input text fields.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@583091 13f79535-47bb-0310-9956-ffa450edef68
2007-10-09 10:17:22 +00:00
Jacques Le Roux d971f0ffec Complete my previous post (I had to change instance because of not related existing changes in controller.xml files)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582731 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 07:08:34 +00:00
Jacques Le Roux 41fe719fb6 To allow to deal with last column empty in CSV files
To allow to render an empty string when null

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582730 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 06:58:49 +00:00
Jacques Le Roux b8a32ab469 To allow to deal with problems in some DOS file, specifically file extracted from zip archives.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582723 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 06:40:05 +00:00
Jacques Le Roux b5a7d153c6 Changed name as suggested by Adrian and David in OFBIZ-1230
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582717 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 06:25:12 +00:00
Andrew Zeneski 08362be9c0 implemented code to support pre-account email verification (verify email before account is created)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582705 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 03:48:24 +00:00
Adrian Crum 4503af892a Step two of OFBIZ-1230. Reduced redundant code by including common-requests.xml in each component's controller.xml file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582517 13f79535-47bb-0310-9956-ffa450edef68
2007-10-06 17:25:42 +00:00
Adrian Crum b16dfa61f9 Small fixup from last commit. Too many lines were deleted from Example component's controller.xml file.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582512 13f79535-47bb-0310-9956-ffa450edef68
2007-10-06 16:14:47 +00:00
Jacques Le Roux 13842bd64b A patch from Adrian Crum "Move common requests to a separate xml file to reduce component's controller.xml file size" (https://issues.apache.org/jira/browse/OFBIZ-1230)
Thanks to BJ Freeman to review and suggestion

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582509 13f79535-47bb-0310-9956-ffa450edef68
2007-10-06 15:17:08 +00:00
Jacques Le Roux 735deae442 This solve the "Quote WorkEffort bug" issue reported by Bilgin Ibryam (https://issues.apache.org/jira/browse/OFBIZ-1180) - OFBIZ-1180.
It does not solve the issue reported in comment https://issues.apache.org/jira/browse/OFBIZ-1180#action_12524674 "Adding WorkEffort to Communications in party manager is also broken due to extending EditWorkEffort." because then we get java.lang.IllegalArgumentException: Could not find screen with name [EditCommEventWorkEffort] in class resource [component://party/widget/partymgr/CommunicationScreens.xml]. But this is another problem : no EditCommEventWorkEffort screen is declared in CommunicationScreens.xml ! I will create a new issue for that...

I wait a bit before back porting in release4.0, to be sure that my (very simple) solution is ok for everybody.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582338 13f79535-47bb-0310-9956-ffa450edef68
2007-10-05 16:35:33 +00:00