Commit Graph
319 Commits
Author SHA1 Message Date
Jacques Le Roux 02d30e60fe A patch from Arun Patidar "Fixed the bug when response type is 'request-redirect' and query string is available." (https://issues.apache.org/jira/browse/OFBIZ-2179) - OFBIZ-2179
Not sure it's the best fix as maybe it fixes only the effect and not the cause, but at least for now it works!

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742983 13f79535-47bb-0310-9956-ffa450edef68
2009-02-10 14:36:21 +00:00
David E. Jones c62ba66bf2 Fixed issue where controller.xml was not reloading based on cache clear or timeout
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742035 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 09:47:46 +00:00
Jacopo Cappellato 153ec0eba1 Misc enhancements to the update password screen and events: improved layout, error handling.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742015 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 08:14:58 +00:00
David E. Jones ebd5c3e78f Implemented StringModel extension and BeansWrapper extension to load it in order to encode strings for HTML use; this is only done throught the HtmlWidget class that is part of the screen widget, so won't interfere with other FTL uses; note that there is other experimental code in here for wrapping the GenericValue object for html encoding, but that option wasn't very complete so went this way instead; this option behaves better and is more transparent than that escape x as x?html option for FTL files; there are also a few cleanups of typos and things in here; note that this means we have a different Configuration object and so a different template cache, and so we have different cache settings and such; after applying this I found a few places that encoded things they shouldn't but for the most part it is pretty good; will be committing some changes in applications in a bit to resolve a couple of these issues in ecommerce; all should watch out for funny things showing up as HTML text instead of being interpreted by the browser as HTML, meaning it was encoded; in extreme cases just comment out lines 71-73 of HtmlWidget.java to turn off this encoding
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742013 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 07:40:40 +00:00
Scott Gray 078a08692b Fix NPE reported by Sneha Chaturvedi on the user mailing list
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741974 13f79535-47bb-0310-9956-ffa450edef68
2009-02-07 22:18:04 +00:00
David E. Jones 375c48a1c5 Changed for new runEvent method signature, fixes compiler error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741846 13f79535-47bb-0310-9956-ffa450edef68
2009-02-07 06:33:05 +00:00
David E. Jones afb434f132 More log message refinements for more info, but less message and noise
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741742 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 21:37:42 +00:00
David E. Jones e0555f78d5 Fixed bug in new RequestHandler related to view override in the URL for a request with no event; addresses issue with entityref reported by Hans
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741494 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:37:41 +00:00
David E. Jones 57dcf34bcd Some refactoring of canonicalize feature, also change ServiceEventHandler to use UtilHttp stuff for parameters so this and other things take effect there
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741478 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:05:50 +00:00
David E. Jones 4d9382e887 Cleanup and pretty-up a bunch of log statements; moved some less helpful ones to verbose, combined some, and generally tried to make logs in various places more user friendly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741424 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:04:58 +00:00
David E. Jones afe3dc9c81 A few related changes:
Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.

Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.

Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.

To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741374 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 02:14:19 +00:00
David E. Jones 4bd8c4399b Added XSD catalog file for webapp component, like exists in other components
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740697 13f79535-47bb-0310-9956-ffa450edef68
2009-02-04 11:10:46 +00:00
Jacopo Cappellato f46ea50361 Fixed wrong pref group type id.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740249 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 09:07:00 +00:00
Jacopo Cappellato e1b1c85e1e Added two new methods to the ViewHandler interface: getter/setter methods for the "name" field, used to store the name of the view handler as set in the controller.xml file.
No functional change, but this mode is required by the upcoming new screen renderer based on Freemarker macros.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739792 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 17:12:19 +00:00
Scott Gray c152c76dd6 Fix for issue OFBIZ-2142 reported by Hans Bakker: " error message of login service does not show with common/messages.ftl
"
The labels had been moved to a different resource file

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739651 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 23:15:01 +00:00
Jacques Le Roux 572b7683e0 All tabs to 4 spaces in *.groovy, *.java, *.xml : less problems in future with that aspect...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737003 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 11:08:47 +00:00
Jacques Le Roux 40f1371b56 A patch from Guy Gershoni "Allow use of HttpServletRequest.getRemoteUser() for 3rd party authentication" '(https://issues.apache.org/jira/browse/OFBIZ-1906) - OFBIZ-1906
I did not test the CAS case, but reviewed the code and tested in std mode (not using CAS) and it's OK

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@736660 13f79535-47bb-0310-9956-ffa450edef68
2009-01-22 14:52:24 +00:00
Jacques Le Roux b680c6cd4a Some French labels fixes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735829 13f79535-47bb-0310-9956-ffa450edef68
2009-01-19 21:25:25 +00:00
Jacques Le Roux 9c5e043c53 Cleanup_labels35.patch from Marco Risaliti 'Clean up labels" (https://issues.apache.org/jira/browse/OFBIZ-1780) - OFBIZ-1780
This close this issue.
There are some labels related to geoLocation in this commit, I will commit the geoLocation work as is since I will not have much time this next weeks to work on it. Anyway it's already sufficient as a basis for other parts. 



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735402 13f79535-47bb-0310-9956-ffa450edef68
2009-01-18 09:06:03 +00:00
Alfred Maxwell Byers d72e39a4dd OK, so I can't do a simple commit without botching it - left some comment where it did not need to be.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735234 13f79535-47bb-0310-9956-ffa450edef68
2009-01-17 06:30:02 +00:00
Alfred Maxwell Byers 40a8915053 Updating JSON lib and changing the three places that "fromMap" was used.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735187 13f79535-47bb-0310-9956-ffa450edef68
2009-01-17 00:25:21 +00:00
Alfred Maxwell Byers 8d8d8085be This is a noop test case to see if I still have commit privileges. Sorry for the junk, but it has been a couple of years.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735125 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 20:54:05 +00:00
Andrew Zeneski 97eb91bc74 added code to make a few properties configurable per instance (webapp) new context-param configurations available:
xmlrpc.enabledForExtensions (true|false)
xmlrpc.enabledForExceptions (true|false)

if the context-param does not exist, defaults will be used


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735066 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 17:56:24 +00:00
David E. Jones dced19567a Moved product store specific field from framework/webapp component to product component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@734897 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 02:57:19 +00:00
David E. Jones 874f02e9da Manual merge of typecheckcleanup200810 branch as of rev 731346 in that branch, resolved all conflicts; with this BigDecimal is not the native type for many entity fields and is used for many calculations; some work is still needed in certain areas of the project but this covers the most critical ones; thanks especially to Scott for his work on this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731851 13f79535-47bb-0310-9956-ffa450edef68
2009-01-06 07:13:36 +00:00
Andrew Zeneski 70f3896222 implemented per-site "protect" settings. Instead of only per request or per instance (setting in security.properties), now we support per application with a new <protect view="name_of_view"/> element in controller.xml. If the "protect" response is not found, first it will check for a applicaiton default before falling back to per instance.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731660 13f79535-47bb-0310-9956-ffa450edef68
2009-01-05 19:46:16 +00:00
Andrew Zeneski 2e2a719ae5 when using :_protect_: only set the error message if one exists
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731642 13f79535-47bb-0310-9956-ffa450edef68
2009-01-05 18:21:48 +00:00
Andrew Zeneski df892b3d5f fixed class javadoc
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731633 13f79535-47bb-0310-9956-ffa450edef68
2009-01-05 17:47:01 +00:00
Jacques Le Roux 233b969df0 cleanup_labels29.patch from Marco Risaliti 'Clean up labels" (https://issues.apache.org/jira/browse/OFBIZ-1780) - OFBIZ-1780
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@731602 13f79535-47bb-0310-9956-ffa450edef68
2009-01-05 15:41:39 +00:00
Jacques Le Roux 303e014f8e Better French translation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@729680 13f79535-47bb-0310-9956-ffa450edef68
2008-12-27 21:45:48 +00:00
Jacques Le Roux c890b3ef32 Reverted on Adam's guidances
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728536 13f79535-47bb-0310-9956-ffa450edef68
2008-12-21 22:25:22 +00:00
Jacques Le Roux f36843386d Close "Grey list feature for confidential data access" (https://issues.apache.org/jira/browse/OFBIZ-2074) - OFBIZ-2074
I put an explanation in http://docs.ofbiz.org/display/OFBTECH/OFBiz+security

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@727508 13f79535-47bb-0310-9956-ffa450edef68
2008-12-17 20:50:11 +00:00
Jacques Le Roux d5f99b443a A modified patch from Erik Wegner "Patch for all language files (*Labels.xml) to correct language order, find duplicates or invalid entries" (https://issues.apache.org/jira/browse/OFBIZ-2073) - OFBIZ-2073
I removed some hunks, see https://issues.apache.org/jira/browse/OFBIZ-2073?focusedCommentId=12656651#action_12656651



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@726808 13f79535-47bb-0310-9956-ffa450edef68
2008-12-15 21:28:06 +00:00
Jacques Le Roux 7ee3cf8194 Finally this was not needed now
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@726518 13f79535-47bb-0310-9956-ffa450edef68
2008-12-14 19:13:45 +00:00
Jacques Le Roux fe4fa08e79 A change needed for the protect view feature
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@726180 13f79535-47bb-0310-9956-ffa450edef68
2008-12-13 07:22:20 +00:00
Jacques Le Roux 5f1f00276d A patch from Philipp Hoppen " Individual logfiles for scheduled jobs" (https://issues.apache.org/jira/browse/OFBIZ-2042) - OFBIZ-2042
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@719836 13f79535-47bb-0310-9956-ffa450edef68
2008-11-22 11:24:28 +00:00
Jacques Le Roux 3457f0f750 A patch from Karim Rahimpur "more and improved spanish translations" (https://issues.apache.org/jira/browse/OFBIZ-2046) - OFBIZ-2046
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@718580 13f79535-47bb-0310-9956-ffa450edef68
2008-11-18 13:28:33 +00:00
Adam Heath 3935ab51c0 Implement multiple resource loading from the classpath; this means
that framework doesn't have to reference transforms that exist in
later components.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@718491 13f79535-47bb-0310-9956-ffa450edef68
2008-11-18 06:09:58 +00:00
Bilgin Ismet Ibryam 9ef0247300 - Allow overriding of "rowSubmit" request paramater with request attribute.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@712476 13f79535-47bb-0310-9956-ffa450edef68
2008-11-09 08:59:47 +00:00
Jacques Le Roux 31d56e8064 A patch from Ravindra Mandre "The userPrefGroupId field on UserPrefGroupType should be userPrefGroupTypeId, as per conventions" (https://issues.apache.org/jira/browse/OFBIZ-1996) - OFBIZ-1996
With some help by Vikas Mayur for the "Upgrading OFBiz from earlier revisions" Wiki page update


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@712366 13f79535-47bb-0310-9956-ffa450edef68
2008-11-08 08:59:31 +00:00
Adrian Crum 6c084dc8e3 Deprecated one more unnecessary class.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@712237 13f79535-47bb-0310-9956-ffa450edef68
2008-11-07 19:47:04 +00:00
Adrian Crum a414ac0c9b Code cleanups in the base component - deprecated unused/unnecessary classes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@712195 13f79535-47bb-0310-9956-ffa450edef68
2008-11-07 16:54:41 +00:00
Adam Heath aea3931bbf Modify all <javadoc> to use the src sets, so that excluded files are
no longer processed.  Reduces javadoc warnings.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709628 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 03:19:00 +00:00
Adam Heath 195170175b Use pattern sets in <javac/>, to include/exclude files, and modify
all build.xml to override the sets, if nescessary.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709627 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 03:06:17 +00:00
David E. Jones cfce74a834 Fixed bad init parameter names for the delegator, was causing the messages on startup about a null delegator name
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@706838 13f79535-47bb-0310-9956-ffa450edef68
2008-10-22 01:25:51 +00:00
Adam Heath 3a9fa034f3 s/delgator/delegator/
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@705778 13f79535-47bb-0310-9956-ffa450edef68
2008-10-17 23:26:12 +00:00
Scott Gray 5601372ea7 Set the autoLoginCookie's domain to what is specified in url.properties
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@700552 13f79535-47bb-0310-9956-ffa450edef68
2008-09-30 19:10:07 +00:00
David E. Jones 3a461ea757 Added visitId persistence to EntityAuditLog stuff
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@688498 13f79535-47bb-0310-9956-ffa450edef68
2008-08-24 12:09:37 +00:00
Scott Gray 9b786b8159 Reverted the rest of Si's recent work since it doesn't look like he is going to complete/correct the RequestHandler part any time soon
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@688265 13f79535-47bb-0310-9956-ffa450edef68
2008-08-23 06:17:06 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00