So far I did not understood that this message meant:
Analyze (javascript)
1 issue was detected with this workflow: Using on.push.paths can prevent Code
Scanning annotating new alerts in your pull requests.
Now I do, better remove them
Forgot 2 things:
I created a Jira (here is the ref)
I removed Java analysis (here it's back)
Now uses again adityasharad's syntax, not sure it's the right one and place
It also needs a not functional change for codeQL to run
Thanks: adityasharad from GH CodeQL
See https://github.com/github/vscode-codeql/issues/735#issuecomment-969348461
Previously in commit dfc7ee4 I blindly followed GH CodeQL's advice about js CSS.
I had a doubt, indeed it was irrelevant. I misinterpreted the advice.
Then I tried to follow OWASP's advice about using node-esapi but was unable to
make it work in a reasonable time. Neither with "node require" nor requireJS;
ie using either CommonJS or AMD format, I guess I missed something there.
Anyway, I finally I set my sights on DOMPurify which is doing the job.
There is only one "foot-gun potential":
https://github.com/cure53/DOMPurify#user-content-is-there-any-foot-gun-potential
"If you first sanitize HTML and then modify it afterwards, you might easily void
the effects of sanitization. If you feed the sanitized markup to another library
after sanitization, please be certain that the library doesn't mess around with
the HTML on its own."
Fortunately, that's not a concern in our simple case.
This commit
* fixes the 3 remaining js vulnerabilty reported by
* prevents checking all under node_modules since it's done by npm in console
(a bit weak though, ie not clearly on purpose)
* gives more information about 'ci' vs 'install' in npmInstallCommand
Run only when a Java or Javascript file has been modified.
Java will still fails OFBiz is too big and there are no ways to restrict the
files to check.