This commit might break some Groovy scripts. There seemed to be a lot of C&P widget import statements, but there were no widget classes being used in the script, so I removed them. I might have overlooked something though.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652852 13f79535-47bb-0310-9956-ffa450edef68
Commit 1626419 changed htmlFormMacroLibrary.ftl renderDateTimeField to use Date.parse instead of Date.parseExact.
https://code.google.com/p/datejs/wiki/APIDocumentation states Date.parse will use current CultureInfo for formats but for parsing ISO yyyy-MM-dd from hidden field, need to use parseExact.
I spotted this when CultureInfo was en-GB and selecting 2014-11-01 on any date field (i18n field displays 11/01/2014 instead of 01/11/2014)
For November all days after the 12th display correctly
jleroux: I simply removed the line added in the block which remove the dot and 000 ms in date/time string. I did not see any reason why this was needed. I modified the comment on this block for faster understanding.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1641066 13f79535-47bb-0310-9956-ffa450edef68
Scenario:
1. Load-seed
2. Create-admin-user
3. Access: /catalog/control/main
4. Login
5. Change password for the first use
After password change, web browser redirect user to /catalog/control/main with an error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1575508 13f79535-47bb-0310-9956-ffa450edef68
Since it uses "GET" method to submit the pagination request, it's restricted by the URL max length limitation.
The patch attached changes the submit way from GET to "POST" if total length of URL > 2k.
jleroux: I also sort of (found after it was due to it) reverted r1204170, I don't see the reason for this now, and it was uselessly duplicating the current entry in the page size dropdown
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1559338 13f79535-47bb-0310-9956-ffa450edef68
There are 2 issues with the existing code.
1 - floor is applied to viewSize only not the computed value
2 - if the listSize divides with viewSize evenly, you'll get one extra
eg
24/2=12 - no of pages = 13
24/5=4.8 - no of pages = 5
Change to correctly calculate the number of pages using ceiling rather than floor
To repoduce this I went into find party screen, search for all and manually set the view size (I had to click next and change the VIEW_SIZE parameter in the url).
In my description I mention 24/2=12 and 24/5=4.8,
24 is number of parties I had
2/5 is the view size
It does not matter what the item size is (as long as its more than 0), you just have to make sure listSize divides by viewSize evenly. In my case 24/2 divided evenly and which should have have given 12 pages but gave 13.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1550201 13f79535-47bb-0310-9956-ffa450edef68
"other-field-size" of drop-down form element is a very nice feature, but it's crippled in current version.
attached a patch to make it works and added an example section for that into FormWidgetExample.
jleroux: Interesting, I did not know this feature existed, it was committed long ago by David (before ASF era)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1511279 13f79535-47bb-0310-9956-ffa450edef68
Simple formatting (tabs to 2 spaces)
Fixes a bug which prevented to show an i18n "clear" text when layered lookups were used in read only mode from FTL templates
Fixes a bug which prevented to clear the description (at right of button) when layered lookups were used in read only mode
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369561 13f79535-47bb-0310-9956-ffa450edef68
Firefox will throw syntax error if you call javascript void function without parameter.
jleroux: I did not reproduce with FF14 on XP (modern browsers correct by themselves) but I agree it's a better syntax. So I changed all where it was needed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1369555 13f79535-47bb-0310-9956-ffa450edef68
Summary: The purpose of this patch is to address the following:
1. Provide a standardized set of image width and height specs for page layout in ofbiz. This gives ofbiz a uniform look throughout as it applies to image display.
2. Preserve the aspect ratio of the image when using these standardized image sizes.
3. One place to make styling modifications (eg. css file).
4. Decouple styling from code (eg. java,ftl,xml,html,jsp,etc).
Regarding including the real image size, the width/height attributes in <img> specifies the boundary of the image when shown on the page. If you need to specify the real size of the image, the server code would have to perform the determination. Afterwards, you can include the actual dimensions of the image in the title attribute of <img>
Details:
Manually specifying the image width and height does help with preserving the layout of a page regardless of the image size to be shown. The challenge with this method is that the image shown on the page in question may be distorted if the aspect ratio of the image differed from that of the width and height attributes of <img>. This basically forces the person uploading the image to be more vigilant about image aspect ratios.
The purpose is to harmonize on the display size of images with a standardized set of width/height constraints in which an image must fit and preserve the aspect ratio of images.
Currently the source files (eg. ftl, xml) either manually specifies the width or height of a displayed image (ie widget <image> and html <img> tag). The problem with specifying only one constraint is that an image can affect the layout of the page if the user uploads an image where the aspect ratio could be large.
Some ftl and xml files specify both the width and the height. The problem with this is that if the aspect ratio of the image in question does not match that of the width and height of the <img> tag, the image would be displayed distorted.
The solution was to create a standardized set of CSS styles that both configure the displayed image size and preserve the image aspect ratio (eg. thumbnail size, medium size and large size). Of course, the developers can further define or modify the styles to suit their need.
By using CSS, one can change the size of displayed images without having to tamper with the ftl and/or xml files. This helps to reduce potential bugs that come with modifying the ftl and xml files. The existing way of doing things is to go through each ftl or xml file in question and manually modify the width and/or height of the <image> and/or <img> tag.
The question about the "border" around images. If you do not wish to have a border around the image, just remove it from the CSS style. It's that easy No need to change anything else. Ie. configuration to the image is done on the CSS style and not on the <image>, <img> tag.
NB: The current patch does not apply to all displayed images. I have only made appropriate modifications to widget <image> and html <img> tags that have either specified the width and/or height. There are numerous <image> and <img> tags spread all over the project that do not specify dimensions. I would have to modify them as I encountered them when I could see where and how they are displayed on the screen. Note that these images would not be affect by this patch.
jleroux: despite my efforts I was not able to check all screens. But I think it's ok
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1296782 13f79535-47bb-0310-9956-ffa450edef68
jQuery library to version 1.7
jQuery UI to version 1.8.16
jQuery Validation to version 1.9
jQuery Flot to version 0.7
jQuery datetimepicker to version 0.9.7
and jsTree
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1199218 13f79535-47bb-0310-9956-ffa450edef68
In last commits (1178141, 1178111) I put wrong paths for:
* elrteEditor for css pathes is now elrte-1.3
* missed js in elrte-1.3/js/i18n for i18n files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1178166 13f79535-47bb-0310-9956-ffa450edef68
When I open a form which include lookup field and then click the expand/collapse button around the upper right corner in the the header, the page will go to "main" after user preference is settled.
The cause is the requests initiated by lookup field does not remember the last view name. It simply use "main" instead.
Patch to make lookup requests remember the LAST_VIEW_NAME correctly.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1137433 13f79535-47bb-0310-9956-ffa450edef68
Lookup tag has a attribute "disabled" that is used to set disabled="disabled" property for lookup input element and it create also a clear button just after lookup field to clear the field value.
But if we set disabled="disabled" for any input field then that field does not passes as parameter and we can't accesses it from parameters or request parameters , so it should be "readonly".
If we set readonly-"readonly" then user can't change the field value directly, and this field passes as parameters.
Only difference between readonly and disabled is that in case of disabled field does not passes as parameter buy in case of readonly field passes as a parameter.
Thanks Deepak for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1098082 13f79535-47bb-0310-9956-ffa450edef68
Initial demand by Michael Pätzold
At the moment we concentrate on increasing the usability of the backend application. One thing we recognized is the way form errors are reported to the users. Now it's done by showing a list of entity fields, that are required. A more common approach would be to highlight the form controls, that were not/wrongly filled. Was/Is there any task related to that or something similar?
Nicolas's solution
With integration of JQuery and validate function integrate by Sascha, I extend the Form renderer to apply required class and alert the form when she submitted to pass by JQuery validate function.
JLR: I have added a required field to InternalName field in Edit Product Form. There are maybe other cases like that which should be improved...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1096293 13f79535-47bb-0310-9956-ffa450edef68
This allows the Navigation bar to be rendered closed to the form itself.
It seems very hard to reduce the BR height using the CSS only.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1091487 13f79535-47bb-0310-9956-ffa450edef68