With the difficulty to test, I create a new test-suite performfindtests with five junit :
* testPerformFindConditionFieldEquals
* testPerformFindConditionFieldLike
* testPerformFindConditionDistinct
* testPerformFindFilterByDate
* testPerformFindFilterByDateWithDedicateDateField
I also improve TestNodeMember with two fields extendFromDate and extendThruDate to realize filter on it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1655499 13f79535-47bb-0310-9956-ffa450edef68
At bootstrap an eca definition like the following:
<eca entity="JobSandbox" operation="store" event="validate">
<action service="ping" mode="sync"/>
</eca>
is causing a deadlock because it is triggered at startup when the reloadCrashedJobs method is executed; reloadCrashedJobs is executed holding a lock on the JobManager object; within this method a "find" operation is performed that (because of the "validate" event) triggers the action; but for this a getDispatchContext is executed and this blocks until the task (executed by a thread Executor) that reads and setups the eca rules is complete; but this task requires a lock on the same JobManager object and thus we get the deadlock
Thanks to Arun Patidar and Deepak Dixit for analyzing the issue with me.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1655046 13f79535-47bb-0310-9956-ffa450edef68
Remove code related to Portal Management functionality from WebTools after equivalent code in MyPortal has been committed.
jleroux: I just removed also the FindPortalPage entry in Webtools main.ftl
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1653481 13f79535-47bb-0310-9956-ffa450edef68
jleroux: I removed
3 specific comments
<!-- ORRTIZ: TAXREPORT -->
<!-- GEO -->
<!-- ORRTIZ:BMS Applications -->
2 duplicates
<value xml:lang="nl">Gesynchroniseerd</value>
<value xml:lang="nl">Req. - geannuleerd</value>
For the later I kept the old one which seems more complete
I replaced 2482 <value xml:lang="(.*)_(.*)"> by <value xml:lang="(.*)-(.*)">
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1653143 13f79535-47bb-0310-9956-ffa450edef68
This commit might break some Groovy scripts. There seemed to be a lot of C&P widget import statements, but there were no widget classes being used in the script, so I removed them. I might have overlooked something though.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652852 13f79535-47bb-0310-9956-ffa450edef68
When you link to your ofbiz installation from another site using _blank as the target and protocol is changing from http to https, google chrome will throw an error -
Blocked a frame with origin "https://ofbiz.company.com" from accessing a frame with origin "http://other.company.com". The frame requesting access has a protocol of "https", the frame being accessed has a protocol of "http". Protocols must match.
This error may prevent other javascript from executing (this has caused, in our ofbiz installation, datetimepickers from working properly)
jleroux: this simply adds a try/catch block and use the parent in case of failure
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652731 13f79535-47bb-0310-9956-ffa450edef68
Simply increases the width of the left and right screens. It is more appropriate UX and fixes the issue. Checked in Safari MAC OS (8.0) and latest Google Chrome, Firefox, it is working fine there.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652725 13f79535-47bb-0310-9956-ffa450edef68
1. Extract and reuse common code/artifacts.
2. Organized the class structure so it makes more sense.
3. Add an XML widget visitor - this restores and improves the widget classes toString() methods. This is a WIP.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1652638 13f79535-47bb-0310-9956-ffa450edef68
<set field-name="partyId" env-name="${userLogin.partyId}"/>
then the expanded value (at the time of creation) is stored in the ServiceEcaSetField and then reused even when the seca is re-executed with a different context.
This commit fix the bug by removing the outer if statement "if (UtilValidate.isEmpty(this.value))".
Thanks to Deepak Dixit for spotting this issue.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1651593 13f79535-47bb-0310-9956-ffa450edef68
When creating a postal address, selecting Canada for country automatically filled the state/province dropdown with values. The issue is that the values of the state/province dropdown list are incorrect.
I was expecting the options for the state/province dropdown to have the following:
name=Alberta, value=AB
name=British Columbia, value=BC
...
What is actually present in the drop down is:
name=AB, value=AB
name=AB, value=BC
...
One observation is that this issue does not appear when the country selected is the United States. It seems to happen with Canada.
Another observation is that this issue applies to the 'en' locale. It seems to work fine for 'fr' locale.
jleroux: this was OK for Saskatchewan, that leaded to the solution
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1650642 13f79535-47bb-0310-9956-ffa450edef68