At this time the alt-target element value is only parse on bsh interpreter. To resynchronise with the rest of framework, convert with a flexibleStringRenderer.
jleroux: re-adding after reverting r1311082
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1311109 13f79535-47bb-0310-9956-ffa450edef68
When you use sort-field, you reorder only the form begin or you need list all file if you want reordered the end form.
Example
<form>
<field name="a"/>
<field name="b"/>
<field name="c"/>
<field name="d"/>
</form>
If you want put c at the end :
<form>
<field name="a"/>
<field name="b"/>
<field name="c"/>
<field name="d"/>
<sort-order>
<sort-field name="a"/>
<sort-field name="b"/>
<sort-field name="d"/>
<sort-field name="c"/>
</sort-order>
</form>
with the patch
<form>
<field name="a"/>
<field name="b"/>
<field name="c"/>
<field name="d"/>
<sort-order>
<last-field name="c"/>
</sort-order>
</form>
It's really useful for inherited forms when you adding new fields, you just use last-field for instance for submit button.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1307784 13f79535-47bb-0310-9956-ffa450edef68
Summary: The purpose of this patch is to address the following:
1. Provide a standardized set of image width and height specs for page layout in ofbiz. This gives ofbiz a uniform look throughout as it applies to image display.
2. Preserve the aspect ratio of the image when using these standardized image sizes.
3. One place to make styling modifications (eg. css file).
4. Decouple styling from code (eg. java,ftl,xml,html,jsp,etc).
Regarding including the real image size, the width/height attributes in <img> specifies the boundary of the image when shown on the page. If you need to specify the real size of the image, the server code would have to perform the determination. Afterwards, you can include the actual dimensions of the image in the title attribute of <img>
Details:
Manually specifying the image width and height does help with preserving the layout of a page regardless of the image size to be shown. The challenge with this method is that the image shown on the page in question may be distorted if the aspect ratio of the image differed from that of the width and height attributes of <img>. This basically forces the person uploading the image to be more vigilant about image aspect ratios.
The purpose is to harmonize on the display size of images with a standardized set of width/height constraints in which an image must fit and preserve the aspect ratio of images.
Currently the source files (eg. ftl, xml) either manually specifies the width or height of a displayed image (ie widget <image> and html <img> tag). The problem with specifying only one constraint is that an image can affect the layout of the page if the user uploads an image where the aspect ratio could be large.
Some ftl and xml files specify both the width and the height. The problem with this is that if the aspect ratio of the image in question does not match that of the width and height of the <img> tag, the image would be displayed distorted.
The solution was to create a standardized set of CSS styles that both configure the displayed image size and preserve the image aspect ratio (eg. thumbnail size, medium size and large size). Of course, the developers can further define or modify the styles to suit their need.
By using CSS, one can change the size of displayed images without having to tamper with the ftl and/or xml files. This helps to reduce potential bugs that come with modifying the ftl and xml files. The existing way of doing things is to go through each ftl or xml file in question and manually modify the width and/or height of the <image> and/or <img> tag.
The question about the "border" around images. If you do not wish to have a border around the image, just remove it from the CSS style. It's that easy No need to change anything else. Ie. configuration to the image is done on the CSS style and not on the <image>, <img> tag.
NB: The current patch does not apply to all displayed images. I have only made appropriate modifications to widget <image> and html <img> tags that have either specified the width and/or height. There are numerous <image> and <img> tags spread all over the project that do not specify dimensions. I would have to modify them as I encountered them when I could see where and how they are displayed on the screen. Note that these images would not be affect by this patch.
jleroux: despite my efforts I was not able to check all screens. But I think it's ok
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1296782 13f79535-47bb-0310-9956-ffa450edef68
In particular these chenges should make it easier to implement JSR-223 (even if I think that we should still treat Groovy in a special way).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1296762 13f79535-47bb-0310-9956-ffa450edef68
In htmlFormMacrolLibrary.ftl, renderFormClose has containerId, hasRequiredField.
But csv, fo, text, xml FormMacroLibary.ftl don't have these fields for this macro.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1245778 13f79535-47bb-0310-9956-ffa450edef68
Description:
Getting errors on clicking "Export" tab. Steps to regenerate the issue.
1. Go to Facility component.
2. Go to inventory tab.
3. After that go to "Export" tab, there is an error:
Macro renderFormOpen has no such argument: viewSize
The problematic instruction:
----------
==> macro renderFormOpen [on line 64, column 1 in component://widget/templates/xmlFormMacroLibrary.ftl]
in user-directive renderFormOpen
For reference- please have a look on below given link-
https://demo-trunk.ofbiz.apache.org:8443/facility/control/ViewFacilityInventoryByProduct?facilityId=WebStoreWarehouse
I have done searching and found that there are parameters missing in some xmlFormMacroLibrary.ftl macros for both trunk and release branch 11.04.
Thanks Amardeep for the contribution!!!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1229090 13f79535-47bb-0310-9956-ffa450edef68
jQuery library to version 1.7
jQuery UI to version 1.8.16
jQuery Validation to version 1.9
jQuery Flot to version 0.7
jQuery datetimepicker to version 0.9.7
and jsTree
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1199218 13f79535-47bb-0310-9956-ffa450edef68
In last commits (1178141, 1178111) I put wrong paths for:
* elrteEditor for css pathes is now elrte-1.3
* missed js in elrte-1.3/js/i18n for i18n files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1178166 13f79535-47bb-0310-9956-ffa450edef68
Removes useless/redundant jQuery files
Adds a elrte translation file for Ukraine file which was provided in a patch from Sascha related to 1.2 but is missing in 1.3
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1178151 13f79535-47bb-0310-9956-ffa450edef68
This commit also removes the demonstration widgetVerbose setting in the Example component's web.xml file - which caused some confusion, and it comments out the setting in the web.xml file that is used for creating new components.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1172954 13f79535-47bb-0310-9956-ffa450edef68
* UtilValidate.is(Not)Empty wherever possible
* Remove useless boiler plate code which makes things harder to read
* if on one line w/out {}, it avoid future errors: you can't miss the block if you need to add a line
* else on one line w/out {}, it avoid future errors: you can't miss the block if you need to add a line
* no else when return in previous if
The result is a much easier code to read. I'd recommend to use this style everywhere in OFBiz. Of course this suppose a screen with larger width than in 2000 years...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1170442 13f79535-47bb-0310-9956-ffa450edef68
I also refactored, I prefer if/else with only one short expression to be on the same line, notably when return is used (then else is useless)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169917 13f79535-47bb-0310-9956-ffa450edef68
ShoppingCart.java: a tabs has been automatically replaced by 8 spaces, fixes it
UtilValidate.java: removes useless parentheses
GeneriDao.java: fixes a wrong UtilValidate.isNotEmpty
ModelFormField.java: revert all UtilValidate.is(Not)Empty() changes though I ddid not find an error there, it must be one because https://localhost:8443/humanres/control/EditResponsibilityTypes is not rendered correctly. I will check again
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169754 13f79535-47bb-0310-9956-ffa450edef68
Changes implementation of UtilValidate.isEmpty() for Collection and Map by using isEmpty() instead of c.size() == 0). It's more clear and as efficient. Removes also useless parentheses there.
Makes use of UtilValidate.is(Not)Empty() everywhere it makes senses. This for 2 reasons:
* Make the code more readable by replacing the (!)null/isEmpty pattern.
* Avoid possible NPEs when only isEmpty() was used (after Entity.find... for instance). I found a lot of cases (242 today) where isEmpty() could perhaps be replaced in Framework. But I guess no NPE checks were missing there and anyway it was too much for me to check them all... So I only did the relevant changes in Applications...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@1169478 13f79535-47bb-0310-9956-ffa450edef68