Jacques Le Roux
e7905f2c8c
Fix the anti-pattern
...
if (* != null && *.size() > 0) {
where * is a variable name (String or Collection). Rewritten to
if (UtilValidate.isNotEmpty(*)) {
Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {
And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Scott Gray
c98e7dc59f
Removed unnecessary "error" response elements from the controller files, if no event is defined then "success" will always be the response name.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686577 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 00:00:49 +00:00
Adam Heath
e410552cc9
No longer *copy* the extra support files into the classes dir;
...
instead, just add them straight to the final jar.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adrian Crum
cd3a137731
Removed deprecated CSS style sepBar, removed unnecessary align="left" HTML element attributes.
...
I did a global search and replace for the align="left" aatribute - I didn't check each replacement because there were hundreds of them. This shouldn't break any layout. If you spot something wrong, post a message on the dev mailing list and I will fix it.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684548 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 16:28:14 +00:00
Jacopo Cappellato
8b9fc02614
Fixed wrong file name; I actually tried to use svn rename to change the file name but I had issues because the svn command seems to ignore upper/lower case characters.
...
Thanks to BJ for the bug report in the ml.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682350 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 11:56:37 +00:00
Adam Heath
43e9cdc2ff
Generics galore.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682078 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 23:31:04 +00:00
Adam Heath
b6a1ae5e5e
Another minor optimization; no longer need to specify classpathref in
...
all the build.xml files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
David E. Jones
0065182657
A few more view and request/event handlers, though not terribly common
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681254 13f79535-47bb-0310-9956-ffa450edef68
2008-07-31 02:05:42 +00:00
Jacques Le Roux
ff3b3617d3
Better handling of bsh->groovy migration
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680062 13f79535-47bb-0310-9956-ffa450edef68
2008-07-27 03:36:22 +00:00
Jacques Le Roux
88aa3dc618
Undoing change committed in r680047.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680061 13f79535-47bb-0310-9956-ffa450edef68
2008-07-27 03:27:06 +00:00
Jacques Le Roux
58a88148db
bsh -> groovy conversion
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680047 13f79535-47bb-0310-9956-ffa450edef68
2008-07-26 21:05:02 +00:00
Jacques Le Roux
78b3a22c59
A fixing patch from J.Enrique Ruiz "Data File bug fixed (CONTRIBUTION)" ( https://issues.apache.org/jira/browse/OFBIZ-1888 ) - OFBIZ-1888
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@680046 13f79535-47bb-0310-9956-ffa450edef68
2008-07-26 21:01:21 +00:00
Jacopo Cappellato
a23589412a
Added select box to filter entities by group, for example useful ootb to quickly see all the entities related to the BI component.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679456 13f79535-47bb-0310-9956-ffa450edef68
2008-07-24 16:40:18 +00:00
Jacopo Cappellato
fa9f0a3253
The default-group-name is now returned by the group name methods of ModelGroupReader.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@679331 13f79535-47bb-0310-9956-ffa450edef68
2008-07-24 09:43:27 +00:00
Jacques Le Roux
641ff10050
Update Copyright to 2008
...
A real replace in files feature was one of the reasons I use Eclipse 3.4 for near a year now (I even helped to test, a real must have :o)
Not sure previous commit was sent partially or not at all (I needed to update)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@677685 13f79535-47bb-0310-9956-ffa450edef68
2008-07-17 18:56:25 +00:00
Jacques Le Roux
6c9bdbb127
A patch from Bruno Busco "New and improved Italian labels" ( https://issues.apache.org/jira/browse/OFBIZ-1864 ) - OFBIZ-1864
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@674749 13f79535-47bb-0310-9956-ffa450edef68
2008-07-08 09:32:18 +00:00
David E. Jones
c489858f21
Changed FindGeneric to not do 2 queries, ie instead of doing a find count and then a find, now just does the find and gets the count using the new EntityListIterator method to seek to the end and get the index; that should be faster, though not totally sure; also changed FindGeneric and ViewGeneric from bsh to groovy and did some cleanups/fixes
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@673025 13f79535-47bb-0310-9956-ffa450edef68
2008-07-01 08:52:27 +00:00
Adam Heath
1dc13f6105
Number.valueOf changes.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672898 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:20:37 +00:00
Jacques Le Roux
798e0cb9ac
Per David's advice revert change (was already done in another way in rev. 539527 ( https://issues.apache.org/jira/browse/OFBIZ-593 )
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672687 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 00:56:20 +00:00
Adam Heath
18391f98a9
The build.xml files are now much smaller and simpler; they reuse a
...
few global definitions. 1585 lines removed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Jacques Le Roux
f11fd686da
Fix a bug when emptying a field (blanking it)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672187 13f79535-47bb-0310-9956-ffa450edef68
2008-06-27 08:32:16 +00:00
Jacques Le Roux
b1ad3b5e14
A patch from Nicolas Malin "CheckDb interface not work for create fkidx" ( https://issues.apache.org/jira/browse/OFBIZ-1819 ) - OFBIZ-1819
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@663022 13f79535-47bb-0310-9956-ffa450edef68
2008-06-04 07:54:54 +00:00
Jacopo Cappellato
a5159661af
Removed unnecessary position attributes.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@661743 13f79535-47bb-0310-9956-ffa450edef68
2008-05-30 14:49:15 +00:00
David E. Jones
82df3529e2
More cleanups of now deprecated constructors and what what
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660840 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 07:16:36 +00:00
David E. Jones
b9d6f8b524
Changed EntityExpr and EntityFunction subclasses to use the factory instead of constructor pattern, plus moved EntityExpr to EntityCondition factory methods; a number of EntityExpr cleanups, but many more to go
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660812 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 05:20:09 +00:00
David E. Jones
3543d6abe3
Changed the way EntityCondition sub-classes work so they use the javolution Reusable class for recycling objects; now all conditions should be created using the factory methods on the EntityCondition object instead of the direct constructors; there is a small variety of classes available there now for ease of use; also changed a bunch of old code to not use the deprecated constructors; note that still need to do a pass similar to this on EntityExpr
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660780 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 01:58:46 +00:00
Jacopo Cappellato
b1bd619d66
Set correct template type for xsl-fo platform dependent templates: this is now required because the platform-dependent element can now accept different templates for different types.
...
Thanks to Jacques Le Roux for the report.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660107 13f79535-47bb-0310-9956-ffa450edef68
2008-05-26 06:25:57 +00:00
Scott Gray
75a4f5676b
Fix for OFBIZ-1802 reported by Ashish Vijaywargiya, Error in Data File Tool. The uiLabelMap was being used in the bsh script without being defined.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@659870 13f79535-47bb-0310-9956-ffa450edef68
2008-05-24 20:32:31 +00:00
Scott Gray
5560235815
Removed calls to the following deprecated GenericDelegator methods from all bsh files:
...
findCountByAnd
findCountByCondition
findListIteratorByCondition
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655456 13f79535-47bb-0310-9956-ffa450edef68
2008-05-12 10:03:50 +00:00
Scott Gray
9bc49a5ce1
Removed calls to deprecated findByPrimaryKey* GenericDelegator methods from all bsh files
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655449 13f79535-47bb-0310-9956-ffa450edef68
2008-05-12 09:21:26 +00:00
Scott Gray
db43c9ca64
Removed calls to the deprecated findAll GenericDelegator methods from all bsh and ftl files plus some java ones in the shark component
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655238 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 04:32:54 +00:00
Scott Gray
153653615b
Removed the rest of the calls to deprecated GenericDelegator methods, except for the findListIteratorByCondition which takes a DynamicViewEntity as a parameter not sure what to do about that one.
...
There's still all the bsh files to check though.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655235 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 03:29:04 +00:00
Scott Gray
3b9cedb7c9
Fixed a bunch of bugs (mostly typos) that show up while generating the artifact information
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653201 13f79535-47bb-0310-9956-ffa450edef68
2008-05-04 11:34:32 +00:00
Scott Gray
112ae8dd76
Need to strip the comments when looking for called services as well
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653187 13f79535-47bb-0310-9956-ffa450edef68
2008-05-04 08:37:57 +00:00
Scott Gray
8ec7821177
Added a method to strip comments when parsing java files, the artifact info stuff was getting a bit confused by them
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653181 13f79535-47bb-0310-9956-ffa450edef68
2008-05-04 05:38:38 +00:00
David E. Jones
329631a4b5
A whole bunch of cleanups to use newer and more consolidated delegator find methods; still lots of deprecation warnings, bots of deprecation warnings but this is a first pass, and things still run as before
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653029 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 09:40:51 +00:00
Scott Gray
451539e829
Small change so that the log shows the orginal entity String rather than an empty String
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@652902 13f79535-47bb-0310-9956-ffa450edef68
2008-05-02 20:41:00 +00:00
Jacques Le Roux
49b4e1bc5c
Better handling of multi-errors (from David's suggestion in dev ML)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@647683 13f79535-47bb-0310-9956-ffa450edef68
2008-04-14 07:49:09 +00:00
Jacques Le Roux
a3d7cdb085
A patch from Ray Barlow "XML export of a no-auto-stamp entity does not work" ( https://issues.apache.org/jira/browse/OFBIZ-1728 ) - OFBIZ-1728
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@647413 13f79535-47bb-0310-9956-ffa450edef68
2008-04-12 10:15:18 +00:00
Jacques Le Roux
af63afe562
New version which automatically deploys in application server see https://cwiki.apache.org/confluence/x/IYBr for more informations
...
One base, one webapp, and the webtools web.xml files are slightly modified, nothing harmful anyway
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@646349 13f79535-47bb-0310-9956-ffa450edef68
2008-04-09 13:51:39 +00:00
Jacopo Cappellato
00bc95e9c3
Fixes for fo (PDF) template files, follow on from: r644081 and r645852
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@645891 13f79535-47bb-0310-9956-ffa450edef68
2008-04-08 13:02:30 +00:00
David E. Jones
de28351d15
Small changes to allow search in general or by artifact type
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@644531 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 22:10:17 +00:00
David E. Jones
616490c775
Artifact info related artifact lists are now all sorted
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@644386 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 16:02:16 +00:00
David E. Jones
0b4bcd4807
Added stuff to get definition location URL for all artifact types
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@644206 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 07:59:52 +00:00
David E. Jones
3141bca290
Finished form to link/target request artifact info stuff
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@644179 13f79535-47bb-0310-9956-ffa450edef68
2008-04-03 06:06:48 +00:00
Andrew Zeneski
33d71a99b7
changed to order descending
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@643751 13f79535-47bb-0310-9956-ffa450edef68
2008-04-02 05:44:27 +00:00
Andrew Zeneski
aefc7b3329
changed job list sort to runTime and default view size to 50
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@643734 13f79535-47bb-0310-9956-ffa450edef68
2008-04-02 04:26:35 +00:00
Jacques Le Roux
944f6f72ff
A patch from Pranay Pandey "Searching entities with non numeric chars in numeric field generates an error" ( https://issues.apache.org/jira/browse/OFBIZ-1729 ) - OFBIZ-1729
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@643134 13f79535-47bb-0310-9956-ffa450edef68
2008-03-31 20:31:43 +00:00
David E. Jones
630950c653
Refactored xml file searching to make more general, now used to search for controller xml files for requests referred to in screen linktroller xml files for requests used in screen defs, code for forms soon to come
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@641730 13f79535-47bb-0310-9956-ffa450edef68
2008-03-27 07:53:39 +00:00
David E. Jones
21235aee5e
Added data structures for forward and reverse request references in screens and forms; no code to populate yet
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@640861 13f79535-47bb-0310-9956-ffa450edef68
2008-03-25 15:29:30 +00:00