Commit Graph
60 Commits
Author SHA1 Message Date
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath 99bf46f085 Switch most new File(string_with_path_separator) calls to
FileUtil.getFile.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682266 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 06:08:42 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Jacques Le Roux 641ff10050 Update Copyright to 2008
A real replace in files feature was one of the reasons I use Eclipse 3.4 for near a year now (I even helped to test, a real must have :o)
Not sure previous commit was sent partially or not at all (I needed to update)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@677685 13f79535-47bb-0310-9956-ffa450edef68
2008-07-17 18:56:25 +00:00
David E. Jones 204d775174 More entitygroups gone, all of framework
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672910 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:49:10 +00:00
Adam Heath 89249b2432 Generics and java1.5 features.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672897 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:16:55 +00:00
David E. Jones 3797437015 Changed to support a default-group-name per delegator, so that they don't have to specified for each entity; also some cleanups of the DelegatorInterface to remove deprecated stuff and add some new things, I still don't think that needs to exist but oh well
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672821 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 17:04:43 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Scott Gray 5e401fcd53 Updated all simple methods to use the new attributes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667748 13f79535-47bb-0310-9956-ffa450edef68
2008-06-14 06:03:12 +00:00
David E. Jones 82df3529e2 More cleanups of now deprecated constructors and what what
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660840 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 07:16:36 +00:00
David E. Jones b9d6f8b524 Changed EntityExpr and EntityFunction subclasses to use the factory instead of constructor pattern, plus moved EntityExpr to EntityCondition factory methods; a number of EntityExpr cleanups, but many more to go
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660812 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 05:20:09 +00:00
David E. Jones 3543d6abe3 Changed the way EntityCondition sub-classes work so they use the javolution Reusable class for recycling objects; now all conditions should be created using the factory methods on the EntityCondition object instead of the direct constructors; there is a small variety of classes available there now for ease of use; also changed a bunch of old code to not use the deprecated constructors; note that still need to do a pass similar to this on EntityExpr
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660780 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 01:58:46 +00:00
Scott Gray 153653615b Removed the rest of the calls to deprecated GenericDelegator methods, except for the findListIteratorByCondition which takes a DynamicViewEntity as a parameter not sure what to do about that one.
There's still all the bsh files to check though.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655235 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 03:29:04 +00:00
Scott Gray 0792342f2a Removed more calls to deprecated GenericDelegator methods
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655016 13f79535-47bb-0310-9956-ffa450edef68
2008-05-10 06:24:19 +00:00
David E. Jones 329631a4b5 A whole bunch of cleanups to use newer and more consolidated delegator find methods; still lots of deprecation warnings, bots of deprecation warnings but this is a first pass, and things still run as before
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653029 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 09:40:51 +00:00
David E. Jones ccb4689365 Added entity set for fixed asset, was missed originally
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@639473 13f79535-47bb-0310-9956-ffa450edef68
2008-03-20 21:43:26 +00:00
Jacopo Cappellato 920dbb91c6 Added missing service and screen definitions.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@638697 13f79535-47bb-0310-9956-ffa450edef68
2008-03-19 03:58:36 +00:00
David E. Jones 999834c2e8 Fixed incorrect package reference for the config entity group
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@635428 13f79535-47bb-0310-9956-ffa450edef68
2008-03-10 04:09:23 +00:00
David E. Jones f2bfb2e3e4 Some cleanups and fleshed out the detail and technical entity sets
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@632727 13f79535-47bb-0310-9956-ffa450edef68
2008-03-02 09:18:04 +00:00
David E. Jones 3d8d9bff51 A start on the entity groups for detailed diagrams
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@631869 13f79535-47bb-0310-9956-ffa450edef68
2008-02-28 06:37:42 +00:00
David E. Jones b58911fa4a Fixed exporting entity eomodeld by entityGroupId
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@631078 13f79535-47bb-0310-9956-ffa450edef68
2008-02-26 03:32:50 +00:00
David E. Jones 69f2a3beff Some cleanups and additions to top level entity diagram groups
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@631073 13f79535-47bb-0310-9956-ffa450edef68
2008-02-26 03:10:14 +00:00
David E. Jones bef729776b Added entity group definition file for some high level diagrams of top-level entities throughout the project
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@631072 13f79535-47bb-0310-9956-ffa450edef68
2008-02-26 02:53:28 +00:00
David E. Jones e8d61ef0b7 Added initial implementation of entity EOModelBundle export, including various utility methods and refactoring and such
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@630279 13f79535-47bb-0310-9956-ffa450edef68
2008-02-22 18:17:21 +00:00
David E. Jones 80acfcb716 Fixed tabs to spaces; it is evil that eclipse comes with this sort of default...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@628703 13f79535-47bb-0310-9956-ffa450edef68
2008-02-18 12:34:08 +00:00
David E. Jones eb542c49ad A few misc cleanups/improvements; some generics stuff, use FastMap/List, convenience methods for meta data
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@628700 13f79535-47bb-0310-9956-ffa450edef68
2008-02-18 12:21:13 +00:00
David E. Jones edafa04bd7 Added seed-initial data set and changed all JobSandbox seed data entries to be in this instead; allows for reloading of seed data withows for reloading of seed data without redundant jobs scheduled
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@627824 13f79535-47bb-0310-9956-ffa450edef68
2008-02-14 18:26:44 +00:00
Hans Bakker 9d4f24a0d3 improved implementation of rev 616995 as suggested by david.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@617966 13f79535-47bb-0310-9956-ffa450edef68
2008-02-03 09:14:56 +00:00
Hans Bakker 67a5ebe862 Entity sync did not work for deletes because the timestamps of the deleted record where also checked to be the same as the original record, this however was never true, even not after the copy of the complete database. Now the deleted record is only checked for the primary key.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@616995 13f79535-47bb-0310-9956-ffa450edef68
2008-01-31 03:59:59 +00:00
David E. Jones 75c26763e5 Fairly significant update to correct a long-standing problem; reverted ByteWrapper back for backward compatibility, and then replaced all use of ByteWrapper with java.nio.ByteBuffer; the main point is to both store only the byte[] data in the database and not a serialized object containing the byte[], and at the same time be able to read the old ByteWrapper objects, and there is a service to read and update all old data to be plan bytes instead of wrapped in a serialized object; this includes changing the java-type for blob fields to be java.sql.Blob to greater compatibility and flexibility, ie you can either set a plain byte[] or you can pass in a Blob object to be persisted, you can also get both as get returns java.sql.Blob, but getBytes always returns the byte[], converting as needed; this is tested a fair amount, but obviously needs to be watched as it is new code
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@587433 13f79535-47bb-0310-9956-ffa450edef68
2007-10-23 09:52:49 +00:00
Adam Heath c69096e93a Switch as much as possible from StringBuffer to StringBuilder.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585805 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 02:56:02 +00:00
Adam Heath 2ff7a8a575 Make use of the single-arg variants of makePK/makeValue, removeAll,
and clearCacheLine


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585803 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 02:46:57 +00:00
Adam Heath 2a86a44888 Allow multiple files to be installed on the command line, by splitting
on comma.  Closes https://issues.apache.org/jira/browse/OFBIZ-1284


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585645 13f79535-47bb-0310-9956-ffa450edef68
2007-10-17 19:46:52 +00:00
David E. Jones 2e96095d1c A few extensions to the watchEntity service
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@570297 13f79535-47bb-0310-9956-ffa450edef68
2007-08-28 03:23:23 +00:00
David E. Jones e20fb4bd36 Added set element for Entity ECA rules, and a simple service to be run as an EECA for watching entire entities or single fields on entities
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@570282 13f79535-47bb-0310-9956-ffa450edef68
2007-08-28 00:47:58 +00:00
David E. Jones 07b48643c5 As noted needing to be done by Jacques Le Roux did a search/replace on source=1.4 and changed to 1.5
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@541997 13f79535-47bb-0310-9956-ffa450edef68
2007-05-27 15:55:18 +00:00
David E. Jones 7d70c41c12 Did a big search/replace to change all xsd file refs from www.ofbiz.org to ofbiz.apache.org
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@539504 13f79535-47bb-0310-9956-ffa450edef68
2007-05-18 15:47:14 +00:00
Andrew Zeneski 800cb93c3c updated data loader new command line -help to show all valid arguments
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@523400 13f79535-47bb-0310-9956-ffa450edef68
2007-03-28 16:31:35 +00:00
Andrew Zeneski 5cf149b79f fixed so loading data for just a specific component works without having to specify readers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@523181 13f79535-47bb-0310-9956-ffa450edef68
2007-03-28 05:27:10 +00:00
Andrew Zeneski ec22d58cac implemented new data loading arguement -component to limit data loading to a single component (by name)
example:
java -jar ofbiz.jar -install -component=mycomponent -readers=seed,ext,demo



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@520902 13f79535-47bb-0310-9956-ffa450edef68
2007-03-21 14:48:21 +00:00
David E. Jones b5a7493883 Cleanup of LocalDispatcher creation through the GenericDispatcher object; consolidates a bunch of code and hopefully simplifies a things; should also more permanently fix the weird problem we were having with the testing services a bit ago
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@516271 13f79535-47bb-0310-9956-ffa450edef68
2007-03-09 02:45:55 +00:00
David E. Jones ff924a279a Changed a number of places to use File.toURI().toURL() instead of just File.toURL(); thanks to Andras Robert for his research and comments on this; looking at the Java API docs it looks like this basically just escaped the characters in the eventual URL
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@505358 13f79535-47bb-0310-9956-ffa450edef68
2007-02-09 16:37:05 +00:00
Jacques Le Roux dad67935f7 A (large) patch from Scott Gray "Update ASL header" (https://issues.apache.org/jira/browse/OFBIZ-637).
I put also some svn:ignore for shark build and lib diretories and assetmaint/build 

I did some by hand lately, too much to remember. They were files with old header but without copyright. A 1st attempt I suppose, will have to check this after this commit.

I add some problems to commit this patch in one piece because it's so huge (specially with Eclipse I had to turn to Tortoise) !

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@499486 13f79535-47bb-0310-9956-ffa450edef68
2007-01-24 17:15:54 +00:00
Jacques Le Roux a5632fa086 This is hte change of ASL2 headers in java files only.
Seems correct (35827 lines to review ;o).
I just wonder if we should keep the copyright comment in Classpath.java (about MortBay)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@496982 13f79535-47bb-0310-9956-ffa450edef68
2007-01-17 10:22:33 +00:00
Andrew Zeneski ad6e81d0e5 existing service group files migrated to new format
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@493120 13f79535-47bb-0310-9956-ffa450edef68
2007-01-05 18:27:44 +00:00
Jacques Le Roux bd428bde64 A patch from Stefan Huehner "Code-Cleanup: new Boolean(true) -> Boolean.TRUE" (https://issues.apache.org/jira/browse/OFBIZ-530).
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@484976 13f79535-47bb-0310-9956-ffa450edef68
2006-12-09 12:19:28 +00:00
Jacques Le Roux f855cb3f2b A patch from Stefan Huehner "Code-Cleanup: remove superflous new String and .toString() calls" (https://issues.apache.org/jira/browse/OFBIZ-533).
This files was missing because I had to revert them to resolve previous conflict


git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@484974 13f79535-47bb-0310-9956-ffa450edef68
2006-12-09 12:15:39 +00:00
Jacques Le Roux 084ff1b883 A patch from Stefan Huehner "Code-Cleanup: remove unncessary return at end of void function" (https://issues.apache.org/jira/browse/OFBIZ-536).
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@484972 13f79535-47bb-0310-9956-ffa450edef68
2006-12-09 11:52:56 +00:00
Jacques Le Roux 9b3b889c7b A patch from Stefan Huehner "Remove unused variables" (https://issues.apache.org/jira/browse/OFBIZ-525).
Issue is not closed : more patches to come

git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@483405 13f79535-47bb-0310-9956-ffa450edef68
2006-12-07 10:21:27 +00:00