Commit Graph
95 Commits
Author SHA1 Message Date
Adrian Crum e4ee374a66 Conversion from java.util.Calendar to com.ibm.icu.util.Calendar. I didn't convert the Cloud component - I wasn't sure if the Calendar class was being passed through SOAP.
OFBiz users who have modifications or add-ons can make the same substitution to get them to compile.

I'll let the dust settle from this, then I'll add the user-selected calendar capability.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792987 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 15:39:21 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
Andrew Zeneski 7b2d865ab7 added command line options to the install directive which drops/re-creates indices/fks/pks and adjusts column widths; updated the -install -help option to detail these changes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@787287 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 15:56:54 +00:00
Hans Bakker 9dec93e375 show full eca location in startup log
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@785512 13f79535-47bb-0310-9956-ffa450edef68
2009-06-17 08:48:02 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
Jacques Le Roux f29b4787b4 As suggested by David, these lines are not needed anymore
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771090 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 17:19:37 +00:00
Adrian Crum 9a753b9865 Fixed a problem where service definitions were using "GenericValue" as attribute types, but that threw exceptions because the service definitions needed the full class name - "org.ofbiz.entity.GenericValue". The problem was reported in https://issues.apache.org/jira/browse/OFBIZ-2268 and https://issues.apache.org/jira/browse/OFBIZ-2311.
I checked the commit logs and I don't see what changed to cause these services to stop working, so I took the shotgun approach and changed all occurrences of GenericValue service attributes.

If anyone has a better solution, please feel free to revert this commit and change it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765864 13f79535-47bb-0310-9956-ffa450edef68
2009-04-17 06:33:43 +00:00
Scott Gray 7531687fdd OFBIZ-2259: Implemented test data rollback per test-suite using the GenericDelegator
Provides the following benefits:
1. Test data independence per component suite
2. Ability to run tests repeatedly without reloading the database
3. Continued database independence for the testing tools
4. The possibility of future improvements for controlling when data is rolled back (per unit test, group of unit tests within a suite or
even tree structured tests where data is partially rolled back before continuing)
5. The future possibility to export data changes resulting from a test run
6. The future possibility to verify a test result automatically based on the output of #4

The rollback currently doesn't catch changes resulting from async service calls and also doesn't rollback changes to SequenceValueItem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765057 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 06:01:36 +00:00
Jacques Le Roux 5dd48e08bf Fix a bug (data reader move not done)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763214 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 12:30:31 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath 1f45b2448a Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759233 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:56:29 +00:00
David E. Jones 8c423bc529 Moved EntityDiagramGroupData.xml from entityext to commonext to resolve framework dependency; a few other little cleanups as well
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757639 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 02:53:31 +00:00
Adam Heath c43fd04b17 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757070 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:23:34 +00:00
Jacques Le Roux 274ee4287e entityext component
Following best practice.
Changed location="org/ofbiz/......... to location="component:// in the service location attribute.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755947 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 11:54:08 +00:00
Jacques Le Roux f796e230d2 catch( => catch(
}else => } else

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751005 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:55:43 +00:00
Jacques Le Roux fc6db9e886 if( => if (
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750997 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:36:09 +00:00
Jacques Le Roux 13a934f823 In spirit of Adam's r749341 and following http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#489
The idea is also that a lot of code is duplicated and then changed (copy/paste). Hence having a rightly formatted code help to keep it rightly formatted
1st (simple) step : ){ => ) { (I checked all occurrences but of course other pairs of eyeballs are welcome)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750993 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:31:13 +00:00
David E. Jones 4d9382e887 Cleanup and pretty-up a bunch of log statements; moved some less helpful ones to verbose, combined some, and generally tried to make logs in various places more user friendly
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741424 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:04:58 +00:00
Jacques Le Roux 572b7683e0 All tabs to 4 spaces in *.groovy, *.java, *.xml : less problems in future with that aspect...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737003 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 11:08:47 +00:00
David E. Jones fd152ab960 Improved GenericValue.checkFks method so that is dummy fk value is created then it will inherit the values create/update stamps so it doesn't seem like newer data; should fix issue reported by Sam Hamilton about 2-way entity sync erasing data when dummy fks are needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@733423 13f79535-47bb-0310-9956-ffa450edef68
2009-01-11 06:53:05 +00:00
Jacques Le Roux 94225b1a34 Fix issues with now-timestamp-to-env and sequence-id-to-env : their factories names where missing in org.ofbiz.minilang.method.MethodOperation$Factory file
also
<sequenced-id-to-env(.*)env-name => <sequenced-id$1field
<now-timestamp-to-env(.*)env-name => <now-timestamp$1field
both on *SimpleMethods*.xml, *events*.xml, *formula*.xml, *services*.xml, *tests*.xml (previously I only used *events*.xml, *services*.xml, but I guess it's not a big deal for now)




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730433 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 17:47:37 +00:00
Jacques Le Roux 0272162a99 revert both
sequenced-id(.*)field to <sequenced-id-to-env$1env-name
<now-timestamp(.*)field => <now-timestamp-to-env$1env-name
Something is wrong with these 2 tags (inconsistency between xsd and java, I'll look at it)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730397 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 13:59:08 +00:00
Jacques Le Roux dbc4228779 <now-timestamp-to-env env-name => <now-timestamp field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730194 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:25:18 +00:00
Jacques Le Roux c1dd5bc296 <remove-value value-name => <remove-value value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730191 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:21:47 +00:00
Jacques Le Roux 79f471e380 <sequenced-id-to-env(.*)env-name => <sequenced-id$1field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730189 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:19:35 +00:00
Jacques Le Roux 38456812e0 <field-to-result(.*)field-name => <field-to-result$1field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730116 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 12:14:23 +00:00
Jacques Le Roux e01e175266 <entity-one(.*)value-name => <entity-one$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730111 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 12:07:14 +00:00
Jacques Le Roux e25c1d9c67 <create-value(.*)value-name => <create-value$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730108 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 12:01:09 +00:00
Jacques Le Roux 4ed4fcf8b9 same but with non
<set-pk-fields(.*)map-name => <set-pk-fields$1map
<set-pk-fields(.*)value-name => <set-pk-fields$1value-field
I was not very clever on this one ;)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730107 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:59:10 +00:00
Jacques Le Roux ec8447c72a <set-pk-fields(.*)map-name => <set-pk-fields$1map
<set-pk-fields(.*)value-name => <set-pk-fields$1value-field

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730104 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:55:26 +00:00
Jacques Le Roux 288c384783 <find-by-primary-key(.*)map-name => <find-by-primary-key$1map
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730101 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:51:58 +00:00
Jacques Le Roux 0f82bfeb3d <find-by-primary-key(.*)value-name => <find-by-primary-key$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730100 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:49:32 +00:00
Jacques Le Roux 5e38ebc0ea <make-value(.*)value-name => <make-value$1value-field
r730090 was naive fix also <iterate list-name and entry-name to <iterate list and entry

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730098 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:28:24 +00:00
Adrian Crum 7692f1851b Updated the job scheduler to use temporal expressions. Recurrence rules still work - so there is no rush to change existing installations.
I moved the recurrence count to the job sandbox. Keeping counters in the recurrence info was a bad idea. Any other code that relied upon counters in recurrence info will have to be redesigned to use temporal expressions.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@695695 13f79535-47bb-0310-9956-ffa450edef68
2008-09-16 00:10:17 +00:00
Adrian Crum ead3169d5c FlexibleStringExpander refactor.
1. Improved parsing logic - the entire expression is pre-parsed now.
2. Factory method stores parsed expressions in the cache.
3. Single null/empty expression instance - saves on memory.
4. Class names and variable names shortened to reduce object size.
5. Small performance improvements.

The expression cache is set up with no limit. We'll have to see if that needs to be changed. Larger installations might need to limit the expression cache size.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@687422 13f79535-47bb-0310-9956-ffa450edef68
2008-08-20 18:50:04 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath 99bf46f085 Switch most new File(string_with_path_separator) calls to
FileUtil.getFile.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682266 13f79535-47bb-0310-9956-ffa450edef68
2008-08-04 06:08:42 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Jacques Le Roux 641ff10050 Update Copyright to 2008
A real replace in files feature was one of the reasons I use Eclipse 3.4 for near a year now (I even helped to test, a real must have :o)
Not sure previous commit was sent partially or not at all (I needed to update)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@677685 13f79535-47bb-0310-9956-ffa450edef68
2008-07-17 18:56:25 +00:00
David E. Jones 204d775174 More entitygroups gone, all of framework
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672910 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:49:10 +00:00
Adam Heath 89249b2432 Generics and java1.5 features.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672897 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:16:55 +00:00
David E. Jones 3797437015 Changed to support a default-group-name per delegator, so that they don't have to specified for each entity; also some cleanups of the DelegatorInterface to remove deprecated stuff and add some new things, I still don't think that needs to exist but oh well
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672821 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 17:04:43 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Scott Gray 5e401fcd53 Updated all simple methods to use the new attributes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667748 13f79535-47bb-0310-9956-ffa450edef68
2008-06-14 06:03:12 +00:00
David E. Jones 82df3529e2 More cleanups of now deprecated constructors and what what
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660840 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 07:16:36 +00:00
David E. Jones b9d6f8b524 Changed EntityExpr and EntityFunction subclasses to use the factory instead of constructor pattern, plus moved EntityExpr to EntityCondition factory methods; a number of EntityExpr cleanups, but many more to go
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660812 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 05:20:09 +00:00
David E. Jones 3543d6abe3 Changed the way EntityCondition sub-classes work so they use the javolution Reusable class for recycling objects; now all conditions should be created using the factory methods on the EntityCondition object instead of the direct constructors; there is a small variety of classes available there now for ease of use; also changed a bunch of old code to not use the deprecated constructors; note that still need to do a pass similar to this on EntityExpr
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@660780 13f79535-47bb-0310-9956-ffa450edef68
2008-05-28 01:58:46 +00:00
Scott Gray 153653615b Removed the rest of the calls to deprecated GenericDelegator methods, except for the findListIteratorByCondition which takes a DynamicViewEntity as a parameter not sure what to do about that one.
There's still all the bsh files to check though.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655235 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 03:29:04 +00:00
Scott Gray 0792342f2a Removed more calls to deprecated GenericDelegator methods
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655016 13f79535-47bb-0310-9956-ffa450edef68
2008-05-10 06:24:19 +00:00