Commit Graph
5087 Commits
Author SHA1 Message Date
Jacques Le Roux 4ced84dd08 A patch from Karl Pitrich "When editing Portal Pages, Drag & Drop for Portlets does not work" (https://issues.apache.org/jira/browse/OFBIZ-3889) - OFBIZ-3889
When editing Portlet Pages, either in MyPortal or PortalAdm, Drag & Drop of Portlets does not work.
Where are several Issues in the MyPortal, some have fixes, none is commited to trunk.

Problems:

    * in myportal.js, function getDestinationInformationPortlets(): DOM ID's are not handled correctly
    * in framework/webtools/widget/PortalAdmScreens.xml: required javascript + css files are not included


JLR: 
While working on this I have found other issues: the login.ftl files used in hhfacility and myportal were not tenant enabled. They are different  but by chance in myportal very close to common so I was finally able  to do both at along with  Karl's changes. Actually I wanted to do 2 commits but forget to uncheck the files while doing a second attempt to commit.

MyPortal
 * The login process in MyPortal was not tenant enabled, it's done in this commit.
 * I kept its specificity : newRegisterLogin and wonder why it has not been extended to common?

hhfacility
The login process in hhfacility was not tenant enabled, it's done in this commit. Doing so, I saw there i18n is not done, not an issue for me...







git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@985163 13f79535-47bb-0310-9956-ffa450edef68
2010-08-13 11:43:38 +00:00
Jacques Le Roux b7642843fd Fixes 2 typos in Javadoc found by chance
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@983946 13f79535-47bb-0310-9956-ffa450edef68
2010-08-10 11:55:44 +00:00
Jacques Le Roux b552004b9b A patch from René Scheibe ""setShippingOption" service called from one page checkout throws Exception" (https://issues.apache.org/jira/browse/OFBIZ-3886) - OFBIZ-3886
The shippingTotal has to be a BigDecimal for the methods called...

    * org.ofbiz.base.util.UtilFormatOut.formatCurrency(...)
    * org.ofbiz.order.shoppingcart.ShoppingCart.setItemShipGroupEstimate(...)

...so in case it's null, initialize it with BigDecimal.ZERO instead of 0.00

Fixes also some JavaDoc in UtilFormatOut.java

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@983920 13f79535-47bb-0310-9956-ffa450edef68
2010-08-10 10:43:01 +00:00
Adam Heath da0da53f2a Fix importing of data in webtools xml file import.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@982871 13f79535-47bb-0310-9956-ffa450edef68
2010-08-06 04:47:01 +00:00
Adam Heath b273b52dad Finally created a script to find and fix tons of missing final newlines.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@982870 13f79535-47bb-0310-9956-ffa450edef68
2010-08-06 04:46:48 +00:00
Adam Heath 2da92e401f Some more trailing newline changes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981698 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 22:32:54 +00:00
Adam Heath d06f72f7f9 FEATURE: Start of union support; parsing isn't tested yet.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981640 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:44:20 +00:00
Adam Heath 872db5befd FEATURE: Start of aggregate function support.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981639 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:44:12 +00:00
Adam Heath 550d275781 FEATURE: Add count-all variant that doesn't require a table name.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981638 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:44:05 +00:00
Adam Heath ca01d94d2a FEATURE: Add support for CREATE INDEX.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981637 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:44:00 +00:00
Adam Heath 56c7c3391a FEATURE: ORDER BY now supports any ConstantValue, which includes any
function, and also math operations.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981636 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:53 +00:00
Adam Heath 066b0716d8 Expose a helper method for parsing order by items.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981635 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:47 +00:00
Adam Heath f7ad0f1ea6 Allow external callers to parse individual OrderByItem instances.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981634 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:42 +00:00
Adam Heath 055e49cb5a FEATURE: Add support for NULLS FIRST/LAST in ORDER BY.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981633 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:36 +00:00
Adam Heath 8ebec8e647 OPTIMIZE: Remove descending and orderingSet booleans, they weren't being used
properly.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981632 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:30 +00:00
Adam Heath 5147b48afa TESTS: Ensure that no more statements has been parsed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981631 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:25 +00:00
Adam Heath eebce0b77f BUG FIX: Fix parsing of -/+ style order by prefixes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981630 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:19 +00:00
Adam Heath 6772e47dd6 FEATURE: Add basic implementations of the available visitors.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981629 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:13 +00:00
Adam Heath 2923612353 OPTIMIZE: Remove unused variable i from Select().
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981628 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:08 +00:00
Adam Heath f150eecfb9 BUG FIX: CountAll needs to remember the tableName; also implement
equals.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981627 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:43:02 +00:00
Adam Heath 46b66d2bd2 BUG FIX: Fix correct formatting around the operator.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981626 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:55 +00:00
Adam Heath 33809facfe TESTS: Start adding low-level object unit tests.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981625 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:49 +00:00
Adam Heath c9f9555c25 No longer use ON in relation settings; instead, use MAP, which makes the
sql a little bit simpler.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981624 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:39 +00:00
Adam Heath 1581156412 TESTS: Test reparsing of all statements.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981623 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:33 +00:00
Adam Heath a9aa86c234 BUG FIX: OFFSET/LIMIT have to be after ORDER BY/GROUP BY.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981622 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:28 +00:00
Adam Heath 1fc630261e BUG FIX: Fix toString with multiple RELATION, they should not be
separated by commas.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981621 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:23 +00:00
Adam Heath 3ade64a656 OPTIMIZE: KeyMap no longer extends Atom, so no longer has any appendTo variants.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981620 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:17 +00:00
Adam Heath 0864fca12f BUG FIX: Fix multiple keymaps in a relation, wasn't separated by AND.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981619 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:11 +00:00
Adam Heath bc6a4b7870 Introduce a new method, getDefaultName(), so that null alias logic
doesn't happen in the constructor.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981618 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:06 +00:00
Adam Heath f8e091775c FEATURE: Make public wrappers around several internal methods.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981617 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:42:00 +00:00
Adam Heath 3929451368 FEATURE: Create a new StaticValue function, based on the contents of
FieldDef.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981616 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:55 +00:00
Adam Heath 81a56ac59c REFACTOR: Move FieldAll call to a new function, SelectField.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981615 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:50 +00:00
Adam Heath e544bd6be0 REFACTOR: Optimize select AS support, so it is only required in one place.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981614 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:44 +00:00
Adam Heath 806332cc89 REFACTOR: Optimize FieldDef, so that the FieldDef object instantiation only
happens in one place.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981613 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:39 +00:00
Adam Heath b98105c65f REFACTOR: Abstract out FieldAll so it can be called externally.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981612 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:34 +00:00
Adam Heath 54c6cb0f16 FEATURE: Add static valueOf methods.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981611 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:28 +00:00
Adam Heath 0038f309a5 FORMAT: Re-indent; couldn't find a standard for indentation, so this is an
attempt to have some sort of common pattern for doing so.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981610 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 17:41:23 +00:00
Adam Heath 5b4e8071c5 Add appendTo/append variant that allows for a prefix and suffix around
the separator.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981533 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 14:46:21 +00:00
Adam Heath cb1646e320 More StringUtil tests; This also tests double-encoding detection, which
required changing the type of defaultWebEncoder.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981532 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 14:46:15 +00:00
Adam Heath 77912ea777 StringUtil now has a private constructor; all uses of it must use the
singleton static INSTANCE(only one such use is in ofbiz).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981531 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 14:46:09 +00:00
Adam Heath ce409cd671 Start adding StringUtil tests.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981530 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 14:46:02 +00:00
Adam Heath 509532a3d4 Add methods for testing iterability.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981529 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 14:45:54 +00:00
Scott Gray 10a56ea013 Copied CommonWorkers.hasParentType(...) over to EntityTypeUtil and deprecated the method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981446 13f79535-47bb-0310-9956-ffa450edef68
2010-08-02 10:47:26 +00:00
Scott Gray b4b155de17 Commented test-suite declaration in webapp's ofbiz-component.xml because the contents of the test suite file are themselves commented out
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981174 13f79535-47bb-0310-9956-ffa450edef68
2010-08-01 08:51:36 +00:00
Adam Heath 66b76faf4e The database check attempted to only check each helper once; however,
the Set used to track whether a helper had been checked was *inside* the
loop, so this optimization never actually did what was intended.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981123 13f79535-47bb-0310-9956-ffa450edef68
2010-08-01 03:08:07 +00:00
Scott Gray ad81f1d1f1 Null check was incorrectly being used to determine if the directory existed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981104 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 23:47:55 +00:00
Adrian Crum de50263021 Built out the new service parameter description feature. Descriptions defined in service interfaces are not being copied to the implementations - so that needs to be fixed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981067 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 15:16:46 +00:00
Jacques Le Roux 04d803790b A patch from Rene Scheibe "Click Expand or Colaspe All does not work as expected" (https://issues.apache.org/jira/browse/OFBIZ-3744) - OFBIZ-3744
Reported by Sam Hamilton:
If you are on say this page - https://localhost:8443/catalog/control/EditProduct?productId=WG-9943
clicking on Expand All it will expand all the ones not expanded and then collapse the ones that were already open
clicking on Collapse All it will collapse all the ones open and open all the ones that were collapsed.

fixed issue

    * css.style.visible cannot be true/false as used so in collapseAll()
    * now using the $() container and calling visible() which returns true/false


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981051 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 13:07:13 +00:00
Jacopo Cappellato 2a7d97b45d Always close the stream of the xml file after the parsing is done: this fixes a bug where the file was not deleted when it was successfully imported at the second or third attempt.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981028 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 10:13:49 +00:00
Scott Gray 4448c4a866 No functional changes, just removing a whole bunch of unused imports and reorganizing them along the way.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@981019 13f79535-47bb-0310-9956-ffa450edef68
2010-07-31 08:28:34 +00:00