===
Improved: Remove all the fk dependencies from stats entities to the business entities
(OFBIZ-10721)
stats related entities foreign key relation has been removed by Jacopo at r#1647271 and new group org.apache.ofbiz.stats introduced for stats related entity. Some remnants were still left in stats entities.
Removed relations of Party, ContactMech and Content from ServerHit entity.
Removed relations of Content from ServerHitBin entity.
Removed relations of UserLogin from Visitor entity.
Thanks Jacques Le Roux and Deepak Dixit for the review.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1849288 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Inconsistent behaviour of ServiceDispatcher.checkAuth
(OFBIZ-10712)
We have checkAuth method in service dispatcher class, this method performs multiple auth related check.
if all checks passed it call the modelService.makeValid method to prepare service context (line#960) but this code executed only when service definition has a permission service call.
If service does not have any permission service call then it does not call the modelService.makeValid and this may cause the service validation issue unknown parameter found.
Ideally modelService.makeValid should call irrespective to permission service check.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1849194 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: ControlEventListener - Change Log-Level
(OFBIZ-10330)
The Log-Level of the Message "Could not find visit value object in
session..." is changed from "warning" to "info".
Thanks Benjamin Jugl for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1848468 13f79535-47bb-0310-9956-ffa450edef68
===
Seed data sequence bug regarding "MIDNIGHT_DAILY" TemporalExpression.
(OFBIZ-10533)
The TemporalExpression for "MIDNIGHT_DAILY" has to be loaded as seed
data instead of initial-seed data to be available for other seed-initial
usages of this TemporalExpression.
The fix moves this TemporalExpression to the other TemporalExpression
seed data in ServiceSeedData.xml.
Thanks Martin Becker for reporting and providing the patch.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1848450 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1848398 | jleroux | 2018-12-07 14:14:48 +0100 (ven. 07 déc. 2018) | 17 lignes
Fixed: User's name is displayed on ecommerce even after user logs out
(OFBIZ-10666)
Steps to regenerate:
Open URL: https://demo-trunk.ofbiz.apache.org/ecommerce/control/main.
Welcome is displayed and user's name is not displayed when URL is opened.
Login at ecommerce, username will be displayed after user logs in.
Logout of ecommerce by clicking on logout. User will be logged out and login
link will be displayed in place of logout link, but the name of user is still
displayed.
Actual: Username is still displayed after user logs out
Expected: Username should not be displayed after the user logs out
Note: Similar issue also exists when the user clicks on (Not You?) link.
Thanks: Arpit Mor for detailled report, Deepak Dixit for discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1848399 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1847478 | jleroux | 2018-11-26 17:41:52 +0100 (lun. 26 nov. 2018) | 21 lignes
Improved: Multi Part Input Parameters not Available in Groovy Event
(OFBIZ-5048)
If a form is of type enctype="multipart/form-data" and we are handling its
submission through Groovy Event then in the parameters Map Ofbiz does not set
the multipart input parameters from request parameters.
The same are available when multipart form submission is handled through service.
The reason being the code that sets the multipart parameters in request
attribute is only available in ServiceEventHandler.java and in
GroovyEventHandler the multipart are never set.
So I have created a method getMultiPartParameterMap in the class UtilHttp.java
and put the common logic in that method so that when getCombinedMap method is
called from the GroovEventHandler the method also call getMultiPartParameterMap
and in the ServiceEventHandler I have written a call for
getMultiPartParameterMap method.
Thanks: Vikramjit Singh for report and initial patch, Rohit Koushal for updated
and revised patch with some minor changes.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1847955 13f79535-47bb-0310-9956-ffa450edef68
R17 branch
(OFBIZ-10657)
Convert Birt component doc from Markdown to AsciiDoc
(OFBIZ-10647)
As discussed in https://markmail.org/message/x7sv2mpvtytr4vl4 we decided to
backport the Asciidoc documentation, and means to generate it, to R17 branch
This is related with OFBIZ-10651 and OFBIZ-10652 tasks.
So 2 parts are impacted: code in framework and plugins and Buildbot script.
It's only a copy from the trunk to the R17 branch, including *.adoc files,
related images and the build.gradle script.
I previous commit I missed to remove security-impersonation.adoc now replaced
by sy-impersonation.adoc
Forgot to commit the plugins part. Including replacing Birt Markdown
documentation by Asciidoc (OFBIZ-10647)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1847253 13f79535-47bb-0310-9956-ffa450edef68
R17 branch
(OFBIZ-10657)
As discussed in https://markmail.org/message/x7sv2mpvtytr4vl4 we decided to
backport the Asciidoc documentation, and means to generate it, to R17 branch
This is related with OFBIZ-10651 and OFBIZ-10652 tasks.
So 2 parts are impacted: code in framework and plusing and Buildbot script.
It's only a copy from the trunk to the R17 branch, including *.adoc files,
related images and the build.gradle script.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1847248 13f79535-47bb-0310-9956-ffa450edef68
===
Fixed: Missing Security and Cache Headers in CMS Events
(OFBIZ-10597)
Instead of having multiple null checks for viewMap separately for each security header we can have a single combined null check at the top in setResponseBrowserDefaultSecurityHeaders() method.
With increasing security headers these may become expensive.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1846633 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845933 | jleroux | 2018-11-06 17:33:11 +0100 (mar. 06 nov. 2018) | 16 lignes
Fixed: Error in GetLocaleListTests.java
(OFBIZ-10641)
A test error related to GetLocaleListTests.java seems to happen only on a fresh
trunk install when running unit tests. It's no stopping tests.
I'm not sure yet if R17 is concerned. I did not try, but will 1st confirm with
this commit with trunk demo error.loç
Mathieu suggested to replace the location
component://base/config/GroovyInit.groovy
with ofbizhome://framework/base/config/GroovyInit.groovy
because GroovyUtil [should not] depend on the component container in the
1st place, and it seems to work.
Thanks: Mathieu for the idea.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1845989 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845558 | jleroux | 2018-11-02 10:46:42 +0100 (ven. 02 nov. 2018) | 15 lignes
Fixed: Correct behaviour of Autologin cookies
(OFBIZ-10635)
Renames "keep-autologin-cookie" to "use-autologin-cookie", and only create
Autologin cookies when needed. No need to create Autologin cookies in
applications that don't need it.
Don't pass webAppName to LoginWorker::getSecuredUserLoginId, that can be handled
with improved LoginWorker::getSecuredLoginIdCookieName
Removes LoginWorker::autoLogoutCleanCookies, no longer needed since only those
needed are created and kept (1 year at least after creation).
For both autoLogin and securedLoginId cookies sets the path to the application.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1845568 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845552 | jleroux | 2018-11-02 09:48:31 +0100 (ven. 02 nov. 2018) | 9 lignes
Fixed: ComponentConfig::getAppBarWebInfos creates infos only for components
without <<app-bar-display="false">>
(OFBIZ-10637)
LoginWorked::getAppBarWebInfos is used to define the apps menus in themes so we
need to also check that no menuName is passed to
ComponentConfig::getAppBarWebInfos. Else all menus appears in the secondary menu
bars
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1845553 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845544 | jleroux | 2018-11-02 08:59:16 +0100 (ven. 02 nov. 2018) | 5 lignes
Fixed: ComponentConfig::getAppBarWebInfos creates infos only for components
without <<app-bar-display="false">>
(OFBIZ-10637)
It makes no sense since if the menuName var is empty the infos are returned.
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1845545 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1845418 | jleroux | 2018-11-01 10:36:35 +0100 (jeu. 01 nov. 2018) | 20 lignes
Fixed: Missing Security and Cache Headers in CMS Events
Fixed:
(OFBIZ-10597)
While rendering the view through the controller request we set the important
security headers like x-frame-options, strict-transport-security,
x-content-type-options, X-XSS-Protection and Referrer-Policy etc. in the
response object. (Please see the 'rendervView' method of RequestHandler class.)
In the similar line, we set the cache related headers like Expires,
Last-Modified, Cache-Control, Pragma.
But these security headers are missing in the pages rendered through CMS.
(Please visit the CmsEvents class).
These headers are very crucial for the security of the application as they help
to prevent various security threats like cross-site scripting,
cross-site request forgery, clickjacking etc.
Thanks: Deepak Nigam for initial patch and review
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1845419 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1843225 | jleroux | 2018-10-09 10:16:01 +0200 (mar. 09 oct. 2018) | 6 lignes
Documented: Wrong handling of response type "cross-redirect"
(OFBIZ-10569)
The documentation was wrong, this fixes it
Thanks: Dennis Balkir for the report and discussion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1843226 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1842372 | jleroux | 2018-09-30 15:49:30 +0200 (dim. 30 sept. 2018) | 11 lignes
Fixed: Service Log screen is broken
(OFBIZ-10342)
Steps to regenerate
Navigate to Logging menu under webtools
https://demo-trunk.ofbiz.apache.org/webtools/control/LogView
Select Service Log menu, see NPE error
Thanks: Swapnil M Mane for report and Swapnil and Rishi Solanki for reviews
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1842373 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1840199 | jleroux | 2018-09-06 11:53:23 +0200 (jeu. 06 sept. 2018) | 7 lignes
Fixed: Action (find) button not visible in LabelManager search screen
(OFBIZ-10549)
When a user executes a search/find action in the Label Manager, and there are
duplicated labels the 'Find' button is not visible anymore.
Thanks: Pierre Smits
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1840200 13f79535-47bb-0310-9956-ffa450edef68
===
Improved: Remove checks to store only 250 characters of URL in VisitHandler.getVisit() & ServerHitBin.saveHit()
(OFBIZ-10508)
When the code was committed the 'URL' field type had a size of 255 characters only which was later changed to 2000 characters. So, the above code logic to restrict no of characters can be removed now.
Removed null pointer check for initialRequest and initialReferrer as it is already handled while setting the values in UtilHttp.setInitialRequestInfo() method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1838257 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10460)
The setLocaleFromBrowser request map defined in common-controller.xml has an
attribute of auth=false
While the service associated with it in framework/common/servicedef/services.xml
has an attribute of auth=true.
jleroux: this was missing in the initial patch. At OFBIZ-9264 the description is
"it sets the time zone of the user logged in to it's browser time zone."
So being logged in seems needed, hence better to set auth=true everywhere
Thanks: as reported by Deepak in OFBIZ-10460 there is a problem with that.
So we need keep the inconsistence and the service protected.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1835616 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1835586 | jleroux | 2018-07-10 19:31:50 +0200 (mar. 10 juil. 2018) | 13 lignes
Fixed: setLocaleFromBrowser requires authentification
(OFBIZ-10460)
The setLocaleFromBrowser request map defined in common-controller.xml has an
attribute of auth=false
While the service associated with it in framework/common/servicedef/services.xml
has an attribute of auth=true.
jleroux: this was missing in the initial patch. At OFBIZ-9264 the description is
"it sets the time zone of the user logged in to it's browser time zone."
So being logged in seems needed, hence better to set auth=true everywhere
Thanks: Mathieu Lirzin for report
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1835587 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10458)
A new Junit test is implemented to validate that no duplicates are present.
Groovy service has been refactored to use a more functional style
Thanks Mathieu Lirzin for reporting and providing the patch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1835283 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832944 | jleroux | 2018-06-05 15:56:29 +0200 (mar. 05 juin 2018) | 17 lignes
Fixed: The first visit event are not executed in case of CMS
(OFBIZ-10389)
Execution of the first visit events depends on the trackVisit function
In RequestHandler.java file
if (this.trackVisit(request) && session.getAttribute("_FIRST_VISIT_EVENTS_") == null) {
// execute first visit event
}
trackVisit function does not honor the default controller request
(in this case, cms) So, we should improve the code of trackVisit to honor
default controller request.
Thanks: Swapnil M Mane
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1832945 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832756 | jleroux | 2018-06-03 10:33:09 +0200 (dim. 03 juin 2018) | 21 lignes
Fixed: Session fixation issue
(OFBIZ-10420)
Prevents the session fixation by making Tomcat generate a new jsessionId
(ultimately put in cookie). Only do when really signing in to avoid unnecessary
calls
This improves the way it's done by using request.changeSessionId() instead of
creating a brand new session. So there is no possible side effects on client and
no need to set initial request info (using setInitialRequestInfo)
Thanks: Taher for asking about it
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1832757 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832662 | jleroux | 2018-06-01 09:37:27 +0200 (ven. 01 juin 2018) | 12 lignes
Fixed: Session fixation issue
(OFBIZ-10420)
Fixes a session fixation security issue discovered by a client with the security
audit tool "IBM Security AppScan Enterprise , Version : 9.0.3.7"
Prevents the session fixation by making Tomcat generate a new jsessionId
(ultimately put in cookie).
Only do when really signing in to avoid unnecessary calls
Though if the client has disabled the use of cookies, then a session will be
new on each request, not a good choice on client side!
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1832663 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1832577 | zhangwei | 2018-05-31 03:20:54 +0200 (jeu. 31 mai 2018) | 1 ligne
Fixed: Incorrect data type conversion of variable serviceEndTime in CoreEvents.java
(OFBIZ-10419)
A minor fix for serviceEndTime conversion
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1832659 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1831831 | jleroux | 2018-05-18 10:11:55 +0200 (ven. 18 mai 2018) | 11 lignes
Fixed:: Dynamic values not rendering properly in property tag of fail-property
attribute
(OFBIZ-10406)
While calling checkProductRelatedPermission, if permission is failed ten
fail-property tag uses ${checkActionLabel} which is not handled properly in
MessageElement.java.
There are 2-3 other occurrences as well of such type but not in working
condition.
Thanks: Suraj
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1831832 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1831078 | jleroux | 2018-05-07 09:48:57 +0200 (lun. 07 mai 2018) | 6 lignes
Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)
Now that we use Tomcat 9 this problem is over
Thanks: Jacopo for upgrading to Tomcat 9
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1831080 13f79535-47bb-0310-9956-ffa450edef68
(OFBIZ-10369)
The events contained in the controller configuration for first-visit, pre-post processor and before-after login are executed in arbitrary order rather than the defined order.
If we define an event configuration as follow:
<after-login>
<event name=keepCartUpdated type=java path=org.apache.ofbiz.order.shoppingcart.ShoppingCartEvents invoke=keepCartUpdated/>
<event name=restoreAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=restoreAutoSaveList/>
<event name=saveCartToAutoSaveList type=java path=org.apache.ofbiz.order.shoppinglist.ShoppingListEvents invoke=saveCartToAutoSaveList/>
</after-login>
We wait that OFBIz run keepCartUpdated, restoreAutoSaveList and after saveCartToAutoSaveList event but the HashMap who organise them return arbitrary order and can return saveCartToAutoSaveList, keepCartUpdated and restoreAutoSaveList. Convert the HashMap to LinkedHashMap help to keep the loaded order.
Thanks to Vikas Mayur for solve this issue
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1830305 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1827439 | jleroux | 2018-03-21 21:53:41 +0100 (mer., 21 mars 2018) | 5 lines
Fixed: The "request" attribute type of the userLogin service is wrong
(OFBIZ-10304)
It should have been org.apache.catalina.connector.RequestFacade"
instead of javax.servlet.http.HttpServletRequest see the Jira for details
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1827440 13f79535-47bb-0310-9956-ffa450edef68
------------------------------------------------------------------------
r1826938 | jleroux | 2018-03-16 10:35:06 +0100 (ven., 16 mars 2018) | 12 lines
Fixed: Logout do not remove autoLogin
(OFBIZ-4959)
I used the only available (and I must say confusing) WebappInfo.getName() when
I needed the webAppName not the WebappInfoName. So this put in a new
WebappInfo.getMountPoint() and use it in getWebappInfo
Also use LoginWorker.autoLoginSet() in different places where I missed it. In
other words all autoUserLogin coockies are deleted on login and logout, and
an autoUserLogin cookie is created when going locally from a webapp to another,
with checkExternalLoginKey
------------------------------------------------------------------------
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/ofbiz-framework/branches/release17.12@1826939 13f79535-47bb-0310-9956-ffa450edef68