Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.
Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.
Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.
To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741374 13f79535-47bb-0310-9956-ffa450edef68
+ some correct changes done with this update of Labels Manager (I updated some wrong ones by hand to keep going forward...)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739955 13f79535-47bb-0310-9956-ffa450edef68
1) added {SHA} prefix to all hashed passwords
2) moved "admin" user to demo data; the only user maintained with seed data is now the "system" user
3) removed password for the "system" user; now there are no passwords in seed data
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739743 13f79535-47bb-0310-9956-ffa450edef68
<!-- tooltip="Same as above, uses the ${'${'bsh:...} notation to call an util method to get the now timestamp}"-->
<!-- tooltip="Same as above, uses the \${bsh:...} notation to call an util method to get the now timestamp}"-->
Maybe even all the block about this bsh syntax should be dropped anyway... (but can still be used, so maybe better to keep it ?)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737329 13f79535-47bb-0310-9956-ffa450edef68
I tried what is documented in the PDF here http://docs.ofbiz.org/download/attachments/6430/UEL.pdf, but no way.
<<To generate literal values that include the character sequence "${" or “#{“, the developer can choose to use a composite expression as shown here:
${'${'}exprA}
#{'#{'}exprB}The resulting values would then be the strings ${exprA} and #{exprB}.
Alternatively, the escape characters \$ and \# can be used to escape what would otherwise be treated as an eval-expression. Given the literal-expressions:
\${exprA}
\#{exprB}
The resulting values would again be the strings ${exprA} and #{exprB}.>>
Or maybe I'm missing something ? (Anyway it's a weird case ;o)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737328 13f79535-47bb-0310-9956-ffa450edef68
also
<sequenced-id-to-env(.*)env-name => <sequenced-id$1field
<now-timestamp-to-env(.*)env-name => <now-timestamp$1field
both on *SimpleMethods*.xml, *events*.xml, *formula*.xml, *services*.xml, *tests*.xml (previously I only used *events*.xml, *services*.xml, but I guess it's not a big deal for now)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730433 13f79535-47bb-0310-9956-ffa450edef68
sequenced-id(.*)field to <sequenced-id-to-env$1env-name
<now-timestamp(.*)field => <now-timestamp-to-env$1env-name
Something is wrong with these 2 tags (inconsistency between xsd and java, I'll look at it)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730397 13f79535-47bb-0310-9956-ffa450edef68
<store-value value-name => <store-value value-field ... Weird : I have already done this one in r730190 !
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730369 13f79535-47bb-0310-9956-ffa450edef68
<get-related(.*)list-name => <get-related$1list
<get-related(.*)\R(.*)list-name => <get-related$1\R$2list-name
<get-related(.*)\R(.*)value-name => <get-related$1\R$2value-field
<calculate field-name => <calculate field
<calcop(.*)field-name => <calcop$1field
<result-to-field(.*)field-name => <result-to-field(.*)field
<result-to-field(.*)field="(.*)"(.*) map-name="(.*)" => <result-to-field$1field="$4.$2"$3
<field-to-request field-name => <field-to-request field
(I had a connection break that's while I put all of them in one sole commit)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730183 13f79535-47bb-0310-9956-ffa450edef68
<set-pk-fields(.*)map-name => <set-pk-fields$1map
<set-pk-fields(.*)value-name => <set-pk-fields$1value-field
I was not very clever on this one ;)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730107 13f79535-47bb-0310-9956-ffa450edef68
value="${bsh: org.ofbiz.base.util.UtilDateTime.nowTimestamp()}"
replacing by
value="${date:nowTimestamp()}"
I let the other for now (it's easy to fix in all OFBiz by replacing the one by the other) for an live example to Adrian who is currently working on JUEL
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728135 13f79535-47bb-0310-9956-ffa450edef68