Commit Graph
293 Commits
Author SHA1 Message Date
Adrian Crum 7fa08f9079 Replaced GenericDelegator.getGenericDelegator(...) calls with new factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821649 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 01:53:50 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Jacques Le Roux 52a03030bb A new feature from Shi Yusen (https://issues.apache.org/jira/browse/OFBIZ-2948) - OFBIZ-2948
This change will make it possible to invoke both static method and instance method. See http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Method.html#invoke(java.lang.Object,%20java.lang.Object...)
Thanks to Scott for optimisation advice

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@819281 13f79535-47bb-0310-9956-ffa450edef68
2009-09-27 10:35:21 +00:00
Scott Gray 2afbb75457 Get rid of a whole pile of unnecessary string instantiations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818665 13f79535-47bb-0310-9956-ffa450edef68
2009-09-24 23:49:02 +00:00
Adam Heath 69a9cfb394 Fix typo in runAsync verbosity message.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@816007 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 23:24:24 +00:00
Adam Heath c8abe01fa5 Apply patch from OFBIZ-1023, adding returnSuccess(List); the javadoc
from the patch wasn't used, however.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@815916 13f79535-47bb-0310-9956-ffa450edef68
2009-09-16 18:10:49 +00:00
Adam Heath 0cdcfa6189 Service definitions are now wrapped with their filename and line
number, for easier debugging.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812783 13f79535-47bb-0310-9956-ffa450edef68
2009-09-09 06:15:08 +00:00
Adrian Crum 74ea95889c Reverted rev 802567.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812692 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 20:56:14 +00:00
Hans Bakker e0ba7104ce create a 'set' of documents: a technical and a user guide and added more info
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812021 13f79535-47bb-0310-9956-ffa450edef68
2009-09-07 07:31:11 +00:00
Jacques Le Roux 3fedb9e5ed Some ASL2 headers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811870 13f79535-47bb-0310-9956-ffa450edef68
2009-09-06 19:54:25 +00:00
Jacques Le Roux 97dc9401b3 A patch from Bob Morley "loadCartFromOrder assumes service call is successful" (https://issues.apache.org/jira/browse/OFBIZ-2782) - OFBIZ-2782
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810921 13f79535-47bb-0310-9956-ffa450edef68
2009-09-03 12:54:16 +00:00
Jacques Le Roux f2cc4c2d52 Fix for "ServiceUtil.getUserLogin tests on null but not empty" (https://issues.apache.org/jira/browse/OFBIZ-2838) - OFBIZ-2838
Thank you Al for report

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@810370 13f79535-47bb-0310-9956-ffa450edef68
2009-09-02 06:22:23 +00:00
Scott Gray 166671a08b Changed the reloadCrashedJobs method to look for crashed jobs by statusId rather than null finish and cancel dates
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@809530 13f79535-47bb-0310-9956-ffa450edef68
2009-08-31 10:24:58 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
David E. Jones d4aa04aee8 Added some documentation about the service definition transaction related attributes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@797962 13f79535-47bb-0310-9956-ffa450edef68
2009-07-26 17:45:24 +00:00
Adrian Crum e4ee374a66 Conversion from java.util.Calendar to com.ibm.icu.util.Calendar. I didn't convert the Cloud component - I wasn't sure if the Calendar class was being passed through SOAP.
OFBiz users who have modifications or add-ons can make the same substitution to get them to compile.

I'll let the dust settle from this, then I'll add the user-selected calendar capability.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792987 13f79535-47bb-0310-9956-ffa450edef68
2009-07-10 15:39:21 +00:00
David E. Jones 497a7cbf0d Change to handling of error messages in simple-methods called as a service to pass errors through in List/Map and not combine into one big String, add text you can't change, etc; now logs details and passes errors as-is
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@792633 13f79535-47bb-0310-9956-ffa450edef68
2009-07-09 18:51:00 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
David E. Jones b7120f61db Removed this deprecated flag for now since it isn't really deprecated yet
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@787416 13f79535-47bb-0310-9956-ffa450edef68
2009-06-22 21:47:09 +00:00
David E. Jones 776d75659c Added divs since it looks like in the bizznesstime theme that h2 no longer causes a newline; also fixed serial warning in ServiceEcaRule
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@780597 13f79535-47bb-0310-9956-ffa450edef68
2009-06-01 08:51:12 +00:00
Andrew Zeneski 336a1cf7b2 more improvements to the message wrapper logic for getting attachments and reading multipart messages; added methods to get headers; mail container now marks messages which are too big to process (the max size setting) as read (but never deleted) so they are not always being checked but remain in the mailbox for human review
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774178 13f79535-47bb-0310-9956-ffa450edef68
2009-05-13 03:05:00 +00:00
Andrew Zeneski 9bd6c7d37a added a bunch of mail handing methods to the message wrapper to make dealing with email messages easiler
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@774087 13f79535-47bb-0310-9956-ffa450edef68
2009-05-12 21:09:48 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
Adam Heath 1a31984695 Several minor generics fixes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771124 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:35:52 +00:00
Andrew Zeneski 485805fe3f Renamed AbtractAuthorization to AbstractAuthorization (bad typo)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770836 13f79535-47bb-0310-9956-ffa450edef68
2009-05-01 21:53:29 +00:00
Andrew Zeneski f36c5a9335 No longer requiring the boolean field 'expanded' as part of the API; after dicussing w/ Adrian; the FSE can handle pre-expanded strings
Added new API method findMatchingPermission() which takes a regular expression for the base permission returning the value of all matching permissions (see unit tests)
Fixed missing base permission in SecurityData.xml

JIRA OFBIZ-2381


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770401 13f79535-47bb-0310-9956-ffa450edef68
2009-04-30 19:14:48 +00:00
Andrew Zeneski d8f436a148 Integration with new Authz API - JIRA OFBIZ-2381
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769936 13f79535-47bb-0310-9956-ffa450edef68
2009-04-29 21:11:35 +00:00
Hans Bakker cdf0d78cf0 corrected non-thread safe code after a comment from David
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769377 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 12:46:43 +00:00
Hans Bakker 4c0c034121 some more faultfixing on customer request notifications: mainly the partyIdTo was not provided
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769274 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 07:49:12 +00:00
Hans Bakker 9c6612b740 intermittent error seems to be solved with this
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769236 13f79535-47bb-0310-9956-ffa450edef68
2009-04-28 04:16:19 +00:00
Scott Gray 4acd7cc4f9 Corrected simple method documentation regarding the transaction timeout UOM, added the same to the services xsd and fixed a couple of service defs that appeared
to be specifying milliseconds rather than seconds.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@769205 13f79535-47bb-0310-9956-ffa450edef68
2009-04-27 23:53:40 +00:00
Jacques Le Roux 5de088f285 I have not seen this error for some times, but anyway this is more secure, suggested by Stephen Rufle on user ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768675 13f79535-47bb-0310-9956-ffa450edef68
2009-04-26 07:43:24 +00:00
Hans Bakker 0c5a93074c fix the new notification services using sendMailFromTemplateSetting using body parameters
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@768245 13f79535-47bb-0310-9956-ffa450edef68
2009-04-24 10:08:55 +00:00
Adam Heath 886e885d39 Add a newInstance() variant that takes a collection of reader urls.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765737 13f79535-47bb-0310-9956-ffa450edef68
2009-04-16 20:06:18 +00:00
Scott Gray 7531687fdd OFBIZ-2259: Implemented test data rollback per test-suite using the GenericDelegator
Provides the following benefits:
1. Test data independence per component suite
2. Ability to run tests repeatedly without reloading the database
3. Continued database independence for the testing tools
4. The possibility of future improvements for controlling when data is rolled back (per unit test, group of unit tests within a suite or
even tree structured tests where data is partially rolled back before continuing)
5. The future possibility to export data changes resulting from a test run
6. The future possibility to verify a test result automatically based on the output of #4

The rollback currently doesn't catch changes resulting from async service calls and also doesn't rollback changes to SequenceValueItem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765057 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 06:01:36 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath a1a9782939 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759240 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:58:16 +00:00
David E. Jones 4a1705a315 Removed some more references to applications stuff from framework, including small cleanup of service engine to get rid of WebAppDispatcher and use new factory method in GenericDispatcher, and changed AvailableServices.groovy to get the real dispatcher list instead of a hard-coded one; also updated eclipse classpath file for new webslinger stuff
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757671 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 06:27:03 +00:00
Adam Heath a941692516 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757069 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:23:25 +00:00
Adam Heath 231f647742 Typo in javadoc.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@753371 13f79535-47bb-0310-9956-ffa450edef68
2009-03-13 20:01:44 +00:00
Adam Heath 9057861730 Add the appropriate configuration to allow webslinger to work at
runtime.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@753084 13f79535-47bb-0310-9956-ffa450edef68
2009-03-13 01:18:54 +00:00
David E. Jones a521969954 Changed the HTML checking to only check and never change values; if they come from a webapp they will already be canonicalized, and for services calling other services and such we don't want to do canonicalization or the like
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751990 13f79535-47bb-0310-9956-ffa450edef68
2009-03-10 06:14:15 +00:00
Jacques Le Roux f0b05c11a9 switch( => switch (
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751007 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:56:24 +00:00
Jacques Le Roux 13a934f823 In spirit of Adam's r749341 and following http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#489
The idea is also that a lot of code is duplicated and then changed (copy/paste). Hence having a rightly formatted code help to keep it rightly formatted
1st (simple) step : ){ => ) { (I checked all occurrences but of course other pairs of eyeballs are welcome)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750993 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:31:13 +00:00
Adam Heath ecd71ac2eb Revert back to the previous version.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750345 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 07:05:04 +00:00
Adam Heath c41f9edc98 Converted to <test-group>, as these are really all related.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750297 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 02:41:37 +00:00
David E. Jones 1a5c2de3c5 Changed LoginWorker.makeLoginUrl back to returning a String and implemented a more general solution for the @ofbizUrl and @ofbizContentUrl tags so that they do decoding and are now tolerant of encoded URLs just in case it happens; this should be a more general fix and avoid the problem more; also a few cleanups like resolving warnings
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744418 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 08:17:05 +00:00
David E. Jones 09825430f1 Added new allow-html tag on the attribute, auto-attribute, and override elements; has 3 options: none, safe, and any; the comments in the XSD file describe what each of these do; the important thing to know is that none is the default meaning no html is allowed; if html is needed use safe and look at the antisamy-esapi.xml file to see policy details; in extreme trust cases use any where any html is allowed; note that many services need updating which should allow at least safe html, and it may take some time to discover all of those and get them handled; please send in issues and requests for service attributes that should allow safe html
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742352 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 09:34:34 +00:00
David E. Jones 9075027988 Some cleanups, no functional changes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742238 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 03:16:02 +00:00