Jacques Le Roux
c72b29cb1f
Use UtilValidate.isNotEmpty methods instead of (obj != null) || (obj.length > 0) and (obj != null) || (obj.size > 0)
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883549 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 23:41:34 +00:00
Jacques Le Roux
5518e9baf8
Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.size == 0)
...
Complete r883492
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883516 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:02:05 +00:00
Adam Heath
820d11eb97
Deprecate UtilCache constructors, and add a create helper function.
...
This is the first step to making utilCacheTable concurrent, and
non-blocking. To do so, the constructor has to have no side-effects.
This means it can't modify utilCacheTable itself; this will be moved to
the helper function created above.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883217 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 02:56:28 +00:00
Jacques Le Roux
a5eae6afcc
Add an EncryptedString format possibilities in datafile (use in Record.java, needed some changes to build in framework/build.xml and datafile/build.xml)
...
+ datafile/dtd/datafiles.xsd enhanced with some documentations, and an enumeration for the type: I used all occurrences found in Record.setString() method)
+ datafile/dtd/datafiles-catalog.xml added
+ Few generics cleaning in login/LoginServices.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882892 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 13:10:07 +00:00
Jacques Le Roux
cd10618fcc
A patch from Bob Morley "Resolve java warnings exposed in Eclipse : framework - datafile" ( https://issues.apache.org/jira/browse/OFBIZ-3106 ) - OFBIZ-3106
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@832669 13f79535-47bb-0310-9956-ffa450edef68
2009-11-04 06:58:07 +00:00
Scott Gray
2afbb75457
Get rid of a whole pile of unnecessary string instantiations
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818665 13f79535-47bb-0310-9956-ffa450edef68
2009-09-24 23:49:02 +00:00
Jacques Le Roux
b9c3ddef08
2d part and end of an effort to remove trailing spaces
...
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg )
Of course this effort to remove trailing spaces has no functional implications.
Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {
So these changes are also in this commit, should not be a problem anyway.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath
054b456bc9
Fix lines that *only* have whitespace.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759232 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:56:23 +00:00
David E. Jones
8c423bc529
Moved EntityDiagramGroupData.xml from entityext to commonext to resolve framework dependency; a few other little cleanups as well
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757639 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 02:53:31 +00:00
Adam Heath
856ab123a8
Fix purely empty whitespace lines, and remove trailing whitespace.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757073 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:23:48 +00:00
Jacques Le Roux
f796e230d2
catch( => catch(
...
}else => } else
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751005 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:55:43 +00:00
Jacques Le Roux
963f02faed
Close https://issues.apache.org/jira/browse/OFBIZ-2168 - OFBIZ-2168
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741491 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 09:30:09 +00:00
Jacques Le Roux
8251d2896c
A patch from Ray Barlow "Export CSV file using specified text delimiter" '( https://issues.apache.org/jira/browse/OFBIZ-2101 ) - OFBIZ-2101
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728718 13f79535-47bb-0310-9956-ffa450edef68
2008-12-22 16:11:01 +00:00
Jacques Le Roux
06f33869c3
A patch from Ray Barlow " Import CSV file using specify text delimiter" ( https://issues.apache.org/jira/browse/OFBIZ-2031 ) - OFBIZ-2031
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709002 13f79535-47bb-0310-9956-ffa450edef68
2008-10-29 20:30:15 +00:00
Jacques Le Roux
e7905f2c8c
Fix the anti-pattern
...
if (* != null && *.size() > 0) {
where * is a variable name (String or Collection). Rewritten to
if (UtilValidate.isNotEmpty(*)) {
Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {
And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath
e410552cc9
No longer *copy* the extra support files into the classes dir;
...
instead, just add them straight to the final jar.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath
b6a1ae5e5e
Another minor optimization; no longer need to specify classpathref in
...
all the build.xml files.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Adam Heath
18ea2f7faa
Generics, enhanced-for, Number.valueOf.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672660 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:47:15 +00:00
Adam Heath
18391f98a9
The build.xml files are now much smaller and simpler; they reuse a
...
few global definitions. 1585 lines removed.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Adam Heath
c69096e93a
Switch as much as possible from StringBuffer to StringBuilder.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585805 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 02:56:02 +00:00
Jacques Le Roux
41fe719fb6
To allow to deal with last column empty in CSV files
...
To allow to render an empty string when null
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582730 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 06:58:49 +00:00
Jacques Le Roux
b8a32ab469
To allow to deal with problems in some DOS file, specifically file extracted from zip archives.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@582723 13f79535-47bb-0310-9956-ffa450edef68
2007-10-08 06:40:05 +00:00
David E. Jones
07b48643c5
As noted needing to be done by Jacques Le Roux did a search/replace on source=1.4 and changed to 1.5
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@541997 13f79535-47bb-0310-9956-ffa450edef68
2007-05-27 15:55:18 +00:00
David E. Jones
7d70c41c12
Did a big search/replace to change all xsd file refs from www.ofbiz.org to ofbiz.apache.org
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@539504 13f79535-47bb-0310-9956-ffa450edef68
2007-05-18 15:47:14 +00:00
Jacopo Cappellato
67cc3c11e7
Misc fixes to make the datafile tool screen work with after recent migration to the widgets.
...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@523767 13f79535-47bb-0310-9956-ffa450edef68
2007-03-29 16:52:55 +00:00
Jacques Le Roux
dad67935f7
A (large) patch from Scott Gray "Update ASL header" ( https://issues.apache.org/jira/browse/OFBIZ-637 ).
...
I put also some svn:ignore for shark build and lib diretories and assetmaint/build
I did some by hand lately, too much to remember. They were files with old header but without copyright. A 1st attempt I suppose, will have to check this after this commit.
I add some problems to commit this patch in one piece because it's so huge (specially with Eclipse I had to turn to Tortoise) !
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@499486 13f79535-47bb-0310-9956-ffa450edef68
2007-01-24 17:15:54 +00:00
Jacques Le Roux
a5632fa086
This is hte change of ASL2 headers in java files only.
...
Seems correct (35827 lines to review ;o).
I just wonder if we should keep the copyright comment in Classpath.java (about MortBay)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@496982 13f79535-47bb-0310-9956-ffa450edef68
2007-01-17 10:22:33 +00:00
Jacques Le Roux
eb82782d03
A patch from Stefan Huehner "Remove unused variables" ( https://issues.apache.org/jira/browse/OFBIZ-525 ).
...
Issue is not closed : more patches to come
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@483235 13f79535-47bb-0310-9956-ffa450edef68
2006-12-06 21:18:30 +00:00
David E. Jones
fc96cf5ab7
Changed all build files to add NOTICE and LICENSE files to the META-INF directory in each jar file that is created in OFBiz
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@472422 13f79535-47bb-0310-9956-ffa450edef68
2006-11-08 08:23:23 +00:00
Jacopo Cappellato
be628b4a00
Removed author information from all the files of the "datafile" component: keeping this information in source files is discouraged by the ASF (clearer information about the contributors of a file can be derived from the commit logs).
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@454157 13f79535-47bb-0310-9956-ffa450edef68
2006-10-08 15:27:14 +00:00
Jacopo Cappellato
b79f8b95c5
Removed unused import statements from Java classes.
...
Patch from Peter Goron (OFBIZ-349).
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@452088 13f79535-47bb-0310-9956-ffa450edef68
2006-10-02 15:50:00 +00:00
Jacopo Cappellato
d653b2c862
License change from MIT to ASL2.0 for the files of the datafile component.
...
Thanks to Scott Gray for the patch (Apache OFBIZ-87).
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@423846 13f79535-47bb-0310-9956-ffa450edef68
2006-07-20 09:11:54 +00:00
Si Chen
b53ae991ae
Reverted 421453: DataFile output can be other than XML, so this needs to be more generic.
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@421464 13f79535-47bb-0310-9956-ffa450edef68
2006-07-12 23:43:44 +00:00
Si Chen
fac611800f
XML escape the DataFile String input, otherwise the entity-engine-xml output will have " characters that are not XML escaped ("), breaking the system
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@421453 13f79535-47bb-0310-9956-ffa450edef68
2006-07-12 23:02:52 +00:00
David E. Jones
94fe6d1cda
Initial OFBiz import from revision 7923 of the old svn.ofbiz.org SVN repository.
...
git-svn-id: https://svn.apache.org/repos/asf/incubator/ofbiz/trunk@418498 13f79535-47bb-0310-9956-ffa450edef68
2006-07-01 19:05:20 +00:00