Added two new IN parameter, internally (and automatically) set for service definitions:
login.username
login.password
They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883056 13f79535-47bb-0310-9956-ffa450edef68
Having the TabBar menu in the "pre-body" seems to be the right pattern (already present in several screens) that should always be followed.
This change allows a much better rendering of the Dropping Crumbs while having a very little TabBar menu shift in other themes.
All other screens will be changed accordingly.
This commit also fixes OFBIZ-3240
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883020 13f79535-47bb-0310-9956-ffa450edef68
+ datafile/dtd/datafiles.xsd enhanced with some documentations, and an enumeration for the type: I used all occurrences found in Record.setString() method)
+ datafile/dtd/datafiles-catalog.xml added
+ Few generics cleaning in login/LoginServices.java
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882892 13f79535-47bb-0310-9956-ffa450edef68
The offending TabBars include-menu tags have been wrapped with a <container style="no-clear">.
I preferred this method instead of what suggested by Adrian in rev.881027 (that consists in changing the menu style) because in principle the menu could be used in other screens where there is no need of this (no multi-column) and also because in this way there is no needs to change the menu every time we change the screen layout.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882725 13f79535-47bb-0310-9956-ffa450edef68
The ContentOperationsData.xml file lists ContentPurposeTypes.
I found that among the typical company / ecommerce content, there is also legal information such as: Terms and Conditions, Imprint / Legal Notices, Data Protection Policies, other policies.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882631 13f79535-47bb-0310-9956-ffa450edef68
Steps regenerate error:
1) Hit url: https://localhost:8443/ordermgr/control/orderentry
2) Select purchase order with supplier
3) Add product for order
4) Click on the productId from showcart page
it will generate error as following
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
Notes from Mridul:
As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId. I would vote for:
1. Showing all reviews.
2. Skipping surveys.
The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232). getProductVariantTree service needs productStoreId to get available inventory. In case of PO's we don't need to check for available inventory at all. Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
1. Add a boolean IN attribute checkInventory to service definition, if its true check the available inventory and if false do not.
2. A check on productStoreId in the implementation can serve our purpose too.
I like #1 more as it won't eliminate importance of productStoreId in case of a sales order. Looking forward to suggestions from community to handle this situation.
Thanks Amit for the contribution. Mridul Thanks a lot for providing useful notes for the implementation.
Guys, I appreciate your coordination on this!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882618 13f79535-47bb-0310-9956-ffa450edef68
However they are empty and so the menu will not be rendered with this output (which should be fine).
OFBIZ-3207
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882601 13f79535-47bb-0310-9956-ffa450edef68
Case 1
(a) Go to Facility -> Shipment, click on New Shipment link.
(b) Select "Status Id = Input", "Origin Facility = Web Store Warehouse" & "Shipment type Id = Sales Shipment" then depress Update button.
(c) Now depress Items tab, enter product Id & quantity then depress create button.
(d) Select "New" for Add to Package dropdown and depress Add button.
(e) Now depress Delete button for Item then it will show error message that can be understood by a warehouse manager.
Case 2
(a) Follow #a to #d process in Case 1
(b) Depress Packages tab.
(c) Depress Delete button for Package then it will show error message that can be understood by a warehouse manager.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882555 13f79535-47bb-0310-9956-ffa450edef68
Steps to reproduce:
Go to - https://localhost:8443/accounting/control/CostCenters
-- Enter the values for cost center 1, 2 and 3 so that the total is not equals to 100.
-- The error appears on click submit, now correct the values in respective fields so total is equals to 100.
-- On click on submit the values save in the DB, but error still shows on the page - remove error message after short duration.
Thanks Mukesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882535 13f79535-47bb-0310-9956-ffa450edef68
This add a simple ant to download the postgreSQL JDBC driver, to simplify the installation of a database based on this engine
Currently it works only for the last drivers available : postgresql-8.4-701.jdbc4.jar. But this may be easily adapted.
I have also added an svn ignore for postgresql-8.4-701.jdbc4.jar
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882502 13f79535-47bb-0310-9956-ffa450edef68
Patch will resolve the following Issues
1) Shipping and Handling Charges are added twice in new order amount.
2) Sales Tax are added twice in new order amount.
3) Add extra tax on shipping and handling charges for new order.
4) When click on "Create as New Order" Link, it is Giving NPE on some Promotion (Happy Hour
Promotion 9020).
5) Click on "Edit Items" Link and then "Update" Link it is it is Giving NPE on some Promotion (Happy
Hour Promotion 9020).
Thanks Arpit for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882454 13f79535-47bb-0310-9956-ffa450edef68
Frmatting and tidy up using the itemized and orderedlist docbook commands for Tax Authorities. I've also included some documentation on the Bank Reconciliation process.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882452 13f79535-47bb-0310-9956-ffa450edef68
a) FixedAssetGeoLocation had its error response going to the wrong view "EditFacility" (which did not exist in this controller).
b) taxAuthorityVATReport was pointing to a view-map entry that was commented out; these are not used yet: WIP...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882326 13f79535-47bb-0310-9956-ffa450edef68
Patch for generic's warnings for accounting application
I will soon commit InvoiceWorker.java (got a conflict) and some other changes I want to do, mostly enhanced for loops
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882210 13f79535-47bb-0310-9956-ffa450edef68
login.username
login.password
They are already used by the authorization service ("userLogin") to authorize the user to the service call and to retrieve the userLogin object (if the user is authorized).
They can be passed to the service in the input context in place of the userLogin object: this is useful when the service is invoked from a remote system (thru SOAP etc...).
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882187 13f79535-47bb-0310-9956-ffa450edef68
Steps to produce the bug:
1) Place a purchase order
2) Once your order is placed then click on "Edit items" button of "Actions block"
3) After this down at the bottom click on "Quick lookup" button
4) You will land on screen which is broken
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882132 13f79535-47bb-0310-9956-ffa450edef68
-- cancelAllBackOrders scheduled service should not attempt to cancel "Completed" Orders. When this service runs for Completed Purchase Orders, it throws error as Completed cannot be cancelled.
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882131 13f79535-47bb-0310-9956-ffa450edef68
SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.
I moved the httpclient httpcore jars to base/lib (also new jcip-annotations-1.0.jar)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882103 13f79535-47bb-0310-9956-ffa450edef68
CacheLineTable and LRUMap do not synchronize on the same lock
* CacheLineTable synchronization use the CacheLineTable instance monitor
* LRUMap synchronization use the LRUMap instance monitor
the LRUMap (memoryTable) can be updated concurrently by 2 differents threads
* one in the CacheLineTable #put or CacheLineTable#remove
* another in the CacheLineTable#get
this leads to the corruption of the LRUMap which is not thread-safe
the CacheLineTable#get should be synchronized or the LRUMap should be replaced by a thead safe collection
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882072 13f79535-47bb-0310-9956-ffa450edef68
Steps to produce the bug:
1) Place a sales Order,
2) Go through Verify Pick process
3) Go to Packing Screen
4) Enter OrderId and then click on "Weigh Package Only button ."
5) Text boxes to enter weights and dimension of packages should render.
Thanks Divesh for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882068 13f79535-47bb-0310-9956-ffa450edef68