Commit Graph
58 Commits
Author SHA1 Message Date
Adam Heath bf7ff532f4 Shark compiles now. Except that you have to add the libraries uploaded
to https://issues.apache.org/jira/browse/OFBIZ-552.  Which you probably
can't, as latest shark(2.0 or 2.5, couldn't really tell) is LGPL.  So we
should probably remove this anyways.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884347 13f79535-47bb-0310-9956-ffa450edef68
2009-11-26 00:40:44 +00:00
Jacques Le Roux e53baa39a9 Allow to build since move from framework. Waiting for community opinion about JavaDoc inside this build file...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884335 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 23:22:30 +00:00
Jacques Le Roux 26b5b57c9f Oops fix r884308 (missed the >0 part when replacing xpdls != null && xpdls.size() > 0 by UtilValidate.isNotEmpty(xpdls)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884325 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 22:55:29 +00:00
Jacques Le Roux 1ec28cc058 Complete Scott's fix in r884292 (using initial code in r821643
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884308 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 22:29:21 +00:00
Scott Gray ba4f02caef Fix invalid code that causing the docs-all target to fail
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@884292 13f79535-47bb-0310-9956-ffa450edef68
2009-11-25 22:03:53 +00:00
Jacques Le Roux c72b29cb1f Use UtilValidate.isNotEmpty methods instead of (obj != null) || (obj.length > 0) and (obj != null) || (obj.size > 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883549 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 23:41:34 +00:00
Jacques Le Roux 4e0d303e06 Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.length == 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883507 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 21:42:18 +00:00
Adrian Crum 9ee18d37c5 Updated client code to use the new Delegator factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@823633 13f79535-47bb-0310-9956-ffa450edef68
2009-10-09 17:44:24 +00:00
Adrian Crum 7fa08f9079 Replaced GenericDelegator.getGenericDelegator(...) calls with new factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821649 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 01:53:50 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Scott Gray 2afbb75457 Get rid of a whole pile of unnecessary string instantiations
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818665 13f79535-47bb-0310-9956-ffa450edef68
2009-09-24 23:49:02 +00:00
Adrian Crum 74ea95889c Reverted rev 802567.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812692 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 20:56:14 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
Adrian Crum ce1660b06a Chinese translation for the specialpurpose folder, provided by Shi Yusen - https://issues.apache.org/jira/browse/OFBIZ-2723.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@798580 13f79535-47bb-0310-9956-ffa450edef68
2009-07-28 15:59:04 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
David E. Jones 70f8da92bb Moved logo and icon images back to images component and removed from everywhere else; all references to these should be to there only now; fixes issue with logo in ecommerce and other little things
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@766426 13f79535-47bb-0310-9956-ffa450edef68
2009-04-19 06:12:55 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Bilgin Ismet Ibryam 7e7c1f375a Added an optional "name" attribute to event element in controller.xml This attribute is used only (also required) in events inside
firstvisit, after-login, before-logout, preprocessor and postprocessor elements. Events with same name will be overridden and only the last one will be executed. Overriding works also in cases when a controller.xml includes other controller files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761220 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 09:47:48 +00:00
Adam Heath 150d86a148 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759266 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 17:02:51 +00:00
Adam Heath 60e4101cb2 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757111 13f79535-47bb-0310-9956-ffa450edef68
2009-03-22 00:38:47 +00:00
Marco Risaliti 80f390b7c3 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755005 13f79535-47bb-0310-9956-ffa450edef68
2009-03-16 21:08:21 +00:00
Bruno Busco a36cb4dd3e Changed WebSiteId parameter description to be more general
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751214 13f79535-47bb-0310-9956-ffa450edef68
2009-03-07 07:19:07 +00:00
Jacques Le Roux f796e230d2 catch( => catch(
}else => } else

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751005 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:55:43 +00:00
Jacques Le Roux dfebb46e4b }else{ => } else {
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751004 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:51:02 +00:00
Jacques Le Roux c9d918afa2 }catch => } catch
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751003 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:50:08 +00:00
Jacques Le Roux ec8e04ad01 try{ => try {
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751002 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:49:18 +00:00
Jacques Le Roux 639a784790 while( => while (
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750998 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:38:03 +00:00
Jacques Le Roux fc6db9e886 if( => if (
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750997 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:36:09 +00:00
Jacques Le Roux 13a934f823 In spirit of Adam's r749341 and following http://java.sun.com/docs/codeconv/html/CodeConventions.doc7.html#489
The idea is also that a lot of code is duplicated and then changed (copy/paste). Hence having a rightly formatted code help to keep it rightly formatted
1st (simple) step : ){ => ) { (I checked all occurrences but of course other pairs of eyeballs are welcome)


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750993 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:31:13 +00:00
Hans Bakker 041ccc0a7d rename applicationext component to commonext
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@748388 13f79535-47bb-0310-9956-ffa450edef68
2009-02-27 04:05:47 +00:00
Hans Bakker 5192a24e48 introduction of a common component for applications. moved the 2 lines containing party info to this component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@748144 13f79535-47bb-0310-9956-ffa450edef68
2009-02-26 13:36:51 +00:00
Marco Risaliti fd032fc098 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746654 13f79535-47bb-0310-9956-ffa450edef68
2009-02-22 10:45:15 +00:00
Marco Risaliti 7712182402 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746406 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 22:53:32 +00:00
Marco Risaliti 201290e8db A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746341 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 19:11:06 +00:00
Bruno Busco 87958df45c Added webSiteId definition for every webapp.
This will be used to link online help pages to OFBiz screens.
The webSiteId will also be used to associate VisualThemeSets to webapps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744502 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 14:35:56 +00:00
Marco Risaliti eb3baebdd1 Move comments on property or value before those tags
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739652 13f79535-47bb-0310-9956-ffa450edef68
2009-01-31 23:22:22 +00:00
Marco Risaliti 1a3edc02f8 A lot of cleaning into MyPage/MyPortal/Pos/ProjectMgr components and some italian translations (Part of OFBIZ-1780)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@735131 13f79535-47bb-0310-9956-ffa450edef68
2009-01-16 21:03:44 +00:00
Jacques Le Roux 7dd8ecf6de Merge all current CompanySubtitle labels in all languages.
It was a real mess. I wondered if I should put them all under a ComonCompanySubtitle label and remove all others. 
But I guess they could be used with other meaning in real world applications (ie not OOTB). So I kept them all.
There are some duplicates in some languages. I kept them commentent out at end of each line.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@728061 13f79535-47bb-0310-9956-ffa450edef68
2008-12-19 16:30:55 +00:00
Jacques Le Roux d5f99b443a A modified patch from Erik Wegner "Patch for all language files (*Labels.xml) to correct language order, find duplicates or invalid entries" (https://issues.apache.org/jira/browse/OFBIZ-2073) - OFBIZ-2073
I removed some hunks, see https://issues.apache.org/jira/browse/OFBIZ-2073?focusedCommentId=12656651#action_12656651



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@726808 13f79535-47bb-0310-9956-ffa450edef68
2008-12-15 21:28:06 +00:00
Adam Heath aea3931bbf Modify all <javadoc> to use the src sets, so that excluded files are
no longer processed.  Reduces javadoc warnings.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709628 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 03:19:00 +00:00
Adam Heath 195170175b Use pattern sets in <javac/>, to include/exclude files, and modify
all build.xml to override the sets, if nescessary.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709627 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 03:06:17 +00:00
Bilgin Ismet Ibryam 40d4c4745b Fixed few requests which allow access to main page without authorization check.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686630 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 18:51:26 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Scott Gray c98e7dc59f Removed unnecessary "error" response elements from the controller files, if no event is defined then "success" will always be the response name.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686577 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 00:00:49 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adrian Crum cd3a137731 Removed deprecated CSS style sepBar, removed unnecessary align="left" HTML element attributes.
I did a global search and replace for the align="left" aatribute - I didn't check each replacement because there were hundreds of them. This shouldn't break any layout. If you spot something wrong, post a message on the dev mailing list and I will fix it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684548 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 16:28:14 +00:00
Adam Heath 2617681b51 Remove svn:executable on a bunch of stuff.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684389 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 00:53:43 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00