Commit Graph
71 Commits
Author SHA1 Message Date
Bruno Busco c3ac175016 Part of OFBIZ-3067 - Menus and form widget files location
Ecommerce, Webtools and hhfacility components
Moved forms from webapp to widget folder
Removed empty folders

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@829443 13f79535-47bb-0310-9956-ffa450edef68
2009-10-24 20:20:18 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Jacques Le Roux 7692db2c4b Revert r772887
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@773095 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 20:44:54 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
Jacques Le Roux 0f15a1f0cb Generalize r767694 to allow better error messages rendering in UI.
Actually I was more interested to solve the same issue in BizznessTime but StringUtil.wrapString is not working there

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772887 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 08:41:53 +00:00
Jacques Le Roux f29b4787b4 As suggested by David, these lines are not needed anymore
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771090 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 17:19:37 +00:00
Jacques Le Roux 999bd7c577 Fix following Chris Howe's message in dev ML
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@764195 13f79535-47bb-0310-9956-ffa450edef68
2009-04-11 13:00:24 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux 76f5ca6638 Secure URLs, we don't need to duplicate in from-field when param-name is the same
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762215 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:25:24 +00:00
Jacques Le Roux 3efbbc81cd Securing URLs, link element in screens and menus : 29th set + tabs to 4 spaces
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761976 13f79535-47bb-0310-9956-ffa450edef68
2009-04-04 17:46:49 +00:00
Bilgin Ismet Ibryam 7e7c1f375a Added an optional "name" attribute to event element in controller.xml This attribute is used only (also required) in events inside
firstvisit, after-login, before-logout, preprocessor and postprocessor elements. Events with same name will be overridden and only the last one will be executed. Overriding works also in cases when a controller.xml includes other controller files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761220 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 09:47:48 +00:00
Jacques Le Roux 77a2ff1d9f 21th set of changes explained in https://issues.apache.org/jira/browse/OFBIZ-2243
In hyperlink and sub-hyperlink elements, replacement of target parameters by parameter sub-elements

We are near the end...

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759684 13f79535-47bb-0310-9956-ffa450edef68
2009-03-29 14:02:55 +00:00
Adam Heath 4112772335 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759261 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 17:02:14 +00:00
Adam Heath a1f26f6963 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757097 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:47:38 +00:00
Jacques Le Roux 5f2afa08af hhfacility component
Following best practice.
Changed location="org/ofbiz/......... to location="component:// in the service location attribute.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755950 13f79535-47bb-0310-9956-ffa450edef68
2009-03-19 11:57:31 +00:00
Marco Risaliti 2d8f185142 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@753028 13f79535-47bb-0310-9956-ffa450edef68
2009-03-12 21:50:12 +00:00
Bruno Busco a36cb4dd3e Changed WebSiteId parameter description to be more general
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751214 13f79535-47bb-0310-9956-ffa450edef68
2009-03-07 07:19:07 +00:00
Marco Risaliti 7712182402 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746406 13f79535-47bb-0310-9956-ffa450edef68
2009-02-20 22:53:32 +00:00
Marco Risaliti ff720d540e A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746049 13f79535-47bb-0310-9956-ffa450edef68
2009-02-19 23:08:30 +00:00
Bruno Busco 87958df45c Added webSiteId definition for every webapp.
This will be used to link online help pages to OFBiz screens.
The webSiteId will also be used to associate VisualThemeSets to webapps.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744502 13f79535-47bb-0310-9956-ffa450edef68
2009-02-14 14:35:56 +00:00
Marco Risaliti e39f705523 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744265 13f79535-47bb-0310-9956-ffa450edef68
2009-02-13 22:22:34 +00:00
Marco Risaliti 54e0334ca2 A lot of hardcoded labels cleaning and changes some wrong references
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742770 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 22:13:57 +00:00
Jacques Le Roux 56c6ad4660 Simple-method and alike tags cleanup. Not sure yet, but I guess there are no "Xerces errors" anymore.
I will post some other errors (of other types I guess) I found using Artifact Info in dev ML soon

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741594 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 15:28:41 +00:00
David E. Jones afe3dc9c81 A few related changes:
Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.

Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.

Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.

To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741374 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 02:14:19 +00:00
Jacques Le Roux fb9d3a2e18 <entity-condition(.*) list-name= => <entity-condition$1 list=
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739740 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 11:08:49 +00:00
Jacques Le Roux 290534059d <entity-one entity-name=(.*)value-name => <entity-one entity-name=$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@739732 13f79535-47bb-0310-9956-ffa450edef68
2009-02-01 10:27:43 +00:00
Jacques Le Roux 94225b1a34 Fix issues with now-timestamp-to-env and sequence-id-to-env : their factories names where missing in org.ofbiz.minilang.method.MethodOperation$Factory file
also
<sequenced-id-to-env(.*)env-name => <sequenced-id$1field
<now-timestamp-to-env(.*)env-name => <now-timestamp$1field
both on *SimpleMethods*.xml, *events*.xml, *formula*.xml, *services*.xml, *tests*.xml (previously I only used *events*.xml, *services*.xml, but I guess it's not a big deal for now)




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730433 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 17:47:37 +00:00
Jacques Le Roux 0272162a99 revert both
sequenced-id(.*)field to <sequenced-id-to-env$1env-name
<now-timestamp(.*)field => <now-timestamp-to-env$1env-name
Something is wrong with these 2 tags (inconsistency between xsd and java, I'll look at it)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730397 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 13:59:08 +00:00
Jacques Le Roux 928ce608a1 Reverted 730372 : an error realted to calculate tag has slipped in
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730373 13f79535-47bb-0310-9956-ffa450edef68
2008-12-31 11:00:51 +00:00
Jacques Le Roux 389d3288a1 <field field-name => <field field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730198 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:30:52 +00:00
Jacques Le Roux dbc4228779 <now-timestamp-to-env env-name => <now-timestamp field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730194 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:25:18 +00:00
Jacques Le Roux bbedb431c2 <get-related(.*)value-name => <get-related$1value-field
<get-related(.*)list-name => <get-related$1list
<get-related(.*)\R(.*)list-name => <get-related$1\R$2list-name
<get-related(.*)\R(.*)value-name => <get-related$1\R$2value-field
<calculate field-name => <calculate field
<calcop(.*)field-name => <calcop$1field
<result-to-field(.*)field-name => <result-to-field(.*)field
<result-to-field(.*)field="(.*)"(.*) map-name="(.*)" => <result-to-field$1field="$4.$2"$3
<field-to-request field-name => <field-to-request field

(I had a connection break that's while I put all of them in one sole commit)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730183 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 17:12:15 +00:00
Jacques Le Roux 460b994519 <clear-field(.*)field-name => <clear-field$1field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730109 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 12:04:24 +00:00
Jacques Le Roux 288c384783 <find-by-primary-key(.*)map-name => <find-by-primary-key$1map
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730101 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:51:58 +00:00
Jacques Le Roux 0f82bfeb3d <find-by-primary-key(.*)value-name => <find-by-primary-key$1value-field
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@730100 13f79535-47bb-0310-9956-ffa450edef68
2008-12-30 11:49:32 +00:00
Jacques Le Roux 1ad9a9c96b A patch from Nicolas Malin "Refactoring product search by id" (https://issues.apache.org/jira/browse/OFBIZ-2027) - OFBIZ-2027
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709726 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 17:19:32 +00:00
Marco Risaliti 5d085e9f42 Converted some bsh scripts to groovy
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@700227 13f79535-47bb-0310-9956-ffa450edef68
2008-09-29 19:58:02 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Scott Gray c98e7dc59f Removed unnecessary "error" response elements from the controller files, if no event is defined then "success" will always be the response name.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686577 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 00:00:49 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adrian Crum cd3a137731 Removed deprecated CSS style sepBar, removed unnecessary align="left" HTML element attributes.
I did a global search and replace for the align="left" aatribute - I didn't check each replacement because there were hundreds of them. This shouldn't break any layout. If you spot something wrong, post a message on the dev mailing list and I will fix it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@684548 13f79535-47bb-0310-9956-ffa450edef68
2008-08-10 16:28:14 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Jacques Le Roux 641ff10050 Update Copyright to 2008
A real replace in files feature was one of the reasons I use Eclipse 3.4 for near a year now (I even helped to test, a real must have :o)
Not sure previous commit was sent partially or not at all (I needed to update)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@677685 13f79535-47bb-0310-9956-ffa450edef68
2008-07-17 18:56:25 +00:00
Adrian Crum 75191fa776 Removed deprecated CSS styles from back office applications.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@676212 13f79535-47bb-0310-9956-ffa450edef68
2008-07-12 18:41:44 +00:00
Adrian Crum af7a0409c1 Removed deprecated CSS styles from the maincss.css file. I skipped the eCommerce component because it doesn't use that style sheet, and I also skipped the content component because it is used in eCommerce.
This shouldn't affect any layout. If it does, just post a message on the dev ml (with link please) and I'll fix it.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@675831 13f79535-47bb-0310-9956-ffa450edef68
2008-07-11 04:02:30 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Scott Gray 5e401fcd53 Updated all simple methods to use the new attributes
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@667748 13f79535-47bb-0310-9956-ffa450edef68
2008-06-14 06:03:12 +00:00
Jacopo Cappellato ca94905cd2 Removed some unused event handler declarations from controller files; converted some Beanshell events to Groovy.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@662338 13f79535-47bb-0310-9956-ffa450edef68
2008-06-02 06:40:50 +00:00
Jacques Le Roux b87af55c8b Show bottom buttons for Asset Maint, HH Facility and CMS site. Finally I did not put eCommerce as it would need more work : a direct link to https//host:8443... does not work.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@661288 13f79535-47bb-0310-9956-ffa450edef68
2008-05-29 10:39:28 +00:00