Commit Graph
79 Commits
Author SHA1 Message Date
Jacques Le Roux 15b7cd6582 Fix an issue in r885112
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885115 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 17:17:48 +00:00
Jacques Le Roux 47b0eff762 More uses of is(Not)Empty
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885112 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 16:27:42 +00:00
Jacques Le Roux 569a4afeea Some cleaning related to isEmpty
* remove duplicate ()
* remove casts no longer needed

I'm doing these last tasks around isEmpty and isNotEmpty mostly to be sure that nothing has slipped in. Despite I have been very careful, I prefer double check.

+ one typo in ofbizSelenium help (not sure this file is used yet though, seems to be missing some parts which are commented out, for now I guess)



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885093 13f79535-47bb-0310-9956-ffa450edef68
2009-11-28 14:08:16 +00:00
Jacques Le Roux d5d543b178 Fix r883508
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883517 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 22:02:49 +00:00
Jacques Le Roux e839974fe7 Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.length == 0)
Complete r883507


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883508 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 21:48:18 +00:00
Jacques Le Roux 7c92156d1c Some other fixes in help files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883333 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 13:15:09 +00:00
Jacques Le Roux 49b2961e9c Fix few things in help files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883329 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 13:02:53 +00:00
Scott Gray 24b64728fe Throw a ContainerException if any tests are unsuccessful during a test run and have the run-tests target fail if that is the case
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882995 13f79535-47bb-0310-9956-ffa450edef68
2009-11-21 21:20:50 +00:00
Jacques Le Roux 65601eeccd A patch from Abdullah Shaikh "SagePay payment gateway integrated" (https://issues.apache.org/jira/browse/OFBIZ-3180) - OFBIZ-3180
SagePay payment gateway integrated. All the gateway parameters are configurable using the Payment gateway configuration, also the transaction types that are available in sagepay are configurable.

I moved the httpclient httpcore jars to base/lib (also new jcip-annotations-1.0.jar)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882103 13f79535-47bb-0310-9956-ffa450edef68
2009-11-19 11:01:29 +00:00
Scott Gray b9b0a55b55 When possible log the actual test case name, makes debugging a lot easier
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882060 13f79535-47bb-0310-9956-ffa450edef68
2009-11-19 07:09:18 +00:00
Jacques Le Roux 63b509222b A patch from Marc Morin "Resolve java warnings exposed in Eclipse : framework - testtools" (https://issues.apache.org/jira/browse/OFBIZ-3119) - OFBIZ-3119
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@832912 13f79535-47bb-0310-9956-ffa450edef68
2009-11-04 23:44:18 +00:00
Jacques Le Roux 4f42d6f76e A patch from Erwan de FERRIERES "Wrong dtd call in a doocbook help file" (https://issues.apache.org/jira/browse/OFBIZ-3089) - OFBIZ-3089
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@829743 13f79535-47bb-0310-9956-ffa450edef68
2009-10-26 09:56:21 +00:00
Adrian Crum 9ee18d37c5 Updated client code to use the new Delegator factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@823633 13f79535-47bb-0310-9956-ffa450edef68
2009-10-09 17:44:24 +00:00
Hans Bakker 682a5ab55b add a new chapter for testtools in the apache technical document
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@822639 13f79535-47bb-0310-9956-ffa450edef68
2009-10-07 10:03:29 +00:00
Hans Bakker 23b160661a paging on testsuites in selenium test corrected
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821731 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 10:00:45 +00:00
Adrian Crum 7fa08f9079 Replaced GenericDelegator.getGenericDelegator(...) calls with new factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821649 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 01:53:50 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Hans Bakker d8de376af1 patch supplied in OFBIZ-2964 by Brett palmer
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@819863 13f79535-47bb-0310-9956-ffa450edef68
2009-09-29 08:57:00 +00:00
Hans Bakker 0fdf9568c8 added webtools/selenium to the help and corrected some problems
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@818733 13f79535-47bb-0310-9956-ffa450edef68
2009-09-25 06:31:20 +00:00
Hans Bakker dd9ae86426 added another level in the accounting help data, added info and reorganized a bit, also fixed the problem with the selenium info which did not load
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@817524 13f79535-47bb-0310-9956-ffa450edef68
2009-09-22 07:39:53 +00:00
Hans Bakker 77fc9fefef added a selenium option to webtools which partially tests if all settings have been done and will now automatically download the selenium server. Sponsored by Antwebsystems, programmed by employee Gan
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@817493 13f79535-47bb-0310-9956-ffa450edef68
2009-09-22 04:00:22 +00:00
Adrian Crum 74ea95889c Reverted rev 802567.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812692 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 20:56:14 +00:00
Adam Heath 9e9553f1a0 Generics, enhanced-for, similiar changes to the other java 1.5
patches.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812320 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 02:22:05 +00:00
Adam Heath 8c6a2a7461 These are not executable.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811565 13f79535-47bb-0310-9956-ffa450edef68
2009-09-04 21:50:15 +00:00
Adrian Crum dbbab57c8a Fixed a problem in testtools - reported by Jacques on the mailing list.
Someone familiar with Selenium will have to figure out a way to get it to use the jar in build/lib.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@805642 13f79535-47bb-0310-9956-ffa450edef68
2009-08-19 00:40:42 +00:00
Jacques Le Roux 7befd1d25e no tabs but 4 spaces in code files (*.ftl, *.gro*, *.java, *.xml)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804935 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 11:01:25 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Hans Bakker 2d51096b6d Excellent contribution from Brett G. Palmer in issue: OFBIZ-2116
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804074 13f79535-47bb-0310-9956-ffa450edef68
2009-08-14 04:22:27 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
Adam Heath dd51c0108b Add a simple initCause helper method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@789400 13f79535-47bb-0310-9956-ffa450edef68
2009-06-29 18:13:19 +00:00
Scott Gray 2bf7a5d9ab Add the test suite name to the log output, otherwise it isn't very clear which test suite's results are being displayed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772560 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 09:04:08 +00:00
Scott Gray 2f0f45e927 Don't throw an exception if the test definitions aren't found, just log an error and continue with the rest of the tests
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772475 13f79535-47bb-0310-9956-ffa450edef68
2009-05-07 00:20:20 +00:00
Adam Heath 2ec0d94197 Another generics fix.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@771125 13f79535-47bb-0310-9956-ffa450edef68
2009-05-03 20:36:13 +00:00
Scott Gray 4049b07769 A little documentation
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@770905 13f79535-47bb-0310-9956-ffa450edef68
2009-05-02 06:57:30 +00:00
Scott Gray 7531687fdd OFBIZ-2259: Implemented test data rollback per test-suite using the GenericDelegator
Provides the following benefits:
1. Test data independence per component suite
2. Ability to run tests repeatedly without reloading the database
3. Continued database independence for the testing tools
4. The possibility of future improvements for controlling when data is rolled back (per unit test, group of unit tests within a suite or
even tree structured tests where data is partially rolled back before continuing)
5. The future possibility to export data changes resulting from a test run
6. The future possibility to verify a test result automatically based on the output of #4

The rollback currently doesn't catch changes resulting from async service calls and also doesn't rollback changes to SequenceValueItem

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@765057 13f79535-47bb-0310-9956-ffa450edef68
2009-04-15 06:01:36 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath 5d28d2dfcf Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759242 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:58:28 +00:00
Adam Heath fcaca96e34 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757079 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:25:15 +00:00
Adam Heath 73edfa7c96 Change implementation to be based on suite-name.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750342 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 06:54:41 +00:00
Adam Heath 35b209c771 Add support for limiting the test run based on suite-name.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750341 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 06:52:40 +00:00
Adam Heath 5c702ec750 Support text and xml output.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750322 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 05:51:43 +00:00
Adam Heath 84795ddd31 Add a <test-group> element, that is a sibling of <test-case>; this
element can take a list of child test definitions.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750296 13f79535-47bb-0310-9956-ffa450edef68
2009-03-05 02:40:06 +00:00
Adam Heath 867799286a Container that prints out the test cases that are available.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750089 13f79535-47bb-0310-9956-ffa450edef68
2009-03-04 18:02:07 +00:00
Adam Heath 974d40665b Set the counts on the run junit ant helper, so that the document
element has the correct values(was always 0 before).

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750049 13f79535-47bb-0310-9956-ffa450edef68
2009-03-04 15:27:33 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath 2fdd964c9d More generics.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@682060 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 21:39:20 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Scott Gray 463d79858f Running a simple method bombs if you don't pass in a locale.
The other option was to get the default locale if one wasn't passed in when creating the MethodContext but I don't know much about that so I took the easy road :-)
On the bright side another one of the unit tests now passes.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@600864 13f79535-47bb-0310-9956-ffa450edef68
2007-12-04 10:00:24 +00:00