Commit Graph
237 Commits
Author SHA1 Message Date
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Jacques Le Roux a5042291f7 1st part of an effort to remove trailing spaces
" +/> => "/>
Should be easier when dealing with Eclipse S/R regexp

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762648 13f79535-47bb-0310-9956-ffa450edef68
2009-04-07 08:27:15 +00:00
Jacques Le Roux 9bbc40ca01 On David and Hans advices
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762221 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 06:41:10 +00:00
Jacques Le Roux 10872c2734 Should fix https://issues.apache.org/jira/browse/OFBIZ-2260?focusedCommentId=12695160&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12695160
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@762208 13f79535-47bb-0310-9956-ffa450edef68
2009-04-06 04:41:08 +00:00
Hans Bakker 7554b24dab security fix reported in tyhe mailing list by CJ Horton
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761526 13f79535-47bb-0310-9956-ffa450edef68
2009-04-03 04:52:44 +00:00
Bilgin Ismet Ibryam 7e7c1f375a Added an optional "name" attribute to event element in controller.xml This attribute is used only (also required) in events inside
firstvisit, after-login, before-logout, preprocessor and postprocessor elements. Events with same name will be overridden and only the last one will be executed. Overriding works also in cases when a controller.xml includes other controller files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@761220 13f79535-47bb-0310-9956-ffa450edef68
2009-04-02 09:47:48 +00:00
Hans Bakker 6504c3723a some more security and go back updates
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759070 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 09:28:02 +00:00
Jacques Le Roux 56568efcce A patch from Bruno Busco "Security update (Link to hidden form change) for Visual Theme selection" https://issues.apache.org/jira/browse/OFBIZ-2255
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759044 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 07:47:31 +00:00
Hans Bakker 002576600a move portal page security change
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759038 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 07:12:18 +00:00
Hans Bakker f2ee862883 security update
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759017 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 03:52:14 +00:00
Hans Bakker cc860ba38b rather big change which contains the following:
1. created a new function in the partyManager called 'myCommunications'
This function enables the sending and receiving of email and internal communications to/from the current userlogin. It looks like an email client for internal and external email.
2. merged the party/webapp/partymgr/communication/CommMenus.xml and party/widget/partymgr/PartyMenus.xml
3. moved all forms/screens from my portal back into the party component
4. fixed some more problems with myportal
5. added 'save-home' and save 'current' in the same pattern as 'save-last' function in the controler.xml
6. added 'view-home' in the same pattern as 'view-last'
7. moved all related uilabels from myportal to party
8. This update needs a re-creation of the portlet/portal entities.




git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@758522 13f79535-47bb-0310-9956-ffa450edef68
2009-03-26 06:06:12 +00:00
David E. Jones 3eee2073cc Moved some party dependent services out of the framework
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757644 13f79535-47bb-0310-9956-ffa450edef68
2009-03-24 03:44:59 +00:00
Jacques Le Roux 0e0519e802 All tabs to 4 spaces in *.groovy, *.java, *.xml
Done with Eclipse S/R "\t"

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@755696 13f79535-47bb-0310-9956-ffa450edef68
2009-03-18 18:43:49 +00:00
Bilgin Ismet Ibryam d5c8d3da4f Trivial fix, reported by Bruno
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@754644 13f79535-47bb-0310-9956-ffa450edef68
2009-03-15 10:15:20 +00:00
Hans Bakker 8cf87156b5 some improvement on the change default organization partyId
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@752760 13f79535-47bb-0310-9956-ffa450edef68
2009-03-12 03:32:06 +00:00
Hans Bakker bb2a666832 if there are more than one default party organization to select from, present a drop down in the header so it can easily be changed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@752416 13f79535-47bb-0310-9956-ffa450edef68
2009-03-11 10:17:26 +00:00
Hans Bakker 1e1ed8fba9 move all examples from the common to the example component, edit parameters of portlet in the general managePortalPage screen
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@752401 13f79535-47bb-0310-9956-ffa450edef68
2009-03-11 08:05:34 +00:00
Jacques Le Roux dcf4045d4f Easier to read
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751550 13f79535-47bb-0310-9956-ffa450edef68
2009-03-08 23:24:33 +00:00
Hans Bakker 2e55dc96d5 move of the first portlet from myportal to the original party component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@750805 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 08:17:34 +00:00
David E. Jones 3659c81be2 Changed the timezones stuff to work like the new locale stuff
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@749978 13f79535-47bb-0310-9956-ffa450edef68
2009-03-04 12:26:05 +00:00
David E. Jones f876f9a0c1 Simple implementation of feature discussed on the mailing list to facilitate getting back to a view after some generic action, like schanging the locale which this commit has use the new feature as a test case; I'm not sure I like this approach, will send message to dev list about it
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@749959 13f79535-47bb-0310-9956-ffa450edef68
2009-03-04 10:27:52 +00:00
Jacques Le Roux 9aa57f3ea4 A patch from Bruno Busco "Linking End User Documentation to OFBiz" (https://issues.apache.org/jira/browse/OFBIZ-2133) - OFBIZ-2133
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@748884 13f79535-47bb-0310-9956-ffa450edef68
2009-02-28 16:29:24 +00:00
Hans Bakker 5192a24e48 introduction of a common component for applications. moved the 2 lines containing party info to this component
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@748144 13f79535-47bb-0310-9956-ffa450edef68
2009-02-26 13:36:51 +00:00
Hans Bakker d4137b9f46 add the possibility to list portlets by portlet category
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@746646 13f79535-47bb-0310-9956-ffa450edef68
2009-02-22 08:16:32 +00:00
Hans Bakker 10723bd15c allow changing the order of the portal pages, currently only for private pages(click first on 'edit' to make the movement pictures show)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@745438 13f79535-47bb-0310-9956-ffa450edef68
2009-02-18 08:55:20 +00:00
Hans Bakker a8c6835b35 several small bug fixes in example, portalpages
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744838 13f79535-47bb-0310-9956-ffa450edef68
2009-02-16 07:40:28 +00:00
Hans Bakker b27e4791b1 small corrections on last commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744679 13f79535-47bb-0310-9956-ffa450edef68
2009-02-15 15:36:59 +00:00
Hans Bakker f43d2f1ecf improved menu widget for portal pages, reactivated menuitem override and various other improvements
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@744675 13f79535-47bb-0310-9956-ffa450edef68
2009-02-15 15:10:50 +00:00
Hans Bakker 8c3bf300e4 fix NPE error reported by BJ Freeman in the mailing list
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743998 13f79535-47bb-0310-9956-ffa450edef68
2009-02-13 05:45:22 +00:00
Hans Bakker daebecd9d5 created a new attribute on the menu widget: portal-page. With this change the example component is now changed back to use the menu widget again however also serving the portal page buttons
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743639 13f79535-47bb-0310-9956-ffa450edef68
2009-02-12 07:26:16 +00:00
Hans Bakker c2cc7aa885 If the portalpage name is deleted the page does not show in the menu. This will enable the possibility to remove system pages
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743248 13f79535-47bb-0310-9956-ffa450edef68
2009-02-11 06:45:41 +00:00
Hans Bakker 8d417276ac The MyPortal component has now at least the functionality of the old mypage component with the portal functions included. Mypage is now taken off the menu and will be removed the coming weeks when no big problems arise
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743245 13f79535-47bb-0310-9956-ffa450edef68
2009-02-11 06:22:53 +00:00
Hans Bakker cf0b7986c1 sort portal pages
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743213 13f79535-47bb-0310-9956-ffa450edef68
2009-02-11 04:26:24 +00:00
Hans Bakker 541e72feb5 correction on last commit
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743199 13f79535-47bb-0310-9956-ffa450edef68
2009-02-11 03:00:30 +00:00
Hans Bakker 1f1e7bb4e4 update/display portlet sequence corrected, also seed data corrected
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@743000 13f79535-47bb-0310-9956-ffa450edef68
2009-02-10 15:48:08 +00:00
David E. Jones 50240bf17f Fixed issue with general html encoding in edit portal page template, reported by Hans
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742866 13f79535-47bb-0310-9956-ffa450edef68
2009-02-10 06:43:05 +00:00
Hans Bakker 6075d20785 some more fault fixes in myportal
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742559 13f79535-47bb-0310-9956-ffa450edef68
2009-02-09 15:20:17 +00:00
David E. Jones a0d0a10ebc Resolved some more problems with the general html encoding, most of which are from funny code that should be cleaned up anyway so haven't run into any dilemmas so far; still looking though so could happen
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742053 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 11:08:32 +00:00
David E. Jones 3d122767ba Fixed issue with links in footer caused by change to general html encoding in ftl files
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742034 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 09:40:32 +00:00
David E. Jones 7d5264a0e8 Fixed appbar issue with html encoding, so general encoding turned back on too
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742030 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 09:05:45 +00:00
Hans Bakker 08ba67420f cleanup of the portal pages, reduced number of screens, changed employee myportal, new user without securitygroups now also have his portal page with a profile portlet. only thing is missing is the usage of the sequence number in the portal page and portalpageportlet entity, probably completed next week
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742018 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 08:33:36 +00:00
Jacopo Cappellato 153ec0eba1 Misc enhancements to the update password screen and events: improved layout, error handling.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@742015 13f79535-47bb-0310-9956-ffa450edef68
2009-02-08 08:14:58 +00:00
Hans Bakker a588477be4 add screenlets to manageportal pages, add descriptions
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741861 13f79535-47bb-0310-9956-ffa450edef68
2009-02-07 09:03:49 +00:00
Jacques Le Roux 96af0d1bd7 Footer l10n and French i18n
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741532 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 11:11:46 +00:00
Jacques Le Roux cadb5144e2 git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741514 13f79535-47bb-0310-9956-ffa450edef68 2009-02-06 10:33:22 +00:00
Hans Bakker 9e807503dc some more fixes and adjustments for the portal page function
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741502 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 10:19:45 +00:00
Hans Bakker 9ea7eebcc0 make example dashboard working again with the recent portal page changes and removed fulladmin pages from myportal because not required
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741439 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 06:59:53 +00:00
David E. Jones afe3dc9c81 A few related changes:
Big refactor of ControlServlet, RequestManager, RequestHandler, and ConfigXMLReader so that simple objects are used instead of Maps within Maps within Maps for the data from the controller.xml file, which results in eliminating hundreds of lines of code including the entire RequestHandler class. I have tested this a lot with different apps that use the ControlServlet differently, but this is a very big change so there could still be issues. Based on this cleanup future issues and new features should be easier and less error prone, and that is why doing it now in order to help with a number of other improvements and bug fixes that are part of this commit.

Also added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues with form data, but if the ID to display (like following a crAlso added redirect-parameter element to go under the request-map -> response element which allows you to specify which parameters will be passed on in a redirect instead of using all of them. Also improved default there and in various places to only include parameters from the URL to avoid issues wd in and also going to the same page after login from auth=true or from clicking on the login link.

Related to cleaning up login URLs also changed how the request and parameters passed to a request before a login are saved and used after a login is successful so that it URL parameters go on the URL in a redirect to the original request to make it more transparent, and non-URL parameters just stay in the session and are used when the original request is run again to avoid putting sensitive information like passwords and big information like textarea data in the URL, which has been a problem before.

To see what some of these things combined can do try going to the example app, login, click on the New Example link, then logout in another tab or window, then go back to the New Example page and enter a name and a whole bunch of text in the long description then click Create, the system will show you the login page so enter username/password, and then after login you'll see a nice URL to EditExample with the correct exampleId parameter and all of the data entered before login successfully saved and never appearing in a URL.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741374 13f79535-47bb-0310-9956-ffa450edef68
2009-02-06 02:14:19 +00:00
Hans Bakker 077bd4641a the myportal component is functionally complete now having also different page sets for different securitygroups.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@741129 13f79535-47bb-0310-9956-ffa450edef68
2009-02-05 15:18:47 +00:00
Jacques Le Roux 345d64b204 A patch from Bruno Busco " Moving Timestamp to footer" '(https://issues.apache.org/jira/browse/OFBIZ-2164) - OFBIZ-2164
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@740299 13f79535-47bb-0310-9956-ffa450edef68
2009-02-03 13:21:30 +00:00