Commit Graph
63 Commits
Author SHA1 Message Date
Jacques Le Roux 8ae9319710 Use UtilValidate.isEmpty methods instead of (obj == null) || (obj.size == 0)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883492 13f79535-47bb-0310-9956-ffa450edef68
2009-11-23 20:34:27 +00:00
Jacques Le Roux 4b127f23a9 A patch from Bob Morley "Resolve java warnings exposed in Eclipse : framework - catalina" (https://issues.apache.org/jira/browse/OFBIZ-3104) - OFBIZ-3104
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@833025 13f79535-47bb-0310-9956-ffa450edef68
2009-11-05 09:29:51 +00:00
Adrian Crum 9ee18d37c5 Updated client code to use the new Delegator factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@823633 13f79535-47bb-0310-9956-ffa450edef68
2009-10-09 17:44:24 +00:00
Adrian Crum 7fa08f9079 Replaced GenericDelegator.getGenericDelegator(...) calls with new factory method.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821649 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 01:53:50 +00:00
Adrian Crum a4d68934c9 Converted GenericDelegator concrete class references to Delegator interface references.
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.



git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
2009-10-05 00:08:27 +00:00
Jacques Le Roux 48fda8a035 A patch from Brett Palmer "Adding Tomcat Catalina configuration for "privileged" applications" (https://issues.apache.org/jira/browse/OFBIZ-2945) - OFBIZ-2945
Out of the box Tomcat allows you to configure "privileged" applications by specifying the context as follows.
<Context path="/manager" debug="0" privileged="true"
   docBase="/usr/local/kinetic/tomcat6/server/webapps/manager">
</Context>

Since OFBiz is an embedded version of Tomcat it does not currently include a similar configuration for privileged applications.

The Tomcat manager application is a "privileged" application that includes utilities for monitoring JMX resources such as thread counts, connections, and any other configured JMX parameter. We use JMX with Hyperic to monitor our OFBiz servers

BTW, I used almost the same for Lambda Probe (https://issues.apache.org/jira/browse/OFBIZ-1397)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@816335 13f79535-47bb-0310-9956-ffa450edef68
2009-09-17 18:56:36 +00:00
Adrian Crum 74ea95889c Reverted rev 802567.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@812692 13f79535-47bb-0310-9956-ffa450edef68
2009-09-08 20:56:14 +00:00
Jacques Le Roux 3fedb9e5ed Some ASL2 headers
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@811870 13f79535-47bb-0310-9956-ffa450edef68
2009-09-06 19:54:25 +00:00
Jacques Le Roux 4c442ee379 Some fusiness
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@804895 13f79535-47bb-0310-9956-ffa450edef68
2009-08-17 08:20:38 +00:00
Adrian Crum 6786aa4dbc Refactored GenericDelegator:
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.

2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.

3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.

This commit paves the way for the forthcoming ExecutionContext.

User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.

Aside from those changes, this commit is backwards compatible.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
2009-08-09 18:04:26 +00:00
Scott Gray dec24b29f2 Sorry for the big commit, got a bit carried away.
Added override and deprecated annotations wherever they were missing
Removed the use of any deprecated classes/methods (except OutputFormat in UtilXml)
A few other random generics and misc. cleanups

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@791212 13f79535-47bb-0310-9956-ffa450edef68
2009-07-05 10:01:19 +00:00
Jacopo Cappellato 452fbe184f Misc fixes and enhancements to the Catalina cluster support.
Patch from Scott Gray and me, based and bug reports and tests from Sam Hamilton and Nico Toerl.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@778560 13f79535-47bb-0310-9956-ffa450edef68
2009-05-26 05:10:57 +00:00
Jacques Le Roux 058d6aed57 A patch from Ashish Vijaywargiya "Change Copyright Year" (https://issues.apache.org/jira/browse/OFBIZ-2346) - OFBIZ-2346
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@772936 13f79535-47bb-0310-9956-ffa450edef68
2009-05-08 10:56:14 +00:00
Jacques Le Roux b9c3ddef08 2d part and end of an effort to remove trailing spaces
[ \t]+$ => "" (empty)
Should be easier to review when committing changes with trailing spaces removed automatically by anyedit or such tool (please refer to http://docs.ofbiz.org/x/mg)

Of course this effort to remove trailing spaces has no functional implications.

Actually, I was doing a 1st commit and as it's long to upload, I got conflicts with r763135
In the meantime I did some refactoring also in *.java and *.groovy files :
){ => ) {
if( => if (
while( => while (
}else => } else
else{ => else {
switch( => switch (
try{ => try {
}catch => } catch
catch( => catch (
}finally{ => } finally {

So these changes are also in this commit, should not be a problem anyway.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@763175 13f79535-47bb-0310-9956-ffa450edef68
2009-04-08 10:54:51 +00:00
Adam Heath fca9bd08e9 Fix lines that *only* have whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@759230 13f79535-47bb-0310-9956-ffa450edef68
2009-03-27 16:56:08 +00:00
Adam Heath 1d0b236799 Fix purely empty whitespace lines, and remove trailing whitespace.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@757067 13f79535-47bb-0310-9956-ffa450edef68
2009-03-21 23:22:57 +00:00
Jacques Le Roux f796e230d2 catch( => catch(
}else => } else

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@751005 13f79535-47bb-0310-9956-ffa450edef68
2009-03-06 17:55:43 +00:00
Scott Gray 52271c33d5 Applied patch from OFBIZ-2060 by Harmeet Bedi
Import ambiguity in CrossSubdomainSessionValve.java


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737408 13f79535-47bb-0310-9956-ffa450edef68
2009-01-24 18:09:41 +00:00
Jacques Le Roux 572b7683e0 All tabs to 4 spaces in *.groovy, *.java, *.xml : less problems in future with that aspect...
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@737003 13f79535-47bb-0310-9956-ffa450edef68
2009-01-23 11:08:47 +00:00
Adam Heath 7cecc5aaf2 Annotations are not the same thing as javadocs.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@709638 13f79535-47bb-0310-9956-ffa450edef68
2008-11-01 03:42:09 +00:00
Scott Gray 3261efb9b0 Forgot to remove some code that wasn't needed
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@704679 13f79535-47bb-0310-9956-ffa450edef68
2008-10-14 20:51:12 +00:00
Scott Gray 6380d64dfd Changed the cross domain session valve to skip rewriting the session cookie if the domain is an IP address
Thanks to Adrian Crum for reporting the issue

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@704678 13f79535-47bb-0310-9956-ffa450edef68
2008-10-14 20:48:32 +00:00
Scott Gray 82e9c5243f Fix for problem that the new cross domain session cookie valve was having with localhost domains.
Thanks to Mridul Pathak for the patch and Andrew Zeneski for his advice

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@703784 13f79535-47bb-0310-9956-ffa450edef68
2008-10-12 10:56:41 +00:00
Scott Gray 1a24259b66 OFBIZ-1980: CrossSubdomainSessionValve for Tomcat, allows a session cookie to be shared across multiple subdomains.
Thanks to Mridul Pathak for the patch, Pranay Pandey and Chirag Manocha for testing and Andrew Zeneski for guidance and review.

Note: I made one small change, switched from logInfo to logVerbose to reduce the amount of noise created in the logs

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@701564 13f79535-47bb-0310-9956-ffa450edef68
2008-10-03 23:08:36 +00:00
Jacques Le Roux e7905f2c8c Fix the anti-pattern
if (* != null && *.size() > 0) { 
where * is a variable name (String or Collection). Rewritten to
    if (UtilValidate.isNotEmpty(*)) {

Done with Eclipse regex replace feature with
search = if \((\w+) *!= *null *&& *(\w+)\.size\(\) *> *0\) *\{
replace = if (UtilValidate.isNotEmpty($1)) {

And of course some hand-work for imports and cleaning. I compiled and tested with ant run-tests

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@686591 13f79535-47bb-0310-9956-ffa450edef68
2008-08-17 07:47:18 +00:00
Adam Heath e410552cc9 No longer *copy* the extra support files into the classes dir;
instead, just add them straight to the final jar.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@685934 13f79535-47bb-0310-9956-ffa450edef68
2008-08-14 15:08:14 +00:00
Adam Heath b6a1ae5e5e Another minor optimization; no longer need to specify classpathref in
all the build.xml files.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@681935 13f79535-47bb-0310-9956-ffa450edef68
2008-08-02 03:41:46 +00:00
Jacques Le Roux 641ff10050 Update Copyright to 2008
A real replace in files feature was one of the reasons I use Eclipse 3.4 for near a year now (I even helped to test, a real must have :o)
Not sure previous commit was sent partially or not at all (I needed to update)

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@677685 13f79535-47bb-0310-9956-ffa450edef68
2008-07-17 18:56:25 +00:00
Jacopo Cappellato 930970efd3 Upgraded (again) to Tomcat 6.0.16.
Upgraded commons-dbcp to the HEAD revision (from snapshot taken in 20071125): the upgrade of the dbcp jar seems to have fixed all the issues we were having with "OutOfMemoryError: Java heap space" exceptions.
Sorry for the noise (two big commits in the base and catalina components in the same day): hopefully this rather critical issue is now resolved (but I will continue my load tests).


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@674776 13f79535-47bb-0310-9956-ffa450edef68
2008-07-08 11:47:02 +00:00
Jacopo Cappellato 3fd79154a9 As a temp fix for issues with "OutOfMemoryError: Java heap space" errors reported after the upgrade of Tomcat, I'm downgrading from Tomcat 6.0.16 to Tomcat 5.5.23.
As soon as the issues is fixed we will commit back the code; this effort is tracked in OFBIZ-1863

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@674732 13f79535-47bb-0310-9956-ffa450edef68
2008-07-08 06:44:12 +00:00
David E. Jones 204d775174 More entitygroups gone, all of framework
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672910 13f79535-47bb-0310-9956-ffa450edef68
2008-06-30 20:49:10 +00:00
Adam Heath 18391f98a9 The build.xml files are now much smaller and simpler; they reuse a
few global definitions.  1585 lines removed.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@672657 13f79535-47bb-0310-9956-ffa450edef68
2008-06-29 18:39:36 +00:00
Jacopo Cappellato dbd34520d7 Cleaned up a bunch of warning messages for deprecated methods; in preparation for the framework release.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@671223 13f79535-47bb-0310-9956-ffa450edef68
2008-06-24 15:47:28 +00:00
Jacques Le Roux 10676abb06 A patch from Michael Brohl "Configure cookie use for a module through the ofbiz-component.xml" (https://issues.apache.org/jira/browse/OFBIZ-1831) - OFBIZ-1831
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@670268 13f79535-47bb-0310-9956-ffa450edef68
2008-06-21 23:02:59 +00:00
Jacopo Cappellato cfd0f1c0c8 Upgrade to Tomcat 6
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@659490 13f79535-47bb-0310-9956-ffa450edef68
2008-05-23 10:26:46 +00:00
Scott Gray 153653615b Removed the rest of the calls to deprecated GenericDelegator methods, except for the findListIteratorByCondition which takes a DynamicViewEntity as a parameter not sure what to do about that one.
There's still all the bsh files to check though.

git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@655235 13f79535-47bb-0310-9956-ffa450edef68
2008-05-11 03:29:04 +00:00
David E. Jones 329631a4b5 A whole bunch of cleanups to use newer and more consolidated delegator find methods; still lots of deprecation warnings, bots of deprecation warnings but this is a first pass, and things still run as before
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@653029 13f79535-47bb-0310-9956-ffa450edef68
2008-05-03 09:40:51 +00:00
Adam Heath d73602df56 Add -Xlint:unchecked to several javac calls; they are all clean, so
no warnings are produced.


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585858 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 04:19:48 +00:00
Adam Heath e780c1da5b Java 1.5 markup for framework/catalina.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585848 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 04:04:05 +00:00
Adam Heath 2ff7a8a575 Make use of the single-arg variants of makePK/makeValue, removeAll,
and clearCacheLine


git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585803 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 02:46:57 +00:00
Adam Heath 686210a51b Fix loc incrementing in OfbizStore.keys().
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@585786 13f79535-47bb-0310-9956-ffa450edef68
2007-10-18 02:15:59 +00:00
Andrew Zeneski c239535138 changed log level to stop annoying error when running test cases
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@576678 13f79535-47bb-0310-9956-ffa450edef68
2007-09-18 03:53:12 +00:00
David E. Jones 07b48643c5 As noted needing to be done by Jacques Le Roux did a search/replace on source=1.4 and changed to 1.5
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@541997 13f79535-47bb-0310-9956-ffa450edef68
2007-05-27 15:55:18 +00:00
David E. Jones 7d70c41c12 Did a big search/replace to change all xsd file refs from www.ofbiz.org to ofbiz.apache.org
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@539504 13f79535-47bb-0310-9956-ffa450edef68
2007-05-18 15:47:14 +00:00
Andrew Zeneski cf8a96276d now disabling the app-bar display when an app is not load due to the fact an app w/ the same mount has already been loaded
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@537920 13f79535-47bb-0310-9956-ffa450edef68
2007-05-14 17:13:35 +00:00
Andrew Zeneski bf62e5f4d1 updated catalina container to load webapps in reverse order from how they are defined, also it only attempts to load a webapp once. Apps which "override" the stock apps will now have priority.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@537918 13f79535-47bb-0310-9956-ffa450edef68
2007-05-14 17:09:04 +00:00
Andrew Zeneski c5700ea665 fixed bad conditions
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@536687 13f79535-47bb-0310-9956-ffa450edef68
2007-05-09 22:12:10 +00:00
Andrew Zeneski a7bb5a0b5c updated tomcat to 5.5.23
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@536686 13f79535-47bb-0310-9956-ffa450edef68
2007-05-09 22:11:50 +00:00
Andrew Zeneski f24adea3c9 added log message when error
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@532040 13f79535-47bb-0310-9956-ffa450edef68
2007-04-24 18:51:36 +00:00
Andrew Zeneski 7cbcc85cbd refactored x509 implementations; now it will use the certificate to determine the userlogin; tomcat changed to ignore cert files (just pass through) so all checking can be handled by ofbiz; login worker updated to use new method of cert checking; added isser entity to configure what issuers are allowed to sign login certs (the certificate must also be included in a trust store) new component based trust/cert stores configured in ofbiz-component.xml
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@531272 13f79535-47bb-0310-9956-ffa450edef68
2007-04-22 20:56:58 +00:00