* remove duplicate ()
* remove casts no longer needed
I'm doing these last tasks around isEmpty and isNotEmpty mostly to be sure that nothing has slipped in. Despite I have been very careful, I prefer double check.
+ one typo in ofbizSelenium help (not sure this file is used yet though, seems to be missing some parts which are commented out, for now I guess)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@885093 13f79535-47bb-0310-9956-ffa450edef68
This is the first step to making utilCacheTable concurrent, and
non-blocking. To do so, the constructor has to have no side-effects.
This means it can't modify utilCacheTable itself; this will be moved to
the helper function created above.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@883217 13f79535-47bb-0310-9956-ffa450edef68
Steps regenerate error:
1) Hit url: https://localhost:8443/ordermgr/control/orderentry
2) Select purchase order with supplier
3) Add product for order
4) Click on the productId from showcart page
it will generate error as following
org.ofbiz.widget.screen.ScreenRenderException: Error rendering screen component://order/widget/ordermgr/OrderEntryCatalogScreens.xml#productdetail: java.lang.NullPointerException: Cannot get property 'productStoreId' on null object (Cannot get property 'productStoreId' on null object)
Notes from Mridul:
As Joe has already stated that we need to do few adjustments in the code based on presence of productStoreId. I would vote for:
1. Showing all reviews.
2. Skipping surveys.
The third section, which is the most important one and needs productStoreId is getProductVariantTree service invoked in ProductDetail.groovy (line 232). getProductVariantTree service needs productStoreId to get available inventory. In case of PO's we don't need to check for available inventory at all. Now for being able to use the same code to display product detail page in case of a PO, we will need to make modifications to getProductVariantTree service too, which can be done in two ways:
1. Add a boolean IN attribute checkInventory to service definition, if its true check the available inventory and if false do not.
2. A check on productStoreId in the implementation can serve our purpose too.
I like #1 more as it won't eliminate importance of productStoreId in case of a sales order. Looking forward to suggestions from community to handle this situation.
Thanks Amit for the contribution. Mridul Thanks a lot for providing useful notes for the implementation.
Guys, I appreciate your coordination on this!
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@882618 13f79535-47bb-0310-9956-ffa450edef68
Layered navigation in an Ecommerce application allows the user to filter the product listing based on categories, features and price ranges. The user can apply multiple filters to the given product listing. He can narrow or expand his search and try different filter combinations so as to find the desired product.
I have implemented Layered Navigation in OFBiz ecommerce with following filters:
1. Sub Categories: This filter is shown whenever there are sub-categories present under the top-level category or current selected category. Count of products within the category is shown against each category, works with multilevel deep category hierarchy. Selecting a sub category will show products within that category and filters will be updated accordingly for the new product list.
2. Features: Feature filters are grouped by Feature Types. Count of products that has the feature associated as standard, selectable or distinguishing is shown against that feature. Current Implementation has feature filters for ProductFeatureType="COLOR".
3. List Price Range: This filter will always show. When applied filters product based on List Price Range. Current implementation is done by listing static price ranges at code level.
The above implementation is completely based on the OOTB Product Search functionality with few additional methods in ProductSearchSession to derive count against different type of filters.
This is collaborative contribution from Mridul Pathak, Jacopo Cappellato & Scott Gray.
Thanks Guys for such a nice contribution - I am sure community will love seeing the existence of "Layered Navigation" in OFBiz trunk.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@835372 13f79535-47bb-0310-9956-ffa450edef68
Following points are covered in this patch:
1) Show associated products for product of type "MARKETING_PKG_AUTO" on order items section of show cart page in order manager application.
2) Marketing packages should only shown backordered when ATP of product which compose Marketing packages product are less than quantity added in cart.
3) Pick sheets should show Products of type Marketing Packages along with the products which compose Marketing Packages.
4) Show link of production run created on order items section of Order detail page while placing order for product of type MARKETING_PKG_AUTO.
5) Product of type Marketing Packages should be shown on Verify Pick Screen along with Products they are composed of.
Thanks Divesh for the contribution - this is very nice addition to the trunk.
I would be more then happy to see comments / concern from - Jacopo? Scott? Anil? or others?
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@834479 13f79535-47bb-0310-9956-ffa450edef68
As we have different productCatalogCategoryType for eBay so add a constraint on searching that if catalog not associated with any PCCT_BROWSE_ROOT type category then also search for PCCT_EBAY_ROOT type category for CatalogConstrain. This will help to manage separate catalog and catalog category association for ebay.
Thanks Parimal for the contribution.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@833054 13f79535-47bb-0310-9956-ffa450edef68
Recently multi store support for Ebay has been implemented. For the multi store support we need ProductStore > ProdCatalog > ProductCategory association. For EBay we define specific categories of type EBAY_CATEGORY, only those products that are associated to an EBay category are eligible for eBay export. In the current implementation there is no proper prodCatalogCategoryTypeId which can be used to associate eBay category to ProdCatalog, one way to associate an eBay category to ProdCatalog is as a PCCT_BROWSE_ROOT category, thus we have two categories associated to the catalog as BROWSE_ROOT, the other one is for online store. Technically, this is wrong, a catalog should be associated with only one browse root category. Due to this wrong association the eBay category doesn't show up on the advance search page of EBAY webapp, instead online store's browse root category is shown which may also contain those products which are not meant to be exported to eBay. So this category associations need to be fixed, and following is how this can be resolved:
1. Create a new ProdCatalogCatagoryType PCCT_EBAY_ROOT
2. Define a worker method in CatalogWorker to derive the top level (root) ebay category
3. Now in the advance search form, first look for top level ebay category associated to the selected catalog
* If found, derive sub category list of the top level ebay category and display, else display the top level ebay category itself
* If not found, derive the top level browse root category (PCCT_BROWSE_ROOT) and display the sub category list for it
Thanks Parimal Gain for the contribution.
Special thanks to Mridul Pathak (Zone of Sharp Mind :-)) for discussing implementation plans & providing wonderful notes.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@832713 13f79535-47bb-0310-9956-ffa450edef68
This patch is a 1st step and add only a filterByDate to the PriceRules obtained after the call to the makeProducePriceRuleList function
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@830528 13f79535-47bb-0310-9956-ffa450edef68
Sorry to bother you guys on this - but yes the service for Ups Transit time will be soon in OFBiz trunk. :)
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821699 13f79535-47bb-0310-9956-ffa450edef68
This commit requires ant clean. Also, external libraries that reference GenericDelegator will need to be updated.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@821643 13f79535-47bb-0310-9956-ffa450edef68
This can create problem for the projects in which "prodSearchExcludeVariants" field is not been set in past so the not-empty check will allow variant product to be included on the search.
Thanks Scott for your comment.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@820249 13f79535-47bb-0310-9956-ffa450edef68
Also I had put a not-empty check so if someone forgot to put this value in demo data then by default it will include variant products.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@820204 13f79535-47bb-0310-9956-ffa450edef68
The method is also used to clean the code related to the two existing marketing package types (that have now in common the same parent).
This will make the framework more flexible because you will be able to create a new product subtype and the system will treat them as its parent type; then you can add custom code to treat it in the special way (if needed). This pattern can be extended in other areas of the system, starting from product types (right now it is also applied to marketing packages).
Thanks to Mridul Pathak for the patch - OFBIZ-2902
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@813413 13f79535-47bb-0310-9956-ffa450edef68
1. Converted GenericDelegator to an interface. We already have DelegatorInterface, but it isn't being used anywhere. Removed DelegatorInterface.java.
2. Extracted the static, cached data from the GenericDelegator implementation and put it in its own class - DelegatorData. The GenericDelegator implementation holds a reference to the DelegatorData instance. This makes it possible to have per-thread instances of GenericDelegator.
3. Replaced the ThreadLocal variables with regular variables. ThreadLocal variables are no longer needed. Client code doesn't need to be concerned with pushing and popping the GenericDelegator state.
This commit paves the way for the forthcoming ExecutionContext.
User modifications will have to replace GenericDelegator.getGenericDelegator(...) with DelegatorFactory.getGenericDelegator(...). Also, replace the push code with the new setXxx methods, and remove the pop code. If modifications used DelegatorInterface, replace that with GenericDelegator.
Aside from those changes, this commit is backwards compatible.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@802567 13f79535-47bb-0310-9956-ffa450edef68
if a different order comes for verification and does have the same product then the country of origin will automatically populate on verify order screen.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@801675 13f79535-47bb-0310-9956-ffa450edef68
These associated products are then shown to the customer on the product pages as "Customers who bought this item also bought: ..." sorted by popularity.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@798500 13f79535-47bb-0310-9956-ffa450edef68
Compares things like name, price, description, long description, brand name and standard, distinguishing and optional features.
Could do with some styling and would be nice to add customer ratings in there as well.
git-svn-id: https://svn.apache.org/repos/asf/ofbiz/trunk@797259 13f79535-47bb-0310-9956-ffa450edef68